WealthLedger/frontend
5
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: respect query eligibility in screen sync (WealthLedger/frontend#54) #82

Merged
codex-bot merged 1 commits from fix/54-periodic-read-lifecycle into develop 2026-10-14 17:01:53 +03:00
Conversation 0 Commits 1 Files Changed 2
+44 -4
codex-bot commented 2026-10-14 16:37:08 +03:00
Owner
Copy Link
Copy Source

Closes WealthLedger/frontend#54

Что изменено

  • useScreenSync теперь принимает isEnabled из query owners.
  • Timer refetch'ит только enabled и не-fetching resources; disabled/unresolved/short-input/session-gated queries не получают ручной GET.
  • refresh и retry используют тот же eligibility guard, не стартуют disabled queries и не дублируют active fetch.
  • Добавлен fake-timer regression test, который проверяет отсутствие refetch для disabled resource во всех трёх ветках.

Оставлен текущий screen timer и существующие owner policies: native refetchInterval не вводится без multi-observer proof; App focus/reconnect defaults не менялись.

Verification

  • npx vitest run src/features/tbank-connection/model/screen-sync.test.tsx — 3 tests passed.
  • npm run verify — exit 0 (typecheck, OpenAPI check, ESLint, tests/coverage, knip, dependency-cruiser, Vite и Storybook builds).
  • git diff --check — exit 0.
Closes WealthLedger/frontend#54 ## Что изменено - `useScreenSync` теперь принимает `isEnabled` из query owners. - Timer refetch'ит только enabled и не-fetching resources; disabled/unresolved/short-input/session-gated queries не получают ручной GET. - `refresh` и `retry` используют тот же eligibility guard, не стартуют disabled queries и не дублируют active fetch. - Добавлен fake-timer regression test, который проверяет отсутствие refetch для disabled resource во всех трёх ветках. Оставлен текущий screen timer и существующие owner policies: native `refetchInterval` не вводится без multi-observer proof; App focus/reconnect defaults не менялись. ## Verification - `npx vitest run src/features/tbank-connection/model/screen-sync.test.tsx` — 3 tests passed. - `npm run verify` — exit 0 (typecheck, OpenAPI check, ESLint, tests/coverage, knip, dependency-cruiser, Vite и Storybook builds). - `git diff --check` — exit 0.
codex-bot added 1 commit 2026-10-14 16:37:08 +03:00
fix: respect query eligibility in screen sync (WealthLedger/frontend#54)
Frontend verify / commits (pull_request) Successful in 41s
Details
Frontend verify / security (pull_request) Successful in 12s
Details
Frontend verify / verify (pull_request) Successful in 7m9s
Details
f01839b28b
codex-bot merged commit f295dea6a6 into develop 2026-10-14 17:01:53 +03:00
codex-bot deleted branch fix/54-periodic-read-lifecycle 2026-10-14 17:01:54 +03:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Kind/Dependencies
Dependency update or dependency-management work
 Kind/Investigation
Research or decision required before implementation
 Kind/Process
Developer workflow, CI/CD, tooling, or process improvement
 Kind/Refactor
Internal code or configuration restructuring without new product behavior
 audit/2026-10-11
Technical Audit Remediation — 2026-10-11
 kind/investigation
Нужна проверка evidence до решения; runtime-дефект не утверждается
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
codex-bot hermes-agent ksv741 publisher-bot renovate-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: WealthLedger/frontend#82