WealthLedger/frontend
5
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: derive payment-system options from schema tuple (#58) #75

Merged
codex-bot merged 1 commits from refactor/58-payment-system-tuple into develop 2026-10-13 21:05:08 +03:00
Conversation 0 Commits 1 Files Changed 2
+5 -4
codex-bot commented 2026-10-13 20:47:30 +03:00
Owner
Copy Link
Copy Source

Что

Схема bank-card владеет единственным runtime-списком payment systems; Zod enum и options в BankCardFields.vm.ts производны от него. Draft-sentinel "" остаётся отдельным элементом enum.

  • form.schema.ts: paymentSystemValues tuple, z.enum(["", ...paymentSystemValues])
  • BankCardFields.vm.ts: options строятся через paymentSystemValues.map(...)

Проверки

  • npx tsc -b --noEmit — ok
  • npx eslint <2 changed files> --fix --max-warnings=0 — 0
  • npx vitest run src/entities/bank-card/model src/entities/bank-card/ui/BankCardForm — 47 passed (в т.ч. loads and saves the selected payment system)
  • npm run verify — exit 0

Refs WealthLedger/frontend#58

## Что Схема bank-card владеет единственным runtime-списком payment systems; Zod enum и options в `BankCardFields.vm.ts` производны от него. Draft-sentinel `""` остаётся отдельным элементом enum. - `form.schema.ts`: `paymentSystemValues` tuple, `z.enum(["", ...paymentSystemValues])` - `BankCardFields.vm.ts`: options строятся через `paymentSystemValues.map(...)` ## Проверки - `npx tsc -b --noEmit` — ok - `npx eslint <2 changed files> --fix --max-warnings=0` — 0 - `npx vitest run src/entities/bank-card/model src/entities/bank-card/ui/BankCardForm` — 47 passed (в т.ч. `loads and saves the selected payment system`) - `npm run verify` — exit 0 Refs WealthLedger/frontend#58
codex-bot added 1 commit 2026-10-13 20:47:30 +03:00
refactor: derive payment-system options from schema tuple (#58)
Frontend verify / commits (pull_request) Successful in 42s
Details
Frontend verify / security (pull_request) Successful in 11s
Details
Frontend verify / verify (pull_request) Successful in 6m45s
Details
001ad2e723
codex-bot merged commit e67c47b102 into develop 2026-10-13 21:05:08 +03:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Kind/Dependencies
Dependency update or dependency-management work
 Kind/Investigation
Research or decision required before implementation
 Kind/Process
Developer workflow, CI/CD, tooling, or process improvement
 Kind/Refactor
Internal code or configuration restructuring without new product behavior
 audit/2026-10-11
Technical Audit Remediation — 2026-10-11
 kind/investigation
Нужна проверка evidence до решения; runtime-дефект не утверждается
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
codex-bot hermes-agent ksv741 publisher-bot renovate-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: WealthLedger/frontend#75