WealthLedger/frontend
5
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: show history loading alert only while loading (WealthLedger/frontend#124) #125

Merged
codex-bot merged 1 commits from fix/124-history-loading-partial into develop 2026-10-28 21:00:46 +03:00
Conversation 0 Commits 1 Files Changed 2
+49 -3
codex-bot commented 2026-10-28 20:40:25 +03:00
Owner
Copy Link
Copy Source

Summary

Плашка «История догружается» показывается только при historyState === "loading". partial больше не означает фоновую загрузку (после WealthLedger/backend#57 lifetime history не догружается). Неполнота данных за период по-прежнему видна через отдельный Alert по meta.completeness.

Linked Issue

Refs WealthLedger/frontend#124; связано с WealthLedger/backend#57 (PR backend #147).

Changes

  • AccountOperationsPage.vm.ts: historyLoading = historyState === "loading".
  • AccountOperationsPage.test.tsx: два теста через MSW — partial → плашки нет, loading → плашка есть.

Verification

  • Тест для partial падал на старом коде, после правки зелёный.
  • vitest run: 68 файлов / 496 тестов; npm run typecheck, npm run lint — зелёные. Полный verify (storybook/build) не запускался — это остаётся на CI.

Breaking Changes (если есть)

Нет. Мержить до или вместе с backend#57.

## Summary Плашка «История догружается» показывается только при `historyState === "loading"`. `partial` больше не означает фоновую загрузку (после WealthLedger/backend#57 lifetime history не догружается). Неполнота данных за период по-прежнему видна через отдельный Alert по `meta.completeness`. ## Linked Issue Refs WealthLedger/frontend#124; связано с WealthLedger/backend#57 (PR backend #147). ## Changes - `AccountOperationsPage.vm.ts`: `historyLoading` = `historyState === "loading"`. - `AccountOperationsPage.test.tsx`: два теста через MSW — `partial` → плашки нет, `loading` → плашка есть. ## Verification - Тест для `partial` падал на старом коде, после правки зелёный. - `vitest run`: 68 файлов / 496 тестов; `npm run typecheck`, `npm run lint` — зелёные. Полный `verify` (storybook/build) не запускался — это остаётся на CI. ## Breaking Changes (если есть) Нет. Мержить до или вместе с backend#57.
codex-bot added 1 commit 2026-10-28 20:40:26 +03:00
fix: show history loading alert only while loading (WealthLedger/frontend#124)
Frontend verify / commits (pull_request) Successful in 32s
Details
Frontend verify / security (pull_request) Successful in 10s
Details
Frontend verify / verify (pull_request) Successful in 5m54s
Details
31d8854d4b
codex-bot merged commit 6792f5b70a into develop 2026-10-28 21:00:46 +03:00
codex-bot deleted branch fix/124-history-loading-partial 2026-10-28 21:00:46 +03:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Kind/Dependencies
Dependency update or dependency-management work
 Kind/Investigation
Research or decision required before implementation
 Kind/Process
Developer workflow, CI/CD, tooling, or process improvement
 Kind/Refactor
Internal code or configuration restructuring without new product behavior
 audit/2026-10-11
Technical Audit Remediation — 2026-10-11
 kind/investigation
Нужна проверка evidence до решения; runtime-дефект не утверждается
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
codex-bot hermes-agent ksv741 publisher-bot renovate-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: WealthLedger/frontend#125