WealthLedger/frontend
5
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: derive api error codes from contract (WealthLedger/backend#117) #123

Merged
codex-bot merged 1 commits from refactor/117-typed-problem-codes into develop 2026-10-28 17:31:22 +03:00
Conversation 0 Commits 1 Files Changed 7
+65 -10
codex-bot commented 2026-10-28 15:42:52 +03:00
Owner
Copy Link
Copy Source

Frontend consumer for WealthLedger/backend#117. Merge AFTER the backend PR refactor/117-typed-problem-codes.

  • spec/openapi.json updated from backend; schema.d.ts regenerated (ProblemDetailsDto.code is now a 35-code union).
  • ApiErrorCode enum kept (conventions forbid machine-code string literals) but guarded by the contract type: any member not in the contract breaks compilation.
  • Unreachable FORBIDDEN removed from enum, client.ts permanent codes, resource-query.ts, AccountPage.vm.ts; 403 no-retry stays status-based.

Checks: npm run verify.

Frontend consumer for WealthLedger/backend#117. Merge AFTER the backend PR `refactor/117-typed-problem-codes`. - `spec/openapi.json` updated from backend; `schema.d.ts` regenerated (`ProblemDetailsDto.code` is now a 35-code union). - `ApiErrorCode` enum kept (conventions forbid machine-code string literals) but guarded by the contract type: any member not in the contract breaks compilation. - Unreachable `FORBIDDEN` removed from enum, `client.ts` permanent codes, `resource-query.ts`, `AccountPage.vm.ts`; 403 no-retry stays status-based. Checks: `npm run verify`.
ksv741 added 1 commit 2026-10-28 17:12:17 +03:00
refactor: derive api error codes from contract (WealthLedger/backend#117)
Frontend verify / commits (pull_request) Successful in 30s
Details
Frontend verify / security (pull_request) Successful in 9s
Details
Frontend verify / verify (pull_request) Successful in 5m46s
Details
dd24ad65a7
ksv741 force-pushed refactor/117-typed-problem-codes from 1336be8c4f to dd24ad65a7 2026-10-28 17:12:17 +03:00 Compare
codex-bot scheduled this pull request to auto merge when all checks succeed 2026-10-28 17:12:51 +03:00
codex-bot merged commit 32e8fe9402 into develop 2026-10-28 17:31:22 +03:00
codex-bot deleted branch refactor/117-typed-problem-codes 2026-10-28 17:31:22 +03:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Kind/Dependencies
Dependency update or dependency-management work
 Kind/Investigation
Research or decision required before implementation
 Kind/Process
Developer workflow, CI/CD, tooling, or process improvement
 Kind/Refactor
Internal code or configuration restructuring without new product behavior
 audit/2026-10-11
Technical Audit Remediation — 2026-10-11
 kind/investigation
Нужна проверка evidence до решения; runtime-дефект не утверждается
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
codex-bot hermes-agent ksv741 publisher-bot renovate-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: WealthLedger/frontend#123