WealthLedger/backend
5
0
Fork 0
Code Issues 7 Pull Requests 1 Actions 1 Packages Projects Releases Wiki Activity

refactor: extract shared public instrument projection (#69) #84

Merged
codex-bot merged 1 commits from fix/69-public-instrument-projection into develop 2026-10-13 21:54:52 +03:00
Conversation 0 Commits 1 Files Changed 4
+104 -69
codex-bot commented 2026-10-13 21:47:05 +03:00
Owner
Copy Link
Copy Source

Closes #69.

What

  • Extract duplicated publicInstrument (detail allowlist + nested brand.logoName policy) into a single stateless module-local projection application/public-instrument.ts.
  • Both catalog-discovery.service.ts and catalog-enrichment.service.ts import it; no DI/module/public API layer added.
  • Targeted trust-boundary spec: private extras and extra brand properties are dropped; null brand / optional fields project correctly.

Verification

  • npm run typecheck:app, npm run typecheck:test
  • eslint src/modules/investments/instruments/application --max-warnings=0
  • npm test -- src/modules/investments/instruments/application (9 passed)
Closes #69. ## What - Extract duplicated `publicInstrument` (detail allowlist + nested `brand.logoName` policy) into a single stateless module-local projection `application/public-instrument.ts`. - Both `catalog-discovery.service.ts` and `catalog-enrichment.service.ts` import it; no DI/module/public API layer added. - Targeted trust-boundary spec: private extras and extra brand properties are dropped; null brand / optional fields project correctly. ## Verification - `npm run typecheck:app`, `npm run typecheck:test` - `eslint src/modules/investments/instruments/application --max-warnings=0` - `npm test -- src/modules/investments/instruments/application` (9 passed)
codex-bot added 1 commit 2026-10-13 21:47:05 +03:00
refactor: extract shared public instrument projection (#69)
Backend verify / commits (pull_request) Successful in 33s
Details
Backend verify / security (pull_request) Successful in 12s
Details
Backend verify / verify (pull_request) Successful in 5m42s
Details
11655cbb08
codex-bot merged commit 9b7e5e1215 into develop 2026-10-13 21:54:52 +03:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Kind/Dependencies
Dependency update or dependency-management work
 Kind/Investigation
Research or decision required before implementation
 Kind/Process
Developer workflow, CI/CD, tooling, or process improvement
 Kind/Refactor
Internal code or configuration restructuring without new product behavior
 audit/2026-10-11
Technical Audit Remediation — 2026-10-11
 kind/investigation
Нужна проверка evidence до решения; runtime-дефект не утверждается
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
codex-bot hermes-agent ksv741 publisher-bot renovate-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: WealthLedger/backend#84