[Refactor] Оставить одну whitelist projection publicInstrument #69
Closed
opened 2026-10-11 21:47:21 +03:00 by codex-bot
·
0 comments
No Branch/Tag Specified
Labels
Clear labels
Kind/Dependencies
Kind/Investigation
Kind/Process
Kind/Refactor
audit/2026-10-11
kind/investigation
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Dependency update or dependency-management work
Research or decision required before implementation
Developer workflow, CI/CD, tooling, or process improvement
Internal code or configuration restructuring without new product behavior
Technical Audit Remediation — 2026-10-11
Нужна проверка evidence до решения; runtime-дефект не утверждается
Breaking change that won't be backward compatible
Something is not working
Documentation changes
Improve existing functionality
New functionality
This is security issue
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Milestone
No items
No Milestone
Technical Audit Remediation — 2026-10-11
Projects
Clear projects
No projects
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: WealthLedger/backend#69
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Problem
Две publicInstrument функции поддерживают одинаковую detail allowlist и nested brand.logoName policy. Текущего drift нет; один instruments boundary owner требует двух правок при изменении fields.
Expected Behavior
Одна stateless module-local projection обслуживает online и saved/enrichment callers без объединения execution models.
Evidence
Audit date
2026-10-11; 03. IDs DRY-002, TA-F15. Revision0ad84ff4f0b4712abc7e69dc299856f14af6eadd; Confidence High; Verification status static.Affected: catalog-discovery.service.ts:499–531; catalog-enrichment.service.ts:646–678.
Scope
In scope
Одна pure projection у existing instruments owner, два local imports.
Out of scope
Nest mapper provider, generic/cross-repo mapper, whole catalog/enrichment merger, удаление privacy allowlist.
Proposed Approach
Reuse одинаковые types/semantics; skinny discovery stored shape имеет другую роль и не включается.
Acceptance Criteria
Verification
Existing instrument selection/whitelist HTTP/source cases, локальный semantic review; minimal targeted projection check только для observable trust boundary. Backend final gates.
Dependencies
Нет; legacy producer deletion не требует сохранять его ради DRY.
Traceability
Campaign WealthLedger/main#23 . Findings DRY-002, TA-F15. WealthLedger/backend; T18.