WealthLedger/backend
5
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: count brokerage cash once in portfolio totals (WealthLedger/backend#140) #141

Merged
codex-bot merged 2 commits from fix/140-portfolio-cash-double-count into develop 2026-10-28 08:46:38 +03:00
Conversation 0 Commits 2 Files Changed 7
+69 -8
codex-bot commented 2026-10-28 08:00:31 +03:00
Owner
Copy Link
Copy Source

Closes #140

Changes

  • totalsByCurrency and portfolioStructure skip CURRENCY positions: T-Bank returns the same cash both as getPositions().money and as RUB000UTSTOM/USD800UTSTOM positions. Same rule as in brokerage-accounts.service.ts.
  • unrealizedReturnByCurrency.percent is null for a currency with a short position (negative cost basis flipped the sign / netted with longs), consistent with instrument-position.ts.
  • Migration 20261028080000_reset_inflated_portfolio_value_points deletes all TbankPortfolioValuePoint rows written by the old code. They cannot be recomputed exactly (no historical compositions or FX rates); points have no public read path. TbankPortfolioValueHistory is kept. Owner-approved destructive data change; back up the SQLite file before deploy.

Verification

  • New regression tests fail without the fix (3) and pass with it; fixture mirrors dev.db account 2197225275 (121.49 instead of 122.74).
  • npm run verify green (293/293 unit, lint, typecheck, build).
  • test:sqlite tbank-value-history.e2e-spec.ts 13/13.
  • Migration applied on a copy of dev.db with a seeded point: points 1 → 0, history row kept, migrate status up to date.

Follow-up

Closes #140 ## Changes - `totalsByCurrency` and `portfolioStructure` skip `CURRENCY` positions: T-Bank returns the same cash both as `getPositions().money` and as `RUB000UTSTOM`/`USD800UTSTOM` positions. Same rule as in `brokerage-accounts.service.ts`. - `unrealizedReturnByCurrency.percent` is `null` for a currency with a short position (negative cost basis flipped the sign / netted with longs), consistent with `instrument-position.ts`. - Migration `20261028080000_reset_inflated_portfolio_value_points` deletes all `TbankPortfolioValuePoint` rows written by the old code. They cannot be recomputed exactly (no historical compositions or FX rates); points have no public read path. `TbankPortfolioValueHistory` is kept. **Owner-approved destructive data change; back up the SQLite file before deploy.** ## Verification - New regression tests fail without the fix (3) and pass with it; fixture mirrors dev.db account 2197225275 (121.49 instead of 122.74). - `npm run verify` green (293/293 unit, lint, typecheck, build). - `test:sqlite tbank-value-history.e2e-spec.ts` 13/13. - Migration applied on a copy of dev.db with a seeded point: points 1 → 0, history row kept, `migrate status` up to date. ## Follow-up - WealthLedger/specs#60: `portfolio-view` wording should state that CURRENCY positions mirror cash (related WealthLedger/frontend#59).
codex-bot added 2 commits 2026-10-28 08:00:32 +03:00
fix: count brokerage cash once and skip short-position return percent (WealthLedger/backend#140) f2843e30bd
fix: reset portfolio value points inflated by double-counted cash (WealthLedger/backend#140)
Backend verify / commits (pull_request) Successful in 27s
Details
Backend verify / security (pull_request) Skipped
Details
Backend verify / verify (pull_request) Skipped
Details
Backend verify / commits (push) Skipped
Details
Backend verify / security (push) Successful in 9s
Details
Backend verify / verify (push) Failing after 4m33s
Details
2325b63883
codex-bot merged commit 2325b63883 into develop 2026-10-28 08:46:38 +03:00
codex-bot deleted branch fix/140-portfolio-cash-double-count 2026-10-28 08:46:38 +03:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Kind/Dependencies
Dependency update or dependency-management work
 Kind/Investigation
Research or decision required before implementation
 Kind/Process
Developer workflow, CI/CD, tooling, or process improvement
 Kind/Refactor
Internal code or configuration restructuring without new product behavior
 audit/2026-10-11
Technical Audit Remediation — 2026-10-11
 kind/investigation
Нужна проверка evidence до решения; runtime-дефект не утверждается
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
codex-bot hermes-agent ksv741 publisher-bot renovate-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: WealthLedger/backend#141