WealthLedger/frontend
5
0
Fork 0
Code Issues 3 Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: round money to currency minor units without negative zero (WealthLedger/frontend#118) #119

Merged
codex-bot merged 1 commits from fix/118-rounded-money-display into develop 2026-10-28 08:45:56 +03:00
Conversation 0 Commits 1 Files Changed 4
+47 -18
codex-bot commented 2026-10-28 08:08:19 +03:00
Owner
Copy Link
Copy Source

Closes #118

  • formatMoney(..., { withRoundedCents }) rounds to ISO 4217 minor units from Intl.NumberFormat().resolvedOptions() (RUB/USD 2, JPY 0, KWD 3; unknown codes 2).
  • A value rounded to zero loses its sign: -0.004 RUB → 0,00 ₽.
  • BigInt string arithmetic kept; no float.
  • CI: npm audit threshold low → moderate (owner decision). GHSA-gcqx-w48m-w2h4 (deepmerge ≤4.3.1, low, no patched release; build-only via vite-plugin-pwa → workbox-build) blocked every PR. README updated.

Verification

  • New test fails on develop (-0,00 ₽), passes now.
  • npm run verify green; CI commits/security/verify green.
Closes #118 - `formatMoney(..., { withRoundedCents })` rounds to ISO 4217 minor units from `Intl.NumberFormat().resolvedOptions()` (RUB/USD 2, JPY 0, KWD 3; unknown codes 2). - A value rounded to zero loses its sign: `-0.004 RUB` → `0,00 ₽`. - BigInt string arithmetic kept; no float. - CI: `npm audit` threshold `low` → `moderate` (owner decision). GHSA-gcqx-w48m-w2h4 (deepmerge ≤4.3.1, low, no patched release; build-only via vite-plugin-pwa → workbox-build) blocked every PR. README updated. ## Verification - New test fails on `develop` (`-0,00 ₽`), passes now. - `npm run verify` green; CI commits/security/verify green.
ksv741 added 1 commit 2026-10-28 08:29:21 +03:00
fix: round money to currency minor units without negative zero (WealthLedger/frontend#118)
Frontend verify / commits (pull_request) Successful in 28s
Details
Frontend verify / security (pull_request) Successful in 11s
Details
Frontend verify / verify (pull_request) Successful in 5m22s
Details
Frontend verify / commits (pull_request) Successful in 29s
Details
7b2bd8d379
ksv741 force-pushed fix/118-rounded-money-display from f1ccd3c7ae to 7b2bd8d379 2026-10-28 08:29:21 +03:00 Compare
codex-bot merged commit 1d4990491f into develop 2026-10-28 08:45:56 +03:00
codex-bot deleted branch fix/118-rounded-money-display 2026-10-28 08:45:56 +03:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Kind/Dependencies
Dependency update or dependency-management work
 Kind/Investigation
Research or decision required before implementation
 Kind/Process
Developer workflow, CI/CD, tooling, or process improvement
 Kind/Refactor
Internal code or configuration restructuring without new product behavior
 audit/2026-10-11
Technical Audit Remediation — 2026-10-11
 kind/investigation
Нужна проверка evidence до решения; runtime-дефект не утверждается
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
codex-bot hermes-agent ksv741 publisher-bot renovate-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: WealthLedger/frontend#119