Compare commits
20
Commits
c809102d73
...
develop
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
2b94a16ae5 | ||
|
|
e2062ce837 | ||
|
|
d910d624d6 | ||
|
|
cc45352243 | ||
|
|
ed0b5388ab | ||
|
|
134c951178 | ||
|
|
2fd7d59e65 | ||
|
|
668f2ef70e | ||
|
|
cadba8d075 | ||
|
|
2db39f25d9 | ||
|
|
2d070ce2b5 | ||
|
|
5077bd4f0b | ||
|
|
e2d143df46 | ||
|
|
ad93725a84 | ||
|
|
8ce1e8e444 | ||
|
|
aaee9591d7 | ||
|
|
9619dc9791 | ||
|
|
71fbe7774d | ||
|
|
870b7e6327 | ||
|
|
70a2c335fd |
+6
-7
@@ -8,7 +8,7 @@ Vitest — отдельную JSDOM конфигурацию. Точные versi
|
|||||||
[package.json](../package.json), реализация — source of truth.
|
[package.json](../package.json), реализация — source of truth.
|
||||||
|
|
||||||
```text
|
```text
|
||||||
app → pages → widgets → features → entities → shared
|
app → pages → features → entities → shared
|
||||||
page container → page VM → entity/feature query → shared/api → backend /api/v1
|
page container → page VM → entity/feature query → shared/api → backend /api/v1
|
||||||
↓
|
↓
|
||||||
props → state/section views
|
props → state/section views
|
||||||
@@ -30,14 +30,13 @@ contract; frontend не читает его checkout для генерации
|
|||||||
| --- | --- |
|
| --- | --- |
|
||||||
| Bootstrap, глобальные providers, routes | `app` |
|
| Bootstrap, глобальные providers, routes | `app` |
|
||||||
| Композиция маршрута и поведение, нужное только этому экрану | `pages/<page>` |
|
| Композиция маршрута и поведение, нужное только этому экрану | `pages/<page>` |
|
||||||
| Крупная переиспользуемая композиция экрана | `widgets/<widget>` |
|
|
||||||
| Самостоятельная пользовательская возможность с собственным смыслом | `features/<capability>` |
|
| Самостоятельная пользовательская возможность с собственным смыслом | `features/<capability>` |
|
||||||
| Представление/поведение бизнес-сущности | `entities/<entity>` |
|
| Представление/поведение бизнес-сущности | `entities/<entity>` |
|
||||||
| Переиспользуемый код без WealthLedger domain meaning | `shared` |
|
| Переиспользуемый код без WealthLedger domain meaning | `shared` |
|
||||||
|
|
||||||
Локальный FSD profile: `app → pages → widgets → features → entities → shared`.
|
Локальный FSD profile: `app → pages → features → entities → shared`.
|
||||||
Widget собирает несколько нижних слоёв в самостоятельный UI-блок; компонент для
|
Слой `widgets` не используется: композиция экрана и компонент для одной page
|
||||||
одной page остаётся у page. Form, mutation или click handler сами по себе не
|
остаются у page. Form, mutation или click handler сами по себе не
|
||||||
требуют feature. Два callers не делают domain helper generic shared.
|
требуют feature. Два callers не делают domain helper generic shared.
|
||||||
Slice именуется по ответственности, а не `helpers`, `hooks` или `types`.
|
Slice именуется по ответственности, а не `helpers`, `hooks` или `types`.
|
||||||
|
|
||||||
@@ -49,12 +48,12 @@ Slice именуется по ответственности, а не `helpers`,
|
|||||||
|
|
||||||
Cross-slice consumer использует `@/` и `index.ts` владельца, например
|
Cross-slice consumer использует `@/` и `index.ts` владельца, например
|
||||||
`@/entities/portfolio`. Alias Vite и TypeScript согласован. Другой slice не
|
`@/entities/portfolio`. Alias Vite и TypeScript согласован. Другой slice не
|
||||||
импортирует внутренний файл напрямую. Slices `pages`, `widgets`, `features`, `entities` не зависят от соседнего slice своего слоя;
|
импортирует внутренний файл напрямую. Slices `pages`, `features`, `entities` не зависят от соседнего slice своего слоя;
|
||||||
композиция принадлежит вышележащему owner. Existing меж-slice исключения
|
композиция принадлежит вышележащему owner. Existing меж-slice исключения
|
||||||
не являются разрешением добавлять новые.
|
не являются разрешением добавлять новые.
|
||||||
|
|
||||||
Направление зависимостей, public imports и запрет соседних slices в
|
Направление зависимостей, public imports и запрет соседних slices в
|
||||||
`pages`, `widgets`, `features`, `entities` проверяет `npm run deps`. Внутренние imports
|
`pages`, `features`, `entities` проверяет `npm run deps`. Внутренние imports
|
||||||
одного slice и связи shared segments этот запрет не ограничивает.
|
одного slice и связи shared segments этот запрет не ограничивает.
|
||||||
Knip проверяет использование exports, а не смысл placement.
|
Knip проверяет использование exports, а не смысл placement.
|
||||||
|
|
||||||
|
|||||||
@@ -1,5 +1,61 @@
|
|||||||
# Changelog
|
# Changelog
|
||||||
|
|
||||||
|
## [1.4.0](https://git.personal.ksv741.ru/WealthLedger/frontend/compare/v1.3.0...v1.4.0) (2026-11-06)
|
||||||
|
|
||||||
|
### Features
|
||||||
|
|
||||||
|
* **investments:** warn and offer retry after exhausted read retries (WealthLedger/frontend[#55](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/55)) ([#136](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/136)) ([8ce1e8e](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/8ce1e8e44486dcc23d4c074559ca2bb517880b60))
|
||||||
|
|
||||||
|
### Bug Fixes
|
||||||
|
|
||||||
|
* **account:** show source metadata on empty account and income (WealthLedger/frontend[#55](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/55)) ([#133](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/133)) ([9619dc9](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/9619dc979172dbc16391206e801ed67862d20116))
|
||||||
|
* align audit findings for Events, currency and auth (WealthLedger/frontend[#155](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/155)) ([668f2ef](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/668f2ef70e535a1222e7f600b1be4a31fefc6f8b))
|
||||||
|
|
||||||
|
### Refactoring
|
||||||
|
|
||||||
|
* **api:** consume bank operation oneOf contract (WealthLedger/frontend[#144](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/144)) ([#152](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/152)) ([2d070ce](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/2d070ce2b54bbee466ecf6cc18b437910f0c07f8))
|
||||||
|
* drop dead query helpers and simplify read deadline (WealthLedger/frontend[#141](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/141)) ([#149](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/149)) ([5077bd4](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/5077bd4f0baa4a59643e875485c2f08253cc198d))
|
||||||
|
* move portfolio structure into account page, drop widgets (WealthLedger/frontend[#139](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/139)) ([#140](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/140)) ([e2d143d](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/e2d143df46e650139e49b7c80a886008ede86d2a))
|
||||||
|
* normalize view models and share breadcrumbs and titles (WealthLedger/frontend[#143](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/143)) ([#153](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/153)) ([2db39f2](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/2db39f25d9478350ad56a1b2e2ca6496068257c5))
|
||||||
|
* replace repeated lazy page wrappers with lazyPage helper ([#131](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/131)) ([#132](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/132)) ([71fbe77](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/71fbe7774d3ed63fcb84bc644da997921bc049b2))
|
||||||
|
* share path-root query predicate (WealthLedger/frontend[#142](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/142)) ([#154](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/154)) ([cadba8d](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/cadba8d075daf9b20c0c9de97ad5bd8f5a3e74fc))
|
||||||
|
|
||||||
|
### Maintenance
|
||||||
|
|
||||||
|
* **api:** update OpenAPI snapshot with UpcomingEventsDto.window (WealthLedger/frontend[#134](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/134)) ([#135](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/135)) ([aaee959](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/aaee9591d7880193ee9b0c14339e8477264e4a94))
|
||||||
|
* **deps:** set Renovate release age, PR limit and update groups (WealthLedger/main[#6](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/6)) ([#137](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/137)) ([ad93725](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/ad93725a84615ec329631b71ed8db33337085740))
|
||||||
|
|
||||||
|
## [1.3.0](https://git.personal.ksv741.ru/WealthLedger/frontend/compare/v1.2.1...v1.3.0) (2026-11-01)
|
||||||
|
|
||||||
|
### Features
|
||||||
|
|
||||||
|
* **account:** add concentration tab with top-5 slices and chart (WealthLedger/main[#48](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/48)) ([#127](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/127)) ([70a2c33](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/70a2c335fdddb8b6a99e3f609befe06aeb8cc45d))
|
||||||
|
* group all-account rows by instrument and day (WealthLedger/main[#47](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/47)) ([#126](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/126)) ([71126c9](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/71126c91f0b30f4d65a313ddc7d7f86963340455))
|
||||||
|
* make brokerage account list compact ([#111](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/111)) ([c24704a](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/c24704affacbe7fbc08f5e2b61bb6e7ffa6053b9))
|
||||||
|
* remove top header and rework mobile bottom navigation ([#109](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/109)) ([1a92f02](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/1a92f023c1c79f646424f72710ab74de63386a11))
|
||||||
|
* replace account page accordion with tabs and show open position result ([#112](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/112)) ([3075081](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/3075081df188de0630d314ba15a34fe6efd1eea9))
|
||||||
|
* show return, cash and structure on account cards ([#114](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/114)) ([431559b](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/431559be0fca9eb37f6a09d930d502f939884e39))
|
||||||
|
|
||||||
|
### Bug Fixes
|
||||||
|
|
||||||
|
* round money to currency minor units without negative zero (WealthLedger/frontend[#118](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/118)) ([#119](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/119)) ([1d49904](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/1d4990491f254e1ec6bafad8204872eaae2982d0))
|
||||||
|
* show account source sync status (WealthLedger/frontend[#120](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/120)) ([#121](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/121)) ([a56edf2](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/a56edf2b3757ef0b0f6c42ecbd422a1a563f6505))
|
||||||
|
* show history loading alert only while loading (WealthLedger/frontend[#124](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/124)) ([#125](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/125)) ([6792f5b](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/6792f5b70aa3ba90b2eb2df7e63d3ae2f669e295))
|
||||||
|
* stabilize auth client registration (WealthLedger/frontend[#95](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/95)) ([#122](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/122)) ([5796d2d](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/5796d2d789963e66a3a4bcd79eab44700f16bd31))
|
||||||
|
|
||||||
|
### Refactoring
|
||||||
|
|
||||||
|
* derive api error codes from contract (WealthLedger/backend[#117](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/117)) ([#123](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/123)) ([32e8fe9](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/32e8fe9402665ea0c350f5f247d87e328ffd44c8))
|
||||||
|
|
||||||
|
### Tests
|
||||||
|
|
||||||
|
* pin date in all accounts events test ([#115](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/115)) ([58b4e12](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/58b4e126330d01c1d6865bd0e9dd066a028fba08))
|
||||||
|
|
||||||
|
### Maintenance
|
||||||
|
|
||||||
|
* **deps:** resolve minimatch and glob audit advisories (WealthLedger/main[#49](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/49)) ([#128](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/128)) ([7242240](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/7242240b2188e9d1ca1325e65d0e1a0a3655d882))
|
||||||
|
* sync brokerage accounts contract (WealthLedger/backend[#138](https://git.personal.ksv741.ru/WealthLedger/frontend/issues/138)) ([0e4bbec](https://git.personal.ksv741.ru/WealthLedger/frontend/commit/0e4bbec2a7b814579095ea7ef6db68a70508fa29))
|
||||||
|
|
||||||
## [1.2.1](https://git.personal.ksv741.ru/WealthLedger/frontend/compare/v1.2.0...v1.2.1) (2026-10-24)
|
## [1.2.1](https://git.personal.ksv741.ru/WealthLedger/frontend/compare/v1.2.0...v1.2.1) (2026-10-24)
|
||||||
|
|
||||||
### Bug Fixes
|
### Bug Fixes
|
||||||
|
|||||||
+5
-11
@@ -29,17 +29,17 @@ module.exports = {
|
|||||||
},
|
},
|
||||||
{
|
{
|
||||||
from: {
|
from: {
|
||||||
path: "^src/(app|pages|widgets|features|entities|shared)/([^/]+)/",
|
path: "^src/(app|pages|features|entities|shared)/([^/]+)/",
|
||||||
},
|
},
|
||||||
name: "slices-must-use-public-api",
|
name: "slices-must-use-public-api",
|
||||||
severity: "error",
|
severity: "error",
|
||||||
to: {
|
to: {
|
||||||
path: String.raw`^src/(app|pages|widgets|features|entities|shared)/([^/]+)/(?!index\.ts$)`,
|
path: String.raw`^src/(app|pages|features|entities|shared)/([^/]+)/(?!index\.ts$)`,
|
||||||
pathNot: "^src/$1/$2/",
|
pathNot: "^src/$1/$2/",
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
from: { path: "^src/(pages|widgets|features|entities)/([^/]+)/" },
|
from: { path: "^src/(pages|features|entities)/([^/]+)/" },
|
||||||
name: "no-same-layer-cross-slice-imports",
|
name: "no-same-layer-cross-slice-imports",
|
||||||
severity: "error",
|
severity: "error",
|
||||||
to: { path: "^src/$1/", pathNot: "^src/$1/$2/" },
|
to: { path: "^src/$1/", pathNot: "^src/$1/$2/" },
|
||||||
@@ -48,24 +48,18 @@ module.exports = {
|
|||||||
from: { path: "^src/shared/" },
|
from: { path: "^src/shared/" },
|
||||||
name: "shared-must-not-depend-on-layers",
|
name: "shared-must-not-depend-on-layers",
|
||||||
severity: "error",
|
severity: "error",
|
||||||
to: { path: "^src/(entities|features|widgets|pages|app)/" },
|
to: { path: "^src/(entities|features|pages|app)/" },
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
from: { path: "^src/entities/" },
|
from: { path: "^src/entities/" },
|
||||||
name: "entities-must-not-depend-on-higher-layers",
|
name: "entities-must-not-depend-on-higher-layers",
|
||||||
severity: "error",
|
severity: "error",
|
||||||
to: { path: "^src/(features|widgets|pages|app)/" },
|
to: { path: "^src/(features|pages|app)/" },
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
from: { path: "^src/features/" },
|
from: { path: "^src/features/" },
|
||||||
name: "features-must-not-depend-on-higher-layers",
|
name: "features-must-not-depend-on-higher-layers",
|
||||||
severity: "error",
|
severity: "error",
|
||||||
to: { path: "^src/(widgets|pages|app)/" },
|
|
||||||
},
|
|
||||||
{
|
|
||||||
from: { path: "^src/widgets/" },
|
|
||||||
name: "widgets-must-not-depend-on-higher-layers",
|
|
||||||
severity: "error",
|
|
||||||
to: { path: "^src/(pages|app)/" },
|
to: { path: "^src/(pages|app)/" },
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
|
|||||||
@@ -17,12 +17,21 @@ http {
|
|||||||
default $http_x_forwarded_proto;
|
default $http_x_forwarded_proto;
|
||||||
'' $scheme;
|
'' $scheme;
|
||||||
}
|
}
|
||||||
|
# One shared budget: the external proxy's client-IP forwarding is not verified.
|
||||||
|
map "$request_method:$uri" $auth_admission_key {
|
||||||
|
default "";
|
||||||
|
POST:/api/v1/auth/login auth;
|
||||||
|
POST:/api/v1/auth/register auth;
|
||||||
|
}
|
||||||
|
limit_req_zone $auth_admission_key zone=auth_admission:1m rate=2r/s;
|
||||||
|
limit_req_status 429;
|
||||||
server {
|
server {
|
||||||
listen 8080;
|
listen 8080;
|
||||||
server_name _;
|
server_name _;
|
||||||
root /usr/share/nginx/html;
|
root /usr/share/nginx/html;
|
||||||
resolver 127.0.0.11 valid=5s ipv6=off;
|
resolver 127.0.0.11 valid=5s ipv6=off;
|
||||||
location /api/ {
|
location /api/ {
|
||||||
|
limit_req zone=auth_admission burst=5 nodelay;
|
||||||
set $backend http://backend:3000;
|
set $backend http://backend:3000;
|
||||||
proxy_pass $backend$request_uri;
|
proxy_pass $backend$request_uri;
|
||||||
proxy_set_header Host $http_host;
|
proxy_set_header Host $http_host;
|
||||||
|
|||||||
+6
-1
@@ -25,7 +25,11 @@ const readability = {
|
|||||||
)
|
)
|
||||||
context.report({ messageId: "schema", node });
|
context.report({ messageId: "schema", node });
|
||||||
},
|
},
|
||||||
FunctionDeclaration: checkParameters,
|
FunctionDeclaration(node) {
|
||||||
|
checkParameters(node);
|
||||||
|
if (node.id?.name?.endsWith?.("ViewModel"))
|
||||||
|
context.report({ messageId: "vmName", node: node.id });
|
||||||
|
},
|
||||||
FunctionExpression: checkParameters,
|
FunctionExpression: checkParameters,
|
||||||
ImportDeclaration(node) {
|
ImportDeclaration(node) {
|
||||||
if (
|
if (
|
||||||
@@ -95,6 +99,7 @@ const readability = {
|
|||||||
schema: "Declare Zod schemas in a dedicated *.schema.ts file.",
|
schema: "Declare Zod schemas in a dedicated *.schema.ts file.",
|
||||||
svg: "Own SVG markup in packages/icons, and import its public component.",
|
svg: "Own SVG markup in packages/icons, and import its public component.",
|
||||||
union: "Put complex union members on separate lines.",
|
union: "Put complex union members on separate lines.",
|
||||||
|
vmName: "Name custom hooks use*Vm, not use*ViewModel.",
|
||||||
},
|
},
|
||||||
schema: [],
|
schema: [],
|
||||||
type: "suggestion",
|
type: "suggestion",
|
||||||
|
|||||||
Generated
+2
-2
@@ -1,12 +1,12 @@
|
|||||||
{
|
{
|
||||||
"name": "wealth-ledger-frontend",
|
"name": "wealth-ledger-frontend",
|
||||||
"version": "1.2.1",
|
"version": "1.4.0",
|
||||||
"lockfileVersion": 3,
|
"lockfileVersion": 3,
|
||||||
"requires": true,
|
"requires": true,
|
||||||
"packages": {
|
"packages": {
|
||||||
"": {
|
"": {
|
||||||
"name": "wealth-ledger-frontend",
|
"name": "wealth-ledger-frontend",
|
||||||
"version": "1.2.1",
|
"version": "1.4.0",
|
||||||
"workspaces": [
|
"workspaces": [
|
||||||
"packages/*"
|
"packages/*"
|
||||||
],
|
],
|
||||||
|
|||||||
+1
-1
@@ -1,7 +1,7 @@
|
|||||||
{
|
{
|
||||||
"name": "wealth-ledger-frontend",
|
"name": "wealth-ledger-frontend",
|
||||||
"private": true,
|
"private": true,
|
||||||
"version": "1.2.1",
|
"version": "1.4.0",
|
||||||
"type": "module",
|
"type": "module",
|
||||||
"engines": {
|
"engines": {
|
||||||
"node": "24.22.1"
|
"node": "24.22.1"
|
||||||
|
|||||||
+16
-1
@@ -1,15 +1,30 @@
|
|||||||
{
|
{
|
||||||
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
|
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
|
||||||
"extends": ["config:recommended", ":semanticCommitTypeAll(chore)"],
|
"extends": ["config:recommended", ":semanticCommitTypeAll(chore)", "security:minimumReleaseAgeNpm"],
|
||||||
"timezone": "Europe/Moscow",
|
"timezone": "Europe/Moscow",
|
||||||
"labels": ["dependencies"],
|
"labels": ["dependencies"],
|
||||||
"dependencyDashboard": true,
|
"dependencyDashboard": true,
|
||||||
"rangeStrategy": "pin",
|
"rangeStrategy": "pin",
|
||||||
|
"prConcurrentLimit": 5,
|
||||||
|
"lockFileMaintenance": {
|
||||||
|
"enabled": true,
|
||||||
|
"schedule": ["before 4am on the first day of the month"]
|
||||||
|
},
|
||||||
"packageRules": [
|
"packageRules": [
|
||||||
{
|
{
|
||||||
"matchUpdateTypes": ["minor", "patch"],
|
"matchUpdateTypes": ["minor", "patch"],
|
||||||
"groupName": "non-major dependencies"
|
"groupName": "non-major dependencies"
|
||||||
},
|
},
|
||||||
|
{
|
||||||
|
"matchManagers": ["github-actions"],
|
||||||
|
"matchUpdateTypes": ["minor", "patch"],
|
||||||
|
"groupName": "non-major github actions"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"matchManagers": ["docker-compose", "dockerfile"],
|
||||||
|
"matchUpdateTypes": ["minor", "patch"],
|
||||||
|
"groupName": "non-major container images"
|
||||||
|
},
|
||||||
{
|
{
|
||||||
"matchUpdateTypes": ["major"],
|
"matchUpdateTypes": ["major"],
|
||||||
"dependencyDashboardApproval": true
|
"dependencyDashboardApproval": true
|
||||||
|
|||||||
@@ -46,19 +46,21 @@ const position: Portfolio["positions"][number]
|
|||||||
displayName: "Сбербанк",
|
displayName: "Сбербанк",
|
||||||
figi: "SBER",
|
figi: "SBER",
|
||||||
isin: null,
|
isin: null,
|
||||||
|
issuer: null,
|
||||||
logoName: null,
|
logoName: null,
|
||||||
quantity: "2",
|
quantity: "2",
|
||||||
|
sector: null,
|
||||||
ticker: "SBER",
|
ticker: "SBER",
|
||||||
type: "STOCK",
|
type: "STOCK",
|
||||||
};
|
};
|
||||||
|
|
||||||
const portfolio: Portfolio = {
|
const portfolio: Portfolio = {
|
||||||
cashBalances: [],
|
cash: { currency: "RUB", value: "0" },
|
||||||
isStale: false,
|
isStale: false,
|
||||||
lastSuccessfulAt: "2026-08-15T12:00:00Z",
|
lastSuccessfulAt: "2026-08-15T12:00:00Z",
|
||||||
positions: accounts.map(account => ({ ...position, account })),
|
positions: accounts.map(account => ({ ...position, account })),
|
||||||
structure: { currencies: [], unvaluedCategories: [] },
|
structure: { categories: [], hasNegativeValues: false, totalValue: "0", unvaluedCategories: [] },
|
||||||
totalsByCurrency: [{ currency: "RUB", value: "1200" }],
|
totals: { currency: "RUB", value: "1200" },
|
||||||
};
|
};
|
||||||
|
|
||||||
const receipt: BrokerageOperation
|
const receipt: BrokerageOperation
|
||||||
@@ -104,14 +106,11 @@ const analytics: IncomeAnalytics
|
|||||||
},
|
},
|
||||||
],
|
],
|
||||||
period: { from: "2026-08-01", to: "2026-08-31" },
|
period: { from: "2026-08-01", to: "2026-08-31" },
|
||||||
totalsByCurrency: [
|
total: {
|
||||||
{
|
|
||||||
coupon: { currency: "RUB", value: "2" },
|
coupon: { currency: "RUB", value: "2" },
|
||||||
currency: "RUB",
|
|
||||||
dividend: { currency: "RUB", value: "0" },
|
dividend: { currency: "RUB", value: "0" },
|
||||||
total: { currency: "RUB", value: "2" },
|
total: { currency: "RUB", value: "2" },
|
||||||
},
|
},
|
||||||
],
|
|
||||||
};
|
};
|
||||||
|
|
||||||
const CurrentLocation: FC = () => {
|
const CurrentLocation: FC = () => {
|
||||||
@@ -214,7 +213,8 @@ beforeEach(() => {
|
|||||||
type: "coupon",
|
type: "coupon",
|
||||||
}),
|
}),
|
||||||
),
|
),
|
||||||
incomeTotalsByCurrency: [],
|
incomeTotal: { currency: "RUB", value: "0" },
|
||||||
|
window: { from: "2026-09-01", to: "2026-10-01" },
|
||||||
}),
|
}),
|
||||||
),
|
),
|
||||||
),
|
),
|
||||||
@@ -224,9 +224,9 @@ beforeEach(() => {
|
|||||||
describe("All accounts routes", () => {
|
describe("All accounts routes", () => {
|
||||||
it.each([
|
it.each([
|
||||||
["/accounts/all", "Все счета"],
|
["/accounts/all", "Все счета"],
|
||||||
["/accounts/all/operations", "Журнал операций"],
|
["/accounts/all/operations", "История операций"],
|
||||||
["/accounts/all/income?from=2026-08-01&to=2026-08-31", "Пассивный доход"],
|
["/accounts/all/income?from=2026-08-01&to=2026-08-31", "Пассивный доход"],
|
||||||
["/accounts/all/events", "Будущие события"],
|
["/accounts/all/events", "Предстоящие события"],
|
||||||
])("opens %s directly", async (path, title) => {
|
])("opens %s directly", async (path, title) => {
|
||||||
renderPage(path);
|
renderPage(path);
|
||||||
expect(
|
expect(
|
||||||
@@ -308,9 +308,9 @@ describe("All accounts routes", () => {
|
|||||||
);
|
);
|
||||||
|
|
||||||
for (const [suffix, tab] of [
|
for (const [suffix, tab] of [
|
||||||
["operations", "Операции"],
|
["operations", "История операций"],
|
||||||
["income", "Доход"],
|
["income", "Доход"],
|
||||||
["events", "События"],
|
["events", "Предстоящие события"],
|
||||||
]) {
|
]) {
|
||||||
fireEvent.click(screen.getByRole("tab", { name: tab }));
|
fireEvent.click(screen.getByRole("tab", { name: tab }));
|
||||||
expect(screen.getByRole("link", { name: "Подробнее" }))
|
expect(screen.getByRole("link", { name: "Подробнее" }))
|
||||||
|
|||||||
@@ -1,4 +1,4 @@
|
|||||||
import type { FC } from "react";
|
import type { ComponentType, FC } from "react";
|
||||||
|
|
||||||
import { lazy } from "react";
|
import { lazy } from "react";
|
||||||
import { Navigate, Route, Routes } from "react-router";
|
import { Navigate, Route, Routes } from "react-router";
|
||||||
@@ -6,101 +6,35 @@ import { Navigate, Route, Routes } from "react-router";
|
|||||||
import { LazyPage } from "../RouteFallback";
|
import { LazyPage } from "../RouteFallback";
|
||||||
import { Protected, Public } from "../RouteGuards";
|
import { Protected, Public } from "../RouteGuards";
|
||||||
|
|
||||||
const CardPage = lazy(async () => {
|
// Pages use named exports; React.lazy needs a default export per dynamic import (one chunk each).
|
||||||
const { CardPage } = await import("@/pages/card");
|
function lazyPage<Name extends string>(
|
||||||
|
load: () => Promise<Record<Name, ComponentType>>,
|
||||||
|
name: Name,
|
||||||
|
) {
|
||||||
|
return lazy(async () => {
|
||||||
|
const page = await load();
|
||||||
|
|
||||||
return { default: CardPage };
|
// eslint-disable-next-line security/detect-object-injection -- `name` is a compile-time literal checked against the module's exports.
|
||||||
|
return { default: page[name] };
|
||||||
});
|
});
|
||||||
|
}
|
||||||
|
|
||||||
const CardsPage = lazy(async () => {
|
const CardPage = lazyPage(async () => import("@/pages/card"), "CardPage");
|
||||||
const { CardsPage } = await import("@/pages/cards");
|
const CardsPage = lazyPage(async () => import("@/pages/cards"), "CardsPage");
|
||||||
|
const BondPage = lazyPage(async () => import("@/pages/bond"), "BondPage");
|
||||||
return { default: CardsPage };
|
const BondsPage = lazyPage(async () => import("@/pages/bonds"), "BondsPage");
|
||||||
});
|
const StockPage = lazyPage(async () => import("@/pages/stock"), "StockPage");
|
||||||
|
const StocksPage = lazyPage(async () => import("@/pages/stocks"), "StocksPage");
|
||||||
const BondPage = lazy(async () => {
|
const AccountPage = lazyPage(async () => import("@/pages/account"), "AccountPage");
|
||||||
const { BondPage } = await import("@/pages/bond");
|
const AccountEventsPage = lazyPage(async () => import("@/pages/account-events"), "AccountEventsPage");
|
||||||
|
const AccountOperationsPage = lazyPage(async () => import("@/pages/account-operations"), "AccountOperationsPage");
|
||||||
return { default: BondPage };
|
const AccountIncomePage = lazyPage(async () => import("@/pages/account-income"), "AccountIncomePage");
|
||||||
});
|
const AccountsPage = lazyPage(async () => import("@/pages/accounts"), "AccountsPage");
|
||||||
|
const LoginPage = lazyPage(async () => import("@/pages/login"), "LoginPage");
|
||||||
const BondsPage = lazy(async () => {
|
const NotFoundPage = lazyPage(async () => import("@/pages/not-found"), "NotFoundPage");
|
||||||
const { BondsPage } = await import("@/pages/bonds");
|
const RegisterPage = lazyPage(async () => import("@/pages/register"), "RegisterPage");
|
||||||
|
const SettingsPage = lazyPage(async () => import("@/pages/settings"), "SettingsPage");
|
||||||
return { default: BondsPage };
|
const ProtectedLayout = lazyPage(async () => import("../ProtectedLayout"), "ProtectedLayout");
|
||||||
});
|
|
||||||
|
|
||||||
const StockPage = lazy(async () => {
|
|
||||||
const { StockPage } = await import("@/pages/stock");
|
|
||||||
|
|
||||||
return { default: StockPage };
|
|
||||||
});
|
|
||||||
|
|
||||||
const StocksPage = lazy(async () => {
|
|
||||||
const { StocksPage } = await import("@/pages/stocks");
|
|
||||||
|
|
||||||
return { default: StocksPage };
|
|
||||||
});
|
|
||||||
|
|
||||||
const AccountPage = lazy(async () => {
|
|
||||||
const { AccountPage } = await import("@/pages/account");
|
|
||||||
|
|
||||||
return { default: AccountPage };
|
|
||||||
});
|
|
||||||
|
|
||||||
const AccountEventsPage = lazy(async () => {
|
|
||||||
const { AccountEventsPage } = await import("@/pages/account-events");
|
|
||||||
|
|
||||||
return { default: AccountEventsPage };
|
|
||||||
});
|
|
||||||
|
|
||||||
const AccountOperationsPage = lazy(async () => {
|
|
||||||
const { AccountOperationsPage } = await import("@/pages/account-operations");
|
|
||||||
|
|
||||||
return { default: AccountOperationsPage };
|
|
||||||
});
|
|
||||||
|
|
||||||
const AccountIncomePage = lazy(async () => {
|
|
||||||
const { AccountIncomePage } = await import("@/pages/account-income");
|
|
||||||
|
|
||||||
return { default: AccountIncomePage };
|
|
||||||
});
|
|
||||||
|
|
||||||
const AccountsPage = lazy(async () => {
|
|
||||||
const { AccountsPage } = await import("@/pages/accounts");
|
|
||||||
|
|
||||||
return { default: AccountsPage };
|
|
||||||
});
|
|
||||||
|
|
||||||
const LoginPage = lazy(async () => {
|
|
||||||
const { LoginPage } = await import("@/pages/login");
|
|
||||||
|
|
||||||
return { default: LoginPage };
|
|
||||||
});
|
|
||||||
|
|
||||||
const NotFoundPage = lazy(async () => {
|
|
||||||
const { NotFoundPage } = await import("@/pages/not-found");
|
|
||||||
|
|
||||||
return { default: NotFoundPage };
|
|
||||||
});
|
|
||||||
|
|
||||||
const RegisterPage = lazy(async () => {
|
|
||||||
const { RegisterPage } = await import("@/pages/register");
|
|
||||||
|
|
||||||
return { default: RegisterPage };
|
|
||||||
});
|
|
||||||
|
|
||||||
const SettingsPage = lazy(async () => {
|
|
||||||
const { SettingsPage } = await import("@/pages/settings");
|
|
||||||
|
|
||||||
return { default: SettingsPage };
|
|
||||||
});
|
|
||||||
|
|
||||||
const ProtectedLayout = lazy(async () => {
|
|
||||||
const { ProtectedLayout } = await import("../ProtectedLayout");
|
|
||||||
|
|
||||||
return { default: ProtectedLayout };
|
|
||||||
});
|
|
||||||
|
|
||||||
const AppRoutes: FC = () => (
|
const AppRoutes: FC = () => (
|
||||||
<Routes>
|
<Routes>
|
||||||
|
|||||||
@@ -1,6 +1,5 @@
|
|||||||
import type { FC } from "react";
|
import type { FC } from "react";
|
||||||
|
|
||||||
import { useDocumentTitle } from "@mantine/hooks";
|
|
||||||
import { useTranslation } from "react-i18next";
|
import { useTranslation } from "react-i18next";
|
||||||
|
|
||||||
import { useCurrentRoute } from "@/app/model";
|
import { useCurrentRoute } from "@/app/model";
|
||||||
@@ -8,12 +7,12 @@ import { useBankCard } from "@/entities/bank-card";
|
|||||||
import { useBond } from "@/entities/bond";
|
import { useBond } from "@/entities/bond";
|
||||||
import { useBrokerageAccounts } from "@/entities/brokerage-account";
|
import { useBrokerageAccounts } from "@/entities/brokerage-account";
|
||||||
import { useStock } from "@/entities/stock";
|
import { useStock } from "@/entities/stock";
|
||||||
|
import { useAppDocumentTitle } from "@/shared/ui";
|
||||||
|
|
||||||
type DocumentTitleProps = { title: string };
|
type DocumentTitleProps = { title: string };
|
||||||
|
|
||||||
const DocumentTitle: FC<DocumentTitleProps> = (props): undefined => {
|
const DocumentTitle: FC<DocumentTitleProps> = (props): undefined => {
|
||||||
const { t } = useTranslation();
|
useAppDocumentTitle(props.title);
|
||||||
useDocumentTitle(`${props.title} — ${t("appName")}`);
|
|
||||||
};
|
};
|
||||||
|
|
||||||
type AccountDocumentTitleProps = {
|
type AccountDocumentTitleProps = {
|
||||||
|
|||||||
@@ -1,12 +1,12 @@
|
|||||||
import type { FC, PropsWithChildren } from "react";
|
import type { FC, PropsWithChildren } from "react";
|
||||||
|
|
||||||
import { Button, Stack, Text, Title } from "@mantine/core";
|
import { Button, Stack, Text, Title } from "@mantine/core";
|
||||||
import { useDocumentTitle } from "@mantine/hooks";
|
|
||||||
import { Component } from "react";
|
import { Component } from "react";
|
||||||
import { useTranslation } from "react-i18next";
|
import { useTranslation } from "react-i18next";
|
||||||
import { Link, useLocation } from "react-router";
|
import { Link, useLocation } from "react-router";
|
||||||
|
|
||||||
import { useAuth } from "@/features/auth";
|
import { useAuth } from "@/features/auth";
|
||||||
|
import { useAppDocumentTitle } from "@/shared/ui";
|
||||||
|
|
||||||
type BoundaryProps = PropsWithChildren<{
|
type BoundaryProps = PropsWithChildren<{
|
||||||
authenticated: boolean;
|
authenticated: boolean;
|
||||||
@@ -37,7 +37,7 @@ class Boundary extends Component<BoundaryProps, State> {
|
|||||||
const RouteErrorFallback: FC<RouteErrorFallbackProps> = (props) => {
|
const RouteErrorFallback: FC<RouteErrorFallbackProps> = (props) => {
|
||||||
const { authenticated } = props;
|
const { authenticated } = props;
|
||||||
const { t } = useTranslation();
|
const { t } = useTranslation();
|
||||||
useDocumentTitle(`${t("routeError.title")} — ${t("appName")}`);
|
useAppDocumentTitle(t("routeError.title"));
|
||||||
const to = authenticated ? "/accounts" : "/login";
|
const to = authenticated ? "/accounts" : "/login";
|
||||||
|
|
||||||
return (
|
return (
|
||||||
|
|||||||
@@ -55,9 +55,9 @@ describe("AppBreadcrumbs", () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
it.each([
|
it.each([
|
||||||
["operations", "Операции"],
|
["operations", "История операций"],
|
||||||
["OPERATIONS", "Операции"],
|
["OPERATIONS", "История операций"],
|
||||||
["events", "Будущие события"],
|
["events", "Предстоящие события"],
|
||||||
["income", "Пассивный доход"],
|
["income", "Пассивный доход"],
|
||||||
])("links to the account hierarchy from %s", (section, title) => {
|
])("links to the account hierarchy from %s", (section, title) => {
|
||||||
renderBreadcrumbs(`/accounts/account-1/${section}`, [
|
renderBreadcrumbs(`/accounts/account-1/${section}`, [
|
||||||
|
|||||||
@@ -7,10 +7,8 @@ import { useCurrentRoute } from "@/app/model";
|
|||||||
|
|
||||||
import { AccountBreadcrumbs } from "./AccountBreadcrumbs";
|
import { AccountBreadcrumbs } from "./AccountBreadcrumbs";
|
||||||
import { AccountScopeSwitch } from "./AccountScopeSwitch/AccountScopeSwitch";
|
import { AccountScopeSwitch } from "./AccountScopeSwitch/AccountScopeSwitch";
|
||||||
import { BondBreadcrumbs } from "./BondBreadcrumbs";
|
|
||||||
import { BreadcrumbTrail } from "./BreadcrumbTrail";
|
import { BreadcrumbTrail } from "./BreadcrumbTrail";
|
||||||
import { CardBreadcrumbs } from "./CardBreadcrumbs";
|
import { EntityBreadcrumbs } from "./EntityBreadcrumbs";
|
||||||
import { StockBreadcrumbs } from "./StockBreadcrumbs";
|
|
||||||
|
|
||||||
const AppBreadcrumbs: FC = () => {
|
const AppBreadcrumbs: FC = () => {
|
||||||
const { t } = useTranslation();
|
const { t } = useTranslation();
|
||||||
@@ -26,9 +24,16 @@ const AppBreadcrumbs: FC = () => {
|
|||||||
stock,
|
stock,
|
||||||
} = useCurrentRoute();
|
} = useCurrentRoute();
|
||||||
|
|
||||||
if (bond) return <BondBreadcrumbs identifier={bond.params.bondId ?? ""} />;
|
if (bond) {
|
||||||
if (stock)
|
return <EntityBreadcrumbs identifier={bond.params.bondId ?? ""} kind="bond" />;
|
||||||
return <StockBreadcrumbs identifier={stock.params.stockId ?? ""} />;
|
}
|
||||||
|
|
||||||
|
if (stock) {
|
||||||
|
return (
|
||||||
|
<EntityBreadcrumbs identifier={stock.params.stockId ?? ""} kind="stock" />
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
if (account && (section || !account.params.section))
|
if (account && (section || !account.params.section))
|
||||||
return (
|
return (
|
||||||
<Stack gap={0} mb="md">
|
<Stack gap={0} mb="md">
|
||||||
@@ -43,8 +48,13 @@ const AppBreadcrumbs: FC = () => {
|
|||||||
/>
|
/>
|
||||||
</Stack>
|
</Stack>
|
||||||
);
|
);
|
||||||
if (card) return <CardBreadcrumbs identifier={card.params.cardId ?? ""} />;
|
|
||||||
|
if (card) {
|
||||||
|
return <EntityBreadcrumbs identifier={card.params.cardId ?? ""} kind="card" />;
|
||||||
|
}
|
||||||
|
|
||||||
if (cards) return <BreadcrumbTrail items={[{ label: t("bank.title") }]} />;
|
if (cards) return <BreadcrumbTrail items={[{ label: t("bank.title") }]} />;
|
||||||
|
|
||||||
if (accounts)
|
if (accounts)
|
||||||
return <BreadcrumbTrail items={[{ label: t("breadcrumbs.accounts") }]} />;
|
return <BreadcrumbTrail items={[{ label: t("breadcrumbs.accounts") }]} />;
|
||||||
|
|
||||||
|
|||||||
@@ -1,25 +0,0 @@
|
|||||||
import type { FC } from "react";
|
|
||||||
|
|
||||||
import { useTranslation } from "react-i18next";
|
|
||||||
|
|
||||||
import { useBond } from "@/entities/bond";
|
|
||||||
|
|
||||||
import { BreadcrumbTrail } from "./BreadcrumbTrail";
|
|
||||||
|
|
||||||
type BondBreadcrumbsProps = { identifier: string };
|
|
||||||
|
|
||||||
const BondBreadcrumbs: FC<BondBreadcrumbsProps> = (props) => {
|
|
||||||
const { data } = useBond(props.identifier);
|
|
||||||
const { t } = useTranslation();
|
|
||||||
|
|
||||||
return (
|
|
||||||
<BreadcrumbTrail
|
|
||||||
items={[
|
|
||||||
{ label: t("bond.searchTitle"), to: "/bonds" },
|
|
||||||
{ label: data?.name ?? t("bond.instrument") },
|
|
||||||
]}
|
|
||||||
/>
|
|
||||||
);
|
|
||||||
};
|
|
||||||
|
|
||||||
export { BondBreadcrumbs };
|
|
||||||
@@ -39,4 +39,4 @@ const BreadcrumbTrail: FC<BreadcrumbTrailProps> = (props) => {
|
|||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|
||||||
export { BreadcrumbTrail };
|
export { BreadcrumbTrail, type Crumb };
|
||||||
|
|||||||
@@ -1,25 +0,0 @@
|
|||||||
import type { FC } from "react";
|
|
||||||
|
|
||||||
import { useTranslation } from "react-i18next";
|
|
||||||
|
|
||||||
import { useBankCard } from "@/entities/bank-card";
|
|
||||||
|
|
||||||
import { BreadcrumbTrail } from "./BreadcrumbTrail";
|
|
||||||
|
|
||||||
type CardBreadcrumbsProps = { identifier: string };
|
|
||||||
|
|
||||||
const CardBreadcrumbs: FC<CardBreadcrumbsProps> = (props) => {
|
|
||||||
const { data } = useBankCard(props.identifier);
|
|
||||||
const { t } = useTranslation();
|
|
||||||
|
|
||||||
return (
|
|
||||||
<BreadcrumbTrail
|
|
||||||
items={[
|
|
||||||
{ label: t("bank.title"), to: "/cards" },
|
|
||||||
{ label: data?.name ?? t("bank.card") },
|
|
||||||
]}
|
|
||||||
/>
|
|
||||||
);
|
|
||||||
};
|
|
||||||
|
|
||||||
export { CardBreadcrumbs };
|
|
||||||
@@ -0,0 +1,48 @@
|
|||||||
|
import type { FC } from "react";
|
||||||
|
|
||||||
|
import { useTranslation } from "react-i18next";
|
||||||
|
|
||||||
|
import { useBankCard } from "@/entities/bank-card";
|
||||||
|
import { useBond } from "@/entities/bond";
|
||||||
|
import { useStock } from "@/entities/stock";
|
||||||
|
|
||||||
|
import type { Crumb } from "./BreadcrumbTrail";
|
||||||
|
|
||||||
|
import { BreadcrumbTrail } from "./BreadcrumbTrail";
|
||||||
|
|
||||||
|
type EntityBreadcrumbsProps = {
|
||||||
|
identifier: string;
|
||||||
|
kind:
|
||||||
|
| "bond"
|
||||||
|
| "card"
|
||||||
|
| "stock";
|
||||||
|
};
|
||||||
|
|
||||||
|
const EntityBreadcrumbs: FC<EntityBreadcrumbsProps> = (props) => {
|
||||||
|
const { identifier, kind } = props;
|
||||||
|
const { t } = useTranslation();
|
||||||
|
|
||||||
|
const bond = useBond(kind === "bond" ? identifier : "");
|
||||||
|
const card = useBankCard(kind === "card" ? identifier : "");
|
||||||
|
const stock = useStock(kind === "stock" ? identifier : "");
|
||||||
|
|
||||||
|
let parent: Crumb;
|
||||||
|
let name: string;
|
||||||
|
|
||||||
|
if (kind === "bond") {
|
||||||
|
parent = { label: t("bond.searchTitle"), to: "/bonds" };
|
||||||
|
name = bond.data?.name ?? t("bond.instrument");
|
||||||
|
}
|
||||||
|
else if (kind === "stock") {
|
||||||
|
parent = { label: t("stock.searchTitle"), to: "/stocks" };
|
||||||
|
name = stock.data?.name ?? t("stock.share");
|
||||||
|
}
|
||||||
|
else {
|
||||||
|
parent = { label: t("bank.title"), to: "/cards" };
|
||||||
|
name = card.data?.name ?? t("bank.card");
|
||||||
|
}
|
||||||
|
|
||||||
|
return <BreadcrumbTrail items={[parent, { label: name }]} />;
|
||||||
|
};
|
||||||
|
|
||||||
|
export { EntityBreadcrumbs };
|
||||||
@@ -1,25 +0,0 @@
|
|||||||
import type { FC } from "react";
|
|
||||||
|
|
||||||
import { useTranslation } from "react-i18next";
|
|
||||||
|
|
||||||
import { useStock } from "@/entities/stock";
|
|
||||||
|
|
||||||
import { BreadcrumbTrail } from "./BreadcrumbTrail";
|
|
||||||
|
|
||||||
type StockBreadcrumbsProps = { identifier: string };
|
|
||||||
|
|
||||||
const StockBreadcrumbs: FC<StockBreadcrumbsProps> = (props) => {
|
|
||||||
const { data } = useStock(props.identifier);
|
|
||||||
const { t } = useTranslation();
|
|
||||||
|
|
||||||
return (
|
|
||||||
<BreadcrumbTrail
|
|
||||||
items={[
|
|
||||||
{ label: t("stock.searchTitle"), to: "/stocks" },
|
|
||||||
{ label: data?.name ?? t("stock.share") },
|
|
||||||
]}
|
|
||||||
/>
|
|
||||||
);
|
|
||||||
};
|
|
||||||
|
|
||||||
export { StockBreadcrumbs };
|
|
||||||
@@ -5,6 +5,7 @@ import {
|
|||||||
ApiErrorCode,
|
ApiErrorCode,
|
||||||
apiErrorCode,
|
apiErrorCode,
|
||||||
isApiErrorCode,
|
isApiErrorCode,
|
||||||
|
isGetUnder,
|
||||||
} from "@/shared/api";
|
} from "@/shared/api";
|
||||||
|
|
||||||
import type {
|
import type {
|
||||||
@@ -26,21 +27,14 @@ async function mutationData<T>(
|
|||||||
return data;
|
return data;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const bankCardGetPredicate = isGetUnder(["/api/v1/bank-cards"]);
|
||||||
|
|
||||||
function useBankMutationOptions() {
|
function useBankMutationOptions() {
|
||||||
const queryClient = useQueryClient();
|
const queryClient = useQueryClient();
|
||||||
|
|
||||||
const invalidate = () =>
|
const invalidate = () =>
|
||||||
queryClient.invalidateQueries({
|
queryClient.invalidateQueries({
|
||||||
predicate: ({ queryKey }) => {
|
predicate: ({ queryKey }) => bankCardGetPredicate(queryKey),
|
||||||
const [method, path] = queryKey;
|
|
||||||
|
|
||||||
return (
|
|
||||||
method === "get"
|
|
||||||
&& typeof path === "string"
|
|
||||||
&& (path === "/api/v1/bank-cards"
|
|
||||||
|| path.startsWith("/api/v1/bank-cards/"))
|
|
||||||
);
|
|
||||||
},
|
|
||||||
});
|
});
|
||||||
|
|
||||||
return {
|
return {
|
||||||
|
|||||||
@@ -49,6 +49,10 @@ function entryLabelKey(operation: BrokerageOperation): string {
|
|||||||
return `ledger.category.${operation.category}`;
|
return `ledger.category.${operation.category}`;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
function isCouponPayment(operation: BrokerageOperation): boolean {
|
||||||
|
return isOperationType(operation.type, OperationType.Coupon);
|
||||||
|
}
|
||||||
|
|
||||||
function isIncomePayment(operation: BrokerageOperation): boolean {
|
function isIncomePayment(operation: BrokerageOperation): boolean {
|
||||||
return [OperationType.Coupon, OperationType.Dividend].some(type =>
|
return [OperationType.Coupon, OperationType.Dividend].some(type =>
|
||||||
isOperationType(operation.type, type),
|
isOperationType(operation.type, type),
|
||||||
@@ -131,6 +135,7 @@ function paymentPresentation(
|
|||||||
export {
|
export {
|
||||||
brokerageOperationGroupKey,
|
brokerageOperationGroupKey,
|
||||||
entryLabelKey,
|
entryLabelKey,
|
||||||
|
isCouponPayment,
|
||||||
isIncomePayment,
|
isIncomePayment,
|
||||||
isZeroDecimal,
|
isZeroDecimal,
|
||||||
operationLabelKey,
|
operationLabelKey,
|
||||||
|
|||||||
@@ -55,23 +55,27 @@ function renderGroup(
|
|||||||
}
|
}
|
||||||
|
|
||||||
describe("OperationGroup", () => {
|
describe("OperationGroup", () => {
|
||||||
it("shows the header, exact total and separate card rows per account", () => {
|
it("shows the received coupon and positive totals in flat account rows", () => {
|
||||||
renderGroup([
|
renderGroup([
|
||||||
operation("1", { id: "broker", name: "Брокерский" }, "0.1"),
|
{ ...operation("1", { id: "broker", name: "Брокерский" }, "0.1"), description: "Выплата купонов СФО ВТБ РКС Эталон 04" },
|
||||||
operation("2", { id: "iis", name: "ИИС" }, "0.2"),
|
operation("2", { id: "iis", name: "ИИС" }, "0.2"),
|
||||||
]);
|
]);
|
||||||
|
|
||||||
expect(screen.getByText("Купон · BOND")).toBeInTheDocument();
|
expect(screen.getByText("Выплата купонов СФО ВТБ РКС Эталон 04")).toBeInTheDocument();
|
||||||
expect(screen.getByText("+0,3 ₽")).toBeInTheDocument();
|
expect(screen.getByText("+0,3 ₽")).toBeInTheDocument();
|
||||||
|
|
||||||
const accounts = within(screen.getByRole("list", {
|
const accounts = within(screen.getByRole("list", {
|
||||||
name: /Купон · BOND, Исполнено 14\.08\.2026.*, \+0,3 ₽/,
|
name: /Выплата купонов СФО ВТБ РКС Эталон 04, Исполнено 14\.08\.2026.*, \+0,3 ₽/,
|
||||||
}));
|
}));
|
||||||
|
|
||||||
expect(accounts.getByRole("listitem", { name: "Брокерский, +0,1 ₽" }))
|
expect(accounts.getByRole("listitem", { name: "Брокерский, +0,1 ₽" }))
|
||||||
.toHaveTextContent("Купон");
|
.toHaveTextContent("Купон");
|
||||||
|
expect(accounts.getByText("+0,1 ₽")).toHaveClass(/positive/);
|
||||||
expect(accounts.getByRole("listitem", { name: "ИИС, +0,2 ₽" }))
|
expect(accounts.getByRole("listitem", { name: "ИИС, +0,2 ₽" }))
|
||||||
.toHaveTextContent("Купон");
|
.toHaveTextContent("Купон");
|
||||||
|
expect(accounts.getByText("+0,2 ₽")).toHaveClass(/positive/);
|
||||||
|
expect(accounts.getByRole("listitem", { name: "ИИС, +0,2 ₽" }))
|
||||||
|
.not.toHaveClass("EntryGroup_accountCardRow");
|
||||||
expect(accounts.queryByText(/Исполнено/)).not.toBeInTheDocument();
|
expect(accounts.queryByText(/Исполнено/)).not.toBeInTheDocument();
|
||||||
expect(accounts.queryByRole("link")).not.toBeInTheDocument();
|
expect(accounts.queryByRole("link")).not.toBeInTheDocument();
|
||||||
});
|
});
|
||||||
@@ -83,8 +87,10 @@ describe("OperationGroup", () => {
|
|||||||
]);
|
]);
|
||||||
|
|
||||||
expect(screen.getByRole("list", {
|
expect(screen.getByRole("list", {
|
||||||
name: /Купон · BOND, Исполнено .*Итог недоступен/,
|
name: /Выплата купонов BOND, Исполнено .*Итог недоступен/,
|
||||||
})).toBeInTheDocument();
|
})).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("Итог недоступен")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("—")).not.toHaveClass(/positive/);
|
||||||
});
|
});
|
||||||
|
|
||||||
it.each(["0", "0.000"])(
|
it.each(["0", "0.000"])(
|
||||||
@@ -114,6 +120,7 @@ describe("OperationGroup", () => {
|
|||||||
operation("2", { id: "iis", name: "ИИС" }, "-100"),
|
operation("2", { id: "iis", name: "ИИС" }, "-100"),
|
||||||
]);
|
]);
|
||||||
expect(screen.getByText("0 ₽")).toBeInTheDocument();
|
expect(screen.getByText("0 ₽")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("−100 ₽")).toHaveClass(/negative/);
|
||||||
});
|
});
|
||||||
|
|
||||||
it("renders repeated ids inside one group as separate rows", () => {
|
it("renders repeated ids inside one group as separate rows", () => {
|
||||||
@@ -123,7 +130,7 @@ describe("OperationGroup", () => {
|
|||||||
]);
|
]);
|
||||||
|
|
||||||
expect(screen.getByText("+30 ₽")).toBeInTheDocument();
|
expect(screen.getByText("+30 ₽")).toBeInTheDocument();
|
||||||
const accounts = within(screen.getByRole("list", { name: /Купон/ }));
|
const accounts = within(screen.getByRole("list", { name: /Выплата купонов/ }));
|
||||||
expect(accounts.getAllByText("Брокерский")).toHaveLength(1);
|
expect(accounts.getAllByText("Брокерский")).toHaveLength(1);
|
||||||
expect(accounts.getAllByText("ИИС")).toHaveLength(1);
|
expect(accounts.getAllByText("ИИС")).toHaveLength(1);
|
||||||
expect(accounts.getAllByRole("listitem")).toHaveLength(2);
|
expect(accounts.getAllByRole("listitem")).toHaveLength(2);
|
||||||
|
|||||||
@@ -9,12 +9,13 @@ import {
|
|||||||
sumMoney,
|
sumMoney,
|
||||||
totalText,
|
totalText,
|
||||||
} from "@/shared/lib";
|
} from "@/shared/lib";
|
||||||
import { AccountCardRow, EntryGroup, EntryGroupTotal } from "@/shared/ui";
|
import { AccountCardRow, AccountRow, EntryGroup, EntryGroupTotal } from "@/shared/ui";
|
||||||
|
|
||||||
import type { BrokerageOperation } from "../api/useBrokerageOperations";
|
import type { BrokerageOperation } from "../api/useBrokerageOperations";
|
||||||
|
|
||||||
import {
|
import {
|
||||||
entryLabelKey,
|
entryLabelKey,
|
||||||
|
isCouponPayment,
|
||||||
isZeroDecimal,
|
isZeroDecimal,
|
||||||
operationLabelKey,
|
operationLabelKey,
|
||||||
paymentPresentation,
|
paymentPresentation,
|
||||||
@@ -37,6 +38,8 @@ const OperationGroup: FC<OperationGroupProps> = (props) => {
|
|||||||
? entryLabelKey(first)
|
? entryLabelKey(first)
|
||||||
: operationLabelKey(first.type));
|
: operationLabelKey(first.type));
|
||||||
|
|
||||||
|
const isCoupon = isCouponPayment(first);
|
||||||
|
|
||||||
const instrument
|
const instrument
|
||||||
= first.ticker ?? first.instrumentType ?? t("ledger.noInstrument");
|
= first.ticker ?? first.instrumentType ?? t("ledger.noInstrument");
|
||||||
|
|
||||||
@@ -52,9 +55,21 @@ const OperationGroup: FC<OperationGroupProps> = (props) => {
|
|||||||
: null;
|
: null;
|
||||||
|
|
||||||
const date = formatSnapshotDay(first.occurredAt);
|
const date = formatSnapshotDay(first.occurredAt);
|
||||||
const title = `${typeLabel} · ${instrument}`;
|
const description = first.description.trim();
|
||||||
|
let title = `${typeLabel} · ${instrument}`;
|
||||||
|
|
||||||
|
if (isCoupon) {
|
||||||
|
title = description && description.toLocaleLowerCase() !== "купон"
|
||||||
|
? description
|
||||||
|
: t("ledger.couponPayment", { instrument });
|
||||||
|
}
|
||||||
|
|
||||||
const totalsText = totalText(totals, true);
|
const totalsText = totalText(totals, true);
|
||||||
|
|
||||||
|
const totalTone = isCoupon && totals && !isZeroDecimal(totals.value) && !totals.value.startsWith("-")
|
||||||
|
? "positive"
|
||||||
|
: "neutral";
|
||||||
|
|
||||||
const accessibleName = [
|
const accessibleName = [
|
||||||
title,
|
title,
|
||||||
t("payout.executedAt", { date }),
|
t("payout.executedAt", { date }),
|
||||||
@@ -63,13 +78,14 @@ const OperationGroup: FC<OperationGroupProps> = (props) => {
|
|||||||
|
|
||||||
return (
|
return (
|
||||||
<EntryGroup
|
<EntryGroup
|
||||||
|
flat={isCoupon}
|
||||||
header={(
|
header={(
|
||||||
<EntryCard
|
<EntryCard
|
||||||
imageSrc={instrumentLogoUrl(first.logoName)}
|
imageSrc={instrumentLogoUrl(first.logoName)}
|
||||||
initial={(first.ticker?.trim()[0] ?? "?").toUpperCase()}
|
initial={(first.ticker?.trim()[0] ?? "?").toUpperCase()}
|
||||||
metadata={t("payout.executedAt", { date })}
|
metadata={t("payout.executedAt", { date })}
|
||||||
title={title}
|
title={title}
|
||||||
tone="neutral"
|
tone={totalTone}
|
||||||
value={<EntryGroupTotal isSigned totals={totals} />}
|
value={<EntryGroupTotal isSigned totals={totals} />}
|
||||||
valueLabel={typeLabel}
|
valueLabel={typeLabel}
|
||||||
wrap
|
wrap
|
||||||
@@ -80,14 +96,15 @@ const OperationGroup: FC<OperationGroupProps> = (props) => {
|
|||||||
{props.entries.map(({ key, operation }) => {
|
{props.entries.map(({ key, operation }) => {
|
||||||
const payment = paymentPresentation(operation);
|
const payment = paymentPresentation(operation);
|
||||||
|
|
||||||
return (
|
const accountRowProps = {
|
||||||
<AccountCardRow
|
accountName: operation.account?.name ?? "—",
|
||||||
accountName={operation.account?.name ?? "—"}
|
value: payment.amount,
|
||||||
key={key}
|
valueLabel: t(payment.label),
|
||||||
value={payment.amount}
|
};
|
||||||
valueLabel={t(payment.label)}
|
|
||||||
/>
|
return isCoupon
|
||||||
);
|
? <AccountRow key={key} {...accountRowProps} tone={payment.tone} />
|
||||||
|
: <AccountCardRow key={key} {...accountRowProps} />;
|
||||||
})}
|
})}
|
||||||
</EntryGroup>
|
</EntryGroup>
|
||||||
);
|
);
|
||||||
|
|||||||
@@ -4,8 +4,6 @@ import type {
|
|||||||
BrokerageAccount,
|
BrokerageAccount,
|
||||||
} from "../api/useBrokerageAccounts";
|
} from "../api/useBrokerageAccounts";
|
||||||
|
|
||||||
const VISIBLE_CURRENCY_LIMIT = 2;
|
|
||||||
|
|
||||||
type BrokerageAccountCard = {
|
type BrokerageAccountCard = {
|
||||||
account: BrokerageAccount;
|
account: BrokerageAccount;
|
||||||
positionCounts: null | PositionCounts;
|
positionCounts: null | PositionCounts;
|
||||||
@@ -13,18 +11,13 @@ type BrokerageAccountCard = {
|
|||||||
summary:
|
summary:
|
||||||
| {
|
| {
|
||||||
portfolio: NonNullable<BrokerageAccount["portfolioSummary"]>;
|
portfolio: NonNullable<BrokerageAccount["portfolioSummary"]>;
|
||||||
remainingCurrencyCount: number;
|
|
||||||
state: "available";
|
state: "available";
|
||||||
totals: Money[];
|
totals: NonNullable<BrokerageAccount["portfolioSummary"]>["totals"];
|
||||||
}
|
}
|
||||||
| { state: "empty" }
|
| { state: "empty" }
|
||||||
| { state: "unavailable" };
|
| { state: "unavailable" };
|
||||||
};
|
};
|
||||||
|
|
||||||
type Money = NonNullable<
|
|
||||||
BrokerageAccount["portfolioSummary"]
|
|
||||||
>["totalsByCurrency"][number];
|
|
||||||
|
|
||||||
type PositionCounts = { bonds: number; stocks: number; total: number };
|
type PositionCounts = { bonds: number; stocks: number; total: number };
|
||||||
|
|
||||||
function accountTypeKey(type: BrokerageAccount["type"]) {
|
function accountTypeKey(type: BrokerageAccount["type"]) {
|
||||||
@@ -57,7 +50,7 @@ function brokerageAccountCards(
|
|||||||
total: summary.totalPositionCount,
|
total: summary.totalPositionCount,
|
||||||
};
|
};
|
||||||
|
|
||||||
if (summary.totalsByCurrency.length === 0)
|
if (Number(summary.totals.value) === 0)
|
||||||
return { account, positionCounts, source, summary: { state: "empty" } };
|
return { account, positionCounts, source, summary: { state: "empty" } };
|
||||||
|
|
||||||
return {
|
return {
|
||||||
@@ -66,12 +59,8 @@ function brokerageAccountCards(
|
|||||||
source,
|
source,
|
||||||
summary: {
|
summary: {
|
||||||
portfolio: summary,
|
portfolio: summary,
|
||||||
remainingCurrencyCount: Math.max(
|
|
||||||
summary.totalsByCurrency.length - VISIBLE_CURRENCY_LIMIT,
|
|
||||||
0,
|
|
||||||
),
|
|
||||||
state: "available",
|
state: "available",
|
||||||
totals: summary.totalsByCurrency.slice(0, VISIBLE_CURRENCY_LIMIT),
|
totals: summary.totals,
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
});
|
});
|
||||||
|
|||||||
+20
-2
@@ -65,18 +65,32 @@
|
|||||||
|
|
||||||
.summary {
|
.summary {
|
||||||
font-variant-numeric: tabular-nums lining-nums;
|
font-variant-numeric: tabular-nums lining-nums;
|
||||||
white-space: nowrap;
|
align-items: flex-end;
|
||||||
|
}
|
||||||
|
|
||||||
|
.currencySummary {
|
||||||
|
min-width: 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
.total {
|
.total {
|
||||||
color: var(--wl-color-text);
|
color: var(--wl-color-text);
|
||||||
font-size: var(--mantine-font-size-lg);
|
font-size: var(--mantine-font-size-lg);
|
||||||
line-height: var(--mantine-line-height-lg);
|
line-height: var(--mantine-line-height-lg);
|
||||||
|
overflow-wrap: anywhere;
|
||||||
}
|
}
|
||||||
|
|
||||||
.return,
|
.return,
|
||||||
.cashValue {
|
.cashValue {
|
||||||
font-variant-numeric: tabular-nums lining-nums;
|
font-variant-numeric: tabular-nums lining-nums;
|
||||||
|
}
|
||||||
|
|
||||||
|
.return {
|
||||||
|
justify-content: flex-end;
|
||||||
|
min-width: 0;
|
||||||
|
overflow-wrap: anywhere;
|
||||||
|
}
|
||||||
|
|
||||||
|
.cashValue {
|
||||||
white-space: nowrap;
|
white-space: nowrap;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -138,7 +152,11 @@
|
|||||||
text-align: left;
|
text-align: left;
|
||||||
}
|
}
|
||||||
|
|
||||||
.balance > div {
|
.summary {
|
||||||
|
align-items: flex-start;
|
||||||
|
}
|
||||||
|
|
||||||
|
.return {
|
||||||
justify-content: flex-start;
|
justify-content: flex-start;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
+17
-53
@@ -14,36 +14,29 @@ type PortfolioSummary = NonNullable<BrokerageAccount["portfolioSummary"]>;
|
|||||||
const rubReturn = {
|
const rubReturn = {
|
||||||
absolute: "136900",
|
absolute: "136900",
|
||||||
costBasis: "1103600.50",
|
costBasis: "1103600.50",
|
||||||
currency: "RUB",
|
|
||||||
partial: false,
|
partial: false,
|
||||||
percent: "12.40",
|
percent: "12.40",
|
||||||
};
|
};
|
||||||
|
|
||||||
const portfolioSummary = {
|
const portfolioSummary = {
|
||||||
bondPositionCount: 12,
|
bondPositionCount: 12,
|
||||||
cashBalances: [
|
cash: { currency: "RUB", value: "82500.50" },
|
||||||
{ currency: "RUB", value: "82500.50" },
|
|
||||||
{ currency: "USD", value: "1500" },
|
|
||||||
],
|
|
||||||
fundPositionCount: 2,
|
fundPositionCount: 2,
|
||||||
stockPositionCount: 5,
|
stockPositionCount: 5,
|
||||||
structure: {
|
structure: {
|
||||||
currencies: [{
|
|
||||||
categories: [
|
categories: [
|
||||||
{ sharePercent: "55.000000", type: "STOCK", value: "682500" },
|
{ sharePercent: "55.000000", type: "STOCK", value: "682500" },
|
||||||
{ sharePercent: "25.000000", type: "BOND", value: "310500" },
|
{ sharePercent: "25.000000", type: "BOND", value: "310500" },
|
||||||
{ sharePercent: "10.000000", type: "OTHER", value: "124200" },
|
{ sharePercent: "10.000000", type: "OTHER", value: "124200" },
|
||||||
{ sharePercent: "10.000000", type: "CASH", value: "124200" },
|
{ sharePercent: "10.000000", type: "CASH", value: "124200" },
|
||||||
],
|
],
|
||||||
currency: "RUB",
|
|
||||||
hasNegativeValues: false,
|
hasNegativeValues: false,
|
||||||
totalValue: "1241400",
|
totalValue: "1241400",
|
||||||
}],
|
|
||||||
unvaluedCategories: [],
|
unvaluedCategories: [],
|
||||||
},
|
},
|
||||||
totalPositionCount: 19,
|
totalPositionCount: 19,
|
||||||
totalsByCurrency: [{ currency: "RUB", value: "1240500.50" }],
|
totals: { currency: "RUB", value: "1240500.50" },
|
||||||
unrealizedReturnByCurrency: [rubReturn],
|
unrealizedReturn: rubReturn,
|
||||||
} satisfies PortfolioSummary;
|
} satisfies PortfolioSummary;
|
||||||
|
|
||||||
function account(
|
function account(
|
||||||
@@ -63,20 +56,25 @@ function account(
|
|||||||
|
|
||||||
const negativeSummary: PortfolioSummary = {
|
const negativeSummary: PortfolioSummary = {
|
||||||
...portfolioSummary,
|
...portfolioSummary,
|
||||||
unrealizedReturnByCurrency: [{
|
unrealizedReturn: {
|
||||||
...rubReturn,
|
...rubReturn,
|
||||||
absolute: "-4200",
|
absolute: "-4200",
|
||||||
percent: "-3.05",
|
percent: "-3.05",
|
||||||
}],
|
},
|
||||||
};
|
};
|
||||||
|
|
||||||
const emptySummary: PortfolioSummary = {
|
const emptySummary: PortfolioSummary = {
|
||||||
...portfolioSummary,
|
...portfolioSummary,
|
||||||
cashBalances: [],
|
cash: { currency: "RUB", value: "0" },
|
||||||
structure: { currencies: [], unvaluedCategories: [] },
|
structure: {
|
||||||
|
categories: [],
|
||||||
|
hasNegativeValues: false,
|
||||||
|
totalValue: "0",
|
||||||
|
unvaluedCategories: [],
|
||||||
|
},
|
||||||
totalPositionCount: 0,
|
totalPositionCount: 0,
|
||||||
totalsByCurrency: [],
|
totals: { currency: "RUB", value: "0" },
|
||||||
unrealizedReturnByCurrency: [],
|
unrealizedReturn: rubReturn,
|
||||||
};
|
};
|
||||||
|
|
||||||
const meta = {
|
const meta = {
|
||||||
@@ -94,7 +92,7 @@ const meta = {
|
|||||||
docs: {
|
docs: {
|
||||||
description: {
|
description: {
|
||||||
component:
|
component:
|
||||||
"Карточки счетов: стоимость и доходность по валютам, деньги, структура и свежесть источника. Денежные и процентные значения остаются строками. Все примеры содержат вымышленные данные; ссылки работают только внутри MemoryRouter.",
|
"Карточки счетов: стоимость и доходность, деньги, структура и свежесть источника. Денежные и процентные значения остаются строками. Все примеры содержат вымышленные данные; ссылки работают только внутри MemoryRouter.",
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
@@ -108,40 +106,6 @@ type Story = StoryObj<typeof meta>;
|
|||||||
|
|
||||||
export const Normal: Story = {};
|
export const Normal: Story = {};
|
||||||
|
|
||||||
export const MultiCurrency: Story = {
|
|
||||||
args: {
|
|
||||||
accounts: brokerageAccountCards([account("multi", "Мультивалютный", {
|
|
||||||
...portfolioSummary,
|
|
||||||
cashBalances: [
|
|
||||||
{ currency: "RUB", value: "82500.50" },
|
|
||||||
{ currency: "USD", value: "1500" },
|
|
||||||
],
|
|
||||||
totalsByCurrency: [
|
|
||||||
{ currency: "RUB", value: "1240500.50" },
|
|
||||||
{ currency: "USD", value: "3200" },
|
|
||||||
{ currency: "EUR", value: "900" },
|
|
||||||
],
|
|
||||||
unrealizedReturnByCurrency: [
|
|
||||||
...portfolioSummary.unrealizedReturnByCurrency,
|
|
||||||
{
|
|
||||||
absolute: "20",
|
|
||||||
costBasis: "3180",
|
|
||||||
currency: "USD",
|
|
||||||
partial: false,
|
|
||||||
percent: "2.10",
|
|
||||||
},
|
|
||||||
{
|
|
||||||
absolute: "0",
|
|
||||||
costBasis: "900",
|
|
||||||
currency: "EUR",
|
|
||||||
partial: false,
|
|
||||||
percent: null,
|
|
||||||
},
|
|
||||||
],
|
|
||||||
})]),
|
|
||||||
},
|
|
||||||
};
|
|
||||||
|
|
||||||
export const Negative: Story = {
|
export const Negative: Story = {
|
||||||
args: {
|
args: {
|
||||||
accounts: brokerageAccountCards([
|
accounts: brokerageAccountCards([
|
||||||
@@ -154,10 +118,10 @@ export const Partial: Story = {
|
|||||||
args: {
|
args: {
|
||||||
accounts: brokerageAccountCards([account("partial", "Частичные данные", {
|
accounts: brokerageAccountCards([account("partial", "Частичные данные", {
|
||||||
...portfolioSummary,
|
...portfolioSummary,
|
||||||
unrealizedReturnByCurrency: [{
|
unrealizedReturn: {
|
||||||
...rubReturn,
|
...rubReturn,
|
||||||
partial: true,
|
partial: true,
|
||||||
}],
|
},
|
||||||
})]),
|
})]),
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
|
|||||||
+27
-51
@@ -14,55 +14,28 @@ type PortfolioSummary = NonNullable<BrokerageAccount["portfolioSummary"]>;
|
|||||||
|
|
||||||
const portfolioSummary = {
|
const portfolioSummary = {
|
||||||
bondPositionCount: 12,
|
bondPositionCount: 12,
|
||||||
cashBalances: [
|
cash: { currency: "RUB", value: "82500.5" },
|
||||||
{ currency: "RUB", value: "82500.5" },
|
|
||||||
{ currency: "USD", value: "20" },
|
|
||||||
],
|
|
||||||
fundPositionCount: 0,
|
fundPositionCount: 0,
|
||||||
stockPositionCount: 5,
|
stockPositionCount: 5,
|
||||||
structure: {
|
structure: {
|
||||||
currencies: [{
|
|
||||||
categories: [
|
categories: [
|
||||||
{ sharePercent: "50.000000", type: "STOCK", value: "100" },
|
{ sharePercent: "50.000000", type: "STOCK", value: "100" },
|
||||||
{ sharePercent: "30.000000", type: "BOND", value: "60" },
|
{ sharePercent: "30.000000", type: "BOND", value: "60" },
|
||||||
{ sharePercent: "0.000000", type: "OTHER", value: "0" },
|
{ sharePercent: "0.000000", type: "OTHER", value: "0" },
|
||||||
{ sharePercent: "20.000000", type: "CASH", value: "40" },
|
{ sharePercent: "20.000000", type: "CASH", value: "40" },
|
||||||
],
|
],
|
||||||
currency: "RUB",
|
|
||||||
hasNegativeValues: false,
|
hasNegativeValues: false,
|
||||||
totalValue: "200",
|
totalValue: "200",
|
||||||
}],
|
|
||||||
unvaluedCategories: [],
|
unvaluedCategories: [],
|
||||||
},
|
},
|
||||||
totalPositionCount: 17,
|
totalPositionCount: 17,
|
||||||
totalsByCurrency: [
|
totals: { currency: "RUB", value: "123456789012345678901.995" },
|
||||||
{ currency: "RUB", value: "123456789012345678901.995" },
|
unrealizedReturn: {
|
||||||
{ currency: "USD", value: "20" },
|
|
||||||
{ currency: "EUR", value: "5" },
|
|
||||||
],
|
|
||||||
unrealizedReturnByCurrency: [
|
|
||||||
{
|
|
||||||
absolute: "136900",
|
absolute: "136900",
|
||||||
costBasis: "1000000",
|
costBasis: "1000000",
|
||||||
currency: "RUB",
|
|
||||||
partial: true,
|
partial: true,
|
||||||
percent: "12.40",
|
percent: "12.40",
|
||||||
},
|
},
|
||||||
{
|
|
||||||
absolute: "-4.2",
|
|
||||||
costBasis: "24.2",
|
|
||||||
currency: "USD",
|
|
||||||
partial: false,
|
|
||||||
percent: "-3.05",
|
|
||||||
},
|
|
||||||
{
|
|
||||||
absolute: "0",
|
|
||||||
costBasis: "5",
|
|
||||||
currency: "EUR",
|
|
||||||
partial: false,
|
|
||||||
percent: null,
|
|
||||||
},
|
|
||||||
],
|
|
||||||
} satisfies PortfolioSummary;
|
} satisfies PortfolioSummary;
|
||||||
|
|
||||||
type BrokerageAccountCardInput = Parameters<typeof BrokerageAccountList>[0][
|
type BrokerageAccountCardInput = Parameters<typeof BrokerageAccountList>[0][
|
||||||
@@ -97,16 +70,19 @@ describe("BrokerageAccountList", () => {
|
|||||||
it("renders returns, cash and structure with precise totals", () => {
|
it("renders returns, cash and structure with precise totals", () => {
|
||||||
const nullReturnSummary: PortfolioSummary = {
|
const nullReturnSummary: PortfolioSummary = {
|
||||||
...portfolioSummary,
|
...portfolioSummary,
|
||||||
cashBalances: [],
|
structure: {
|
||||||
structure: { currencies: [], unvaluedCategories: [] },
|
categories: [],
|
||||||
totalsByCurrency: [{ currency: "EUR", value: "5" }],
|
hasNegativeValues: false,
|
||||||
unrealizedReturnByCurrency: [{
|
totalValue: "0",
|
||||||
|
unvaluedCategories: [],
|
||||||
|
},
|
||||||
|
totals: { currency: "RUB", value: "5" },
|
||||||
|
unrealizedReturn: {
|
||||||
absolute: "0",
|
absolute: "0",
|
||||||
costBasis: "5",
|
costBasis: "5",
|
||||||
currency: "EUR",
|
|
||||||
partial: false,
|
partial: false,
|
||||||
percent: null,
|
percent: null,
|
||||||
}],
|
},
|
||||||
};
|
};
|
||||||
|
|
||||||
renderList(brokerageAccountCards([
|
renderList(brokerageAccountCards([
|
||||||
@@ -118,38 +94,38 @@ describe("BrokerageAccountList", () => {
|
|||||||
expect(link).toHaveAttribute("href", "/accounts/account-1");
|
expect(link).toHaveAttribute("href", "/accounts/account-1");
|
||||||
expect(within(link).getByText("123 456 789 012 345 678 902,00 ₽"))
|
expect(within(link).getByText("123 456 789 012 345 678 902,00 ₽"))
|
||||||
.toBeInTheDocument();
|
.toBeInTheDocument();
|
||||||
expect(within(link).getByText("Еще 1 валюта")).toBeInTheDocument();
|
expect(within(link).getByText("+12,4 %")).toBeInTheDocument();
|
||||||
expect(within(link).getByText("+12,40 %")).toBeInTheDocument();
|
|
||||||
expect(within(link).getByText("+136 900 ₽")).toBeInTheDocument();
|
expect(within(link).getByText("+136 900 ₽")).toBeInTheDocument();
|
||||||
expect(within(link).getByText("−3,05 %")).toBeInTheDocument();
|
|
||||||
expect(within(link).getByText("−4,2 USD")).toBeInTheDocument();
|
|
||||||
const nullReturnLink = screen.getByRole("link", { name: /Без доходности/ });
|
const nullReturnLink = screen.getByRole("link", { name: /Без доходности/ });
|
||||||
expect(within(nullReturnLink).getByText("—")).toBeInTheDocument();
|
expect(within(nullReturnLink).getByText("—")).toBeInTheDocument();
|
||||||
expect(within(link).getByText("частично")).toBeInTheDocument();
|
expect(within(link).getByText("частично")).toBeInTheDocument();
|
||||||
expect(within(link).getByText("82 500,50 ₽")).toBeInTheDocument();
|
expect(within(link).getByText("82 500,50 ₽")).toBeInTheDocument();
|
||||||
expect(within(link).getAllByText("20,00 USD")).not.toHaveLength(0);
|
|
||||||
expect(within(link).getByText("17 позиций")).toBeInTheDocument();
|
expect(within(link).getByText("17 позиций")).toBeInTheDocument();
|
||||||
expect(screen.getByRole("img", {
|
expect(screen.getByRole("img", {
|
||||||
name: "Структура в RUB: Акции 50 %; Облигации 30 %; "
|
name: "Структура: Акции 50,0 %; Облигации 30,0 %; "
|
||||||
+ "Другие активы 0 %; Свободные деньги 20 %",
|
+ "Другие активы 0,0 %; Свободные деньги 20,0 %",
|
||||||
})).toBeInTheDocument();
|
})).toBeInTheDocument();
|
||||||
const stockLegend = within(link).getByText(/Акции 50 %/);
|
const stockLegend = within(link).getByText(/Акции 50,0 %/);
|
||||||
expect(stockLegend).toHaveTextContent("● Акции 50 %");
|
expect(stockLegend).toHaveTextContent("● Акции 50,0 %");
|
||||||
// eslint-disable-next-line testing-library/no-node-access -- The legend is aria-hidden, so only DOM traversal reaches its container.
|
// eslint-disable-next-line testing-library/no-node-access -- The legend is aria-hidden, so only DOM traversal reaches its container.
|
||||||
expect(stockLegend.parentElement).toHaveAttribute("aria-hidden", "true");
|
expect(stockLegend.parentElement).toHaveAttribute("aria-hidden", "true");
|
||||||
expect(within(link).queryByText(/Другие активы 0 %/)).not.toBeInTheDocument();
|
expect(within(link).queryByText(/Другие активы 0,0 %/))
|
||||||
|
.not.toBeInTheDocument();
|
||||||
expect(link).toHaveTextContent("По данным брокера");
|
expect(link).toHaveTextContent("По данным брокера");
|
||||||
expect(link).toHaveTextContent("Структура RUB: Акции 100");
|
expect(link).toHaveTextContent("Структура: Акции 100");
|
||||||
});
|
});
|
||||||
|
|
||||||
it("preserves empty, unavailable and stale states", () => {
|
it("preserves empty, unavailable and stale states", () => {
|
||||||
const emptySummary: PortfolioSummary = {
|
const emptySummary: PortfolioSummary = {
|
||||||
...portfolioSummary,
|
...portfolioSummary,
|
||||||
cashBalances: [],
|
structure: {
|
||||||
structure: { currencies: [], unvaluedCategories: [] },
|
categories: [],
|
||||||
|
hasNegativeValues: false,
|
||||||
|
totalValue: "0",
|
||||||
|
unvaluedCategories: [],
|
||||||
|
},
|
||||||
totalPositionCount: 0,
|
totalPositionCount: 0,
|
||||||
totalsByCurrency: [],
|
totals: { currency: "RUB", value: "0" },
|
||||||
unrealizedReturnByCurrency: [],
|
|
||||||
};
|
};
|
||||||
|
|
||||||
const cards = brokerageAccountCards([
|
const cards = brokerageAccountCards([
|
||||||
|
|||||||
@@ -15,6 +15,11 @@ import classes from "./BrokerageAccountList.module.css";
|
|||||||
const DECIMAL_PART_COUNT = 2;
|
const DECIMAL_PART_COUNT = 2;
|
||||||
const STRUCTURE_CATEGORY_ORDER = ["STOCK", "BOND", "OTHER", "CASH"] as const;
|
const STRUCTURE_CATEGORY_ORDER = ["STOCK", "BOND", "OTHER", "CASH"] as const;
|
||||||
|
|
||||||
|
const percentFormatter = new Intl.NumberFormat("ru-RU", {
|
||||||
|
maximumFractionDigits: 1,
|
||||||
|
minimumFractionDigits: 1,
|
||||||
|
});
|
||||||
|
|
||||||
type AvailableSummary = Extract<
|
type AvailableSummary = Extract<
|
||||||
BrokerageAccountCard["summary"],
|
BrokerageAccountCard["summary"],
|
||||||
{ state: "available" }
|
{ state: "available" }
|
||||||
@@ -29,28 +34,23 @@ type BrokerageAccountSummaryProps = {
|
|||||||
type PortfolioSummary = AvailableSummary["portfolio"];
|
type PortfolioSummary = AvailableSummary["portfolio"];
|
||||||
|
|
||||||
type ReturnValueProps = {
|
type ReturnValueProps = {
|
||||||
item: PortfolioSummary["unrealizedReturnByCurrency"][number];
|
item: PortfolioSummary["unrealizedReturn"];
|
||||||
};
|
};
|
||||||
|
|
||||||
type StructureCurrency = PortfolioSummary["structure"]["currencies"][number];
|
type StructureCurrency = PortfolioSummary["structure"];
|
||||||
|
|
||||||
function formatPercent(value: null | string) {
|
function formatPercent(value: null | string) {
|
||||||
if (value === null) return "—";
|
if (value === null) return "—";
|
||||||
|
|
||||||
const formatted = `${value.replace(".", ",")}\u{A0}%`;
|
const rounded = percentFormatter.format(Math.abs(Number(value)));
|
||||||
if (isZero(value))
|
let sign = "";
|
||||||
return value.startsWith("-") ? formatted.slice(1) : formatted;
|
if (rounded !== "0,0") sign = value.startsWith("-") ? "−" : "+";
|
||||||
|
|
||||||
return value.startsWith("-") ? `−${formatted.slice(1)}` : `+${formatted}`;
|
return `${sign}${rounded}\u{A0}%`;
|
||||||
}
|
}
|
||||||
|
|
||||||
function formatStructurePercent(value: string) {
|
function formatStructurePercent(value: string) {
|
||||||
let trimmed = value;
|
return percentFormatter.format(Number(value));
|
||||||
while (trimmed.includes(".") && trimmed.endsWith("0"))
|
|
||||||
trimmed = trimmed.slice(0, -1);
|
|
||||||
if (trimmed.endsWith(".")) trimmed = trimmed.slice(0, -1);
|
|
||||||
|
|
||||||
return trimmed.replace(".", ",");
|
|
||||||
}
|
}
|
||||||
|
|
||||||
function isZero(value: string) {
|
function isZero(value: string) {
|
||||||
@@ -65,27 +65,23 @@ const ReturnValue: FC<ReturnValueProps> = (props) => {
|
|||||||
const { t } = useTranslation();
|
const { t } = useTranslation();
|
||||||
const { item } = props;
|
const { item } = props;
|
||||||
|
|
||||||
const isNegative = item.percent !== null
|
const displayedPercent = formatPercent(item.percent);
|
||||||
&& item.percent.startsWith("-")
|
const isNegative = displayedPercent.startsWith("−");
|
||||||
&& !isZero(item.percent);
|
const isPositive = displayedPercent.startsWith("+");
|
||||||
|
|
||||||
const isPositive = item.percent !== null
|
|
||||||
&& !item.percent.startsWith("-")
|
|
||||||
&& !isZero(item.percent);
|
|
||||||
|
|
||||||
let toneClass = classes.neutral;
|
let toneClass = classes.neutral;
|
||||||
if (isNegative) toneClass = classes.negative;
|
if (isNegative) toneClass = classes.negative;
|
||||||
else if (isPositive) toneClass = classes.positive;
|
else if (isPositive) toneClass = classes.positive;
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<Group className={classes.return} gap="xs" wrap="nowrap">
|
<Group className={classes.return} gap="xs" wrap="wrap">
|
||||||
<Text className={toneClass} fw={700} size="sm">
|
<Text className={toneClass} fw={700} size="sm">
|
||||||
{formatPercent(item.percent)}
|
{displayedPercent}
|
||||||
</Text>
|
</Text>
|
||||||
|
|
||||||
<Text className={toneClass} size="sm">
|
<Text className={toneClass} size="sm">
|
||||||
{formatMoney(
|
{formatMoney(
|
||||||
{ currency: item.currency, value: item.absolute },
|
{ currency: "RUB", value: item.absolute },
|
||||||
{ withSign: true },
|
{ withSign: true },
|
||||||
)}
|
)}
|
||||||
</Text>
|
</Text>
|
||||||
@@ -123,7 +119,6 @@ const StructureBar: FC<StructureBarProps> = (props) => {
|
|||||||
}).join("; ");
|
}).join("; ");
|
||||||
|
|
||||||
const label = t("accounts.structure.label", {
|
const label = t("accounts.structure.label", {
|
||||||
currency: props.item.currency,
|
|
||||||
value: description,
|
value: description,
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -200,51 +195,25 @@ const BrokerageAccountSummary: FC<BrokerageAccountSummaryProps> = (props) => {
|
|||||||
|
|
||||||
return (
|
return (
|
||||||
<Stack className={classes.balance} gap="xs">
|
<Stack className={classes.balance} gap="xs">
|
||||||
<Group align="flex-start" gap="lg" justify="flex-end" wrap="nowrap">
|
<Stack className={classes.summary} gap="sm">
|
||||||
<Stack className={classes.summary} gap={4}>
|
<Stack className={classes.currencySummary} gap={2}>
|
||||||
{summary.totals.map(total => (
|
<Text className={classes.total} fw={700}>
|
||||||
<Text className={classes.total} fw={700} key={total.currency}>
|
{formatMoney(summary.totals, { withRoundedCents: true })}
|
||||||
{formatMoney(total, { withRoundedCents: true })}
|
|
||||||
</Text>
|
</Text>
|
||||||
))}
|
|
||||||
|
|
||||||
{!!summary.remainingCurrencyCount && (
|
<ReturnValue item={summary.portfolio.unrealizedReturn} />
|
||||||
<Text c="dimmed" size="sm">
|
</Stack>
|
||||||
{t("accounts.remainingCurrencies", {
|
|
||||||
count: summary.remainingCurrencyCount,
|
|
||||||
})}
|
|
||||||
</Text>
|
|
||||||
)}
|
|
||||||
</Stack>
|
</Stack>
|
||||||
|
|
||||||
<Stack gap={4}>
|
|
||||||
{summary.totals.map((total) => {
|
|
||||||
const item = summary.portfolio.unrealizedReturnByCurrency.find(
|
|
||||||
returnItem => returnItem.currency === total.currency,
|
|
||||||
);
|
|
||||||
|
|
||||||
return item
|
|
||||||
? <ReturnValue item={item} key={total.currency} />
|
|
||||||
: null;
|
|
||||||
})}
|
|
||||||
</Stack>
|
|
||||||
</Group>
|
|
||||||
|
|
||||||
{summary.portfolio.cashBalances.length > 0 && (
|
|
||||||
<Group className={classes.cash} gap="xs" justify="flex-end">
|
<Group className={classes.cash} gap="xs" justify="flex-end">
|
||||||
<Text c="dimmed" size="xs">
|
<Text c="dimmed" size="xs">
|
||||||
{t("accounts.cash")}
|
{t("accounts.cash")}
|
||||||
</Text>
|
</Text>
|
||||||
|
|
||||||
<Stack gap={0}>
|
<Text className={classes.cashValue} size="sm">
|
||||||
{summary.portfolio.cashBalances.map(cash => (
|
{formatMoney(summary.portfolio.cash, { withRoundedCents: true })}
|
||||||
<Text className={classes.cashValue} key={cash.currency} size="sm">
|
|
||||||
{formatMoney(cash, { withRoundedCents: true })}
|
|
||||||
</Text>
|
</Text>
|
||||||
))}
|
|
||||||
</Stack>
|
|
||||||
</Group>
|
</Group>
|
||||||
)}
|
|
||||||
</Stack>
|
</Stack>
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
@@ -291,39 +260,31 @@ const AccountDescription: FC<AccountDescriptionProps> = (props) => {
|
|||||||
const { account, summary } = props.account;
|
const { account, summary } = props.account;
|
||||||
if (summary.state !== "available") return null;
|
if (summary.state !== "available") return null;
|
||||||
|
|
||||||
const returns = summary.portfolio.unrealizedReturnByCurrency.map(item =>
|
const returns = [t("accounts.description.return", {
|
||||||
t("accounts.description.return", {
|
|
||||||
absolute: formatMoney(
|
absolute: formatMoney(
|
||||||
{ currency: item.currency, value: item.absolute },
|
{ currency: "RUB", value: summary.portfolio.unrealizedReturn.absolute },
|
||||||
{ withSign: true },
|
{ withSign: true },
|
||||||
),
|
),
|
||||||
currency: item.currency,
|
percent: formatPercent(summary.portfolio.unrealizedReturn.percent),
|
||||||
percent: formatPercent(item.percent),
|
})];
|
||||||
}),
|
|
||||||
);
|
|
||||||
|
|
||||||
const structures = summary.portfolio.structure.currencies.map((item) => {
|
const structures = (() => {
|
||||||
const categories = item.categories.map(category =>
|
const categories = summary.portfolio.structure.categories.map(category =>
|
||||||
t("accounts.description.structureCategory", {
|
t("accounts.description.structureCategory", {
|
||||||
category: t(portfolioCategoryPresentation[category.type].label),
|
category: t(portfolioCategoryPresentation[category.type].label),
|
||||||
value: formatMoney(
|
value: formatMoney(
|
||||||
{ currency: item.currency, value: category.value },
|
{ currency: "RUB", value: category.value },
|
||||||
{ withRoundedCents: true },
|
{ withRoundedCents: true },
|
||||||
),
|
),
|
||||||
}),
|
}),
|
||||||
).join(", ");
|
).join(", ");
|
||||||
|
|
||||||
return t("accounts.description.structure", {
|
return t("accounts.description.structure", { value: categories });
|
||||||
currency: item.currency,
|
})();
|
||||||
value: categories,
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
|
||||||
const hasPartialReturn = summary.portfolio.unrealizedReturnByCurrency.some(
|
const hasPartialReturn = summary.portfolio.unrealizedReturn.partial;
|
||||||
item => item.partial,
|
|
||||||
);
|
|
||||||
|
|
||||||
const details = [...returns, ...structures].join(". ");
|
const details = [returns, structures].join(". ");
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<VisuallyHidden>
|
<VisuallyHidden>
|
||||||
@@ -332,8 +293,7 @@ const AccountDescription: FC<AccountDescriptionProps> = (props) => {
|
|||||||
type: t(accountTypeKey(account.type)),
|
type: t(accountTypeKey(account.type)),
|
||||||
})}
|
})}
|
||||||
{t("accounts.description.currentValue", {
|
{t("accounts.description.currentValue", {
|
||||||
value: summary.portfolio.totalsByCurrency
|
value: formatMoney(summary.portfolio.totals),
|
||||||
.map(total => formatMoney(total)).join(", "),
|
|
||||||
})}
|
})}
|
||||||
{details ? `${details}. ` : ""}
|
{details ? `${details}. ` : ""}
|
||||||
{hasPartialReturn ? t("accounts.brokerDescription") : ""}
|
{hasPartialReturn ? t("accounts.brokerDescription") : ""}
|
||||||
@@ -373,9 +333,7 @@ const BrokerageAccountList: FC<BrokerageAccountListProps> = (props) => {
|
|||||||
|
|
||||||
{summary.state === "available" && (
|
{summary.state === "available" && (
|
||||||
<Stack className={classes.structure} gap={4}>
|
<Stack className={classes.structure} gap={4}>
|
||||||
{summary.portfolio.structure.currencies.map(item => (
|
<StructureBar item={summary.portfolio.structure} />
|
||||||
<StructureBar item={item} key={item.currency} />
|
|
||||||
))}
|
|
||||||
</Stack>
|
</Stack>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
|
|||||||
@@ -97,13 +97,13 @@ describe("BrokerageEventGroup", () => {
|
|||||||
expect(screen.getByText("0,00 ₽")).toBeInTheDocument();
|
expect(screen.getByText("0,00 ₽")).toBeInTheDocument();
|
||||||
});
|
});
|
||||||
|
|
||||||
it("shows separate forecast totals per currency without conversion", () => {
|
it("sums forecast totals exactly", () => {
|
||||||
renderGroup([
|
renderGroup([
|
||||||
event({ id: "broker", name: "Брокерский" }, "10", "USD"),
|
event({ id: "broker", name: "Брокерский" }, "10"),
|
||||||
event({ id: "iis", name: "ИИС" }, "200"),
|
event({ id: "iis", name: "ИИС" }, "200"),
|
||||||
]);
|
]);
|
||||||
|
|
||||||
expect(screen.getByRole("list", { name: /10 USD.*200 ₽/ }))
|
expect(screen.getByRole("list", { name: /210 ₽/ }))
|
||||||
.toBeInTheDocument();
|
.toBeInTheDocument();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,20 @@
|
|||||||
|
import { apiQueryClient, type paths, useAuthenticatedQuery } from "@/shared/api";
|
||||||
|
|
||||||
|
type Performance = NonNullable<
|
||||||
|
paths["/api/v1/brokerage-accounts/{accountId}/performance"]["get"]["responses"][200]["content"]["application/json"]["data"]
|
||||||
|
>;
|
||||||
|
|
||||||
|
function usePerformance(accountId: string) {
|
||||||
|
return useAuthenticatedQuery({
|
||||||
|
meta: { accessGroup: "brokerage" },
|
||||||
|
...apiQueryClient.queryOptions(
|
||||||
|
"get",
|
||||||
|
"/api/v1/brokerage-accounts/{accountId}/performance",
|
||||||
|
{ params: { path: { accountId } } },
|
||||||
|
),
|
||||||
|
enabled: Boolean(accountId),
|
||||||
|
staleTime: 30_000,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
export { type Performance, usePerformance };
|
||||||
@@ -0,0 +1 @@
|
|||||||
|
export { type Performance, usePerformance } from "./api/usePerformance";
|
||||||
@@ -2,7 +2,7 @@ import type { Portfolio } from "../api/usePortfolio";
|
|||||||
|
|
||||||
const PERCENT_SCALE = 100;
|
const PERCENT_SCALE = 100;
|
||||||
|
|
||||||
type Money = Portfolio["totalsByCurrency"][number];
|
type Money = Portfolio["totals"];
|
||||||
|
|
||||||
function formatShare(
|
function formatShare(
|
||||||
numerator: Money | null,
|
numerator: Money | null,
|
||||||
|
|||||||
@@ -1,4 +1,4 @@
|
|||||||
import { describe, expect, it } from "vitest";
|
import { describe, expect, it, vi } from "vitest";
|
||||||
|
|
||||||
import { resource } from "@/test/resource";
|
import { resource } from "@/test/resource";
|
||||||
|
|
||||||
@@ -76,4 +76,29 @@ describe("instrument source and transport presentation", () => {
|
|||||||
loading: false,
|
loading: false,
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("carries the retry of an exhausted read and only of that read", () => {
|
||||||
|
const refetch = vi.fn(() => Promise.resolve());
|
||||||
|
|
||||||
|
const state = section({
|
||||||
|
data: { rows: [] },
|
||||||
|
error: { code: "TBANK_UNAVAILABLE", status: 503 },
|
||||||
|
isError: true,
|
||||||
|
isFetching: false,
|
||||||
|
refetch,
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(state.readRetry?.exhausted).toBe(true);
|
||||||
|
state.readRetry?.onRetry();
|
||||||
|
expect(refetch).toHaveBeenCalledOnce();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("offers no retry for access loss or a healthy read", () => {
|
||||||
|
const base = { data: undefined, isFetching: false, refetch: vi.fn() };
|
||||||
|
|
||||||
|
expect(section({ ...base, error: { code: "NOT_FOUND" }, isError: true })
|
||||||
|
.readRetry?.exhausted).toBe(false);
|
||||||
|
expect(section({ ...base, error: null, isError: false })
|
||||||
|
.readRetry?.exhausted).toBe(false);
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -1,10 +1,11 @@
|
|||||||
import type { InvestmentResourceMeta } from "@/shared/api";
|
import { type InvestmentResourceMeta, readRetry } from "@/shared/api";
|
||||||
|
|
||||||
type SectionState = {
|
type SectionState = {
|
||||||
error: boolean;
|
error: boolean;
|
||||||
hasData: boolean;
|
hasData: boolean;
|
||||||
loading: boolean;
|
loading: boolean;
|
||||||
partial?: boolean;
|
partial?: boolean;
|
||||||
|
readRetry?: ReturnType<typeof readRetry>;
|
||||||
};
|
};
|
||||||
|
|
||||||
function hasSectionData(data: unknown) {
|
function hasSectionData(data: unknown) {
|
||||||
@@ -13,8 +14,11 @@ function hasSectionData(data: unknown) {
|
|||||||
|
|
||||||
function section(query: {
|
function section(query: {
|
||||||
data: unknown;
|
data: unknown;
|
||||||
|
error?: unknown;
|
||||||
isError: boolean;
|
isError: boolean;
|
||||||
|
isFetching?: boolean;
|
||||||
meta?: InvestmentResourceMeta;
|
meta?: InvestmentResourceMeta;
|
||||||
|
refetch?: () => Promise<unknown>;
|
||||||
}): SectionState {
|
}): SectionState {
|
||||||
const isError = query.isError || query.meta?.lastAttempt.state === "failed";
|
const isError = query.isError || query.meta?.lastAttempt.state === "failed";
|
||||||
const hasData = hasSectionData(query.data);
|
const hasData = hasSectionData(query.data);
|
||||||
@@ -24,6 +28,17 @@ function section(query: {
|
|||||||
hasData,
|
hasData,
|
||||||
loading: !hasData && !isError,
|
loading: !hasData && !isError,
|
||||||
partial: query.meta?.completeness === "incomplete",
|
partial: query.meta?.completeness === "incomplete",
|
||||||
|
// Each section retries only its own GET, so sections recover independently.
|
||||||
|
readRetry: query.refetch
|
||||||
|
? readRetry([
|
||||||
|
{
|
||||||
|
error: query.error,
|
||||||
|
isError: query.isError,
|
||||||
|
isFetching: query.isFetching ?? false,
|
||||||
|
refetch: query.refetch,
|
||||||
|
},
|
||||||
|
])
|
||||||
|
: undefined,
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -19,7 +19,6 @@ function useInstrumentChartVm(props: InstrumentChartProps) {
|
|||||||
const average = vm.position?.averagePurchasePrice;
|
const average = vm.position?.averagePurchasePrice;
|
||||||
|
|
||||||
const averageLine = average && props.priceUnit !== "percent"
|
const averageLine = average && props.priceUnit !== "percent"
|
||||||
&& average.currency === vm.candles?.currency
|
|
||||||
? Number(average.value)
|
? Number(average.value)
|
||||||
: null;
|
: null;
|
||||||
|
|
||||||
@@ -47,7 +46,7 @@ function useInstrumentChartVm(props: InstrumentChartProps) {
|
|||||||
currency:
|
currency:
|
||||||
props.priceUnit === "percent"
|
props.priceUnit === "percent"
|
||||||
? t("bond.percentOfNominal")
|
? t("bond.percentOfNominal")
|
||||||
: (vm.candles?.currency ?? ""),
|
: "₽",
|
||||||
},
|
},
|
||||||
);
|
);
|
||||||
|
|
||||||
|
|||||||
@@ -12,6 +12,8 @@ import {
|
|||||||
import { LoadingSkeleton } from "@wealthledger/ui";
|
import { LoadingSkeleton } from "@wealthledger/ui";
|
||||||
import { useTranslation } from "react-i18next";
|
import { useTranslation } from "react-i18next";
|
||||||
|
|
||||||
|
import { ReadRetry } from "@/shared/ui";
|
||||||
|
|
||||||
import type { SectionState } from "../model/section";
|
import type { SectionState } from "../model/section";
|
||||||
|
|
||||||
import classes from "./InstrumentDetails.module.css";
|
import classes from "./InstrumentDetails.module.css";
|
||||||
@@ -81,6 +83,8 @@ const InstrumentSection: FC<InstrumentSectionProps> = (props) => {
|
|||||||
</Alert>
|
</Alert>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
|
{!!props.state.readRetry && <ReadRetry {...props.state.readRetry} />}
|
||||||
|
|
||||||
{sectionContent}
|
{sectionContent}
|
||||||
</Paper>
|
</Paper>
|
||||||
);
|
);
|
||||||
|
|||||||
@@ -2,19 +2,18 @@ import type { QueryClient } from "@tanstack/react-query";
|
|||||||
|
|
||||||
import {
|
import {
|
||||||
apiQueryClient,
|
apiQueryClient,
|
||||||
|
isGetUnder,
|
||||||
type paths,
|
type paths,
|
||||||
} from "@/shared/api";
|
} from "@/shared/api";
|
||||||
|
|
||||||
type TbankConnectionStatus
|
type TbankConnectionStatus
|
||||||
= paths["/api/v1/tbank-connection"]["get"]["responses"][200]["content"]["application/json"];
|
= paths["/api/v1/tbank-connection"]["get"]["responses"][200]["content"]["application/json"];
|
||||||
|
|
||||||
function isInvestmentPath(path: string) {
|
const investmentGetPredicate = isGetUnder([
|
||||||
return [
|
|
||||||
"/api/v1/brokerage-accounts",
|
"/api/v1/brokerage-accounts",
|
||||||
"/api/v1/stocks",
|
"/api/v1/stocks",
|
||||||
"/api/v1/bonds",
|
"/api/v1/bonds",
|
||||||
].some(root => path === root || path.startsWith(`${root}/`));
|
]);
|
||||||
}
|
|
||||||
|
|
||||||
const tbankConnectionQueryOptions = () =>
|
const tbankConnectionQueryOptions = () =>
|
||||||
apiQueryClient.queryOptions("get", "/api/v1/tbank-connection");
|
apiQueryClient.queryOptions("get", "/api/v1/tbank-connection");
|
||||||
@@ -27,15 +26,7 @@ function commitTbankConnectionBoundary(
|
|||||||
) {
|
) {
|
||||||
queryClient.setQueryData(tbankConnectionQueryKey, status);
|
queryClient.setQueryData(tbankConnectionQueryKey, status);
|
||||||
void queryClient.resetQueries({
|
void queryClient.resetQueries({
|
||||||
predicate: ({ queryKey }) => {
|
predicate: ({ queryKey }) => investmentGetPredicate(queryKey),
|
||||||
const [method, path] = queryKey;
|
|
||||||
|
|
||||||
return (
|
|
||||||
method === "get"
|
|
||||||
&& typeof path === "string"
|
|
||||||
&& isInvestmentPath(path)
|
|
||||||
);
|
|
||||||
},
|
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -10,6 +10,9 @@ import { server } from "@/test/server";
|
|||||||
|
|
||||||
import { useScreenSync } from "../index";
|
import { useScreenSync } from "../index";
|
||||||
|
|
||||||
|
const TRANSPORT_ATTEMPTS = 3;
|
||||||
|
const TRANSPORT_RECOVERY_MS = 3000;
|
||||||
|
|
||||||
function auth() {
|
function auth() {
|
||||||
configureAuthClient({
|
configureAuthClient({
|
||||||
accessToken: () => "synthetic",
|
accessToken: () => "synthetic",
|
||||||
@@ -28,11 +31,13 @@ describe("read-only screen synchronization", () => {
|
|||||||
gets += 1;
|
gets += 1;
|
||||||
syncModes.push(new URL(request.url).searchParams.get("sync"));
|
syncModes.push(new URL(request.url).searchParams.get("sync"));
|
||||||
|
|
||||||
return gets === 1
|
// The transport retries a transient read twice (1 s, 2 s) on its own.
|
||||||
|
return gets <= TRANSPORT_ATTEMPTS
|
||||||
? HttpResponse.json({ code: "TBANK_UNAVAILABLE" }, { status: 503 })
|
? HttpResponse.json({ code: "TBANK_UNAVAILABLE" }, { status: 503 })
|
||||||
: HttpResponse.json(resource([]));
|
: HttpResponse.json(resource([]));
|
||||||
}),
|
}),
|
||||||
);
|
);
|
||||||
|
vi.useFakeTimers();
|
||||||
|
|
||||||
const { result } = renderHook(
|
const { result } = renderHook(
|
||||||
() => {
|
() => {
|
||||||
@@ -46,12 +51,26 @@ describe("read-only screen synchronization", () => {
|
|||||||
{ wrapper: createQueryWrapper().wrapper },
|
{ wrapper: createQueryWrapper().wrapper },
|
||||||
);
|
);
|
||||||
|
|
||||||
await waitFor(() => expect(gets).toBe(1));
|
try {
|
||||||
await act(async () => result.current.sync.retry());
|
// Exhaust the transport back-off so the query settles in error.
|
||||||
await waitFor(() => expect(result.current.accounts.data).toEqual([]));
|
await vi.waitFor(async () => {
|
||||||
|
await act(() => vi.advanceTimersByTimeAsync(TRANSPORT_RECOVERY_MS));
|
||||||
|
expect(result.current.sync.transportError).toBe(true);
|
||||||
|
});
|
||||||
|
expect(gets).toBe(TRANSPORT_ATTEMPTS);
|
||||||
|
|
||||||
expect(gets).toBe(2);
|
await act(async () => result.current.sync.retry());
|
||||||
expect(syncModes).toEqual([null, null]);
|
await vi.waitFor(async () => {
|
||||||
|
await act(() => vi.advanceTimersByTimeAsync(0));
|
||||||
|
expect(result.current.accounts.data).toEqual([]);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
finally {
|
||||||
|
vi.useRealTimers();
|
||||||
|
}
|
||||||
|
|
||||||
|
expect(gets).toBe(TRANSPORT_ATTEMPTS + 1);
|
||||||
|
expect(syncModes).toEqual(Array.from({ length: gets }, () => null));
|
||||||
});
|
});
|
||||||
|
|
||||||
it("refreshes the currently open resources together", async () => {
|
it("refreshes the currently open resources together", async () => {
|
||||||
|
|||||||
+1
-1
@@ -23,7 +23,7 @@ const meta = {
|
|||||||
},
|
},
|
||||||
render: arguments_ => (
|
render: arguments_ => (
|
||||||
<Stack>
|
<Stack>
|
||||||
<Text>125 000,50 ₽ · 320 USD</Text>
|
<Text>125 000,50 ₽</Text>
|
||||||
|
|
||||||
<InvestmentRefreshState {...arguments_} />
|
<InvestmentRefreshState {...arguments_} />
|
||||||
</Stack>
|
</Stack>
|
||||||
|
|||||||
@@ -4,16 +4,16 @@ import {
|
|||||||
TbankConnectionError,
|
TbankConnectionError,
|
||||||
TbankConnectionLoading,
|
TbankConnectionLoading,
|
||||||
} from "./TbankConnectionSection.view";
|
} from "./TbankConnectionSection.view";
|
||||||
import { useTbankConnectionViewModel } from "./TbankConnectionSection.vm";
|
import { useTbankConnectionSectionVm } from "./TbankConnectionSection.vm";
|
||||||
import { TbankConnectionSectionLoaded } from "./TbankConnectionSectionLoaded";
|
import { TbankConnectionSectionLoaded } from "./TbankConnectionSectionLoaded";
|
||||||
|
|
||||||
const TbankConnectionSection: FC = () => {
|
const TbankConnectionSection: FC = () => {
|
||||||
const viewModel = useTbankConnectionViewModel();
|
const vm = useTbankConnectionSectionVm();
|
||||||
if (viewModel.state === "loading") return <TbankConnectionLoading />;
|
if (vm.state === "loading") return <TbankConnectionLoading />;
|
||||||
|
|
||||||
return viewModel.state === "error"
|
return vm.state === "error"
|
||||||
? <TbankConnectionError retry={viewModel.retry} />
|
? <TbankConnectionError retry={vm.retry} />
|
||||||
: <TbankConnectionSectionLoaded {...viewModel} />;
|
: <TbankConnectionSectionLoaded {...vm} />;
|
||||||
};
|
};
|
||||||
|
|
||||||
export { TbankConnectionSection };
|
export { TbankConnectionSection };
|
||||||
|
|||||||
+2
-2
@@ -2,7 +2,7 @@ import { useAuthenticatedQuery } from "@/shared/api";
|
|||||||
|
|
||||||
import { tbankConnectionQueryOptions } from "../../model/connection-boundary";
|
import { tbankConnectionQueryOptions } from "../../model/connection-boundary";
|
||||||
|
|
||||||
function useTbankConnectionViewModel() {
|
function useTbankConnectionSectionVm() {
|
||||||
const status = useAuthenticatedQuery({
|
const status = useAuthenticatedQuery({
|
||||||
...tbankConnectionQueryOptions(),
|
...tbankConnectionQueryOptions(),
|
||||||
});
|
});
|
||||||
@@ -22,4 +22,4 @@ function useTbankConnectionViewModel() {
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
export { useTbankConnectionViewModel };
|
export { useTbankConnectionSectionVm };
|
||||||
|
|||||||
@@ -26,7 +26,7 @@ import { resource } from "@/test/resource";
|
|||||||
import { server } from "@/test/server";
|
import { server } from "@/test/server";
|
||||||
|
|
||||||
import { AccountEventsPage } from "./AccountEventsPage";
|
import { AccountEventsPage } from "./AccountEventsPage";
|
||||||
import { useAccountEventsPageViewModel } from "./AccountEventsPage.vm";
|
import { useAccountEventsPageVm } from "./AccountEventsPage.vm";
|
||||||
|
|
||||||
const Navigation: FC = () => {
|
const Navigation: FC = () => {
|
||||||
const location = useLocation();
|
const location = useLocation();
|
||||||
@@ -100,7 +100,7 @@ describe("Upcoming event date filters", () => {
|
|||||||
);
|
);
|
||||||
const queryClient = createTestQueryClient();
|
const queryClient = createTestQueryClient();
|
||||||
|
|
||||||
const { result } = renderHook(() => useAccountEventsPageViewModel(), {
|
const { result } = renderHook(() => useAccountEventsPageVm(), {
|
||||||
wrapper: ({ children }) => (
|
wrapper: ({ children }) => (
|
||||||
<QueryClientProvider client={queryClient}>
|
<QueryClientProvider client={queryClient}>
|
||||||
<MemoryRouter initialEntries={["?from=2099-02-01"]}>
|
<MemoryRouter initialEntries={["?from=2099-02-01"]}>
|
||||||
@@ -146,7 +146,7 @@ describe("Upcoming event date filters", () => {
|
|||||||
const queryClient = createTestQueryClient();
|
const queryClient = createTestQueryClient();
|
||||||
|
|
||||||
const { result } = renderHook(
|
const { result } = renderHook(
|
||||||
() => useAccountEventsPageViewModel(),
|
() => useAccountEventsPageVm(),
|
||||||
{
|
{
|
||||||
wrapper: ({ children }) => (
|
wrapper: ({ children }) => (
|
||||||
<QueryClientProvider client={queryClient}>
|
<QueryClientProvider client={queryClient}>
|
||||||
@@ -176,7 +176,11 @@ describe("Upcoming event date filters", () => {
|
|||||||
({ request }) => {
|
({ request }) => {
|
||||||
searches.push(new URL(request.url).search);
|
searches.push(new URL(request.url).search);
|
||||||
|
|
||||||
return HttpResponse.json(resource({ events: [] }));
|
return HttpResponse.json(resource({
|
||||||
|
calculatedAt: "2026-08-14T00:00:00Z",
|
||||||
|
events: [],
|
||||||
|
window: { from: "2026-08-14", to: "2026-09-13" },
|
||||||
|
}));
|
||||||
},
|
},
|
||||||
),
|
),
|
||||||
);
|
);
|
||||||
@@ -223,7 +227,11 @@ describe("Upcoming event date filters", () => {
|
|||||||
"*/api/v1/brokerage-accounts/:accountId/events",
|
"*/api/v1/brokerage-accounts/:accountId/events",
|
||||||
({ request }) =>
|
({ request }) =>
|
||||||
new URL(request.url).searchParams.get("from") === defaultFrom
|
new URL(request.url).searchParams.get("from") === defaultFrom
|
||||||
? HttpResponse.json(resource({ events: [] }))
|
? HttpResponse.json(resource({
|
||||||
|
calculatedAt: "2026-08-14T00:00:00Z",
|
||||||
|
events: [],
|
||||||
|
window: { from: "2026-08-14", to: "2026-09-13" },
|
||||||
|
}))
|
||||||
: HttpResponse.json({ code: "VALIDATION_ERROR" }, { status: 400 }),
|
: HttpResponse.json({ code: "VALIDATION_ERROR" }, { status: 400 }),
|
||||||
),
|
),
|
||||||
);
|
);
|
||||||
@@ -255,7 +263,8 @@ describe("Upcoming event date filters", () => {
|
|||||||
accountId,
|
accountId,
|
||||||
calculatedAt: "2099-01-01T00:00:00Z",
|
calculatedAt: "2099-01-01T00:00:00Z",
|
||||||
events: [],
|
events: [],
|
||||||
incomeTotalsByCurrency: [],
|
incomeTotal: { currency: "RUB", value: "0" },
|
||||||
|
window: { from: "2099-01-01", to: "2099-01-31" },
|
||||||
}),
|
}),
|
||||||
);
|
);
|
||||||
},
|
},
|
||||||
@@ -264,6 +273,7 @@ describe("Upcoming event date filters", () => {
|
|||||||
renderEvents(accountId, ["?from=2026-02-01&to=2026-02-28"]);
|
renderEvents(accountId, ["?from=2026-02-01&to=2026-02-28"]);
|
||||||
const from = await screen.findByLabelText("Период");
|
const from = await screen.findByLabelText("Период");
|
||||||
expect(from).toHaveTextContent("01.02.2026 – 28.02.2026");
|
expect(from).toHaveTextContent("01.02.2026 – 28.02.2026");
|
||||||
|
expect(screen.getByText(/Прогноз от .* на 01\.01\.2099 – 31\.01\.2099/)).toBeVisible();
|
||||||
expect(screen.getByRole("button", { name: "Применить" })).toBeDisabled();
|
expect(screen.getByRole("button", { name: "Применить" })).toBeDisabled();
|
||||||
expect(searches).toEqual(["?from=2026-02-01&to=2026-02-28"]);
|
expect(searches).toEqual(["?from=2026-02-01&to=2026-02-28"]);
|
||||||
|
|
||||||
@@ -320,7 +330,7 @@ describe("Upcoming event date filters", () => {
|
|||||||
expect(screen.getByLabelText("URL")).toBeEmptyDOMElement();
|
expect(screen.getByLabelText("URL")).toBeEmptyDOMElement();
|
||||||
expect(screen.getByRole("button", { name: "Применить" })).toBeDisabled();
|
expect(screen.getByRole("button", { name: "Применить" })).toBeDisabled();
|
||||||
expect(
|
expect(
|
||||||
screen.getByText("За выбранный период событий не найдено"),
|
screen.getByText("На выбранный период предстоящих событий не найдено"),
|
||||||
).toBeVisible();
|
).toBeVisible();
|
||||||
},
|
},
|
||||||
);
|
);
|
||||||
@@ -343,7 +353,7 @@ it("retains the previous complete forecast when its source refresh fails", async
|
|||||||
];
|
];
|
||||||
|
|
||||||
const snapshot = resource(
|
const snapshot = resource(
|
||||||
{ events, incomeTotalsByCurrency: [{ currency: "RUB", value: "123.45" }] },
|
{ events, incomeTotal: { currency: "RUB", value: "123.45" } },
|
||||||
{
|
{
|
||||||
lastAttempt: {
|
lastAttempt: {
|
||||||
finishedAt: "2026-08-14T00:01:00Z",
|
finishedAt: "2026-08-14T00:01:00Z",
|
||||||
@@ -361,7 +371,7 @@ it("retains the previous complete forecast when its source refresh fails", async
|
|||||||
);
|
);
|
||||||
const queryClient = createTestQueryClient();
|
const queryClient = createTestQueryClient();
|
||||||
|
|
||||||
const { result } = renderHook(() => useAccountEventsPageViewModel(), {
|
const { result } = renderHook(() => useAccountEventsPageVm(), {
|
||||||
wrapper: ({ children }) => (
|
wrapper: ({ children }) => (
|
||||||
<QueryClientProvider client={queryClient}>
|
<QueryClientProvider client={queryClient}>
|
||||||
<MemoryRouter initialEntries={["/accounts/all/events"]}>
|
<MemoryRouter initialEntries={["/accounts/all/events"]}>
|
||||||
|
|||||||
@@ -0,0 +1,167 @@
|
|||||||
|
import { MantineProvider } from "@mantine/core";
|
||||||
|
import { QueryClientProvider } from "@tanstack/react-query";
|
||||||
|
import { fireEvent, render, screen, waitFor } from "@testing-library/react";
|
||||||
|
import { http, HttpResponse } from "msw";
|
||||||
|
import { MemoryRouter, Route, Routes } from "react-router";
|
||||||
|
import { describe, expect, it, vi } from "vitest";
|
||||||
|
|
||||||
|
import { configureAuthClient } from "@/shared/api";
|
||||||
|
import { createTestQueryClient } from "@/test/query";
|
||||||
|
import { resource } from "@/test/resource";
|
||||||
|
import { server } from "@/test/server";
|
||||||
|
|
||||||
|
import { AccountEventsPage } from "./AccountEventsPage";
|
||||||
|
|
||||||
|
// Automatic read retries wait 1s + 2s before the failure is final.
|
||||||
|
const RETRIES_EXHAUSTED_MS = 6000;
|
||||||
|
const TEST_MS = 10_000;
|
||||||
|
|
||||||
|
const snapshot = resource({
|
||||||
|
accountId: "account-1",
|
||||||
|
calculatedAt: "2026-08-14T00:00:00Z",
|
||||||
|
events: [
|
||||||
|
{
|
||||||
|
date: "2026-10-01",
|
||||||
|
dateKind: "event",
|
||||||
|
displayName: "Synthetic coupon",
|
||||||
|
figi: null,
|
||||||
|
instrumentUid: null,
|
||||||
|
isin: null,
|
||||||
|
logoName: null,
|
||||||
|
projectedAmount: { currency: "RUB", value: "123.45" },
|
||||||
|
ticker: "SYN",
|
||||||
|
type: "coupon",
|
||||||
|
},
|
||||||
|
],
|
||||||
|
incomeTotal: { currency: "RUB", value: "123.45" },
|
||||||
|
window: { from: "2026-08-14", to: "2026-09-13" },
|
||||||
|
});
|
||||||
|
|
||||||
|
function renderEvents() {
|
||||||
|
configureAuthClient({
|
||||||
|
accessToken: () => "token",
|
||||||
|
clear: vi.fn(),
|
||||||
|
refresh: () => Promise.resolve(true),
|
||||||
|
});
|
||||||
|
const queryClient = createTestQueryClient();
|
||||||
|
|
||||||
|
render(
|
||||||
|
<QueryClientProvider client={queryClient}>
|
||||||
|
<MantineProvider env="test">
|
||||||
|
<MemoryRouter initialEntries={["/accounts/account-1/events"]}>
|
||||||
|
<Routes>
|
||||||
|
<Route
|
||||||
|
element={<AccountEventsPage />}
|
||||||
|
path="/accounts/:accountId/events"
|
||||||
|
/>
|
||||||
|
</Routes>
|
||||||
|
</MemoryRouter>
|
||||||
|
</MantineProvider>
|
||||||
|
</QueryClientProvider>,
|
||||||
|
);
|
||||||
|
|
||||||
|
return { queryClient };
|
||||||
|
}
|
||||||
|
|
||||||
|
describe("AccountEventsPage read retry", () => {
|
||||||
|
it(
|
||||||
|
"offers retry after an initial failure and recovers in place",
|
||||||
|
{ timeout: TEST_MS },
|
||||||
|
async () => {
|
||||||
|
let isFailing = true;
|
||||||
|
let requests = 0;
|
||||||
|
server.use(
|
||||||
|
http.get("*/api/v1/brokerage-accounts/:accountId/events", () => {
|
||||||
|
requests += 1;
|
||||||
|
|
||||||
|
return isFailing
|
||||||
|
? HttpResponse.json({ code: "TBANK_UNAVAILABLE" }, { status: 503 })
|
||||||
|
: HttpResponse.json(snapshot);
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
renderEvents();
|
||||||
|
|
||||||
|
const retry = await screen.findByRole(
|
||||||
|
"button",
|
||||||
|
{ name: "Повторить" },
|
||||||
|
{ timeout: RETRIES_EXHAUSTED_MS },
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(requests).toBe(3);
|
||||||
|
|
||||||
|
isFailing = false;
|
||||||
|
fireEvent.click(retry);
|
||||||
|
|
||||||
|
expect(await screen.findByText("Купон · Synthetic coupon")).toBeInTheDocument();
|
||||||
|
expect(requests).toBe(4);
|
||||||
|
},
|
||||||
|
);
|
||||||
|
|
||||||
|
it(
|
||||||
|
"keeps cached events, warns and retries the same GET",
|
||||||
|
{ timeout: TEST_MS },
|
||||||
|
async () => {
|
||||||
|
let isFailing = false;
|
||||||
|
let requests = 0;
|
||||||
|
let imports = 0;
|
||||||
|
server.use(
|
||||||
|
http.post("*/api/v1/tbank-sync", () => {
|
||||||
|
imports += 1;
|
||||||
|
|
||||||
|
return HttpResponse.json({}, { status: 202 });
|
||||||
|
}),
|
||||||
|
http.get("*/api/v1/brokerage-accounts/:accountId/events", () => {
|
||||||
|
requests += 1;
|
||||||
|
|
||||||
|
return isFailing
|
||||||
|
? HttpResponse.json({ code: "TBANK_UNAVAILABLE" }, { status: 503 })
|
||||||
|
: HttpResponse.json(snapshot);
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
const { queryClient } = renderEvents();
|
||||||
|
await screen.findByText("Купон · Synthetic coupon");
|
||||||
|
expect(screen.getByText(/Прогноз от .* на 14\.08\.2026 – 13\.09\.2026/)).toBeVisible();
|
||||||
|
expect(screen.queryByRole("button", { name: "Повторить" }))
|
||||||
|
.not.toBeInTheDocument();
|
||||||
|
|
||||||
|
isFailing = true;
|
||||||
|
void queryClient.invalidateQueries({
|
||||||
|
queryKey: ["get", "/api/v1/brokerage-accounts/{accountId}/events"],
|
||||||
|
});
|
||||||
|
|
||||||
|
const retry = await screen.findByRole(
|
||||||
|
"button",
|
||||||
|
{ name: "Повторить" },
|
||||||
|
{ timeout: RETRIES_EXHAUSTED_MS },
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(screen.getByText("Не удалось обновить данные")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("Купон · Synthetic coupon")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText(/Прогноз от .* на 14\.08\.2026 – 13\.09\.2026/)).toBeVisible();
|
||||||
|
expect(requests).toBe(4);
|
||||||
|
|
||||||
|
isFailing = false;
|
||||||
|
fireEvent.click(retry);
|
||||||
|
|
||||||
|
await waitFor(() =>
|
||||||
|
expect(screen.queryByText("Не удалось обновить данные"))
|
||||||
|
.not.toBeInTheDocument());
|
||||||
|
expect(requests).toBe(5);
|
||||||
|
expect(imports).toBe(0);
|
||||||
|
},
|
||||||
|
);
|
||||||
|
|
||||||
|
it("does not offer a plain retry when the account is gone", async () => {
|
||||||
|
server.use(
|
||||||
|
http.get("*/api/v1/brokerage-accounts/:accountId/events", () =>
|
||||||
|
HttpResponse.json({ code: "NOT_FOUND" }, { status: 404 })),
|
||||||
|
);
|
||||||
|
renderEvents();
|
||||||
|
|
||||||
|
await waitFor(() =>
|
||||||
|
expect(screen.queryByRole("heading", { name: "Загрузка" }))
|
||||||
|
.not.toBeInTheDocument());
|
||||||
|
expect(screen.queryByRole("button", { name: "Повторить" }))
|
||||||
|
.not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -47,6 +47,7 @@ describe("AccountEventsPage", () => {
|
|||||||
accountId: "account",
|
accountId: "account",
|
||||||
calculatedAt: "2026-08-14T00:00:00Z",
|
calculatedAt: "2026-08-14T00:00:00Z",
|
||||||
events: [],
|
events: [],
|
||||||
|
window: { from: "2026-08-14", to: "2026-09-13" },
|
||||||
},
|
},
|
||||||
isError: false,
|
isError: false,
|
||||||
isLoading: false,
|
isLoading: false,
|
||||||
@@ -136,6 +137,7 @@ describe("AccountEventsPage", () => {
|
|||||||
type: "offer",
|
type: "offer",
|
||||||
},
|
},
|
||||||
],
|
],
|
||||||
|
window: { from: "2026-08-14", to: "2026-09-13" },
|
||||||
},
|
},
|
||||||
isError: false,
|
isError: false,
|
||||||
isLoading: false,
|
isLoading: false,
|
||||||
@@ -169,15 +171,18 @@ describe("AccountEventsPage", () => {
|
|||||||
expect(screen.getAllByText("O")).toHaveLength(2);
|
expect(screen.getAllByText("O")).toHaveLength(2);
|
||||||
});
|
});
|
||||||
|
|
||||||
it("renders empty and quiet error states", async () => {
|
it("renders empty and error states with retry", async () => {
|
||||||
const { rerender } = renderPage();
|
const { rerender } = renderPage();
|
||||||
expect(
|
expect(
|
||||||
screen.getByText("За выбранный период событий не найдено"),
|
screen.getByText("На выбранный период предстоящих событий не найдено"),
|
||||||
).toBeInTheDocument();
|
).toBeInTheDocument();
|
||||||
query.mockReturnValue({
|
query.mockReturnValue({
|
||||||
data: undefined,
|
data: undefined,
|
||||||
|
error: { code: "TBANK_UNAVAILABLE", status: 503 },
|
||||||
isError: true,
|
isError: true,
|
||||||
|
isFetching: false,
|
||||||
isLoading: false,
|
isLoading: false,
|
||||||
|
refetch: vi.fn(),
|
||||||
} as never);
|
} as never);
|
||||||
rerender(
|
rerender(
|
||||||
<MantineProvider>
|
<MantineProvider>
|
||||||
@@ -187,7 +192,7 @@ describe("AccountEventsPage", () => {
|
|||||||
</MantineProvider>,
|
</MantineProvider>,
|
||||||
);
|
);
|
||||||
expect(await screen.findByRole("button", { name: "Сбросить" })).toBeVisible();
|
expect(await screen.findByRole("button", { name: "Сбросить" })).toBeVisible();
|
||||||
expect(screen.queryByRole("button", { name: "Повторить" })).not.toBeInTheDocument();
|
expect(screen.getByRole("button", { name: "Повторить" })).toBeVisible();
|
||||||
});
|
});
|
||||||
|
|
||||||
it("shows a structural busy state before events are available", () => {
|
it("shows a structural busy state before events are available", () => {
|
||||||
@@ -234,7 +239,7 @@ describe("AccountEventsPage", () => {
|
|||||||
"true",
|
"true",
|
||||||
);
|
);
|
||||||
expect(
|
expect(
|
||||||
screen.queryByText("За выбранный период событий не найдено"),
|
screen.queryByText("На выбранный период предстоящих событий не найдено"),
|
||||||
).not.toBeInTheDocument();
|
).not.toBeInTheDocument();
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -273,6 +278,7 @@ describe("AccountEventsPage", () => {
|
|||||||
accountId: "all",
|
accountId: "all",
|
||||||
calculatedAt: "2026-08-14T00:00:00Z",
|
calculatedAt: "2026-08-14T00:00:00Z",
|
||||||
events: [...events],
|
events: [...events],
|
||||||
|
window: { from: "2026-08-14", to: "2026-09-13" },
|
||||||
},
|
},
|
||||||
isError: false,
|
isError: false,
|
||||||
isLoading: false,
|
isLoading: false,
|
||||||
|
|||||||
@@ -1,17 +1,17 @@
|
|||||||
import type { FC } from "react";
|
import type { FC } from "react";
|
||||||
|
|
||||||
import { useAccountEventsPageViewModel } from "./AccountEventsPage.vm";
|
import { useAccountEventsPageVm } from "./AccountEventsPage.vm";
|
||||||
import { AccountEventsPageError } from "./components/AccountEventsPageError.view";
|
import { AccountEventsPageError } from "./components/AccountEventsPageError.view";
|
||||||
import { AccountEventsPageLoaded } from "./components/AccountEventsPageLoaded.view";
|
import { AccountEventsPageLoaded } from "./components/AccountEventsPageLoaded.view";
|
||||||
import { AccountEventsPageLoading } from "./components/AccountEventsPageLoading.view";
|
import { AccountEventsPageLoading } from "./components/AccountEventsPageLoading.view";
|
||||||
|
|
||||||
const AccountEventsPage: FC = () => {
|
const AccountEventsPage: FC = () => {
|
||||||
const viewModel = useAccountEventsPageViewModel();
|
const vm = useAccountEventsPageVm();
|
||||||
if (viewModel.state === "loading") return <AccountEventsPageLoading />;
|
if (vm.state === "loading") return <AccountEventsPageLoading />;
|
||||||
|
|
||||||
return viewModel.state === "error"
|
return vm.state === "error"
|
||||||
? <AccountEventsPageError {...viewModel} />
|
? <AccountEventsPageError {...vm} />
|
||||||
: <AccountEventsPageLoaded {...viewModel} />;
|
: <AccountEventsPageLoaded {...vm} />;
|
||||||
};
|
};
|
||||||
|
|
||||||
export { AccountEventsPage };
|
export { AccountEventsPage };
|
||||||
|
|||||||
@@ -1,13 +1,12 @@
|
|||||||
import { useState } from "react";
|
import { useState } from "react";
|
||||||
import { useParams } from "react-router";
|
import { useParams } from "react-router";
|
||||||
|
|
||||||
import type { InvestmentResourceMeta } from "@/shared/api";
|
|
||||||
|
|
||||||
import {
|
import {
|
||||||
type BrokerageEvent,
|
type BrokerageEvent,
|
||||||
useBrokerageEvents,
|
useBrokerageEvents,
|
||||||
} from "@/entities/brokerage-event";
|
} from "@/entities/brokerage-event";
|
||||||
import { useScreenSync } from "@/features/tbank-connection";
|
import { useScreenSync } from "@/features/tbank-connection";
|
||||||
|
import { type InvestmentResourceMeta, readRetry } from "@/shared/api";
|
||||||
import {
|
import {
|
||||||
defaultPeriod,
|
defaultPeriod,
|
||||||
isValidPeriod,
|
isValidPeriod,
|
||||||
@@ -19,6 +18,7 @@ import {
|
|||||||
type AccountEventsPageViewModel
|
type AccountEventsPageViewModel
|
||||||
= | {
|
= | {
|
||||||
allAccounts: boolean;
|
allAccounts: boolean;
|
||||||
|
calculatedAt: string;
|
||||||
canApply: boolean;
|
canApply: boolean;
|
||||||
draftPeriod: [null | string, null | string];
|
draftPeriod: [null | string, null | string];
|
||||||
events: BrokerageEvent[];
|
events: BrokerageEvent[];
|
||||||
@@ -28,14 +28,20 @@ type AccountEventsPageViewModel
|
|||||||
onPeriodPopoverOpen: () => void;
|
onPeriodPopoverOpen: () => void;
|
||||||
onReset: () => void;
|
onReset: () => void;
|
||||||
partial?: boolean;
|
partial?: boolean;
|
||||||
|
readRetry: ReturnType<typeof readRetry>;
|
||||||
source?: InvestmentResourceMeta;
|
source?: InvestmentResourceMeta;
|
||||||
state: "loaded";
|
state: "loaded";
|
||||||
totalVisible: boolean;
|
totalVisible: boolean;
|
||||||
|
window: { from: string; to: string };
|
||||||
|
}
|
||||||
|
| {
|
||||||
|
onReset: () => void;
|
||||||
|
readRetry: ReturnType<typeof readRetry>;
|
||||||
|
state: "error";
|
||||||
}
|
}
|
||||||
| { onReset: () => void; state: "error" }
|
|
||||||
| { state: "loading" };
|
| { state: "loading" };
|
||||||
|
|
||||||
function useAccountEventsPageViewModel(): AccountEventsPageViewModel {
|
function useAccountEventsPageVm(): AccountEventsPageViewModel {
|
||||||
const { accountId = "" } = useParams();
|
const { accountId = "" } = useParams();
|
||||||
|
|
||||||
const {
|
const {
|
||||||
@@ -83,6 +89,8 @@ function useAccountEventsPageViewModel(): AccountEventsPageViewModel {
|
|||||||
isFetching: events.isFetching,
|
isFetching: events.isFetching,
|
||||||
});
|
});
|
||||||
|
|
||||||
|
const retry = readRetry([events]);
|
||||||
|
|
||||||
if (availability === "loading" && events.isLoading)
|
if (availability === "loading" && events.isLoading)
|
||||||
return { state: "loading" };
|
return { state: "loading" };
|
||||||
|
|
||||||
@@ -94,15 +102,17 @@ function useAccountEventsPageViewModel(): AccountEventsPageViewModel {
|
|||||||
if ((events.isError || events.meta?.lastAttempt.state === "failed") && !events.data)
|
if ((events.isError || events.meta?.lastAttempt.state === "failed") && !events.data)
|
||||||
return {
|
return {
|
||||||
onReset,
|
onReset,
|
||||||
|
readRetry: retry,
|
||||||
state: "error",
|
state: "error",
|
||||||
};
|
};
|
||||||
if (!events.data)
|
if (!events.data)
|
||||||
return availability === "unavailable"
|
return availability === "unavailable"
|
||||||
? { onReset, state: "error" }
|
? { onReset, readRetry: retry, state: "error" }
|
||||||
: { state: "loading" };
|
: { state: "loading" };
|
||||||
|
|
||||||
return {
|
return {
|
||||||
allAccounts: accountId === "all",
|
allAccounts: accountId === "all",
|
||||||
|
calculatedAt: events.data.calculatedAt,
|
||||||
canApply:
|
canApply:
|
||||||
(draftFrom !== appliedFrom || draftTo !== appliedTo)
|
(draftFrom !== appliedFrom || draftTo !== appliedTo)
|
||||||
&& isValidPeriod(draftFrom, draftTo),
|
&& isValidPeriod(draftFrom, draftTo),
|
||||||
@@ -122,10 +132,12 @@ function useAccountEventsPageViewModel(): AccountEventsPageViewModel {
|
|||||||
onPeriodPopoverOpen: () => setMinDate(moscowDate(new Date())),
|
onPeriodPopoverOpen: () => setMinDate(moscowDate(new Date())),
|
||||||
onReset,
|
onReset,
|
||||||
partial: events.meta?.completeness === "incomplete",
|
partial: events.meta?.completeness === "incomplete",
|
||||||
|
readRetry: retry,
|
||||||
source: events.meta,
|
source: events.meta,
|
||||||
state: "loaded",
|
state: "loaded",
|
||||||
totalVisible: events.meta?.completeness === "complete",
|
totalVisible: events.meta?.completeness === "complete",
|
||||||
|
window: events.data.window,
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
export { type AccountEventsPageViewModel, useAccountEventsPageViewModel };
|
export { type AccountEventsPageViewModel, useAccountEventsPageVm };
|
||||||
|
|||||||
+13
-1
@@ -4,7 +4,12 @@ import { Button, Group } from "@mantine/core";
|
|||||||
import { StateView } from "@wealthledger/ui";
|
import { StateView } from "@wealthledger/ui";
|
||||||
import { useTranslation } from "react-i18next";
|
import { useTranslation } from "react-i18next";
|
||||||
|
|
||||||
type AccountEventsPageErrorProps = { onReset: () => void };
|
import { ReadRetryButton, type ReadRetryProps } from "@/shared/ui";
|
||||||
|
|
||||||
|
type AccountEventsPageErrorProps = {
|
||||||
|
onReset: () => void;
|
||||||
|
readRetry: ReadRetryProps;
|
||||||
|
};
|
||||||
|
|
||||||
const AccountEventsPageError: FC<AccountEventsPageErrorProps> = (props) => {
|
const AccountEventsPageError: FC<AccountEventsPageErrorProps> = (props) => {
|
||||||
const { t } = useTranslation();
|
const { t } = useTranslation();
|
||||||
@@ -13,6 +18,13 @@ const AccountEventsPageError: FC<AccountEventsPageErrorProps> = (props) => {
|
|||||||
<StateView
|
<StateView
|
||||||
action={(
|
action={(
|
||||||
<Group>
|
<Group>
|
||||||
|
{props.readRetry.exhausted && (
|
||||||
|
<ReadRetryButton
|
||||||
|
onRetry={props.readRetry.onRetry}
|
||||||
|
retrying={props.readRetry.retrying}
|
||||||
|
/>
|
||||||
|
)}
|
||||||
|
|
||||||
<Button onClick={props.onReset} variant="default">
|
<Button onClick={props.onReset} variant="default">
|
||||||
{t("ledger.reset")}
|
{t("ledger.reset")}
|
||||||
</Button>
|
</Button>
|
||||||
|
|||||||
+12
-2
@@ -17,8 +17,8 @@ import {
|
|||||||
brokerageEventGroupKey,
|
brokerageEventGroupKey,
|
||||||
brokerageEventKey,
|
brokerageEventKey,
|
||||||
} from "@/entities/brokerage-event";
|
} from "@/entities/brokerage-event";
|
||||||
import { groupItems } from "@/shared/lib";
|
import { formatDate, formatSnapshotTime, groupItems } from "@/shared/lib";
|
||||||
import { SourceSyncStatus } from "@/shared/ui";
|
import { ReadRetry, SourceSyncStatus } from "@/shared/ui";
|
||||||
|
|
||||||
import type { AccountEventsPageViewModel } from "../AccountEventsPage.vm";
|
import type { AccountEventsPageViewModel } from "../AccountEventsPage.vm";
|
||||||
|
|
||||||
@@ -83,10 +83,20 @@ const AccountEventsPageLoaded: FC<AccountEventsPageLoadedProps> = (props) => {
|
|||||||
stale={props.source?.freshness === "stale"}
|
stale={props.source?.freshness === "stale"}
|
||||||
/>
|
/>
|
||||||
|
|
||||||
|
<ReadRetry {...props.readRetry} />
|
||||||
|
|
||||||
{!!props.partial && <Alert role="status">{t("investment.partial")}</Alert>}
|
{!!props.partial && <Alert role="status">{t("investment.partial")}</Alert>}
|
||||||
|
|
||||||
<Text c="dimmed">{t("events.hint")}</Text>
|
<Text c="dimmed">{t("events.hint")}</Text>
|
||||||
|
|
||||||
|
<Text c="dimmed" size="sm">
|
||||||
|
{t("events.forecastWindow", {
|
||||||
|
date: formatSnapshotTime(props.calculatedAt),
|
||||||
|
from: formatDate(props.window.from),
|
||||||
|
to: formatDate(props.window.to),
|
||||||
|
})}
|
||||||
|
</Text>
|
||||||
|
|
||||||
<Group align="end">
|
<Group align="end">
|
||||||
<DatePickerInput
|
<DatePickerInput
|
||||||
allowSingleDateInRange
|
allowSingleDateInRange
|
||||||
|
|||||||
@@ -26,6 +26,7 @@ import { afterEach, describe, expect, it, vi } from "vitest";
|
|||||||
import type { IncomeAnalytics } from "@/entities/income";
|
import type { IncomeAnalytics } from "@/entities/income";
|
||||||
|
|
||||||
import { configureAuthClient } from "@/shared/api";
|
import { configureAuthClient } from "@/shared/api";
|
||||||
|
import { formatSnapshotTime } from "@/shared/lib";
|
||||||
import { createTestQueryClient } from "@/test/query";
|
import { createTestQueryClient } from "@/test/query";
|
||||||
import { resource } from "@/test/resource";
|
import { resource } from "@/test/resource";
|
||||||
import { server } from "@/test/server";
|
import { server } from "@/test/server";
|
||||||
@@ -33,10 +34,14 @@ import { server } from "@/test/server";
|
|||||||
import { toIncomeDisplayModel } from "../../model/display";
|
import { toIncomeDisplayModel } from "../../model/display";
|
||||||
import { AccountIncomePage } from "./AccountIncomePage";
|
import { AccountIncomePage } from "./AccountIncomePage";
|
||||||
import {
|
import {
|
||||||
useAccountIncomePageViewModel,
|
useAccountIncomePageVm,
|
||||||
} from "./AccountIncomePage.vm";
|
} from "./AccountIncomePage.vm";
|
||||||
import { IncomePayments } from "./components/IncomePayments.view";
|
import { IncomePayments } from "./components/IncomePayments.view";
|
||||||
|
|
||||||
|
// Automatic read retries wait 1s + 2s before the failure is final.
|
||||||
|
const RETRIES_EXHAUSTED_MS = 6000;
|
||||||
|
const TEST_MS = 10_000;
|
||||||
|
|
||||||
const analytics
|
const analytics
|
||||||
= {
|
= {
|
||||||
accountId: "account-1",
|
accountId: "account-1",
|
||||||
@@ -44,7 +49,7 @@ const analytics
|
|||||||
buckets: [
|
buckets: [
|
||||||
{
|
{
|
||||||
period: { from: "2026-08-01", to: "2026-08-01" },
|
period: { from: "2026-08-01", to: "2026-08-01" },
|
||||||
totalsByCurrency: [summary("RUB", "10", "2")],
|
total: summary("10", "2"),
|
||||||
},
|
},
|
||||||
],
|
],
|
||||||
calculatedAt: "2026-08-27T00:00:00Z",
|
calculatedAt: "2026-08-27T00:00:00Z",
|
||||||
@@ -72,7 +77,7 @@ const analytics
|
|||||||
},
|
},
|
||||||
],
|
],
|
||||||
period: { from: "2026-08-01", to: "2026-08-27" },
|
period: { from: "2026-08-01", to: "2026-08-27" },
|
||||||
totalsByCurrency: [summary("RUB", "10", "2")],
|
total: summary("10", "2"),
|
||||||
} satisfies IncomeAnalytics & { instruments: [unknown] };
|
} satisfies IncomeAnalytics & { instruments: [unknown] };
|
||||||
|
|
||||||
function entry(): IncomeAnalytics["entries"][number] {
|
function entry(): IncomeAnalytics["entries"][number] {
|
||||||
@@ -140,12 +145,11 @@ function renderPage(
|
|||||||
return { ...view, queryClient };
|
return { ...view, queryClient };
|
||||||
}
|
}
|
||||||
|
|
||||||
function summary(currency: string, coupon: string, dividend: string) {
|
function summary(coupon: string, dividend: string) {
|
||||||
return {
|
return {
|
||||||
coupon: money(currency, coupon),
|
coupon: money("RUB", coupon),
|
||||||
currency,
|
dividend: money("RUB", dividend),
|
||||||
dividend: money(currency, dividend),
|
total: money("RUB", String(Number(coupon) + Number(dividend))),
|
||||||
total: money(currency, String(Number(coupon) + Number(dividend))),
|
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -166,7 +170,7 @@ describe("AccountIncomePage", () => {
|
|||||||
);
|
);
|
||||||
const queryClient = createTestQueryClient();
|
const queryClient = createTestQueryClient();
|
||||||
|
|
||||||
const { result } = renderHook(() => useAccountIncomePageViewModel(), {
|
const { result } = renderHook(() => useAccountIncomePageVm(), {
|
||||||
wrapper: ({ children }) => (
|
wrapper: ({ children }) => (
|
||||||
<QueryClientProvider client={queryClient}>
|
<QueryClientProvider client={queryClient}>
|
||||||
<MemoryRouter initialEntries={["?from=2024-02-29&to=2024-03-01"]}>
|
<MemoryRouter initialEntries={["?from=2024-02-29&to=2024-03-01"]}>
|
||||||
@@ -303,7 +307,7 @@ describe("AccountIncomePage", () => {
|
|||||||
buckets: [],
|
buckets: [],
|
||||||
entries: [],
|
entries: [],
|
||||||
instruments: [],
|
instruments: [],
|
||||||
totalsByCurrency: [],
|
total: summary("0", "0"),
|
||||||
}),
|
}),
|
||||||
),
|
),
|
||||||
),
|
),
|
||||||
@@ -403,21 +407,124 @@ describe("AccountIncomePage", () => {
|
|||||||
expect(screen.queryByText(/Сравнение с/)).not.toBeInTheDocument();
|
expect(screen.queryByText(/Сравнение с/)).not.toBeInTheDocument();
|
||||||
});
|
});
|
||||||
|
|
||||||
it("shows a quiet realized error", async () => {
|
it.each([
|
||||||
|
["full", analytics],
|
||||||
|
["empty", { ...analytics, buckets: [], entries: [], instruments: [], total: summary("0", "0") }],
|
||||||
|
])("shows the server source time and last attempt for a %s result", async (_name, data) => {
|
||||||
|
server.use(
|
||||||
|
http.get("*/api/v1/brokerage-accounts/account-1/income-analytics", () =>
|
||||||
|
HttpResponse.json(
|
||||||
|
resource(data, {
|
||||||
|
freshness: "stale",
|
||||||
|
lastAttempt: {
|
||||||
|
finishedAt: "2026-08-27T01:00:00Z",
|
||||||
|
problems: [],
|
||||||
|
startedAt: "2026-08-27T00:59:00Z",
|
||||||
|
state: "failed",
|
||||||
|
},
|
||||||
|
lastSuccessfulAt: "2026-08-26T12:00:00Z",
|
||||||
|
}),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
);
|
||||||
|
renderPage();
|
||||||
|
expect(await screen.findByText(/^Данные на /)).toHaveTextContent(
|
||||||
|
formatSnapshotTime("2026-08-26T12:00:00Z"),
|
||||||
|
);
|
||||||
|
expect(screen.getByText("Обновление не удалось")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("Данные требуют обновления")).toBeInTheDocument();
|
||||||
|
expect(screen.queryByRole("button", { name: "Повторить" })).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it(
|
||||||
|
"offers retry after an initial failure and recovers in place",
|
||||||
|
{ timeout: TEST_MS },
|
||||||
|
async () => {
|
||||||
|
let isFailing = true;
|
||||||
|
let requests = 0;
|
||||||
server.use(
|
server.use(
|
||||||
http.get(
|
http.get(
|
||||||
"*/api/v1/brokerage-accounts/account-1/income-analytics",
|
"*/api/v1/brokerage-accounts/account-1/income-analytics",
|
||||||
() => new HttpResponse(null, { status: 503 }),
|
() => {
|
||||||
|
requests += 1;
|
||||||
|
|
||||||
|
return isFailing
|
||||||
|
? new HttpResponse(null, { status: 503 })
|
||||||
|
: HttpResponse.json(resource(analytics));
|
||||||
|
},
|
||||||
),
|
),
|
||||||
);
|
);
|
||||||
renderPage();
|
renderPage();
|
||||||
expect(
|
expect(
|
||||||
await screen.findByText("Не удалось рассчитать пассивный доход", undefined, {
|
await screen.findByText(
|
||||||
timeout: 4000,
|
"Не удалось рассчитать пассивный доход",
|
||||||
}),
|
undefined,
|
||||||
|
{ timeout: RETRIES_EXHAUSTED_MS },
|
||||||
|
),
|
||||||
).toBeInTheDocument();
|
).toBeInTheDocument();
|
||||||
expect(screen.queryByRole("button", { name: "Повторить" })).not.toBeInTheDocument();
|
const retry = screen.getByRole("button", { name: "Повторить" });
|
||||||
|
expect(requests).toBe(3);
|
||||||
|
|
||||||
|
isFailing = false;
|
||||||
|
fireEvent.click(retry);
|
||||||
|
|
||||||
|
expect(
|
||||||
|
await screen.findByRole("region", { name: "Выплаты" }),
|
||||||
|
).toBeInTheDocument();
|
||||||
|
expect(requests).toBe(4);
|
||||||
|
},
|
||||||
|
);
|
||||||
|
|
||||||
|
it(
|
||||||
|
"keeps cached income, warns and retries the same GET",
|
||||||
|
{ timeout: TEST_MS },
|
||||||
|
async () => {
|
||||||
|
let isFailing = false;
|
||||||
|
let requests = 0;
|
||||||
|
server.use(
|
||||||
|
http.get(
|
||||||
|
"*/api/v1/brokerage-accounts/account-1/income-analytics",
|
||||||
|
() => {
|
||||||
|
requests += 1;
|
||||||
|
|
||||||
|
return isFailing
|
||||||
|
? HttpResponse.json(
|
||||||
|
{ code: "TBANK_UNAVAILABLE" },
|
||||||
|
{ status: 503 },
|
||||||
|
)
|
||||||
|
: HttpResponse.json(resource(analytics));
|
||||||
|
},
|
||||||
|
),
|
||||||
|
);
|
||||||
|
const { queryClient } = renderPage();
|
||||||
|
await screen.findByRole("region", { name: "Выплаты" });
|
||||||
|
expect(screen.queryByRole("button", { name: "Повторить" }))
|
||||||
|
.not.toBeInTheDocument();
|
||||||
|
|
||||||
|
isFailing = true;
|
||||||
|
void queryClient.invalidateQueries({
|
||||||
|
queryKey: ["get", "/api/v1/brokerage-accounts/{accountId}/income-analytics"],
|
||||||
});
|
});
|
||||||
|
|
||||||
|
const retry = await screen.findByRole(
|
||||||
|
"button",
|
||||||
|
{ name: "Повторить" },
|
||||||
|
{ timeout: RETRIES_EXHAUSTED_MS },
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(screen.getByText("Не удалось обновить данные")).toBeInTheDocument();
|
||||||
|
expect(screen.getByRole("region", { name: "Выплаты" })).toBeInTheDocument();
|
||||||
|
expect(requests).toBe(4);
|
||||||
|
|
||||||
|
isFailing = false;
|
||||||
|
fireEvent.click(retry);
|
||||||
|
|
||||||
|
await waitFor(() =>
|
||||||
|
expect(screen.queryByText("Не удалось обновить данные"))
|
||||||
|
.not.toBeInTheDocument());
|
||||||
|
expect(requests).toBe(5);
|
||||||
|
},
|
||||||
|
);
|
||||||
});
|
});
|
||||||
|
|
||||||
const LocationProbe: FC = () => {
|
const LocationProbe: FC = () => {
|
||||||
@@ -629,11 +736,11 @@ describe("income period and snapshot boundary", () => {
|
|||||||
const instruments = [
|
const instruments = [
|
||||||
{
|
{
|
||||||
...analytics.instruments[0],
|
...analytics.instruments[0],
|
||||||
coupon: money("USD", "10"),
|
coupon: money("RUB", "10"),
|
||||||
dividend: money("USD", "0"),
|
dividend: money("RUB", "0"),
|
||||||
key: "usd",
|
key: "rub-positive",
|
||||||
receiptCount: 1,
|
receiptCount: 1,
|
||||||
total: money("USD", "10"),
|
total: money("RUB", "10"),
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
...analytics.instruments[0],
|
...analytics.instruments[0],
|
||||||
@@ -662,7 +769,7 @@ describe("income period and snapshot boundary", () => {
|
|||||||
payment: instrument.total,
|
payment: instrument.total,
|
||||||
})),
|
})),
|
||||||
instruments,
|
instruments,
|
||||||
totalsByCurrency: [summary("RUB", "-5", "0"), summary("USD", "10", "0")],
|
total: summary("-5", "0"),
|
||||||
});
|
});
|
||||||
|
|
||||||
render(
|
render(
|
||||||
@@ -674,10 +781,9 @@ describe("income period and snapshot boundary", () => {
|
|||||||
screen.getByRole("heading", { name: "Выплаты" }),
|
screen.getByRole("heading", { name: "Выплаты" }),
|
||||||
).toBeInTheDocument();
|
).toBeInTheDocument();
|
||||||
expect(screen.queryByText("RUB")).not.toBeInTheDocument();
|
expect(screen.queryByText("RUB")).not.toBeInTheDocument();
|
||||||
expect(screen.queryByText("USD")).not.toBeInTheDocument();
|
|
||||||
const cards = screen.getAllByRole("listitem");
|
const cards = screen.getAllByRole("listitem");
|
||||||
expect(cards).toHaveLength(3);
|
expect(cards).toHaveLength(3);
|
||||||
expect(cards[0]).toHaveTextContent("+10 USD");
|
expect(cards[0]).toHaveTextContent("+10 ₽");
|
||||||
expect(cards[1]).toHaveTextContent("−2 ₽");
|
expect(cards[1]).toHaveTextContent("−2 ₽");
|
||||||
expect(cards[2]).toHaveTextContent("−3 ₽");
|
expect(cards[2]).toHaveTextContent("−3 ₽");
|
||||||
expect(screen.queryByText(/Итого:|Выплат:/)).not.toBeInTheDocument();
|
expect(screen.queryByText(/Итого:|Выплат:/)).not.toBeInTheDocument();
|
||||||
@@ -709,11 +815,11 @@ describe("income period and snapshot boundary", () => {
|
|||||||
);
|
);
|
||||||
renderPage(undefined, "all");
|
renderPage(undefined, "all");
|
||||||
|
|
||||||
expect(await screen.findByText("Купон · BOND")).toBeInTheDocument();
|
expect(await screen.findByText("Выплата купонов BOND")).toBeInTheDocument();
|
||||||
expect(screen.getByText("+30 ₽")).toBeInTheDocument();
|
expect(screen.getByText("+30 ₽")).toBeInTheDocument();
|
||||||
|
|
||||||
const accounts = within(screen.getByRole("list", {
|
const accounts = within(screen.getByRole("list", {
|
||||||
name: /Купон · BOND, Исполнено/,
|
name: /Выплата купонов BOND, Исполнено/,
|
||||||
}));
|
}));
|
||||||
|
|
||||||
expect(accounts.getByText("Брокерский")).toBeInTheDocument();
|
expect(accounts.getByText("Брокерский")).toBeInTheDocument();
|
||||||
@@ -748,7 +854,7 @@ describe("income period and snapshot boundary", () => {
|
|||||||
expect(await screen.findByText("+30 ₽")).toBeInTheDocument();
|
expect(await screen.findByText("+30 ₽")).toBeInTheDocument();
|
||||||
|
|
||||||
const accounts = within(screen.getByRole("list", {
|
const accounts = within(screen.getByRole("list", {
|
||||||
name: /Купон · BOND/,
|
name: /Выплата купонов BOND/,
|
||||||
}));
|
}));
|
||||||
|
|
||||||
expect(accounts.getAllByRole("listitem")).toHaveLength(2);
|
expect(accounts.getAllByRole("listitem")).toHaveLength(2);
|
||||||
@@ -781,7 +887,7 @@ describe("income period and snapshot boundary", () => {
|
|||||||
);
|
);
|
||||||
const view = renderPage(undefined, "all");
|
const view = renderPage(undefined, "all");
|
||||||
|
|
||||||
await screen.findByText("Купон · BOND");
|
await screen.findByText("Выплата купонов BOND");
|
||||||
expect(screen.queryByText("+30 ₽")).not.toBeInTheDocument();
|
expect(screen.queryByText("+30 ₽")).not.toBeInTheDocument();
|
||||||
view.unmount();
|
view.unmount();
|
||||||
|
|
||||||
|
|||||||
@@ -1,17 +1,17 @@
|
|||||||
import type { FC } from "react";
|
import type { FC } from "react";
|
||||||
|
|
||||||
import { useAccountIncomePageViewModel } from "./AccountIncomePage.vm";
|
import { useAccountIncomePageVm } from "./AccountIncomePage.vm";
|
||||||
import { AccountIncomePageError } from "./components/AccountIncomePageError.view";
|
import { AccountIncomePageError } from "./components/AccountIncomePageError.view";
|
||||||
import { AccountIncomePageLoaded } from "./components/AccountIncomePageLoaded.view";
|
import { AccountIncomePageLoaded } from "./components/AccountIncomePageLoaded.view";
|
||||||
import { AccountIncomePageLoading } from "./components/AccountIncomePageLoading.view";
|
import { AccountIncomePageLoading } from "./components/AccountIncomePageLoading.view";
|
||||||
|
|
||||||
const AccountIncomePage: FC = () => {
|
const AccountIncomePage: FC = () => {
|
||||||
const viewModel = useAccountIncomePageViewModel();
|
const vm = useAccountIncomePageVm();
|
||||||
if (viewModel.state === "loading") return <AccountIncomePageLoading />;
|
if (vm.state === "loading") return <AccountIncomePageLoading />;
|
||||||
|
|
||||||
return viewModel.state === "error"
|
return vm.state === "error"
|
||||||
? <AccountIncomePageError {...viewModel} />
|
? <AccountIncomePageError {...vm} />
|
||||||
: <AccountIncomePageLoaded {...viewModel} />;
|
: <AccountIncomePageLoaded {...vm} />;
|
||||||
};
|
};
|
||||||
|
|
||||||
export { AccountIncomePage };
|
export { AccountIncomePage };
|
||||||
|
|||||||
@@ -5,6 +5,7 @@ import { useParams, useSearchParams } from "react-router";
|
|||||||
|
|
||||||
import { type IncomeAnalytics, useIncomeAnalytics } from "@/entities/income";
|
import { type IncomeAnalytics, useIncomeAnalytics } from "@/entities/income";
|
||||||
import { useScreenSync } from "@/features/tbank-connection";
|
import { useScreenSync } from "@/features/tbank-connection";
|
||||||
|
import { type InvestmentResourceMeta, readRetry } from "@/shared/api";
|
||||||
import { isValidPeriod, moscowDate, useInitialAvailability } from "@/shared/lib";
|
import { isValidPeriod, moscowDate, useInitialAvailability } from "@/shared/lib";
|
||||||
|
|
||||||
import {
|
import {
|
||||||
@@ -30,16 +31,19 @@ type AccountIncomePageViewModel
|
|||||||
onReset: () => void;
|
onReset: () => void;
|
||||||
onSubmit: (values: IncomeForm) => void;
|
onSubmit: (values: IncomeForm) => void;
|
||||||
partial?: boolean;
|
partial?: boolean;
|
||||||
|
readRetry: ReturnType<typeof readRetry>;
|
||||||
|
source?: InvestmentResourceMeta;
|
||||||
state: "loaded";
|
state: "loaded";
|
||||||
totalVisible: boolean;
|
totalVisible: boolean;
|
||||||
}
|
}
|
||||||
| {
|
| {
|
||||||
period: IncomePeriod;
|
period: IncomePeriod;
|
||||||
|
readRetry: ReturnType<typeof readRetry>;
|
||||||
state: "error";
|
state: "error";
|
||||||
}
|
}
|
||||||
| { state: "loading" };
|
| { state: "loading" };
|
||||||
|
|
||||||
const useAccountIncomePageViewModel = (): AccountIncomePageViewModel => {
|
const useAccountIncomePageVm = (): AccountIncomePageViewModel => {
|
||||||
const { accountId = "" } = useParams();
|
const { accountId = "" } = useParams();
|
||||||
const [searchParameters, setSearchParameters] = useSearchParams();
|
const [searchParameters, setSearchParameters] = useSearchParams();
|
||||||
|
|
||||||
@@ -84,12 +88,14 @@ const useAccountIncomePageViewModel = (): AccountIncomePageViewModel => {
|
|||||||
isFetching: analytics.isFetching,
|
isFetching: analytics.isFetching,
|
||||||
});
|
});
|
||||||
|
|
||||||
|
const retry = readRetry([analytics]);
|
||||||
|
|
||||||
if (availability === "loading" && analytics.isLoading)
|
if (availability === "loading" && analytics.isLoading)
|
||||||
return { state: "loading" };
|
return { state: "loading" };
|
||||||
|
|
||||||
if (!analytics.data)
|
if (!analytics.data)
|
||||||
return availability === "unavailable"
|
return availability === "unavailable"
|
||||||
? { period, state: "error" }
|
? { period, readRetry: retry, state: "error" }
|
||||||
: { state: "loading" };
|
: { state: "loading" };
|
||||||
|
|
||||||
const display = toIncomeDisplayModel(analytics.data);
|
const display = toIncomeDisplayModel(analytics.data);
|
||||||
@@ -116,6 +122,8 @@ const useAccountIncomePageViewModel = (): AccountIncomePageViewModel => {
|
|||||||
onReset,
|
onReset,
|
||||||
onSubmit,
|
onSubmit,
|
||||||
partial: analytics.meta?.completeness === "incomplete",
|
partial: analytics.meta?.completeness === "incomplete",
|
||||||
|
readRetry: retry,
|
||||||
|
source: analytics.meta,
|
||||||
state: "loaded",
|
state: "loaded",
|
||||||
totalVisible: analytics.meta?.completeness === "complete",
|
totalVisible: analytics.meta?.completeness === "complete",
|
||||||
};
|
};
|
||||||
@@ -138,5 +146,5 @@ function isValidIncomePeriod(period: IncomePeriod): boolean {
|
|||||||
|
|
||||||
export {
|
export {
|
||||||
type AccountIncomePageViewModel,
|
type AccountIncomePageViewModel,
|
||||||
useAccountIncomePageViewModel,
|
useAccountIncomePageVm,
|
||||||
};
|
};
|
||||||
|
|||||||
+13
-1
@@ -3,15 +3,27 @@ import type { FC } from "react";
|
|||||||
import { StateView } from "@wealthledger/ui";
|
import { StateView } from "@wealthledger/ui";
|
||||||
import { useTranslation } from "react-i18next";
|
import { useTranslation } from "react-i18next";
|
||||||
|
|
||||||
|
import { ReadRetryButton } from "@/shared/ui";
|
||||||
|
|
||||||
import type { AccountIncomePageViewModel } from "../AccountIncomePage.vm";
|
import type { AccountIncomePageViewModel } from "../AccountIncomePage.vm";
|
||||||
|
|
||||||
type ErrorProps = Extract<AccountIncomePageViewModel, { state: "error" }>;
|
type ErrorProps = Extract<AccountIncomePageViewModel, { state: "error" }>;
|
||||||
|
|
||||||
const AccountIncomePageError: FC<ErrorProps> = () => {
|
const AccountIncomePageError: FC<ErrorProps> = (props) => {
|
||||||
const { t } = useTranslation();
|
const { t } = useTranslation();
|
||||||
|
|
||||||
|
const retry = props.readRetry.exhausted
|
||||||
|
? (
|
||||||
|
<ReadRetryButton
|
||||||
|
onRetry={props.readRetry.onRetry}
|
||||||
|
retrying={props.readRetry.retrying}
|
||||||
|
/>
|
||||||
|
)
|
||||||
|
: undefined;
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<StateView
|
<StateView
|
||||||
|
action={retry}
|
||||||
error
|
error
|
||||||
text={t("income.errorText")}
|
text={t("income.errorText")}
|
||||||
title={t("income.errorTitle")}
|
title={t("income.errorTitle")}
|
||||||
|
|||||||
+13
-8
@@ -5,10 +5,11 @@ import {
|
|||||||
Stack,
|
Stack,
|
||||||
Title,
|
Title,
|
||||||
} from "@mantine/core";
|
} from "@mantine/core";
|
||||||
import { StateView } from "@wealthledger/ui";
|
|
||||||
import { FormProvider } from "react-hook-form";
|
import { FormProvider } from "react-hook-form";
|
||||||
import { useTranslation } from "react-i18next";
|
import { useTranslation } from "react-i18next";
|
||||||
|
|
||||||
|
import { ReadRetry, SourceSyncStatus } from "@/shared/ui";
|
||||||
|
|
||||||
import type { AccountIncomePageViewModel } from "../AccountIncomePage.vm";
|
import type { AccountIncomePageViewModel } from "../AccountIncomePage.vm";
|
||||||
|
|
||||||
import classes from "../AccountIncomePage.module.css";
|
import classes from "../AccountIncomePage.module.css";
|
||||||
@@ -23,13 +24,9 @@ const AccountIncomePageLoadedSummary: FC<LoadedProps> = (props) => {
|
|||||||
|
|
||||||
const { analytics } = props;
|
const { analytics } = props;
|
||||||
|
|
||||||
if (props.partial) {
|
return props.partial
|
||||||
return <Alert role="status">{t("investment.partial")}</Alert>;
|
? <Alert role="status">{t("investment.partial")}</Alert>
|
||||||
}
|
: <IncomeSummary totals={analytics.total} />;
|
||||||
|
|
||||||
return analytics.totalsByCurrency.length > 0
|
|
||||||
? <IncomeSummary totals={analytics.totalsByCurrency} />
|
|
||||||
: <StateView text={t("income.emptyText")} title={t("income.emptyTitle")} />;
|
|
||||||
};
|
};
|
||||||
|
|
||||||
const AccountIncomePageLoaded: FC<LoadedProps> = (props) => {
|
const AccountIncomePageLoaded: FC<LoadedProps> = (props) => {
|
||||||
@@ -49,6 +46,14 @@ const AccountIncomePageLoaded: FC<LoadedProps> = (props) => {
|
|||||||
/>
|
/>
|
||||||
</FormProvider>
|
</FormProvider>
|
||||||
|
|
||||||
|
<SourceSyncStatus
|
||||||
|
lastAttempt={props.source?.lastAttempt}
|
||||||
|
lastSuccessfulAt={props.source?.lastSuccessfulAt}
|
||||||
|
stale={props.source?.freshness === "stale"}
|
||||||
|
/>
|
||||||
|
|
||||||
|
<ReadRetry {...props.readRetry} />
|
||||||
|
|
||||||
<AccountIncomePageLoadedSummary {...props} />
|
<AccountIncomePageLoadedSummary {...props} />
|
||||||
|
|
||||||
<Alert color="blue">{t("income.taxBoundary")}</Alert>
|
<Alert color="blue">{t("income.taxBoundary")}</Alert>
|
||||||
|
|||||||
@@ -7,7 +7,7 @@ import type { IncomeAnalytics } from "@/entities/income";
|
|||||||
|
|
||||||
import { formatMoney } from "@/shared/lib";
|
import { formatMoney } from "@/shared/lib";
|
||||||
|
|
||||||
type IncomeSummaryProps = { totals: IncomeAnalytics["totalsByCurrency"] };
|
type IncomeSummaryProps = { totals: IncomeAnalytics["total"] };
|
||||||
|
|
||||||
const IncomeSummary: FC<IncomeSummaryProps> = (props) => {
|
const IncomeSummary: FC<IncomeSummaryProps> = (props) => {
|
||||||
const { t } = useTranslation();
|
const { t } = useTranslation();
|
||||||
@@ -16,16 +16,14 @@ const IncomeSummary: FC<IncomeSummaryProps> = (props) => {
|
|||||||
<Stack>
|
<Stack>
|
||||||
<Title order={2}>{t("income.summaryTitle")}</Title>
|
<Title order={2}>{t("income.summaryTitle")}</Title>
|
||||||
|
|
||||||
{props.totals.map(total => (
|
<Paper p="md" radius="md" withBorder>
|
||||||
<Paper key={total.currency} p="md" radius="md" withBorder>
|
<Text fw={700}>{formatMoney(props.totals.total)}</Text>
|
||||||
<Text fw={700}>{formatMoney(total.total)}</Text>
|
|
||||||
|
|
||||||
<Text c="dimmed" size="sm">
|
<Text c="dimmed" size="sm">
|
||||||
{t("income.coupon")}: {formatMoney(total.coupon)} ·{" "}
|
{t("income.coupon")}: {formatMoney(props.totals.coupon)} ·{" "}
|
||||||
{t("income.dividend")}: {formatMoney(total.dividend)}
|
{t("income.dividend")}: {formatMoney(props.totals.dividend)}
|
||||||
</Text>
|
</Text>
|
||||||
</Paper>
|
</Paper>
|
||||||
))}
|
|
||||||
</Stack>
|
</Stack>
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|||||||
+96
-13
@@ -90,9 +90,13 @@ function configureTestAuth() {
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
function renderPage(search = "", accountId = "account-1") {
|
function renderPage(
|
||||||
|
search = "",
|
||||||
|
accountId = "account-1",
|
||||||
|
queryClient = createTestQueryClient(),
|
||||||
|
) {
|
||||||
return render(
|
return render(
|
||||||
<QueryClientProvider client={createTestQueryClient()}>
|
<QueryClientProvider client={queryClient}>
|
||||||
<MantineProvider>
|
<MantineProvider>
|
||||||
<MemoryRouter
|
<MemoryRouter
|
||||||
initialEntries={[`/accounts/${accountId}/operations${search}`]}
|
initialEntries={[`/accounts/${accountId}/operations${search}`]}
|
||||||
@@ -109,6 +113,18 @@ function renderPage(search = "", accountId = "account-1") {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Automatic read retries wait 1s + 2s before the failure is final.
|
||||||
|
const RETRIES_EXHAUSTED_MS = 6000;
|
||||||
|
const TEST_MS = 10_000;
|
||||||
|
|
||||||
|
const loadedOperations = {
|
||||||
|
accountId: "account-1",
|
||||||
|
hasNext: false,
|
||||||
|
items: [operation],
|
||||||
|
nextCursor: null,
|
||||||
|
observedAt: "2026-08-14T00:00:00Z",
|
||||||
|
};
|
||||||
|
|
||||||
describe("LedgerEntryRow", () => {
|
describe("LedgerEntryRow", () => {
|
||||||
it("marks cashless operations without rendering operation details", () => {
|
it("marks cashless operations without rendering operation details", () => {
|
||||||
render(
|
render(
|
||||||
@@ -424,7 +440,7 @@ describe("AccountOperationsPage", () => {
|
|||||||
renderPage();
|
renderPage();
|
||||||
|
|
||||||
expect(
|
expect(
|
||||||
await screen.findByRole("heading", { name: "Журнал операций" }),
|
await screen.findByRole("heading", { name: "История операций" }),
|
||||||
).toBeInTheDocument();
|
).toBeInTheDocument();
|
||||||
expect(
|
expect(
|
||||||
screen.queryByRole("link", { name: "К счету" }),
|
screen.queryByRole("link", { name: "К счету" }),
|
||||||
@@ -466,7 +482,7 @@ describe("AccountOperationsPage", () => {
|
|||||||
renderPage();
|
renderPage();
|
||||||
|
|
||||||
expect(
|
expect(
|
||||||
await screen.findByRole("heading", { name: "Журнал операций" }),
|
await screen.findByRole("heading", { name: "История операций" }),
|
||||||
).toBeInTheDocument();
|
).toBeInTheDocument();
|
||||||
await waitFor(() => expect(searches.length).toBeGreaterThan(0));
|
await waitFor(() => expect(searches.length).toBeGreaterThan(0));
|
||||||
const countBefore = searches.length;
|
const countBefore = searches.length;
|
||||||
@@ -505,7 +521,7 @@ describe("AccountOperationsPage", () => {
|
|||||||
renderPage();
|
renderPage();
|
||||||
|
|
||||||
expect(
|
expect(
|
||||||
await screen.findByRole("heading", { name: "Журнал операций" }),
|
await screen.findByRole("heading", { name: "История операций" }),
|
||||||
).toBeInTheDocument();
|
).toBeInTheDocument();
|
||||||
fireEvent.click(screen.getByRole("combobox", { name: "Категории" }));
|
fireEvent.click(screen.getByRole("combobox", { name: "Категории" }));
|
||||||
fireEvent.click(await screen.findByText("Налог"));
|
fireEvent.click(await screen.findByText("Налог"));
|
||||||
@@ -545,21 +561,88 @@ describe("AccountOperationsPage", () => {
|
|||||||
).toBeInTheDocument();
|
).toBeInTheDocument();
|
||||||
});
|
});
|
||||||
|
|
||||||
it("renders an error state", async () => {
|
it(
|
||||||
|
"renders an error state with retry that recovers in place",
|
||||||
|
{ timeout: TEST_MS },
|
||||||
|
async () => {
|
||||||
configureTestAuth();
|
configureTestAuth();
|
||||||
|
let isFailing = true;
|
||||||
|
let requests = 0;
|
||||||
server.use(
|
server.use(
|
||||||
http.get("*/api/v1/brokerage-accounts/:accountId/operations", () =>
|
http.get("*/api/v1/brokerage-accounts/:accountId/operations", () => {
|
||||||
HttpResponse.json({ code: "TBANK_UNAVAILABLE" }, { status: 503 }),
|
requests += 1;
|
||||||
),
|
|
||||||
|
return isFailing
|
||||||
|
? HttpResponse.json({ code: "TBANK_UNAVAILABLE" }, { status: 503 })
|
||||||
|
: HttpResponse.json(resource(loadedOperations));
|
||||||
|
}),
|
||||||
);
|
);
|
||||||
renderPage();
|
renderPage();
|
||||||
expect(
|
expect(
|
||||||
await screen.findByText("Не удалось загрузить журнал", undefined, {
|
await screen.findByText("Не удалось загрузить историю операций", undefined, {
|
||||||
timeout: 4000,
|
timeout: RETRIES_EXHAUSTED_MS,
|
||||||
}),
|
}),
|
||||||
).toBeInTheDocument();
|
).toBeInTheDocument();
|
||||||
|
expect(requests).toBe(3);
|
||||||
|
|
||||||
|
isFailing = false;
|
||||||
|
fireEvent.click(screen.getByRole("button", { name: "Повторить" }));
|
||||||
|
|
||||||
|
expect(await screen.findByText("Покупка акций")).toBeInTheDocument();
|
||||||
|
expect(requests).toBe(4);
|
||||||
|
},
|
||||||
|
);
|
||||||
|
|
||||||
|
it(
|
||||||
|
"keeps cached operations, warns and retries the same GET",
|
||||||
|
{ timeout: TEST_MS },
|
||||||
|
async () => {
|
||||||
|
configureTestAuth();
|
||||||
|
let isFailing = false;
|
||||||
|
let requests = 0;
|
||||||
|
server.use(
|
||||||
|
http.get("*/api/v1/brokerage-accounts/:accountId/operations", () => {
|
||||||
|
requests += 1;
|
||||||
|
|
||||||
|
return isFailing
|
||||||
|
? HttpResponse.json({ code: "TBANK_UNAVAILABLE" }, { status: 503 })
|
||||||
|
: HttpResponse.json(resource(loadedOperations));
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
const queryClient = createTestQueryClient();
|
||||||
|
renderPage("", "account-1", queryClient);
|
||||||
|
await screen.findByText("Покупка акций");
|
||||||
|
expect(screen.queryByRole("button", { name: "Повторить" }))
|
||||||
|
.not.toBeInTheDocument();
|
||||||
|
|
||||||
|
isFailing = true;
|
||||||
|
void queryClient.invalidateQueries({
|
||||||
|
queryKey: [
|
||||||
|
"get",
|
||||||
|
"/api/v1/brokerage-accounts/{accountId}/operations",
|
||||||
|
],
|
||||||
});
|
});
|
||||||
|
|
||||||
|
const retry = await screen.findByRole(
|
||||||
|
"button",
|
||||||
|
{ name: "Повторить" },
|
||||||
|
{ timeout: RETRIES_EXHAUSTED_MS },
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(screen.getByText("Не удалось обновить данные")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("Покупка акций")).toBeInTheDocument();
|
||||||
|
expect(requests).toBe(4);
|
||||||
|
|
||||||
|
isFailing = false;
|
||||||
|
fireEvent.click(retry);
|
||||||
|
|
||||||
|
await waitFor(() =>
|
||||||
|
expect(screen.queryByText("Не удалось обновить данные"))
|
||||||
|
.not.toBeInTheDocument());
|
||||||
|
expect(requests).toBe(5);
|
||||||
|
},
|
||||||
|
);
|
||||||
|
|
||||||
it("keeps a null operations envelope loading instead of a confirmed empty period", async () => {
|
it("keeps a null operations envelope loading instead of a confirmed empty period", async () => {
|
||||||
configureTestAuth();
|
configureTestAuth();
|
||||||
server.use(
|
server.use(
|
||||||
@@ -704,10 +787,10 @@ describe("all-account operation groups", () => {
|
|||||||
fireEvent.click(screen.getByRole("button", { name: "Далее" }));
|
fireEvent.click(screen.getByRole("button", { name: "Далее" }));
|
||||||
|
|
||||||
const accounts = await screen.findByRole("list", {
|
const accounts = await screen.findByRole("list", {
|
||||||
name: /Купон · BOND, Исполнено/,
|
name: /Выплата купонов BOND, Исполнено/,
|
||||||
});
|
});
|
||||||
|
|
||||||
expect(screen.getByText("Купон · BOND")).toBeInTheDocument();
|
expect(screen.getByText("Выплата купонов BOND")).toBeInTheDocument();
|
||||||
expect(screen.getByText("+200 ₽")).toBeInTheDocument();
|
expect(screen.getByText("+200 ₽")).toBeInTheDocument();
|
||||||
expect(within(accounts).getAllByRole("listitem")).toHaveLength(2);
|
expect(within(accounts).getAllByRole("listitem")).toHaveLength(2);
|
||||||
|
|
||||||
|
|||||||
@@ -6,15 +6,15 @@ import { AccountOperationsPageLoaded } from "./components/AccountOperationsPageL
|
|||||||
import { AccountOperationsPageLoading } from "./components/AccountOperationsPageLoading.view";
|
import { AccountOperationsPageLoading } from "./components/AccountOperationsPageLoading.view";
|
||||||
|
|
||||||
const AccountOperationsPage: FC = () => {
|
const AccountOperationsPage: FC = () => {
|
||||||
const viewModel = useAccountOperationsPageVm();
|
const vm = useAccountOperationsPageVm();
|
||||||
|
|
||||||
if (viewModel.state === "loading") {
|
if (vm.state === "loading") {
|
||||||
return <AccountOperationsPageLoading />;
|
return <AccountOperationsPageLoading />;
|
||||||
}
|
}
|
||||||
|
|
||||||
return viewModel.state === "error"
|
return vm.state === "error"
|
||||||
? <AccountOperationsPageError {...viewModel} />
|
? <AccountOperationsPageError {...vm} />
|
||||||
: <AccountOperationsPageLoaded {...viewModel} />;
|
: <AccountOperationsPageLoaded {...vm} />;
|
||||||
};
|
};
|
||||||
|
|
||||||
export { AccountOperationsPage };
|
export { AccountOperationsPage };
|
||||||
|
|||||||
@@ -12,7 +12,12 @@ import {
|
|||||||
useBrokerageOperationHistory,
|
useBrokerageOperationHistory,
|
||||||
} from "@/entities/broker-operation";
|
} from "@/entities/broker-operation";
|
||||||
import { useScreenSync } from "@/features/tbank-connection";
|
import { useScreenSync } from "@/features/tbank-connection";
|
||||||
import { ApiErrorCode, apiErrorCode, isApiErrorCode } from "@/shared/api";
|
import {
|
||||||
|
ApiErrorCode,
|
||||||
|
apiErrorCode,
|
||||||
|
isApiErrorCode,
|
||||||
|
readRetry,
|
||||||
|
} from "@/shared/api";
|
||||||
import {
|
import {
|
||||||
defaultPeriod,
|
defaultPeriod,
|
||||||
isValidPeriod,
|
isValidPeriod,
|
||||||
@@ -42,11 +47,16 @@ type AccountOperationsPageViewModel
|
|||||||
onPrevious: () => void;
|
onPrevious: () => void;
|
||||||
onReset: () => void;
|
onReset: () => void;
|
||||||
partial?: boolean;
|
partial?: boolean;
|
||||||
|
readRetry: ReturnType<typeof readRetry>;
|
||||||
source?: InvestmentResourceMeta;
|
source?: InvestmentResourceMeta;
|
||||||
state: "loaded";
|
state: "loaded";
|
||||||
totalVisible: boolean;
|
totalVisible: boolean;
|
||||||
}
|
}
|
||||||
| { onReset: () => void; state: "error" }
|
| {
|
||||||
|
onReset: () => void;
|
||||||
|
readRetry: ReturnType<typeof readRetry>;
|
||||||
|
state: "error";
|
||||||
|
}
|
||||||
| { state: "loading" };
|
| { state: "loading" };
|
||||||
|
|
||||||
const useAccountOperationsPageVm = (): AccountOperationsPageViewModel => {
|
const useAccountOperationsPageVm = (): AccountOperationsPageViewModel => {
|
||||||
@@ -107,6 +117,8 @@ const useAccountOperationsPageVm = (): AccountOperationsPageViewModel => {
|
|||||||
isFetching: operations.isFetching,
|
isFetching: operations.isFetching,
|
||||||
});
|
});
|
||||||
|
|
||||||
|
const retry = readRetry([operations]);
|
||||||
|
|
||||||
if (availability === "loading" && operations.isLoading)
|
if (availability === "loading" && operations.isLoading)
|
||||||
return { state: "loading" };
|
return { state: "loading" };
|
||||||
|
|
||||||
@@ -134,11 +146,11 @@ const useAccountOperationsPageVm = (): AccountOperationsPageViewModel => {
|
|||||||
(isInvalidCursor || !operations.data)
|
(isInvalidCursor || !operations.data)
|
||||||
&& (operations.isError || operations.meta?.lastAttempt.state === "failed")
|
&& (operations.isError || operations.meta?.lastAttempt.state === "failed")
|
||||||
)
|
)
|
||||||
return { onReset, state: "error" };
|
return { onReset, readRetry: retry, state: "error" };
|
||||||
|
|
||||||
if (!operations.data)
|
if (!operations.data)
|
||||||
return availability === "unavailable"
|
return availability === "unavailable"
|
||||||
? { onReset, state: "error" }
|
? { onReset, readRetry: retry, state: "error" }
|
||||||
: { state: "loading" };
|
: { state: "loading" };
|
||||||
|
|
||||||
const nextCursor = operations.data.nextCursor;
|
const nextCursor = operations.data.nextCursor;
|
||||||
@@ -182,6 +194,7 @@ const useAccountOperationsPageVm = (): AccountOperationsPageViewModel => {
|
|||||||
onPrevious: history.onPrevious,
|
onPrevious: history.onPrevious,
|
||||||
onReset,
|
onReset,
|
||||||
partial: operations.meta?.completeness === "incomplete",
|
partial: operations.meta?.completeness === "incomplete",
|
||||||
|
readRetry: retry,
|
||||||
source: operations.meta,
|
source: operations.meta,
|
||||||
state: "loaded",
|
state: "loaded",
|
||||||
totalVisible: operations.meta?.completeness === "complete",
|
totalVisible: operations.meta?.completeness === "complete",
|
||||||
|
|||||||
+12
-1
@@ -1,9 +1,11 @@
|
|||||||
import type { FC } from "react";
|
import type { FC } from "react";
|
||||||
|
|
||||||
import { Button } from "@mantine/core";
|
import { Button, Group } from "@mantine/core";
|
||||||
import { StateView } from "@wealthledger/ui";
|
import { StateView } from "@wealthledger/ui";
|
||||||
import { useTranslation } from "react-i18next";
|
import { useTranslation } from "react-i18next";
|
||||||
|
|
||||||
|
import { ReadRetryButton } from "@/shared/ui";
|
||||||
|
|
||||||
import type { AccountOperationsPageViewModel } from "../AccountOperationsPage.vm";
|
import type { AccountOperationsPageViewModel } from "../AccountOperationsPage.vm";
|
||||||
|
|
||||||
type AccountOperationsPageErrorProps = Extract<
|
type AccountOperationsPageErrorProps = Extract<
|
||||||
@@ -19,9 +21,18 @@ const AccountOperationsPageError: FC<AccountOperationsPageErrorProps> = (
|
|||||||
return (
|
return (
|
||||||
<StateView
|
<StateView
|
||||||
action={(
|
action={(
|
||||||
|
<Group gap="sm" justify="center">
|
||||||
|
{props.readRetry.exhausted && (
|
||||||
|
<ReadRetryButton
|
||||||
|
onRetry={props.readRetry.onRetry}
|
||||||
|
retrying={props.readRetry.retrying}
|
||||||
|
/>
|
||||||
|
)}
|
||||||
|
|
||||||
<Button onClick={props.onReset} variant="default">
|
<Button onClick={props.onReset} variant="default">
|
||||||
{t("ledger.reset")}
|
{t("ledger.reset")}
|
||||||
</Button>
|
</Button>
|
||||||
|
</Group>
|
||||||
)}
|
)}
|
||||||
text={t("ledger.errorText")}
|
text={t("ledger.errorText")}
|
||||||
title={t("ledger.errorTitle")}
|
title={t("ledger.errorTitle")}
|
||||||
|
|||||||
+3
-1
@@ -19,7 +19,7 @@ import {
|
|||||||
OperationGroup,
|
OperationGroup,
|
||||||
} from "@/entities/broker-operation";
|
} from "@/entities/broker-operation";
|
||||||
import { groupItems } from "@/shared/lib";
|
import { groupItems } from "@/shared/lib";
|
||||||
import { SourceSyncStatus } from "@/shared/ui";
|
import { ReadRetry, SourceSyncStatus } from "@/shared/ui";
|
||||||
|
|
||||||
import type { AccountOperationsPageViewModel } from "../AccountOperationsPage.vm";
|
import type { AccountOperationsPageViewModel } from "../AccountOperationsPage.vm";
|
||||||
|
|
||||||
@@ -102,6 +102,8 @@ const AccountOperationsPageLoaded: FC<AccountOperationsPageLoadedProps> = (
|
|||||||
stale={props.source?.freshness === "stale"}
|
stale={props.source?.freshness === "stale"}
|
||||||
/>
|
/>
|
||||||
|
|
||||||
|
<ReadRetry {...props.readRetry} />
|
||||||
|
|
||||||
{!!props.partial && <Alert role="status">{t("investment.partial")}</Alert>}
|
{!!props.partial && <Alert role="status">{t("investment.partial")}</Alert>}
|
||||||
|
|
||||||
{!!props.historyLoading && <Alert>{t("investment.history")}</Alert>}
|
{!!props.historyLoading && <Alert>{t("investment.history")}</Alert>}
|
||||||
|
|||||||
@@ -0,0 +1,173 @@
|
|||||||
|
import { describe, expect, it } from "vitest";
|
||||||
|
|
||||||
|
import type { Portfolio } from "@/entities/portfolio";
|
||||||
|
|
||||||
|
import { toConcentration } from "./concentration";
|
||||||
|
import { portfolio, position } from "./positions.fixtures";
|
||||||
|
|
||||||
|
function snapshot(positions: Portfolio["positions"]): Portfolio {
|
||||||
|
return { ...portfolio, positions };
|
||||||
|
}
|
||||||
|
|
||||||
|
function stock(
|
||||||
|
name: string,
|
||||||
|
value: null | string,
|
||||||
|
currency = "RUB",
|
||||||
|
overrides: Partial<Portfolio["positions"][number]> = {},
|
||||||
|
): Portfolio["positions"][number] {
|
||||||
|
return {
|
||||||
|
...position,
|
||||||
|
currentValue: value === null ? null : { currency, value },
|
||||||
|
displayName: name,
|
||||||
|
...overrides,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
const labels = {
|
||||||
|
missingIssuer: "Эмитент не указан",
|
||||||
|
missingSector: "Сектор не указан",
|
||||||
|
other: "Прочее",
|
||||||
|
sector: (code: string) => code,
|
||||||
|
};
|
||||||
|
|
||||||
|
describe("account concentration", () => {
|
||||||
|
it("uses exact positive values and excludes cash, negatives and nulls", () => {
|
||||||
|
const model = toConcentration(snapshot([
|
||||||
|
stock("A", "1"), stock("B", "15"),
|
||||||
|
stock("C", "0"), stock("D", "-50"), stock("E", null),
|
||||||
|
]), "stocks", labels);
|
||||||
|
|
||||||
|
expect(model.total).toBe("16");
|
||||||
|
expect(model.items.map(item => item.share)).toEqual(["93,8 %", "6,3 %"]);
|
||||||
|
expect(model.unaccounted).toBe(2);
|
||||||
|
const negative = snapshot([stock("A", "-3")]);
|
||||||
|
expect(toConcentration(negative, "stocks", labels))
|
||||||
|
.toMatchObject({ empty: true, unaccounted: 1 });
|
||||||
|
});
|
||||||
|
|
||||||
|
it("ranks seven positions with exact other and top-five totals", () => {
|
||||||
|
const model = toConcentration(snapshot([
|
||||||
|
stock("A", "400"), stock("B", "250"), stock("C", "150"),
|
||||||
|
stock("D", "100"), stock("E", "50"), stock("F", "30"),
|
||||||
|
stock("G", "20"),
|
||||||
|
]), "stocks", labels);
|
||||||
|
|
||||||
|
expect(model.items.map(item => item.amount)).toEqual([
|
||||||
|
"400", "250", "150", "100", "50",
|
||||||
|
]);
|
||||||
|
expect(model.other).toMatchObject({
|
||||||
|
amount: "50", count: 2, share: "5 %",
|
||||||
|
});
|
||||||
|
expect(model.top5Share).toBe("95 %");
|
||||||
|
expect(model.other?.entries.map(item => item.share)).toEqual([
|
||||||
|
"3 %", "2 %",
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("keeps sixth row, tiny share and stable alphabetical ties", () => {
|
||||||
|
const model = toConcentration(snapshot([
|
||||||
|
stock("Сбер", "100"), stock("X5", "100"),
|
||||||
|
stock("VK", "100"), stock("D", "100"),
|
||||||
|
stock("E", "100"), stock("F", "100"),
|
||||||
|
]), "stocks", labels);
|
||||||
|
|
||||||
|
expect(model.items).toHaveLength(6);
|
||||||
|
expect(model.other).toBeNull();
|
||||||
|
expect(model.items.slice(0, 2).map(item => item.name)).toEqual([
|
||||||
|
"D", "E",
|
||||||
|
]);
|
||||||
|
|
||||||
|
const tiny = snapshot([
|
||||||
|
stock("Large", "100000000"), stock("Small", "1"),
|
||||||
|
]);
|
||||||
|
|
||||||
|
expect(toConcentration(tiny, "stocks", labels).items[1]?.share)
|
||||||
|
.toBe("< 0,1 %");
|
||||||
|
});
|
||||||
|
|
||||||
|
it("groups sectors and issuers by codes, not labels", () => {
|
||||||
|
const positions = [
|
||||||
|
stock("A", "300", "RUB", {
|
||||||
|
issuer: { id: "one", name: "Сбербанк" }, sector: "energy",
|
||||||
|
}),
|
||||||
|
stock("B", "200", "RUB", {
|
||||||
|
issuer: { id: "one", name: "Сбер" }, sector: "energy",
|
||||||
|
type: "BOND",
|
||||||
|
}),
|
||||||
|
stock("C", "100", "RUB", {
|
||||||
|
issuer: { id: "two", name: "Сбер" }, sector: "financial",
|
||||||
|
type: "FUND",
|
||||||
|
}),
|
||||||
|
stock("D", "50", "RUB", { issuer: null, sector: null }),
|
||||||
|
];
|
||||||
|
|
||||||
|
expect(toConcentration(snapshot(positions), "sectors", labels)
|
||||||
|
.items.map(item => item.amount)).toEqual(["500", "100", "50"]);
|
||||||
|
expect(toConcentration(snapshot(positions), "issuers", labels)
|
||||||
|
.items.map(item => [item.name, item.amount])).toEqual([
|
||||||
|
["Сбербанк", "500"], ["", "50"],
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("orders equal sums by displayed name", () => {
|
||||||
|
const issuers = snapshot([
|
||||||
|
stock("A", "300", "RUB", {
|
||||||
|
issuer: { id: "g", name: "Газпром" }, sector: "energy",
|
||||||
|
}),
|
||||||
|
stock("B", "300", "RUB", {
|
||||||
|
issuer: { id: "s", name: "Сбер" }, sector: "energy",
|
||||||
|
}),
|
||||||
|
stock("C", "200", "RUB", { issuer: null, sector: "energy" }),
|
||||||
|
stock("D", "100", "RUB", { issuer: null, sector: "energy" }),
|
||||||
|
]);
|
||||||
|
|
||||||
|
expect(toConcentration(issuers, "issuers", labels)
|
||||||
|
.items.map(item => [item.label, item.amount])).toEqual([
|
||||||
|
["Газпром", "300"], ["Сбер", "300"], ["Эмитент не указан", "300"],
|
||||||
|
]);
|
||||||
|
|
||||||
|
const sectors = snapshot([
|
||||||
|
stock("A", "100", "RUB", { sector: "it" }),
|
||||||
|
stock("B", "100", "RUB", { sector: "energy" }),
|
||||||
|
]);
|
||||||
|
|
||||||
|
const sectorLabels = {
|
||||||
|
...labels,
|
||||||
|
sector: (code: string) => code === "it"
|
||||||
|
? "Информационные технологии"
|
||||||
|
: "Энергетика",
|
||||||
|
};
|
||||||
|
|
||||||
|
expect(toConcentration(sectors, "sectors", sectorLabels)
|
||||||
|
.items.map(item => item.label))
|
||||||
|
.toEqual(["Информационные технологии", "Энергетика"]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("chooses issuer name from the largest position, then alphabetically", () => {
|
||||||
|
const data = snapshot([
|
||||||
|
stock("A", "100", "RUB", {
|
||||||
|
issuer: { id: "brand", name: "Ястреб" },
|
||||||
|
}),
|
||||||
|
stock("B", "300", "RUB", {
|
||||||
|
issuer: { id: "brand", name: "Альфа" },
|
||||||
|
}),
|
||||||
|
stock("C", "400", "RUB", {
|
||||||
|
issuer: { id: "other", name: "Бета" },
|
||||||
|
}),
|
||||||
|
]);
|
||||||
|
|
||||||
|
expect(toConcentration(data, "issuers", labels).items
|
||||||
|
.map(item => [item.name, item.label, item.amount])).toEqual([
|
||||||
|
["Альфа", "Альфа", "400"], ["Бета", "Бета", "400"],
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("uses ISIN before ticker for bonds", () => {
|
||||||
|
const data = snapshot([stock("Облигация", "100", "RUB", {
|
||||||
|
isin: "RU000A0JX0J2", ticker: "BOND", type: "BOND",
|
||||||
|
})]);
|
||||||
|
|
||||||
|
expect(toConcentration(data, "bonds", labels)
|
||||||
|
.items[0]?.logo?.subtitle).toBe("RU000A0JX0J2");
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,276 @@
|
|||||||
|
import type { Portfolio } from "@/entities/portfolio";
|
||||||
|
|
||||||
|
import {
|
||||||
|
type Decimal,
|
||||||
|
decimalFromString,
|
||||||
|
decimalToString,
|
||||||
|
instrumentLogoUrl,
|
||||||
|
sumDecimals,
|
||||||
|
} from "@/shared/lib";
|
||||||
|
|
||||||
|
type Concentration = {
|
||||||
|
empty: boolean;
|
||||||
|
items: ConcentrationItem[];
|
||||||
|
other: ConcentrationOther | null;
|
||||||
|
top5Share: null | string;
|
||||||
|
total: null | string;
|
||||||
|
unaccounted: number;
|
||||||
|
};
|
||||||
|
|
||||||
|
type ConcentrationItem = {
|
||||||
|
amount: string;
|
||||||
|
chartValue: number;
|
||||||
|
key: string;
|
||||||
|
label: string;
|
||||||
|
logo: ConcentrationLogo | null;
|
||||||
|
name: string;
|
||||||
|
share: string;
|
||||||
|
unknown: boolean;
|
||||||
|
};
|
||||||
|
|
||||||
|
type ConcentrationLabels = {
|
||||||
|
missingIssuer: string;
|
||||||
|
missingSector: string;
|
||||||
|
other: string;
|
||||||
|
sector: (code: string) => string;
|
||||||
|
};
|
||||||
|
|
||||||
|
type ConcentrationLogo = {
|
||||||
|
src: null | string;
|
||||||
|
subtitle: null | string;
|
||||||
|
};
|
||||||
|
|
||||||
|
type ConcentrationOther = ConcentrationItem & {
|
||||||
|
count: number;
|
||||||
|
entries: ConcentrationItem[];
|
||||||
|
};
|
||||||
|
|
||||||
|
type Group = {
|
||||||
|
best?: { name: string; value: Decimal };
|
||||||
|
first: number;
|
||||||
|
key: string;
|
||||||
|
label: string;
|
||||||
|
logo: ConcentrationLogo | null;
|
||||||
|
name: string;
|
||||||
|
unknown: boolean;
|
||||||
|
values: Decimal[];
|
||||||
|
};
|
||||||
|
|
||||||
|
type Position = Portfolio["positions"][number];
|
||||||
|
|
||||||
|
type Slice = "bonds"
|
||||||
|
| "issuers"
|
||||||
|
| "sectors"
|
||||||
|
| "stocks";
|
||||||
|
|
||||||
|
const eligibleTypes = new Set(["BOND", "FUND", "STOCK"]);
|
||||||
|
const RADIX = 10n;
|
||||||
|
const CHART_PRECISION = 1_000_000n;
|
||||||
|
const SHARE_PRECISION = 1000n;
|
||||||
|
const HALF = 2n;
|
||||||
|
const TOP = 5;
|
||||||
|
const FIRST_OTHER = 7;
|
||||||
|
|
||||||
|
const compareNames = (a: string, b: string) =>
|
||||||
|
a.toLowerCase().localeCompare(b.toLowerCase(), "en", {
|
||||||
|
numeric: false,
|
||||||
|
});
|
||||||
|
|
||||||
|
function addPosition(
|
||||||
|
groups: Map<string, Group>,
|
||||||
|
position: Position,
|
||||||
|
index: number,
|
||||||
|
slice: Slice,
|
||||||
|
labels: ConcentrationLabels,
|
||||||
|
): number {
|
||||||
|
if (!isIncluded(slice, position.type)) return 0;
|
||||||
|
if (!position.currentValue) return 1;
|
||||||
|
const value = decimalFromString(position.currentValue.value);
|
||||||
|
if (value.value < 0n) return 1;
|
||||||
|
if (value.value === 0n) return 0;
|
||||||
|
const identity = groupIdentity(position, slice, index, labels);
|
||||||
|
|
||||||
|
const group = groups.get(identity.key) ?? {
|
||||||
|
...identity, first: index, values: [],
|
||||||
|
};
|
||||||
|
|
||||||
|
group.values.push(value);
|
||||||
|
|
||||||
|
if (slice === "issuers" && !identity.unknown) {
|
||||||
|
const best = group.best;
|
||||||
|
|
||||||
|
if (!best || compareDecimal(value, best.value) > 0
|
||||||
|
|| (compareDecimal(value, best.value) === 0
|
||||||
|
&& compareNames(identity.name, best.name) < 0)) {
|
||||||
|
group.best = { name: identity.name, value };
|
||||||
|
group.name = identity.name;
|
||||||
|
group.label = identity.label;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
groups.set(identity.key, group);
|
||||||
|
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
function chartValue(part: Decimal, total: Decimal): number {
|
||||||
|
const scale = Math.max(part.scale, total.scale);
|
||||||
|
const numerator = part.value * RADIX ** BigInt(scale - part.scale);
|
||||||
|
const denominator = total.value * RADIX ** BigInt(scale - total.scale);
|
||||||
|
|
||||||
|
return Number(numerator * CHART_PRECISION / denominator)
|
||||||
|
/ Number(CHART_PRECISION);
|
||||||
|
}
|
||||||
|
|
||||||
|
function compareDecimal(a: Decimal, b: Decimal): number {
|
||||||
|
const scale = Math.max(a.scale, b.scale);
|
||||||
|
const left = a.value * RADIX ** BigInt(scale - a.scale);
|
||||||
|
const right = b.value * RADIX ** BigInt(scale - b.scale);
|
||||||
|
|
||||||
|
if (left > right) return 1;
|
||||||
|
|
||||||
|
return left < right ? -1 : 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
function groupIdentity(
|
||||||
|
position: Position,
|
||||||
|
slice: Slice,
|
||||||
|
index: number,
|
||||||
|
labels: ConcentrationLabels,
|
||||||
|
) {
|
||||||
|
if (slice === "sectors") {
|
||||||
|
const sector = position.sector;
|
||||||
|
const isUnknown = !sector;
|
||||||
|
|
||||||
|
return {
|
||||||
|
key: sector ?? "",
|
||||||
|
label: isUnknown
|
||||||
|
? labels.missingSector
|
||||||
|
: labels.sector(sector),
|
||||||
|
logo: null,
|
||||||
|
name: sector ?? "",
|
||||||
|
unknown: isUnknown,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
if (slice === "issuers") {
|
||||||
|
const isUnknown = !position.issuer;
|
||||||
|
|
||||||
|
return {
|
||||||
|
key: position.issuer?.id ?? "",
|
||||||
|
label: position.issuer ? position.issuer.name : labels.missingIssuer,
|
||||||
|
logo: null,
|
||||||
|
name: position.issuer?.name ?? "",
|
||||||
|
unknown: isUnknown,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
return {
|
||||||
|
key: String(index),
|
||||||
|
label: position.displayName,
|
||||||
|
logo: {
|
||||||
|
src: instrumentLogoUrl(position.logoName),
|
||||||
|
subtitle: slice === "bonds"
|
||||||
|
? position.isin ?? position.ticker ?? position.figi
|
||||||
|
: position.ticker ?? position.isin ?? position.figi,
|
||||||
|
},
|
||||||
|
name: position.displayName,
|
||||||
|
unknown: false,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
function isIncluded(slice: Slice, type: string): boolean {
|
||||||
|
if (slice === "stocks") return type === "STOCK";
|
||||||
|
if (slice === "bonds") return type === "BOND";
|
||||||
|
|
||||||
|
return slice === "issuers" ? type === "STOCK" || type === "BOND" : eligibleTypes.has(type);
|
||||||
|
}
|
||||||
|
|
||||||
|
function share(part: Decimal, total: Decimal): string {
|
||||||
|
const scale = Math.max(part.scale, total.scale);
|
||||||
|
const numerator = part.value * RADIX ** BigInt(scale - part.scale);
|
||||||
|
const denominator = total.value * RADIX ** BigInt(scale - total.scale);
|
||||||
|
if (numerator * SHARE_PRECISION < denominator) return "< 0,1 %";
|
||||||
|
|
||||||
|
const tenths = (numerator * SHARE_PRECISION * HALF + denominator)
|
||||||
|
/ (HALF * denominator);
|
||||||
|
|
||||||
|
return tenths % RADIX === 0n ? `${tenths / RADIX} %` : `${tenths / RADIX},${tenths % RADIX} %`;
|
||||||
|
}
|
||||||
|
|
||||||
|
function toConcentration(
|
||||||
|
portfolio: Portfolio,
|
||||||
|
slice: Slice,
|
||||||
|
labels: ConcentrationLabels,
|
||||||
|
): Concentration {
|
||||||
|
const groups = new Map<string, Group>();
|
||||||
|
let unaccounted = 0;
|
||||||
|
|
||||||
|
for (const [index, position] of portfolio.positions.entries()) {
|
||||||
|
unaccounted += addPosition(groups, position, index, slice, labels);
|
||||||
|
}
|
||||||
|
|
||||||
|
const ranked = Array.from(groups.values(), group => ({
|
||||||
|
...group, sum: sumDecimals(group.values),
|
||||||
|
})).toSorted((a, b) => compareDecimal(b.sum, a.sum)
|
||||||
|
|| compareNames(a.label, b.label) || a.first - b.first);
|
||||||
|
|
||||||
|
const total = ranked.length > 0
|
||||||
|
? sumDecimals(ranked.map(item => item.sum))
|
||||||
|
: null;
|
||||||
|
|
||||||
|
const entries = total
|
||||||
|
? ranked.map(group => ({
|
||||||
|
amount: decimalToString(group.sum),
|
||||||
|
chartValue: chartValue(group.sum, total),
|
||||||
|
key: group.key,
|
||||||
|
label: group.label,
|
||||||
|
logo: group.logo,
|
||||||
|
name: group.name,
|
||||||
|
share: share(group.sum, total),
|
||||||
|
unknown: group.unknown,
|
||||||
|
}))
|
||||||
|
: [];
|
||||||
|
|
||||||
|
const rest = entries.length >= FIRST_OTHER ? entries.slice(TOP) : [];
|
||||||
|
|
||||||
|
const otherSum = rest.length > 0
|
||||||
|
? sumDecimals(ranked.slice(TOP).map(item => item.sum))
|
||||||
|
: null;
|
||||||
|
|
||||||
|
const other = otherSum && total
|
||||||
|
? {
|
||||||
|
amount: decimalToString(otherSum),
|
||||||
|
chartValue: chartValue(otherSum, total),
|
||||||
|
count: rest.length,
|
||||||
|
entries: rest,
|
||||||
|
key: "__other",
|
||||||
|
label: labels.other,
|
||||||
|
logo: null,
|
||||||
|
name: "", share: share(otherSum, total), unknown: false,
|
||||||
|
}
|
||||||
|
: null;
|
||||||
|
|
||||||
|
const top5 = ranked.length > TOP
|
||||||
|
? sumDecimals(ranked.slice(0, TOP).map(item => item.sum))
|
||||||
|
: null;
|
||||||
|
|
||||||
|
return {
|
||||||
|
empty: !total,
|
||||||
|
items: other ? entries.slice(0, TOP) : entries,
|
||||||
|
other,
|
||||||
|
top5Share: top5 && total ? share(top5, total) : null,
|
||||||
|
total: total && decimalToString(total),
|
||||||
|
unaccounted,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
export {
|
||||||
|
toConcentration,
|
||||||
|
};
|
||||||
|
export type {
|
||||||
|
Concentration,
|
||||||
|
ConcentrationItem,
|
||||||
|
ConcentrationLabels,
|
||||||
|
Slice,
|
||||||
|
};
|
||||||
@@ -0,0 +1,104 @@
|
|||||||
|
import type { Performance } from "@/entities/performance";
|
||||||
|
|
||||||
|
import { formatDate, formatMoney, formatPercentagePoints, formatSignedPercent } from "@/shared/lib";
|
||||||
|
|
||||||
|
type TextValue = { tone: Tone; value: string };
|
||||||
|
|
||||||
|
type Tone
|
||||||
|
= | "negative"
|
||||||
|
| "neutral"
|
||||||
|
| "positive";
|
||||||
|
|
||||||
|
const reasonLabels: Record<string, string> = {
|
||||||
|
ACCOUNT_VALUATION_DATES_DIFFER: "Оценки счетов сделаны в разные дни",
|
||||||
|
AMBIGUOUS_RETURN: "У расчёта доходности несколько возможных решений",
|
||||||
|
HISTORY_START_UNKNOWN: "Начало истории счёта неизвестно",
|
||||||
|
INDEX_HISTORY_UNAVAILABLE: "История индекса временно недоступна",
|
||||||
|
NO_SOLUTION: "Расчёт доходности не сходится",
|
||||||
|
OPERATIONS_HISTORY_INCOMPLETE: "История операций ещё не получена полностью",
|
||||||
|
PORTFOLIO_VALUATION_INCOMPLETE: "Нет полной оценки портфеля",
|
||||||
|
UNCONFIRMED_TRANSFER: "Перевод между счетами не удалось подтвердить",
|
||||||
|
UNVALUED_SECURITIES_TRANSFER: "Бумаги переведены без денежной оценки",
|
||||||
|
};
|
||||||
|
|
||||||
|
const unknownReason = "Причину недоступности не удалось определить";
|
||||||
|
|
||||||
|
function performanceVm(data: Performance) {
|
||||||
|
return {
|
||||||
|
basis: data.return.basis,
|
||||||
|
comparison: data.outperformance
|
||||||
|
? {
|
||||||
|
money: signedMoney(data.outperformance.money),
|
||||||
|
points: valueText(
|
||||||
|
data.outperformance.percentagePoints,
|
||||||
|
formatPercentagePoints,
|
||||||
|
),
|
||||||
|
}
|
||||||
|
: null,
|
||||||
|
current: formatMoney(data.currentValue),
|
||||||
|
currentPoint: data.series.length > 0
|
||||||
|
? { date: formatDate(`${data.series.at(-1)?.date ?? data.period.to}T00:00:00Z`) }
|
||||||
|
: null,
|
||||||
|
days: data.period.days,
|
||||||
|
excluded: data.excludedAccounts.map(item => ({
|
||||||
|
id: item.accountId,
|
||||||
|
name: item.name,
|
||||||
|
reason: reasonText(item.reason),
|
||||||
|
})),
|
||||||
|
from: data.period.from,
|
||||||
|
indexReason: data.benchmark.unavailableReason
|
||||||
|
? reasonText(data.benchmark.unavailableReason)
|
||||||
|
: null,
|
||||||
|
indexReturn: valueText(data.benchmark.return.value, formatSignedPercent),
|
||||||
|
indexValue: data.benchmark.value ? formatMoney(data.benchmark.value) : "—",
|
||||||
|
invested: formatMoney(data.netInvested),
|
||||||
|
profit: signedMoney(data.profit),
|
||||||
|
returnReason: data.return.unavailableReason
|
||||||
|
? reasonText(data.return.unavailableReason)
|
||||||
|
: null,
|
||||||
|
returnValue: valueText(data.return.value, formatSignedPercent),
|
||||||
|
series: data.series.map(item => ({
|
||||||
|
benchmarkValue: Number(item.benchmarkValue),
|
||||||
|
date: item.date,
|
||||||
|
label: formatDate(`${item.date}T00:00:00Z`),
|
||||||
|
netInvested: Number(item.netInvested),
|
||||||
|
referenceValue: item.referenceValue === null
|
||||||
|
? null
|
||||||
|
: Number(item.referenceValue),
|
||||||
|
})),
|
||||||
|
to: data.period.to,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
function reasonText(reason: string): string {
|
||||||
|
// eslint-disable-next-line security/detect-object-injection -- Lookup accepts only an API reason, with a safe fallback.
|
||||||
|
return reasonLabels[reason] ?? unknownReason;
|
||||||
|
}
|
||||||
|
|
||||||
|
function signedMoney(value: Performance["profit"]): TextValue {
|
||||||
|
return {
|
||||||
|
tone: tone(value.value),
|
||||||
|
value: formatMoney(value, { withSign: true }),
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
function tone(value: string): Tone {
|
||||||
|
const number = Number(value);
|
||||||
|
if (number > 0) return "positive";
|
||||||
|
|
||||||
|
return number < 0 ? "negative" : "neutral";
|
||||||
|
}
|
||||||
|
|
||||||
|
// Tone follows the displayed text, so "0,0 %" is never coloured.
|
||||||
|
function valueText(
|
||||||
|
value: null | string,
|
||||||
|
format: (value: string) => string,
|
||||||
|
): TextValue {
|
||||||
|
if (value === null) return { tone: "neutral", value: "—" };
|
||||||
|
const text = format(value);
|
||||||
|
if (text.startsWith("+")) return { tone: "positive", value: text };
|
||||||
|
|
||||||
|
return { tone: text.startsWith("−") ? "negative" : "neutral", value: text };
|
||||||
|
}
|
||||||
|
|
||||||
|
export { performanceVm, reasonText };
|
||||||
@@ -2,7 +2,7 @@ import type { Portfolio } from "@/entities/portfolio";
|
|||||||
|
|
||||||
const portfolio
|
const portfolio
|
||||||
= {
|
= {
|
||||||
cashBalances: [{ currency: "USD", value: "1" }],
|
cash: { currency: "RUB", value: "1" },
|
||||||
isStale: true,
|
isStale: true,
|
||||||
lastSuccessfulAt: "2026-08-13T10:00:00Z",
|
lastSuccessfulAt: "2026-08-13T10:00:00Z",
|
||||||
positions: [
|
positions: [
|
||||||
@@ -13,8 +13,10 @@ const portfolio
|
|||||||
displayName: "Акция",
|
displayName: "Акция",
|
||||||
figi: "FIGI-STOCK",
|
figi: "FIGI-STOCK",
|
||||||
isin: null,
|
isin: null,
|
||||||
|
issuer: null,
|
||||||
logoName: "akciya.png",
|
logoName: "akciya.png",
|
||||||
quantity: "2",
|
quantity: "2",
|
||||||
|
sector: null,
|
||||||
ticker: null,
|
ticker: null,
|
||||||
type: "STOCK",
|
type: "STOCK",
|
||||||
},
|
},
|
||||||
@@ -25,8 +27,10 @@ const portfolio
|
|||||||
displayName: "Облигация",
|
displayName: "Облигация",
|
||||||
figi: "FIGI-BOND",
|
figi: "FIGI-BOND",
|
||||||
isin: "RU000A0JX0J2",
|
isin: "RU000A0JX0J2",
|
||||||
|
issuer: null,
|
||||||
logoName: null,
|
logoName: null,
|
||||||
quantity: "1",
|
quantity: "1",
|
||||||
|
sector: null,
|
||||||
ticker: null,
|
ticker: null,
|
||||||
type: "BOND",
|
type: "BOND",
|
||||||
},
|
},
|
||||||
@@ -37,14 +41,21 @@ const portfolio
|
|||||||
displayName: "Фонд",
|
displayName: "Фонд",
|
||||||
figi: "FIGI-FUND",
|
figi: "FIGI-FUND",
|
||||||
isin: null,
|
isin: null,
|
||||||
|
issuer: null,
|
||||||
logoName: "fond.png",
|
logoName: "fond.png",
|
||||||
quantity: "3",
|
quantity: "3",
|
||||||
|
sector: null,
|
||||||
ticker: null,
|
ticker: null,
|
||||||
type: "FUND",
|
type: "FUND",
|
||||||
},
|
},
|
||||||
] satisfies [Portfolio["positions"][number], ...Portfolio["positions"]],
|
] satisfies [Portfolio["positions"][number], ...Portfolio["positions"]],
|
||||||
structure: { currencies: [], unvaluedCategories: [] },
|
structure: {
|
||||||
totalsByCurrency: [{ currency: "RUB", value: "150" }],
|
categories: [],
|
||||||
|
hasNegativeValues: false,
|
||||||
|
totalValue: "0",
|
||||||
|
unvaluedCategories: [],
|
||||||
|
},
|
||||||
|
totals: { currency: "RUB", value: "150" },
|
||||||
} satisfies Portfolio;
|
} satisfies Portfolio;
|
||||||
|
|
||||||
const position: Portfolio["positions"][number] = {
|
const position: Portfolio["positions"][number] = {
|
||||||
|
|||||||
@@ -23,7 +23,7 @@ function sections(positions: Portfolio["positions"]) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
describe("account position sections", () => {
|
describe("account position sections", () => {
|
||||||
it("excludes currency instruments only from display, preserving order and share denominators", () => {
|
it("excludes currency mirrors from display and share denominators", () => {
|
||||||
const otherTypes = [
|
const otherTypes = [
|
||||||
"OPTION",
|
"OPTION",
|
||||||
"OTHER",
|
"OTHER",
|
||||||
@@ -35,7 +35,7 @@ describe("account position sections", () => {
|
|||||||
|
|
||||||
const snapshot: Portfolio = {
|
const snapshot: Portfolio = {
|
||||||
...portfolio,
|
...portfolio,
|
||||||
cashBalances: [{ currency: "RUB", value: "1000" }],
|
cash: { currency: "RUB", value: "1000" },
|
||||||
positions: [
|
positions: [
|
||||||
...portfolio.positions,
|
...portfolio.positions,
|
||||||
{
|
{
|
||||||
@@ -56,8 +56,8 @@ describe("account position sections", () => {
|
|||||||
}),
|
}),
|
||||||
),
|
),
|
||||||
],
|
],
|
||||||
structure: { currencies: [], unvaluedCategories: [] },
|
structure: { categories: [], hasNegativeValues: false, totalValue: "0", unvaluedCategories: [] },
|
||||||
totalsByCurrency: [{ currency: "RUB", value: "1250" }],
|
totals: { currency: "RUB", value: "1250" },
|
||||||
};
|
};
|
||||||
|
|
||||||
const original = structuredClone(snapshot);
|
const original = structuredClone(snapshot);
|
||||||
@@ -73,12 +73,30 @@ describe("account position sections", () => {
|
|||||||
"FIGI-FUND",
|
"FIGI-FUND",
|
||||||
...otherTypes.map(type => `FIGI-${type}-NEXT`),
|
...otherTypes.map(type => `FIGI-${type}-NEXT`),
|
||||||
]);
|
]);
|
||||||
expect(sections[0]?.groups[0]?.positions[0].shareText).toBe("40 %");
|
expect(sections[0]?.groups[0]?.positions[0].shareText).toBe("50 %");
|
||||||
expect(sections[1]?.groups[0]?.positions[0].shareText).toBe("20 %");
|
expect(sections[1]?.groups[0]?.positions[0].shareText).toBe("25 %");
|
||||||
expect(sections[2]?.groups[1]?.positions[0].shareText).toBe("20 %");
|
expect(sections[2]?.groups[1]?.positions[0].shareText).toBe("25 %");
|
||||||
expect(snapshot).toEqual(original);
|
expect(snapshot).toEqual(original);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("keeps all-account positions from both accounts without counting mirrored cash", () => {
|
||||||
|
const result = sections([
|
||||||
|
makePosition({ account: { id: "a", name: "Основной" }, currentValue: { currency: "RUB", value: "100" } }),
|
||||||
|
makePosition({ account: { id: "a", name: "Основной" }, currentValue: { currency: "RUB", value: "50" }, type: "CURRENCY" }),
|
||||||
|
makePosition({ account: { id: "b", name: "ИИС" }, currentValue: { currency: "RUB", value: "100" } }),
|
||||||
|
]);
|
||||||
|
|
||||||
|
const visible = result.flatMap(section =>
|
||||||
|
section.groups.flatMap(group => group.positions));
|
||||||
|
|
||||||
|
expect(visible)
|
||||||
|
.toEqual(expect.arrayContaining([
|
||||||
|
expect.objectContaining({ account: { id: "a", name: "Основной" }, shareText: "50 %" }),
|
||||||
|
expect.objectContaining({ account: { id: "b", name: "ИИС" }, shareText: "50 %" }),
|
||||||
|
]));
|
||||||
|
expect(visible).toHaveLength(2);
|
||||||
|
});
|
||||||
|
|
||||||
it("prepares grouped position sections with derived display data", () => {
|
it("prepares grouped position sections with derived display data", () => {
|
||||||
expect(
|
expect(
|
||||||
toAccountPagePositionSections(portfolio).map(({ groups, kind }) => ({
|
toAccountPagePositionSections(portfolio).map(({ groups, kind }) => ({
|
||||||
@@ -175,13 +193,13 @@ describe("account position sections", () => {
|
|||||||
).toHaveLength(2);
|
).toHaveLength(2);
|
||||||
});
|
});
|
||||||
|
|
||||||
it("keeps currencies and purchase prices attached to their source positions", () => {
|
it("keeps values and purchase prices attached to their source positions", () => {
|
||||||
const source = [
|
const source = [
|
||||||
position,
|
position,
|
||||||
{
|
{
|
||||||
...second,
|
...second,
|
||||||
averagePurchasePrice: { currency: "USD", value: "0.99" },
|
averagePurchasePrice: { currency: "RUB", value: "0.99" },
|
||||||
currentValue: { currency: "USD", value: "1.01" },
|
currentValue: { currency: "RUB", value: "1.01" },
|
||||||
},
|
},
|
||||||
];
|
];
|
||||||
|
|
||||||
@@ -246,10 +264,6 @@ describe("account position returns", () => {
|
|||||||
{ name: "zero quantity", overrides: { quantity: "0" } },
|
{ name: "zero quantity", overrides: { quantity: "0" } },
|
||||||
{ name: "negative quantity", overrides: { quantity: "-1" } },
|
{ name: "negative quantity", overrides: { quantity: "-1" } },
|
||||||
{ name: "missing average price", overrides: { averagePurchasePrice: null } },
|
{ name: "missing average price", overrides: { averagePurchasePrice: null } },
|
||||||
{
|
|
||||||
name: "currency mismatch",
|
|
||||||
overrides: { averagePurchasePrice: { currency: "USD", value: "280" } },
|
|
||||||
},
|
|
||||||
{ name: "zero cost", overrides: { averagePurchasePrice: { currency: "RUB", value: "0" } } },
|
{ name: "zero cost", overrides: { averagePurchasePrice: { currency: "RUB", value: "0" } } },
|
||||||
])("returns null for $name", ({ overrides }) => {
|
])("returns null for $name", ({ overrides }) => {
|
||||||
const result = sections([makePosition({
|
const result = sections([makePosition({
|
||||||
@@ -283,29 +297,24 @@ describe("account position returns", () => {
|
|||||||
expect(formatPositionReturnPercent(testCase.value)).toBe(testCase.expected);
|
expect(formatPositionReturnPercent(testCase.value)).toBe(testCase.expected);
|
||||||
});
|
});
|
||||||
|
|
||||||
it("sums complete unrealized returns by currency", () => {
|
it("sums complete unrealized returns", () => {
|
||||||
const result = toUnrealizedReturns([
|
const result = toUnrealizedReturns([
|
||||||
makePosition({ absoluteReturn: { currency: "RUB", value: "0.1" } }),
|
makePosition({ absoluteReturn: { currency: "RUB", value: "0.1" } }),
|
||||||
makePosition({ absoluteReturn: { currency: "RUB", value: "0.2" } }),
|
makePosition({ absoluteReturn: { currency: "RUB", value: "0.2" } }),
|
||||||
makePosition({ absoluteReturn: { currency: "USD", value: "-2.5" } }),
|
|
||||||
]);
|
]);
|
||||||
|
|
||||||
expect(result).toEqual([
|
expect(result).toEqual({ currency: "RUB", value: "0.3" });
|
||||||
{ currency: "RUB", value: "0.3" },
|
|
||||||
{ currency: "USD", value: "-2.5" },
|
|
||||||
]);
|
|
||||||
});
|
});
|
||||||
|
|
||||||
it("omits only currencies with incomplete returns", () => {
|
it("returns null when any return is incomplete", () => {
|
||||||
const result = toUnrealizedReturns([
|
const result = toUnrealizedReturns([
|
||||||
makePosition({ absoluteReturn: { currency: "RUB", value: "10" } }),
|
makePosition({ absoluteReturn: { currency: "RUB", value: "10" } }),
|
||||||
makePosition({
|
makePosition({
|
||||||
absoluteReturn: null,
|
absoluteReturn: null,
|
||||||
currentValue: { currency: "RUB", value: "100" },
|
currentValue: { currency: "RUB", value: "100" },
|
||||||
}),
|
}),
|
||||||
makePosition({ absoluteReturn: { currency: "USD", value: "2" } }),
|
|
||||||
]);
|
]);
|
||||||
|
|
||||||
expect(result).toEqual([{ currency: "USD", value: "2" }]);
|
expect(result).toBeNull();
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -152,7 +152,7 @@ function toAccountPagePositionSections(
|
|||||||
const denominators = new Map<string, number>();
|
const denominators = new Map<string, number>();
|
||||||
|
|
||||||
for (const position of portfolio.positions) {
|
for (const position of portfolio.positions) {
|
||||||
if (!position.currentValue) continue;
|
if (position.type === "CURRENCY" || !position.currentValue) continue;
|
||||||
const currency = position.currentValue.currency;
|
const currency = position.currentValue.currency;
|
||||||
denominators.set(
|
denominators.set(
|
||||||
currency,
|
currency,
|
||||||
@@ -249,37 +249,23 @@ function toSection(
|
|||||||
|
|
||||||
function toUnrealizedReturns(
|
function toUnrealizedReturns(
|
||||||
positions: Portfolio["positions"],
|
positions: Portfolio["positions"],
|
||||||
): Money[] {
|
): Money | null {
|
||||||
const totals = new Map<string, {
|
const values: Decimal[] = [];
|
||||||
complete: boolean;
|
|
||||||
values: Decimal[];
|
|
||||||
}>();
|
|
||||||
|
|
||||||
for (const position of positions) {
|
for (const position of positions) {
|
||||||
const currencies = position.absoluteReturn
|
if (!position.absoluteReturn) {
|
||||||
? [position.absoluteReturn.currency]
|
// A position without any valuation has nothing to contribute.
|
||||||
: [...new Set([
|
|
||||||
position.averagePurchasePrice?.currency,
|
|
||||||
position.currentValue?.currency,
|
|
||||||
].filter((currency): currency is string => !!currency))];
|
|
||||||
|
|
||||||
for (const currency of currencies) {
|
if (!position.averagePurchasePrice && !position.currentValue)
|
||||||
const total = totals.get(currency) ?? { complete: true, values: [] };
|
continue;
|
||||||
|
|
||||||
if (position.absoluteReturn) {
|
return null;
|
||||||
total.values.push(decimalFromString(position.absoluteReturn.value));
|
|
||||||
}
|
|
||||||
else {
|
|
||||||
total.complete = false;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
totals.set(currency, total);
|
values.push(decimalFromString(position.absoluteReturn.value));
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
return [...totals].flatMap(([currency, total]) => total.complete
|
return { currency: "RUB", value: decimalToString(sumDecimals(values)) };
|
||||||
? [{ currency, value: decimalToString(sumDecimals(total.values)) }]
|
|
||||||
: []);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
export {
|
export {
|
||||||
|
|||||||
@@ -64,7 +64,7 @@ function toIncomeSummary(
|
|||||||
if (income.meta?.completeness === "incomplete") return { state: "partial", to };
|
if (income.meta?.completeness === "incomplete") return { state: "partial", to };
|
||||||
if (!income.data && (income.isError || income.meta?.lastAttempt.state === "failed"))
|
if (!income.data && (income.isError || income.meta?.lastAttempt.state === "failed"))
|
||||||
return { state: "error", to };
|
return { state: "error", to };
|
||||||
if (!income.data?.totalsByCurrency.length) return { state: "empty", to };
|
if (!income.data) return { state: "empty", to };
|
||||||
|
|
||||||
return {
|
return {
|
||||||
state: "loaded",
|
state: "loaded",
|
||||||
|
|||||||
File diff suppressed because it is too large
Load Diff
@@ -1,38 +1,46 @@
|
|||||||
import type { FC } from "react";
|
import type { FC } from "react";
|
||||||
|
|
||||||
import { useAccountPageViewModel } from "./AccountPage.vm";
|
import { useAccountPageVm } from "./AccountPage.vm";
|
||||||
import { AccountPageEmpty } from "./components/AccountPageEmpty.view";
|
import { AccountPageEmpty } from "./components/AccountPageEmpty.view";
|
||||||
import { AccountPageError } from "./components/AccountPageError.view";
|
import { AccountPageError } from "./components/AccountPageError.view";
|
||||||
import { AccountPageLoaded } from "./components/AccountPageLoaded.view";
|
import { AccountPageLoaded } from "./components/AccountPageLoaded.view";
|
||||||
import { AccountPageLoading } from "./components/AccountPageLoading/AccountPageLoading.view";
|
import { AccountPageLoading } from "./components/AccountPageLoading/AccountPageLoading.view";
|
||||||
|
|
||||||
const AccountPage: FC = () => {
|
const AccountPage: FC = () => {
|
||||||
const viewModel = useAccountPageViewModel();
|
const vm = useAccountPageVm();
|
||||||
if (viewModel.state === "loading") return <AccountPageLoading />;
|
if (vm.state === "loading") return <AccountPageLoading />;
|
||||||
if (viewModel.state === "error") return <AccountPageError {...viewModel} />;
|
if (vm.state === "error") return <AccountPageError {...vm} />;
|
||||||
if (viewModel.state === "empty")
|
if (vm.state === "empty")
|
||||||
return (
|
return (
|
||||||
<AccountPageEmpty
|
<AccountPageEmpty
|
||||||
account={viewModel.account}
|
account={vm.account}
|
||||||
accountId={viewModel.accountId}
|
accountId={vm.accountId}
|
||||||
incomeSummary={viewModel.incomeSummary}
|
incomeSummary={vm.incomeSummary}
|
||||||
recentEvents={viewModel.recentEvents}
|
readRetry={vm.readRetry}
|
||||||
recentOperations={viewModel.recentOperations}
|
recentEvents={vm.recentEvents}
|
||||||
|
recentOperations={vm.recentOperations}
|
||||||
|
source={vm.source}
|
||||||
/>
|
/>
|
||||||
);
|
);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<AccountPageLoaded
|
<AccountPageLoaded
|
||||||
account={viewModel.account}
|
account={vm.account}
|
||||||
accountId={viewModel.accountId}
|
accountId={vm.accountId}
|
||||||
incomeSummary={viewModel.incomeSummary}
|
concentration={vm.concentration}
|
||||||
partial={viewModel.partial}
|
incomeSummary={vm.incomeSummary}
|
||||||
portfolio={viewModel.portfolio}
|
onSliceChange={vm.onSliceChange}
|
||||||
positionSections={viewModel.positionSections}
|
onTabChange={vm.onTabChange}
|
||||||
recentEvents={viewModel.recentEvents}
|
partial={vm.partial}
|
||||||
recentOperations={viewModel.recentOperations}
|
portfolio={vm.portfolio}
|
||||||
source={viewModel.source}
|
positionSections={vm.positionSections}
|
||||||
unrealizedReturns={viewModel.unrealizedReturns}
|
readRetry={vm.readRetry}
|
||||||
|
recentEvents={vm.recentEvents}
|
||||||
|
recentOperations={vm.recentOperations}
|
||||||
|
slice={vm.slice}
|
||||||
|
source={vm.source}
|
||||||
|
tab={vm.tab}
|
||||||
|
unrealizedReturns={vm.unrealizedReturns}
|
||||||
/>
|
/>
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -12,7 +12,7 @@ import { resource } from "@/test/resource";
|
|||||||
import { server } from "@/test/server";
|
import { server } from "@/test/server";
|
||||||
|
|
||||||
import { portfolio } from "../../model/positions.fixtures";
|
import { portfolio } from "../../model/positions.fixtures";
|
||||||
import { useAccountPageViewModel } from "./AccountPage.vm";
|
import { useAccountPageVm } from "./AccountPage.vm";
|
||||||
|
|
||||||
function configureTestAuth() {
|
function configureTestAuth() {
|
||||||
configureAuthClient({
|
configureAuthClient({
|
||||||
@@ -102,12 +102,12 @@ function mockLoadedAccountPage() {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
describe("useAccountPageViewModel", () => {
|
describe("useAccountPageVm", () => {
|
||||||
it("prepares recent operations and events state for presentation views", async () => {
|
it("prepares recent operations and events state for presentation views", async () => {
|
||||||
configureTestAuth();
|
configureTestAuth();
|
||||||
mockLoadedAccountPage();
|
mockLoadedAccountPage();
|
||||||
|
|
||||||
const { result } = renderHook(() => useAccountPageViewModel(), {
|
const { result } = renderHook(() => useAccountPageVm(), {
|
||||||
wrapper: createWrapper(),
|
wrapper: createWrapper(),
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -154,7 +154,7 @@ describe("useAccountPageViewModel", () => {
|
|||||||
),
|
),
|
||||||
);
|
);
|
||||||
|
|
||||||
const { result } = renderHook(() => useAccountPageViewModel(), {
|
const { result } = renderHook(() => useAccountPageVm(), {
|
||||||
wrapper: createWrapper(),
|
wrapper: createWrapper(),
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -187,14 +187,14 @@ it("keeps overview sections independent when their source data is incomplete", a
|
|||||||
http.get("*/api/v1/brokerage-accounts/:accountId/events", () =>
|
http.get("*/api/v1/brokerage-accounts/:accountId/events", () =>
|
||||||
HttpResponse.json(
|
HttpResponse.json(
|
||||||
resource(
|
resource(
|
||||||
{ events: [], incomeTotalsByCurrency: [] },
|
{ events: [], incomeTotal: { currency: "RUB", value: "0" } },
|
||||||
{ completeness: "incomplete" },
|
{ completeness: "incomplete" },
|
||||||
),
|
),
|
||||||
),
|
),
|
||||||
),
|
),
|
||||||
);
|
);
|
||||||
|
|
||||||
const { result } = renderHook(() => useAccountPageViewModel(), {
|
const { result } = renderHook(() => useAccountPageVm(), {
|
||||||
wrapper: createWrapper(),
|
wrapper: createWrapper(),
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -213,8 +213,8 @@ it("keeps overview sections loaded without exposing technical retry", async () =
|
|||||||
|
|
||||||
const sections: Record<string, unknown>
|
const sections: Record<string, unknown>
|
||||||
= {
|
= {
|
||||||
"events": { events: [], incomeTotalsByCurrency: [] },
|
"events": { events: [], incomeTotal: { currency: "RUB", value: "0" } },
|
||||||
"income-summary": { totalsByCurrency: [] },
|
"income-summary": { total: { coupon: { currency: "RUB", value: "0" }, dividend: { currency: "RUB", value: "0" }, total: { currency: "RUB", value: "0" } } },
|
||||||
"operations": { hasNext: false, items: [], nextCursor: null },
|
"operations": { hasNext: false, items: [], nextCursor: null },
|
||||||
portfolio,
|
portfolio,
|
||||||
};
|
};
|
||||||
@@ -232,13 +232,13 @@ it("keeps overview sections loaded without exposing technical retry", async () =
|
|||||||
),
|
),
|
||||||
);
|
);
|
||||||
|
|
||||||
const { result } = renderHook(() => useAccountPageViewModel(), {
|
const { result } = renderHook(() => useAccountPageVm(), {
|
||||||
wrapper: createWrapper(),
|
wrapper: createWrapper(),
|
||||||
});
|
});
|
||||||
|
|
||||||
await waitFor(() =>
|
await waitFor(() =>
|
||||||
expect(result.current).toMatchObject({
|
expect(result.current).toMatchObject({
|
||||||
incomeSummary: { state: "empty" },
|
incomeSummary: { state: "loaded" },
|
||||||
recentEvents: { state: "empty" },
|
recentEvents: { state: "empty" },
|
||||||
recentOperations: { state: "empty" },
|
recentOperations: { state: "empty" },
|
||||||
state: "loaded",
|
state: "loaded",
|
||||||
|
|||||||
@@ -1,3 +1,5 @@
|
|||||||
|
import { useState } from "react";
|
||||||
|
import { useTranslation } from "react-i18next";
|
||||||
import { useParams } from "react-router";
|
import { useParams } from "react-router";
|
||||||
|
|
||||||
import type { Portfolio } from "@/entities/portfolio";
|
import type { Portfolio } from "@/entities/portfolio";
|
||||||
@@ -14,9 +16,15 @@ import {
|
|||||||
import { useIncomeSummary } from "@/entities/income";
|
import { useIncomeSummary } from "@/entities/income";
|
||||||
import { usePortfolio } from "@/entities/portfolio";
|
import { usePortfolio } from "@/entities/portfolio";
|
||||||
import { useScreenSync } from "@/features/tbank-connection";
|
import { useScreenSync } from "@/features/tbank-connection";
|
||||||
import { ApiErrorCode, apiErrorCode, isApiErrorCode } from "@/shared/api";
|
import { apiErrorCode, isBrokerageAccessLoss, readRetry } from "@/shared/api";
|
||||||
import { useInitialAvailability } from "@/shared/lib";
|
import { useInitialAvailability } from "@/shared/lib";
|
||||||
|
|
||||||
|
import {
|
||||||
|
type Concentration,
|
||||||
|
type ConcentrationLabels,
|
||||||
|
type Slice,
|
||||||
|
toConcentration,
|
||||||
|
} from "../../model/concentration";
|
||||||
import {
|
import {
|
||||||
type AccountPagePositionSection,
|
type AccountPagePositionSection,
|
||||||
toAccountPagePositionSections,
|
toAccountPagePositionSections,
|
||||||
@@ -36,8 +44,10 @@ type AccountPageContent = {
|
|||||||
accountId?: string;
|
accountId?: string;
|
||||||
incomeSummary: AccountPageIncomeSummary;
|
incomeSummary: AccountPageIncomeSummary;
|
||||||
partial?: boolean;
|
partial?: boolean;
|
||||||
|
readRetry: AccountPageReadRetry;
|
||||||
recentEvents: AccountPageRecentEvents;
|
recentEvents: AccountPageRecentEvents;
|
||||||
recentOperations: AccountPageRecentOperations;
|
recentOperations: AccountPageRecentOperations;
|
||||||
|
source?: InvestmentResourceMeta;
|
||||||
};
|
};
|
||||||
|
|
||||||
type AccountPageEmptyViewModel = AccountPageContent & {
|
type AccountPageEmptyViewModel = AccountPageContent & {
|
||||||
@@ -45,27 +55,46 @@ type AccountPageEmptyViewModel = AccountPageContent & {
|
|||||||
};
|
};
|
||||||
|
|
||||||
type AccountPageLoadedViewModel = AccountPageContent & {
|
type AccountPageLoadedViewModel = AccountPageContent & {
|
||||||
|
concentration: Concentration | null;
|
||||||
|
onSliceChange: (slice: Slice) => void;
|
||||||
|
onTabChange: (tab: null | string) => void;
|
||||||
portfolio: Portfolio;
|
portfolio: Portfolio;
|
||||||
positionSections: AccountPagePositionSection[];
|
positionSections: AccountPagePositionSection[];
|
||||||
source?: InvestmentResourceMeta;
|
slice: Slice;
|
||||||
state: "loaded";
|
state: "loaded";
|
||||||
unrealizedReturns: Portfolio["totalsByCurrency"];
|
tab: string;
|
||||||
|
unrealizedReturns:
|
||||||
|
| null
|
||||||
|
| { currency: string; value: string };
|
||||||
};
|
};
|
||||||
|
|
||||||
|
type AccountPageReadRetry = ReturnType<typeof readRetry>;
|
||||||
|
|
||||||
type AccountPageViewModel
|
type AccountPageViewModel
|
||||||
= | AccountPageEmptyViewModel
|
= | AccountPageEmptyViewModel
|
||||||
| AccountPageLoadedViewModel
|
| AccountPageLoadedViewModel
|
||||||
| { code?: string; state: "error" }
|
| { code?: string; readRetry: AccountPageReadRetry; state: "error" }
|
||||||
| { state: "loading" };
|
| { state: "loading" };
|
||||||
|
|
||||||
function isPortfolioAccessFailure(code?: string) {
|
function useAccountPageVm(): AccountPageViewModel {
|
||||||
return isApiErrorCode(code, ApiErrorCode.InvalidTbankToken)
|
|
||||||
|| isApiErrorCode(code, ApiErrorCode.NotFound)
|
|
||||||
|| isApiErrorCode(code, ApiErrorCode.TbankNotConnected);
|
|
||||||
}
|
|
||||||
|
|
||||||
function useAccountPageViewModel(): AccountPageViewModel {
|
|
||||||
const { accountId } = useParams();
|
const { accountId } = useParams();
|
||||||
|
const { t } = useTranslation();
|
||||||
|
|
||||||
|
const [selection, setSelection] = useState<{
|
||||||
|
accountId?: string;
|
||||||
|
slice: Slice;
|
||||||
|
tab: string;
|
||||||
|
}>({ accountId, slice: "stocks", tab: "positions" });
|
||||||
|
|
||||||
|
const current = selection.accountId === accountId
|
||||||
|
? selection
|
||||||
|
: {
|
||||||
|
accountId, slice: "stocks" as const, tab: "positions",
|
||||||
|
};
|
||||||
|
|
||||||
|
const updateSelection = (change: Partial<typeof selection>) =>
|
||||||
|
setSelection({ ...current, ...change });
|
||||||
|
|
||||||
const portfolio = usePortfolio(accountId);
|
const portfolio = usePortfolio(accountId);
|
||||||
|
|
||||||
const operations = useBrokerageOperations(accountId, {
|
const operations = useBrokerageOperations(accountId, {
|
||||||
@@ -85,7 +114,9 @@ function useAccountPageViewModel(): AccountPageViewModel {
|
|||||||
]);
|
]);
|
||||||
|
|
||||||
const code = apiErrorCode(portfolio.error);
|
const code = apiErrorCode(portfolio.error);
|
||||||
const isAccessFailure = isPortfolioAccessFailure(code);
|
// The portfolio drives this screen; the retry repeats only its GET.
|
||||||
|
const retry = readRetry([portfolio]);
|
||||||
|
const isAccessFailure = isBrokerageAccessLoss(code);
|
||||||
|
|
||||||
const availability = useInitialAvailability({
|
const availability = useInitialAvailability({
|
||||||
hasContent: !!portfolio.data,
|
hasContent: !!portfolio.data,
|
||||||
@@ -94,12 +125,13 @@ function useAccountPageViewModel(): AccountPageViewModel {
|
|||||||
isFetching: portfolio.isFetching,
|
isFetching: portfolio.isFetching,
|
||||||
});
|
});
|
||||||
|
|
||||||
if (isAccessFailure) return { code, state: "error" as const };
|
if (isAccessFailure)
|
||||||
|
return { code, readRetry: retry, state: "error" as const };
|
||||||
|
|
||||||
if (!portfolio.data)
|
if (!portfolio.data)
|
||||||
return {
|
return availability === "unavailable"
|
||||||
state: availability === "unavailable" ? "error" : "loading",
|
? { code, readRetry: retry, state: "error" as const }
|
||||||
} as const;
|
: { state: "loading" as const };
|
||||||
|
|
||||||
const account = accounts.data?.find(item => item.id === accountId);
|
const account = accounts.data?.find(item => item.id === accountId);
|
||||||
const recentOperations = toRecentOperations(accountId, operations);
|
const recentOperations = toRecentOperations(accountId, operations);
|
||||||
@@ -110,32 +142,52 @@ function useAccountPageViewModel(): AccountPageViewModel {
|
|||||||
if (
|
if (
|
||||||
portfolio.meta?.availability === "available"
|
portfolio.meta?.availability === "available"
|
||||||
&& portfolio.data.positions.length === 0
|
&& portfolio.data.positions.length === 0
|
||||||
&& portfolio.data.cashBalances.length === 0
|
&& Number(portfolio.data.cash.value) === 0
|
||||||
)
|
)
|
||||||
return {
|
return {
|
||||||
account,
|
account,
|
||||||
accountId,
|
accountId,
|
||||||
incomeSummary,
|
incomeSummary,
|
||||||
|
readRetry: retry,
|
||||||
recentEvents,
|
recentEvents,
|
||||||
recentOperations,
|
recentOperations,
|
||||||
|
source: portfolio.meta,
|
||||||
state: "empty" as const,
|
state: "empty" as const,
|
||||||
};
|
};
|
||||||
|
|
||||||
const isPartial = portfolio.meta?.completeness === "incomplete";
|
const isPartial = portfolio.meta?.completeness === "incomplete";
|
||||||
|
|
||||||
|
const labels: ConcentrationLabels = {
|
||||||
|
missingIssuer: t("portfolio.concentration.missingIssuer"),
|
||||||
|
missingSector: t("portfolio.concentration.missingSector"),
|
||||||
|
other: t("portfolio.concentration.other"),
|
||||||
|
sector: code => t(`stock.sectors.${code}`, { defaultValue: code }),
|
||||||
|
};
|
||||||
|
|
||||||
|
const concentration = accountId !== "all"
|
||||||
|
&& current.tab === "concentration"
|
||||||
|
? toConcentration(portfolio.data, current.slice, labels)
|
||||||
|
: null;
|
||||||
|
|
||||||
return {
|
return {
|
||||||
account,
|
account,
|
||||||
accountId,
|
accountId,
|
||||||
|
concentration,
|
||||||
incomeSummary,
|
incomeSummary,
|
||||||
|
onSliceChange: slice => updateSelection({ slice }),
|
||||||
|
onTabChange: tab => updateSelection({ tab: tab ?? "positions" }),
|
||||||
partial: isPartial,
|
partial: isPartial,
|
||||||
portfolio: portfolio.data,
|
portfolio: portfolio.data,
|
||||||
positionSections: toAccountPagePositionSections(portfolio.data),
|
positionSections: toAccountPagePositionSections(portfolio.data),
|
||||||
|
readRetry: retry,
|
||||||
recentEvents,
|
recentEvents,
|
||||||
recentOperations,
|
recentOperations,
|
||||||
|
slice: current.slice,
|
||||||
source: portfolio.meta,
|
source: portfolio.meta,
|
||||||
state: "loaded" as const,
|
state: "loaded" as const,
|
||||||
|
tab: current.tab,
|
||||||
unrealizedReturns: toUnrealizedReturns(portfolio.data.positions),
|
unrealizedReturns: toUnrealizedReturns(portfolio.data.positions),
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
export { useAccountPageViewModel };
|
export { useAccountPageVm };
|
||||||
|
|||||||
@@ -5,9 +5,10 @@ import { StateView } from "@wealthledger/ui";
|
|||||||
import { useTranslation } from "react-i18next";
|
import { useTranslation } from "react-i18next";
|
||||||
|
|
||||||
import type { BrokerageAccount } from "@/entities/brokerage-account";
|
import type { BrokerageAccount } from "@/entities/brokerage-account";
|
||||||
|
import type { InvestmentResourceMeta } from "@/shared/api";
|
||||||
|
|
||||||
import { BrokerageEventsPreview } from "@/entities/brokerage-event";
|
import { BrokerageEventsPreview } from "@/entities/brokerage-event";
|
||||||
import { PortfolioStructure } from "@/widgets/portfolio-structure";
|
import { ReadRetry, type ReadRetryProps, SourceSyncStatus } from "@/shared/ui";
|
||||||
|
|
||||||
import type {
|
import type {
|
||||||
AccountPageIncomeSummary,
|
AccountPageIncomeSummary,
|
||||||
@@ -17,14 +18,17 @@ import type {
|
|||||||
|
|
||||||
import { AccountHeading } from "./AccountHeading.view";
|
import { AccountHeading } from "./AccountHeading.view";
|
||||||
import { IncomeSummary } from "./IncomeSummary.view";
|
import { IncomeSummary } from "./IncomeSummary.view";
|
||||||
|
import { PortfolioStructure } from "./PortfolioStructure/PortfolioStructure";
|
||||||
import { RecentOperations } from "./RecentOperations.view";
|
import { RecentOperations } from "./RecentOperations.view";
|
||||||
|
|
||||||
type AccountPageEmptyProps = {
|
type AccountPageEmptyProps = {
|
||||||
account?: BrokerageAccount;
|
account?: BrokerageAccount;
|
||||||
accountId?: string;
|
accountId?: string;
|
||||||
incomeSummary?: AccountPageIncomeSummary;
|
incomeSummary?: AccountPageIncomeSummary;
|
||||||
|
readRetry?: ReadRetryProps;
|
||||||
recentEvents: AccountPageRecentEvents;
|
recentEvents: AccountPageRecentEvents;
|
||||||
recentOperations: AccountPageRecentOperations;
|
recentOperations: AccountPageRecentOperations;
|
||||||
|
source?: InvestmentResourceMeta;
|
||||||
};
|
};
|
||||||
|
|
||||||
const AccountPageEmpty: FC<AccountPageEmptyProps> = (props) => {
|
const AccountPageEmpty: FC<AccountPageEmptyProps> = (props) => {
|
||||||
@@ -40,10 +44,23 @@ const AccountPageEmpty: FC<AccountPageEmptyProps> = (props) => {
|
|||||||
<Stack>
|
<Stack>
|
||||||
<AccountHeading account={props.account} accountId={props.accountId} />
|
<AccountHeading account={props.account} accountId={props.accountId} />
|
||||||
|
|
||||||
|
<SourceSyncStatus
|
||||||
|
lastAttempt={props.source?.lastAttempt}
|
||||||
|
lastSuccessfulAt={props.source?.lastSuccessfulAt}
|
||||||
|
stale={props.source?.freshness === "stale"}
|
||||||
|
/>
|
||||||
|
|
||||||
|
{!!props.readRetry && <ReadRetry {...props.readRetry} />}
|
||||||
|
|
||||||
<StateView text={text} title={t("portfolio.emptyTitle")} />
|
<StateView text={text} title={t("portfolio.emptyTitle")} />
|
||||||
|
|
||||||
<PortfolioStructure
|
<PortfolioStructure
|
||||||
structure={{ currencies: [], unvaluedCategories: [] }}
|
structure={{
|
||||||
|
categories: [],
|
||||||
|
hasNegativeValues: false,
|
||||||
|
totalValue: "0",
|
||||||
|
unvaluedCategories: [],
|
||||||
|
}}
|
||||||
/>
|
/>
|
||||||
|
|
||||||
<RecentOperations
|
<RecentOperations
|
||||||
|
|||||||
@@ -6,8 +6,12 @@ import { useTranslation } from "react-i18next";
|
|||||||
import { Link } from "react-router";
|
import { Link } from "react-router";
|
||||||
|
|
||||||
import { ApiErrorCode, isApiErrorCode } from "@/shared/api";
|
import { ApiErrorCode, isApiErrorCode } from "@/shared/api";
|
||||||
|
import { ReadRetryButton, type ReadRetryProps } from "@/shared/ui";
|
||||||
|
|
||||||
type AccountPageErrorProps = { code?: string };
|
type AccountPageErrorProps = {
|
||||||
|
code?: string;
|
||||||
|
readRetry?: ReadRetryProps;
|
||||||
|
};
|
||||||
|
|
||||||
const AccountPageError: FC<AccountPageErrorProps> = (props) => {
|
const AccountPageError: FC<AccountPageErrorProps> = (props) => {
|
||||||
const { code } = props;
|
const { code } = props;
|
||||||
@@ -43,8 +47,18 @@ const AccountPageError: FC<AccountPageErrorProps> = (props) => {
|
|||||||
/>
|
/>
|
||||||
);
|
);
|
||||||
|
|
||||||
|
const retry = props.readRetry?.exhausted
|
||||||
|
? (
|
||||||
|
<ReadRetryButton
|
||||||
|
onRetry={props.readRetry.onRetry}
|
||||||
|
retrying={props.readRetry.retrying}
|
||||||
|
/>
|
||||||
|
)
|
||||||
|
: undefined;
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<StateView
|
<StateView
|
||||||
|
action={retry}
|
||||||
text={t("states.unavailableText")}
|
text={t("states.unavailableText")}
|
||||||
title={t("states.unavailableTitle")}
|
title={t("states.unavailableTitle")}
|
||||||
/>
|
/>
|
||||||
|
|||||||
@@ -15,9 +15,9 @@ import type { InvestmentResourceMeta } from "@/shared/api";
|
|||||||
|
|
||||||
import { BrokerageEventsPreview } from "@/entities/brokerage-event";
|
import { BrokerageEventsPreview } from "@/entities/brokerage-event";
|
||||||
import { formatMoney } from "@/shared/lib";
|
import { formatMoney } from "@/shared/lib";
|
||||||
import { SourceSyncStatus } from "@/shared/ui";
|
import { ReadRetry, type ReadRetryProps, SourceSyncStatus } from "@/shared/ui";
|
||||||
import { PortfolioStructure } from "@/widgets/portfolio-structure";
|
|
||||||
|
|
||||||
|
import type { Concentration as ConcentrationModel, Slice } from "../../../model/concentration";
|
||||||
import type { AccountPagePositionSection } from "../../../model/positions";
|
import type { AccountPagePositionSection } from "../../../model/positions";
|
||||||
import type {
|
import type {
|
||||||
AccountPageIncomeSummary,
|
AccountPageIncomeSummary,
|
||||||
@@ -27,27 +27,40 @@ import type {
|
|||||||
|
|
||||||
import classes from "../AccountPage.module.css";
|
import classes from "../AccountPage.module.css";
|
||||||
import { AccountHeading } from "./AccountHeading.view";
|
import { AccountHeading } from "./AccountHeading.view";
|
||||||
import { CurrencyCards } from "./CurrencyCards/CurrencyCards.view";
|
import { Concentration } from "./Concentration/Concentration.view";
|
||||||
import { IncomeSummary } from "./IncomeSummary.view";
|
import { IncomeSummary } from "./IncomeSummary.view";
|
||||||
|
import { PerformanceTab } from "./Performance/PerformanceTab";
|
||||||
|
import { PortfolioStructure } from "./PortfolioStructure/PortfolioStructure";
|
||||||
import { PositionSection } from "./PositionSection.view";
|
import { PositionSection } from "./PositionSection.view";
|
||||||
import { RecentOperations } from "./RecentOperations.view";
|
import { RecentOperations } from "./RecentOperations.view";
|
||||||
|
|
||||||
type AccountPageLoadedProps = {
|
type AccountPageLoadedProps = {
|
||||||
account?: BrokerageAccount;
|
account?: BrokerageAccount;
|
||||||
accountId?: string;
|
accountId?: string;
|
||||||
|
concentration: ConcentrationModel | null;
|
||||||
incomeSummary?: AccountPageIncomeSummary;
|
incomeSummary?: AccountPageIncomeSummary;
|
||||||
|
onSliceChange: (slice: Slice) => void;
|
||||||
|
onTabChange: (tab: null | string) => void;
|
||||||
partial?: boolean;
|
partial?: boolean;
|
||||||
portfolio: Portfolio;
|
portfolio: Portfolio;
|
||||||
positionSections: AccountPagePositionSection[];
|
positionSections: AccountPagePositionSection[];
|
||||||
|
readRetry?: ReadRetryProps;
|
||||||
recentEvents: AccountPageRecentEvents;
|
recentEvents: AccountPageRecentEvents;
|
||||||
recentOperations: AccountPageRecentOperations;
|
recentOperations: AccountPageRecentOperations;
|
||||||
|
slice: Slice;
|
||||||
source?: InvestmentResourceMeta;
|
source?: InvestmentResourceMeta;
|
||||||
unrealizedReturns: Portfolio["totalsByCurrency"];
|
tab: string;
|
||||||
|
unrealizedReturns:
|
||||||
|
| null
|
||||||
|
| { currency: string; value: string };
|
||||||
};
|
};
|
||||||
|
|
||||||
const AccountPageLoaded: FC<AccountPageLoadedProps> = (props) => {
|
const AccountPageLoaded: FC<AccountPageLoadedProps> = (props) => {
|
||||||
const { t } = useTranslation();
|
const { t } = useTranslation();
|
||||||
const [filter, setFilter] = useState<string>();
|
const [filter, setFilter] = useState<string>();
|
||||||
|
const tab = props.tab;
|
||||||
|
|
||||||
|
const onTabChange = props.onTabChange;
|
||||||
|
|
||||||
const activeSection = props.positionSections.find(
|
const activeSection = props.positionSections.find(
|
||||||
section => section.kind === filter,
|
section => section.kind === filter,
|
||||||
@@ -74,11 +87,29 @@ const AccountPageLoaded: FC<AccountPageLoadedProps> = (props) => {
|
|||||||
stale={props.source?.freshness === "stale"}
|
stale={props.source?.freshness === "stale"}
|
||||||
/>
|
/>
|
||||||
|
|
||||||
{props.partial
|
{!!props.readRetry && <ReadRetry {...props.readRetry} />}
|
||||||
? <Alert role="status">{t("investment.partial")}</Alert>
|
|
||||||
: <CurrencyCards amounts={props.portfolio.totalsByCurrency} />}
|
|
||||||
|
|
||||||
{!props.partial && props.unrealizedReturns.length > 0 && (
|
{props.partial
|
||||||
|
? tab !== "concentration" && (
|
||||||
|
<Alert role="status">{t("investment.partial")}</Alert>
|
||||||
|
)
|
||||||
|
: (
|
||||||
|
<Stack component="dl" gap={4} m={0}>
|
||||||
|
<dt>
|
||||||
|
<Text fw={600}>{t("portfolio.total")}</Text>
|
||||||
|
</dt>
|
||||||
|
|
||||||
|
<dd style={{ margin: 0 }}>
|
||||||
|
<Text className={classes.totalAmount}>
|
||||||
|
{formatMoney(props.portfolio.totals, {
|
||||||
|
withRoundedCents: true,
|
||||||
|
})}
|
||||||
|
</Text>
|
||||||
|
</dd>
|
||||||
|
</Stack>
|
||||||
|
)}
|
||||||
|
|
||||||
|
{!props.partial && props.unrealizedReturns && (
|
||||||
<Stack
|
<Stack
|
||||||
aria-label={t("portfolio.unrealizedResult")}
|
aria-label={t("portfolio.unrealizedResult")}
|
||||||
component="section"
|
component="section"
|
||||||
@@ -87,9 +118,7 @@ const AccountPageLoaded: FC<AccountPageLoadedProps> = (props) => {
|
|||||||
<Text fw={600}>{t("portfolio.unrealizedResult")}</Text>
|
<Text fw={600}>{t("portfolio.unrealizedResult")}</Text>
|
||||||
|
|
||||||
<Group gap="md">
|
<Group gap="md">
|
||||||
{props.unrealizedReturns.map(total => (
|
<Text>{formatMoney(props.unrealizedReturns)}</Text>
|
||||||
<Text key={total.currency}>{formatMoney(total)}</Text>
|
|
||||||
))}
|
|
||||||
</Group>
|
</Group>
|
||||||
|
|
||||||
<Text c="dimmed" size="xs">
|
<Text c="dimmed" size="xs">
|
||||||
@@ -107,14 +136,21 @@ const AccountPageLoaded: FC<AccountPageLoadedProps> = (props) => {
|
|||||||
|
|
||||||
<Tabs
|
<Tabs
|
||||||
classNames={{ list: classes.tabsList }}
|
classNames={{ list: classes.tabsList }}
|
||||||
defaultValue="positions"
|
|
||||||
keepMounted={false}
|
keepMounted={false}
|
||||||
|
onChange={onTabChange}
|
||||||
|
value={tab}
|
||||||
>
|
>
|
||||||
<Tabs.List aria-label={t("portfolio.sections")} mb="md">
|
<Tabs.List aria-label={t("portfolio.sections")} mb="md">
|
||||||
<Tabs.Tab value="positions">
|
<Tabs.Tab value="positions">
|
||||||
{t("portfolio.tabs.positions")}
|
{t("portfolio.tabs.positions")}
|
||||||
</Tabs.Tab>
|
</Tabs.Tab>
|
||||||
|
|
||||||
|
{props.accountId !== "all" && (
|
||||||
|
<Tabs.Tab value="concentration">
|
||||||
|
{t("portfolio.concentration.title")}
|
||||||
|
</Tabs.Tab>
|
||||||
|
)}
|
||||||
|
|
||||||
<Tabs.Tab value="cash">{t("portfolio.tabs.cash")}</Tabs.Tab>
|
<Tabs.Tab value="cash">{t("portfolio.tabs.cash")}</Tabs.Tab>
|
||||||
|
|
||||||
<Tabs.Tab value="operations">
|
<Tabs.Tab value="operations">
|
||||||
@@ -124,6 +160,8 @@ const AccountPageLoaded: FC<AccountPageLoadedProps> = (props) => {
|
|||||||
<Tabs.Tab value="events">{t("portfolio.tabs.events")}</Tabs.Tab>
|
<Tabs.Tab value="events">{t("portfolio.tabs.events")}</Tabs.Tab>
|
||||||
|
|
||||||
<Tabs.Tab value="income">{t("portfolio.tabs.income")}</Tabs.Tab>
|
<Tabs.Tab value="income">{t("portfolio.tabs.income")}</Tabs.Tab>
|
||||||
|
|
||||||
|
<Tabs.Tab value="performance">{t("portfolio.tabs.performance")}</Tabs.Tab>
|
||||||
</Tabs.List>
|
</Tabs.List>
|
||||||
|
|
||||||
<Tabs.Panel value="positions">
|
<Tabs.Panel value="positions">
|
||||||
@@ -143,8 +181,32 @@ const AccountPageLoaded: FC<AccountPageLoadedProps> = (props) => {
|
|||||||
</Stack>
|
</Stack>
|
||||||
</Tabs.Panel>
|
</Tabs.Panel>
|
||||||
|
|
||||||
|
{props.accountId !== "all" && (
|
||||||
|
<Tabs.Panel value="concentration">
|
||||||
|
{props.concentration && (
|
||||||
|
<Concentration
|
||||||
|
key={props.slice}
|
||||||
|
model={props.concentration}
|
||||||
|
onSliceChange={props.onSliceChange}
|
||||||
|
partial={!!props.partial}
|
||||||
|
slice={props.slice}
|
||||||
|
/>
|
||||||
|
)}
|
||||||
|
</Tabs.Panel>
|
||||||
|
)}
|
||||||
|
|
||||||
<Tabs.Panel value="cash">
|
<Tabs.Panel value="cash">
|
||||||
<CurrencyCards amounts={props.portfolio.cashBalances} />
|
<Stack component="dl" gap={4} m={0}>
|
||||||
|
<dt>
|
||||||
|
<Text fw={600}>{t("portfolio.cashTitle")}</Text>
|
||||||
|
</dt>
|
||||||
|
|
||||||
|
<dd style={{ margin: 0 }}>
|
||||||
|
<Text>
|
||||||
|
{formatMoney(props.portfolio.cash, { withRoundedCents: true })}
|
||||||
|
</Text>
|
||||||
|
</dd>
|
||||||
|
</Stack>
|
||||||
</Tabs.Panel>
|
</Tabs.Panel>
|
||||||
|
|
||||||
<Tabs.Panel value="operations">
|
<Tabs.Panel value="operations">
|
||||||
@@ -171,6 +233,10 @@ const AccountPageLoaded: FC<AccountPageLoadedProps> = (props) => {
|
|||||||
/>
|
/>
|
||||||
)}
|
)}
|
||||||
</Tabs.Panel>
|
</Tabs.Panel>
|
||||||
|
|
||||||
|
<Tabs.Panel value="performance">
|
||||||
|
{props.accountId && <PerformanceTab accountId={props.accountId} />}
|
||||||
|
</Tabs.Panel>
|
||||||
</Tabs>
|
</Tabs>
|
||||||
</Stack>
|
</Stack>
|
||||||
);
|
);
|
||||||
|
|||||||
@@ -0,0 +1,111 @@
|
|||||||
|
.layout {
|
||||||
|
display: grid;
|
||||||
|
grid-template-columns: minmax(260px, 1fr) minmax(0, 1.4fr);
|
||||||
|
gap: var(--mantine-spacing-xl);
|
||||||
|
align-items: center;
|
||||||
|
}
|
||||||
|
|
||||||
|
.chart {
|
||||||
|
position: relative;
|
||||||
|
justify-self: center;
|
||||||
|
}
|
||||||
|
|
||||||
|
.pattern {
|
||||||
|
position: absolute;
|
||||||
|
width: 0;
|
||||||
|
height: 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
.center {
|
||||||
|
position: absolute;
|
||||||
|
inset: 32%;
|
||||||
|
display: flex;
|
||||||
|
flex-direction: column;
|
||||||
|
align-items: center;
|
||||||
|
justify-content: center;
|
||||||
|
text-align: center;
|
||||||
|
font-size: clamp(12px, 1.3vw, 17px);
|
||||||
|
overflow-wrap: anywhere;
|
||||||
|
pointer-events: none;
|
||||||
|
}
|
||||||
|
|
||||||
|
.srOnly {
|
||||||
|
position: absolute;
|
||||||
|
width: 1px;
|
||||||
|
height: 1px;
|
||||||
|
padding: 0;
|
||||||
|
overflow: hidden;
|
||||||
|
clip: rect(0, 0, 0, 0);
|
||||||
|
white-space: nowrap;
|
||||||
|
}
|
||||||
|
|
||||||
|
.list {
|
||||||
|
list-style: none;
|
||||||
|
margin: 0;
|
||||||
|
padding: 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
.row {
|
||||||
|
display: flex;
|
||||||
|
align-items: center;
|
||||||
|
gap: var(--mantine-spacing-sm);
|
||||||
|
min-height: 58px;
|
||||||
|
border-bottom: 1px solid var(--mantine-color-gray-2);
|
||||||
|
}
|
||||||
|
|
||||||
|
.rank {
|
||||||
|
display: grid;
|
||||||
|
place-items: center;
|
||||||
|
width: 28px;
|
||||||
|
height: 28px;
|
||||||
|
flex: none;
|
||||||
|
border-radius: 50%;
|
||||||
|
color: white;
|
||||||
|
}
|
||||||
|
|
||||||
|
.identity {
|
||||||
|
flex: 1;
|
||||||
|
min-width: 0;
|
||||||
|
overflow-wrap: anywhere;
|
||||||
|
}
|
||||||
|
|
||||||
|
.bar,
|
||||||
|
.bar span {
|
||||||
|
display: block;
|
||||||
|
height: 4px;
|
||||||
|
border-radius: 4px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.bar {
|
||||||
|
background: var(--mantine-color-gray-2);
|
||||||
|
}
|
||||||
|
|
||||||
|
.value {
|
||||||
|
text-align: right;
|
||||||
|
white-space: nowrap;
|
||||||
|
}
|
||||||
|
|
||||||
|
.other {
|
||||||
|
display: flex;
|
||||||
|
justify-content: space-between;
|
||||||
|
gap: var(--mantine-spacing-sm);
|
||||||
|
width: 100%;
|
||||||
|
min-height: 44px;
|
||||||
|
align-items: center;
|
||||||
|
border: 0;
|
||||||
|
background: var(--mantine-color-gray-0);
|
||||||
|
color: inherit;
|
||||||
|
cursor: pointer;
|
||||||
|
text-align: left;
|
||||||
|
}
|
||||||
|
|
||||||
|
.other:focus-visible {
|
||||||
|
outline: 2px solid var(--mantine-color-blue-6);
|
||||||
|
outline-offset: 2px;
|
||||||
|
}
|
||||||
|
|
||||||
|
@media (max-width: 700px) {
|
||||||
|
.layout { grid-template-columns: 1fr; }
|
||||||
|
.slices { max-width: 100%; overflow-x: auto; }
|
||||||
|
.other { flex-wrap: wrap; }
|
||||||
|
}
|
||||||
@@ -0,0 +1,310 @@
|
|||||||
|
import { DonutChart } from "@mantine/charts";
|
||||||
|
import {
|
||||||
|
Alert, Box, Group, Paper, SegmentedControl, Stack,
|
||||||
|
Text, Title,
|
||||||
|
} from "@mantine/core";
|
||||||
|
import { type FC, useId, useState } from "react";
|
||||||
|
import { useTranslation } from "react-i18next";
|
||||||
|
|
||||||
|
import { formatMoney } from "@/shared/lib";
|
||||||
|
|
||||||
|
import type {
|
||||||
|
ConcentrationItem,
|
||||||
|
Concentration as ConcentrationModel,
|
||||||
|
Slice,
|
||||||
|
} from "../../../../model/concentration";
|
||||||
|
|
||||||
|
import { PositionLogo } from "../PositionLogo.view";
|
||||||
|
import classes from "./Concentration.module.css";
|
||||||
|
|
||||||
|
type Props = {
|
||||||
|
model: ConcentrationModel;
|
||||||
|
onSliceChange: (slice: Slice) => void;
|
||||||
|
partial: boolean;
|
||||||
|
slice: Slice;
|
||||||
|
};
|
||||||
|
|
||||||
|
const sliceLabels = {
|
||||||
|
bonds: "portfolio.bonds",
|
||||||
|
issuers: "portfolio.concentration.issuers",
|
||||||
|
sectors: "portfolio.concentration.sectors",
|
||||||
|
stocks: "portfolio.stocks",
|
||||||
|
} as const;
|
||||||
|
|
||||||
|
type RowProps = {
|
||||||
|
color: string;
|
||||||
|
index: number;
|
||||||
|
item: ConcentrationItem;
|
||||||
|
logo?: ConcentrationItem["logo"];
|
||||||
|
name: string;
|
||||||
|
};
|
||||||
|
|
||||||
|
const colors = [
|
||||||
|
"#2563eb", "#18a999", "#f59e0b", "#8b5cf6", "#ef6c5b",
|
||||||
|
"#64748b",
|
||||||
|
];
|
||||||
|
|
||||||
|
const PERCENT = 100;
|
||||||
|
const OTHER_START = 6;
|
||||||
|
|
||||||
|
function amountFor(item: ConcentrationItem): string {
|
||||||
|
return formatMoney({ currency: "RUB", value: item.amount });
|
||||||
|
}
|
||||||
|
|
||||||
|
const ConcentrationRow: FC<RowProps> = props => (
|
||||||
|
<li className={classes.row}>
|
||||||
|
<span
|
||||||
|
aria-hidden="true"
|
||||||
|
className={classes.rank}
|
||||||
|
style={{ backgroundColor: props.color }}
|
||||||
|
>
|
||||||
|
{props.index}
|
||||||
|
</span>
|
||||||
|
|
||||||
|
{props.logo && <PositionLogo label={props.name} src={props.logo.src} />}
|
||||||
|
|
||||||
|
<span className={classes.identity}>
|
||||||
|
<span>{props.name}</span>
|
||||||
|
|
||||||
|
{props.logo?.subtitle && (
|
||||||
|
<Text c="dimmed" size="xs">{props.logo.subtitle}</Text>
|
||||||
|
)}
|
||||||
|
|
||||||
|
<span aria-hidden="true" className={classes.bar}>
|
||||||
|
<span style={{
|
||||||
|
backgroundColor: props.color,
|
||||||
|
width: `${props.item.chartValue * PERCENT}%`,
|
||||||
|
}}
|
||||||
|
/>
|
||||||
|
</span>
|
||||||
|
</span>
|
||||||
|
|
||||||
|
<span className={classes.value}>
|
||||||
|
<strong>{amountFor(props.item)}</strong>
|
||||||
|
|
||||||
|
<Text c="dimmed" size="sm">{props.item.share}</Text>
|
||||||
|
</span>
|
||||||
|
</li>
|
||||||
|
);
|
||||||
|
|
||||||
|
type TooltipProps = {
|
||||||
|
active?: boolean;
|
||||||
|
payload?: { name?: number | string }[];
|
||||||
|
rows: { amount: string; label: string; share: string }[];
|
||||||
|
};
|
||||||
|
|
||||||
|
function chartCellProps(series: { name: string }, rows: ConcentrationItem[]) {
|
||||||
|
const index = Number(series.name);
|
||||||
|
const item = rows.at(index);
|
||||||
|
|
||||||
|
return {
|
||||||
|
stroke: "white",
|
||||||
|
strokeWidth: 2,
|
||||||
|
...((item?.unknown || (index === rows.length - 1
|
||||||
|
&& item?.key === "__other"))
|
||||||
|
&& { strokeDasharray: "3 2" }),
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
function rankLabel({ index }: { index: number; percent?: number }) {
|
||||||
|
return String(index + 1);
|
||||||
|
}
|
||||||
|
|
||||||
|
const ChartTooltip: FC<TooltipProps> = (props) => {
|
||||||
|
const row = props.rows[Number(props.payload?.[0]?.name)];
|
||||||
|
if (!row || !props.active) return;
|
||||||
|
|
||||||
|
return (
|
||||||
|
<Paper p="sm" radius="md" shadow="sm">
|
||||||
|
<Text fw={600} size="sm">{row.label}</Text>
|
||||||
|
|
||||||
|
<Text size="sm">{row.amount} · {row.share}</Text>
|
||||||
|
</Paper>
|
||||||
|
);
|
||||||
|
};
|
||||||
|
|
||||||
|
const Concentration: FC<Props> = (props) => {
|
||||||
|
const { t } = useTranslation();
|
||||||
|
const [expanded, setExpanded] = useState(false);
|
||||||
|
const otherId = useId();
|
||||||
|
const chartId = useId();
|
||||||
|
|
||||||
|
const rows = props.model.other
|
||||||
|
? [...props.model.items, props.model.other]
|
||||||
|
: props.model.items;
|
||||||
|
|
||||||
|
const chartData = rows.map((item, index) => ({
|
||||||
|
color: colors[index % colors.length] ?? colors[0] ?? "blue",
|
||||||
|
name: String(index),
|
||||||
|
value: item.chartValue,
|
||||||
|
}));
|
||||||
|
|
||||||
|
const chartText = [
|
||||||
|
props.model.top5Share && t("portfolio.concentration.top5", {
|
||||||
|
share: props.model.top5Share,
|
||||||
|
}),
|
||||||
|
props.model.total && formatMoney({ currency: "RUB", value: props.model.total }),
|
||||||
|
...rows.map(item => `${item.label}: ${amountFor(item)}, ${item.share}`),
|
||||||
|
].filter(Boolean).join("; ");
|
||||||
|
|
||||||
|
const slices = [
|
||||||
|
{ label: t("portfolio.stocks"), value: "stocks" },
|
||||||
|
{ label: t("portfolio.bonds"), value: "bonds" },
|
||||||
|
{ label: t("portfolio.concentration.sectors"), value: "sectors" },
|
||||||
|
{ label: t("portfolio.concentration.issuers"), value: "issuers" },
|
||||||
|
];
|
||||||
|
|
||||||
|
// eslint-disable-next-line frontend/readability -- Mantine callback closes over page action.
|
||||||
|
const selectSlice = (value: string) => props.onSliceChange(value as Slice);
|
||||||
|
// eslint-disable-next-line frontend/readability -- Disclosure state belongs to this view.
|
||||||
|
const toggleOther = () => setExpanded(value => !value);
|
||||||
|
|
||||||
|
// eslint-disable-next-line frontend/readability -- Chart callback closes over visible rows.
|
||||||
|
const cellProps = (series: { name: string }) => chartCellProps(series, rows);
|
||||||
|
const pieProps = { isAnimationActive: false, label: rankLabel };
|
||||||
|
|
||||||
|
const tooltipRows = rows.map(item => ({
|
||||||
|
amount: amountFor(item),
|
||||||
|
label: item.label,
|
||||||
|
share: item.share,
|
||||||
|
}));
|
||||||
|
|
||||||
|
const tooltipProps = { content: <ChartTooltip rows={tooltipRows} /> };
|
||||||
|
|
||||||
|
const totalText = props.model.total
|
||||||
|
? formatMoney({ currency: "RUB", value: props.model.total })
|
||||||
|
: "";
|
||||||
|
|
||||||
|
return (
|
||||||
|
<Stack gap="lg">
|
||||||
|
<Group align="end" justify="space-between">
|
||||||
|
<SegmentedControl
|
||||||
|
aria-label={t("portfolio.concentration.slice")}
|
||||||
|
className={classes.slices}
|
||||||
|
data={slices}
|
||||||
|
onChange={selectSlice}
|
||||||
|
value={props.slice}
|
||||||
|
/>
|
||||||
|
|
||||||
|
</Group>
|
||||||
|
|
||||||
|
{props.partial && (
|
||||||
|
<Alert role="status">{t("portfolio.concentration.incomplete")}</Alert>
|
||||||
|
)}
|
||||||
|
|
||||||
|
{props.model.empty
|
||||||
|
? (
|
||||||
|
<Stack gap="xs">
|
||||||
|
<Text fw={600}>{t(sliceLabels[props.slice])}</Text>
|
||||||
|
|
||||||
|
<Text>{t("portfolio.concentration.empty")}</Text>
|
||||||
|
</Stack>
|
||||||
|
)
|
||||||
|
: (
|
||||||
|
<Paper className={classes.layout} p="lg" radius="md" withBorder>
|
||||||
|
<Box className={classes.chart}>
|
||||||
|
<DonutChart
|
||||||
|
aria-describedby={chartId}
|
||||||
|
aria-label={t("portfolio.concentration.chart")}
|
||||||
|
cellProps={cellProps}
|
||||||
|
data={chartData}
|
||||||
|
pieProps={pieProps}
|
||||||
|
role="img"
|
||||||
|
size={260}
|
||||||
|
strokeWidth={24}
|
||||||
|
tooltipDataSource="segment"
|
||||||
|
tooltipProps={tooltipProps}
|
||||||
|
/>
|
||||||
|
|
||||||
|
<div aria-hidden="true" className={classes.center}>
|
||||||
|
{props.model.top5Share && (
|
||||||
|
<Text fw={700} size="sm">{t("portfolio.concentration.top5", {
|
||||||
|
share: props.model.top5Share,
|
||||||
|
})}
|
||||||
|
</Text>
|
||||||
|
)}
|
||||||
|
|
||||||
|
<Text fw={700}>{totalText}</Text>
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<Text
|
||||||
|
className={classes.srOnly}
|
||||||
|
id={chartId}
|
||||||
|
>
|
||||||
|
{chartText}
|
||||||
|
</Text>
|
||||||
|
</Box>
|
||||||
|
|
||||||
|
<Stack gap="xs">
|
||||||
|
<Title order={3} size="md">{t("portfolio.concentration.title")}</Title>
|
||||||
|
|
||||||
|
<ol className={classes.list}>
|
||||||
|
{props.model.items.map((item, index) => (
|
||||||
|
<ConcentrationRow
|
||||||
|
color={colors[index % colors.length] ?? "blue"}
|
||||||
|
index={index + 1}
|
||||||
|
item={item}
|
||||||
|
key={item.key}
|
||||||
|
logo={item.logo}
|
||||||
|
name={item.label}
|
||||||
|
/>
|
||||||
|
))}
|
||||||
|
</ol>
|
||||||
|
|
||||||
|
{props.model.other && (
|
||||||
|
<>
|
||||||
|
<button
|
||||||
|
aria-controls={otherId}
|
||||||
|
aria-expanded={expanded}
|
||||||
|
className={classes.other}
|
||||||
|
onClick={toggleOther}
|
||||||
|
type="button"
|
||||||
|
>
|
||||||
|
<span>{t("portfolio.concentration.other")} · {t(
|
||||||
|
"portfolio.concentration.otherCount",
|
||||||
|
{ count: props.model.other.count },
|
||||||
|
)}
|
||||||
|
</span>
|
||||||
|
|
||||||
|
<span>{amountFor(props.model.other)} · {
|
||||||
|
props.model.other.share
|
||||||
|
}
|
||||||
|
</span>
|
||||||
|
</button>
|
||||||
|
|
||||||
|
<ol
|
||||||
|
className={classes.list}
|
||||||
|
hidden={!expanded}
|
||||||
|
id={otherId}
|
||||||
|
start={OTHER_START}
|
||||||
|
>
|
||||||
|
{props.model.other.entries.map((item, index) => (
|
||||||
|
<ConcentrationRow
|
||||||
|
color={colors[(index + OTHER_START) % colors.length]
|
||||||
|
?? "blue"}
|
||||||
|
index={index + OTHER_START}
|
||||||
|
item={item}
|
||||||
|
key={item.key}
|
||||||
|
logo={item.logo}
|
||||||
|
name={item.label}
|
||||||
|
/>
|
||||||
|
))}
|
||||||
|
</ol>
|
||||||
|
</>
|
||||||
|
)}
|
||||||
|
</Stack>
|
||||||
|
</Paper>
|
||||||
|
)}
|
||||||
|
|
||||||
|
{props.model.unaccounted > 0 && (
|
||||||
|
<Text c="dimmed" size="sm">{t(
|
||||||
|
"portfolio.concentration.unaccounted",
|
||||||
|
{ count: props.model.unaccounted },
|
||||||
|
)}
|
||||||
|
</Text>
|
||||||
|
)}
|
||||||
|
</Stack>
|
||||||
|
);
|
||||||
|
};
|
||||||
|
|
||||||
|
export { Concentration };
|
||||||
@@ -1,77 +0,0 @@
|
|||||||
import { MantineProvider } from "@mantine/core";
|
|
||||||
import { render, screen } from "@testing-library/react";
|
|
||||||
import { describe, expect, it } from "vitest";
|
|
||||||
|
|
||||||
import { CurrencyCards } from "./CurrencyCards.view";
|
|
||||||
|
|
||||||
describe("CurrencyCards currency presentation", () => {
|
|
||||||
it.each([0, 5])(
|
|
||||||
"renders only the %i supplied totals in upstream order",
|
|
||||||
(count) => {
|
|
||||||
const totals = [
|
|
||||||
{ currency: "EUR", value: "3.00" },
|
|
||||||
{ currency: "USD", value: "2.00" },
|
|
||||||
{ currency: "RUB", value: "1.00" },
|
|
||||||
{ currency: "CAD", value: "4.00" },
|
|
||||||
{ currency: "XYZ", value: "5.00" },
|
|
||||||
].slice(0, count);
|
|
||||||
|
|
||||||
const { container } = render(
|
|
||||||
<MantineProvider>
|
|
||||||
<CurrencyCards amounts={totals} />
|
|
||||||
</MantineProvider>,
|
|
||||||
);
|
|
||||||
|
|
||||||
expect(
|
|
||||||
screen.queryAllByRole("definition").map(node => node.textContent),
|
|
||||||
).toEqual(
|
|
||||||
["3,00 €", "2,00 $", "1,00 ₽", "4,00 CAD", "5,00 XYZ"].slice(0, count),
|
|
||||||
);
|
|
||||||
// eslint-disable-next-line testing-library/no-container, testing-library/no-node-access -- This assertion checks DOM structure, decoration or focus behavior that semantic queries cannot establish.
|
|
||||||
expect(container.querySelectorAll("dl")).toHaveLength(count);
|
|
||||||
expect(
|
|
||||||
// eslint-disable-next-line testing-library/no-container, testing-library/no-node-access -- This assertion checks DOM structure, decoration or focus behavior that semantic queries cannot establish.
|
|
||||||
container.querySelector("[tabindex], button, a, input"),
|
|
||||||
).toBeNull();
|
|
||||||
},
|
|
||||||
);
|
|
||||||
|
|
||||||
it.each([
|
|
||||||
["RUB", "125000.50", "125 000,50 ₽", "Российский рубль", "₽"],
|
|
||||||
["USD", "320.00", "320,00 $", "Доллар США", "$"],
|
|
||||||
["EUR", "9876.54321", "9 876,54321 €", "Евро", "€"],
|
|
||||||
[
|
|
||||||
"RUB",
|
|
||||||
"123456789012.345678901",
|
|
||||||
"123 456 789 012,345678901 ₽",
|
|
||||||
"Российский рубль",
|
|
||||||
"₽",
|
|
||||||
],
|
|
||||||
["USD", "-1234567.890123", "-1 234 567,890123 $", "Доллар США", "$"],
|
|
||||||
["EUR", "987654321.000001", "987 654 321,000001 €", "Евро", "€"],
|
|
||||||
["USD", "-0.5", "-0,5 $", "Доллар США", "$"],
|
|
||||||
["CAD", "20.00", "20,00 CAD", "CAD", "CAD"],
|
|
||||||
["XYZ", "1.000", "1,000 XYZ", "XYZ", "XYZ"],
|
|
||||||
])(
|
|
||||||
"preserves %s %s and its currency identity",
|
|
||||||
(currency, value, expected, name, symbol) => {
|
|
||||||
render(
|
|
||||||
<MantineProvider>
|
|
||||||
<CurrencyCards amounts={[{ currency, value }]} />
|
|
||||||
</MantineProvider>,
|
|
||||||
);
|
|
||||||
const term = screen.getByRole("term");
|
|
||||||
expect(term).toHaveTextContent(name);
|
|
||||||
// eslint-disable-next-line testing-library/no-node-access -- This assertion checks DOM structure, decoration or focus behavior that semantic queries cannot establish.
|
|
||||||
expect(term.querySelector("[aria-hidden=\"true\"]")).toHaveTextContent(
|
|
||||||
symbol,
|
|
||||||
);
|
|
||||||
expect(screen.getByRole("definition")).toHaveTextContent(expected);
|
|
||||||
// eslint-disable-next-line testing-library/no-node-access -- This assertion checks DOM structure, decoration or focus behavior that semantic queries cannot establish.
|
|
||||||
expect(term.parentElement).toBe(
|
|
||||||
// eslint-disable-next-line testing-library/no-node-access -- This assertion checks DOM structure, decoration or focus behavior that semantic queries cannot establish.
|
|
||||||
screen.getByRole("definition").parentElement,
|
|
||||||
);
|
|
||||||
},
|
|
||||||
);
|
|
||||||
});
|
|
||||||
@@ -1,74 +0,0 @@
|
|||||||
import type { FC } from "react";
|
|
||||||
|
|
||||||
import { Paper, SimpleGrid, Text, VisuallyHidden } from "@mantine/core";
|
|
||||||
import { useTranslation } from "react-i18next";
|
|
||||||
|
|
||||||
import type { Portfolio } from "@/entities/portfolio";
|
|
||||||
|
|
||||||
import { formatDecimal } from "@/shared/lib";
|
|
||||||
|
|
||||||
import classes from "../../AccountPage.module.css";
|
|
||||||
|
|
||||||
const SIGN_PREFIX_LENGTH = 2;
|
|
||||||
|
|
||||||
type CurrencyCardsProps = {
|
|
||||||
amounts: Portfolio["totalsByCurrency"];
|
|
||||||
};
|
|
||||||
|
|
||||||
const CurrencyCards: FC<CurrencyCardsProps> = (props) => {
|
|
||||||
const { t } = useTranslation();
|
|
||||||
const { amounts } = props;
|
|
||||||
|
|
||||||
const currencies: Record<string, { name: string; symbol: string }> = {
|
|
||||||
EUR: { name: t("portfolio.currencies.EUR"), symbol: "€" },
|
|
||||||
RUB: { name: t("portfolio.currencies.RUB"), symbol: "₽" },
|
|
||||||
USD: { name: t("portfolio.currencies.USD"), symbol: "$" },
|
|
||||||
};
|
|
||||||
|
|
||||||
return (
|
|
||||||
<SimpleGrid cols={{ base: 1, md: 3, sm: 2 }} spacing={10}>
|
|
||||||
{amounts.map((money) => {
|
|
||||||
const amount = formatDecimal(money.value);
|
|
||||||
|
|
||||||
return (
|
|
||||||
<Paper
|
|
||||||
className={classes.total}
|
|
||||||
component="dl"
|
|
||||||
key={money.currency}
|
|
||||||
m={0}
|
|
||||||
withBorder
|
|
||||||
>
|
|
||||||
<Text className={classes.totalBadge} component="dt">
|
|
||||||
<span aria-hidden="true">
|
|
||||||
{currencies[money.currency]?.symbol ?? money.currency}
|
|
||||||
</span>
|
|
||||||
|
|
||||||
<VisuallyHidden>
|
|
||||||
{currencies[money.currency]?.name ?? money.currency}
|
|
||||||
</VisuallyHidden>
|
|
||||||
</Text>
|
|
||||||
|
|
||||||
<Text className={classes.totalAmount} component="dd" m={0}>
|
|
||||||
{amount.startsWith("-")
|
|
||||||
? (
|
|
||||||
<>
|
|
||||||
<span className={classes.totalLeadingDigits}>
|
|
||||||
{amount.slice(0, SIGN_PREFIX_LENGTH)}
|
|
||||||
</span>
|
|
||||||
|
|
||||||
{amount.slice(SIGN_PREFIX_LENGTH)}
|
|
||||||
</>
|
|
||||||
)
|
|
||||||
: (
|
|
||||||
amount
|
|
||||||
)}{" "}
|
|
||||||
{currencies[money.currency]?.symbol ?? money.currency}
|
|
||||||
</Text>
|
|
||||||
</Paper>
|
|
||||||
);
|
|
||||||
})}
|
|
||||||
</SimpleGrid>
|
|
||||||
);
|
|
||||||
};
|
|
||||||
|
|
||||||
export { CurrencyCards };
|
|
||||||
@@ -64,16 +64,14 @@ const IncomeSummary: FC<IncomeSummaryProps> = (props) => {
|
|||||||
|
|
||||||
return (
|
return (
|
||||||
<Stack gap="xs">
|
<Stack gap="xs">
|
||||||
{props.summary.totalsByCurrency.map(total => (
|
<Paper p="sm" withBorder>
|
||||||
<Paper key={total.currency} p="sm" withBorder>
|
<Text fw={700}>{formatMoney(props.summary.total.total)}</Text>
|
||||||
<Text fw={700}>{formatMoney(total.total)}</Text>
|
|
||||||
|
|
||||||
<Text c="dimmed" size="sm">
|
<Text c="dimmed" size="sm">
|
||||||
{t("income.coupon")}: {formatMoney(total.coupon)} ·{" "}
|
{t("income.coupon")}: {formatMoney(props.summary.total.coupon)} ·{" "}
|
||||||
{t("income.dividend")}: {formatMoney(total.dividend)}
|
{t("income.dividend")}: {formatMoney(props.summary.total.dividend)}
|
||||||
</Text>
|
</Text>
|
||||||
</Paper>
|
</Paper>
|
||||||
))}
|
|
||||||
|
|
||||||
<Button component={Link} to={props.to} variant="subtle">
|
<Button component={Link} to={props.to} variant="subtle">
|
||||||
{props.moreLabel ?? t("income.open")}
|
{props.moreLabel ?? t("income.open")}
|
||||||
|
|||||||
@@ -0,0 +1,3 @@
|
|||||||
|
.positive { color: var(--wl-color-positive); }
|
||||||
|
.negative { color: var(--wl-color-negative); }
|
||||||
|
.neutral { color: var(--mantine-color-dark-7); }
|
||||||
@@ -0,0 +1,106 @@
|
|||||||
|
import type { Meta, StoryObj } from "@storybook/react-vite";
|
||||||
|
|
||||||
|
import type { Performance } from "@/entities/performance";
|
||||||
|
|
||||||
|
import { PerformanceView } from "./Performance.view";
|
||||||
|
|
||||||
|
const rub = (value: string) => ({ currency: "RUB", value });
|
||||||
|
|
||||||
|
const series = Array.from({ length: 24 }, (_, month) => {
|
||||||
|
const date = new Date(Date.UTC(2024, month, 1)).toISOString().slice(0, 10);
|
||||||
|
const invested = 300_000 + Math.floor(month / 6) * 150_000;
|
||||||
|
|
||||||
|
return {
|
||||||
|
benchmarkValue: String(Math.round(invested * (1 + month * 0.009))),
|
||||||
|
date,
|
||||||
|
netInvested: String(invested),
|
||||||
|
referenceValue: String(Math.round(invested * (1 + month * 0.004))),
|
||||||
|
};
|
||||||
|
});
|
||||||
|
|
||||||
|
const data: Performance = {
|
||||||
|
accountId: "account-1",
|
||||||
|
benchmark: {
|
||||||
|
asOf: "2025-12-01",
|
||||||
|
code: "MCFTRR",
|
||||||
|
return: { basis: "annual", unavailableReason: null, value: "0.108" },
|
||||||
|
unavailableReason: null,
|
||||||
|
value: rub("1387973"),
|
||||||
|
},
|
||||||
|
calculatedAt: "2025-12-01T00:00:00Z",
|
||||||
|
completeness: "complete",
|
||||||
|
currentValue: rub("1536400"),
|
||||||
|
excludedAccounts: [],
|
||||||
|
netInvested: rub("1060000"),
|
||||||
|
outperformance: { money: rub("148427"), percentagePoints: "0.043" },
|
||||||
|
period: { days: 700, from: "2024-01-01", to: "2025-12-01" },
|
||||||
|
profit: rub("476400"),
|
||||||
|
reference: {
|
||||||
|
asOf: "2025-12-01",
|
||||||
|
code: "IMOEX",
|
||||||
|
return: { basis: "annual", unavailableReason: null, value: "0.047" },
|
||||||
|
unavailableReason: null,
|
||||||
|
value: rub("1150000"),
|
||||||
|
},
|
||||||
|
return: { basis: "annual", unavailableReason: null, value: "0.151" },
|
||||||
|
series,
|
||||||
|
};
|
||||||
|
|
||||||
|
const meta = {
|
||||||
|
args: { data },
|
||||||
|
component: PerformanceView,
|
||||||
|
parameters: {
|
||||||
|
docs: {
|
||||||
|
description: {
|
||||||
|
component:
|
||||||
|
"Вкладка «Результат»: доходность, прибыль, те же деньги в индексе Мосбиржи и опережение. Синтетический серверный ответ без расчётов на клиенте.",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
tags: ["autodocs"],
|
||||||
|
title: "Product/Performance",
|
||||||
|
} satisfies Meta<typeof PerformanceView>;
|
||||||
|
|
||||||
|
export default meta;
|
||||||
|
|
||||||
|
type Story = StoryObj<typeof meta>;
|
||||||
|
|
||||||
|
export const Ahead: Story = {};
|
||||||
|
|
||||||
|
export const Behind: Story = {
|
||||||
|
args: {
|
||||||
|
data: {
|
||||||
|
...data,
|
||||||
|
currentValue: rub("1172400"),
|
||||||
|
outperformance: { money: rub("-215573"), percentagePoints: "-0.068" },
|
||||||
|
profit: rub("112400"),
|
||||||
|
return: { basis: "annual", unavailableReason: null, value: "0.04" },
|
||||||
|
},
|
||||||
|
},
|
||||||
|
};
|
||||||
|
|
||||||
|
export const ShortHistory: Story = {
|
||||||
|
args: {
|
||||||
|
data: {
|
||||||
|
...data,
|
||||||
|
benchmark: {
|
||||||
|
...data.benchmark,
|
||||||
|
return: { basis: "period", unavailableReason: null, value: "0.112" },
|
||||||
|
},
|
||||||
|
period: { days: 277, from: "2025-02-27", to: "2025-12-01" },
|
||||||
|
return: { basis: "period", unavailableReason: null, value: "0.074" },
|
||||||
|
},
|
||||||
|
},
|
||||||
|
};
|
||||||
|
|
||||||
|
export const Incomplete: Story = {
|
||||||
|
args: {
|
||||||
|
data: {
|
||||||
|
...data,
|
||||||
|
completeness: "incomplete",
|
||||||
|
excludedAccounts: [
|
||||||
|
{ accountId: "usd", name: "Валютный", reason: "PORTFOLIO_VALUATION_INCOMPLETE" },
|
||||||
|
],
|
||||||
|
},
|
||||||
|
},
|
||||||
|
};
|
||||||
@@ -0,0 +1,185 @@
|
|||||||
|
import { LineChart } from "@mantine/charts";
|
||||||
|
import {
|
||||||
|
Accordion,
|
||||||
|
ActionIcon,
|
||||||
|
Alert,
|
||||||
|
Group,
|
||||||
|
Paper,
|
||||||
|
SimpleGrid,
|
||||||
|
Stack,
|
||||||
|
Text,
|
||||||
|
Title,
|
||||||
|
Tooltip,
|
||||||
|
} from "@mantine/core";
|
||||||
|
import { useTranslation } from "react-i18next";
|
||||||
|
|
||||||
|
import type { Performance } from "@/entities/performance";
|
||||||
|
|
||||||
|
import { formatChartValue, formatDate } from "@/shared/lib";
|
||||||
|
|
||||||
|
import { performanceVm } from "../../../../model/performance";
|
||||||
|
import classes from "./Performance.module.css";
|
||||||
|
|
||||||
|
const formatRub = (value: number) => `${formatChartValue(Math.round(value))} ₽`;
|
||||||
|
|
||||||
|
function PerformanceView({ data }: Readonly<{ data: Performance }>) {
|
||||||
|
const { t } = useTranslation();
|
||||||
|
const vm = performanceVm(data);
|
||||||
|
|
||||||
|
const basis = vm.basis === "annual"
|
||||||
|
? t("portfolio.performance.yearly")
|
||||||
|
: t("portfolio.performance.periodLabel", { days: vm.days });
|
||||||
|
|
||||||
|
const comparisonTone = vm.comparison?.points.tone ?? "neutral";
|
||||||
|
let comparisonTitle = t("portfolio.performance.marketEqual");
|
||||||
|
if (comparisonTone === "positive") comparisonTitle = t("portfolio.performance.marketAhead");
|
||||||
|
else if (comparisonTone === "negative") comparisonTitle = t("portfolio.performance.marketBehind");
|
||||||
|
const percentText = vm.returnValue.value;
|
||||||
|
const indexText = vm.indexReturn.value;
|
||||||
|
|
||||||
|
const currentLines = vm.currentPoint
|
||||||
|
? [{ color: "blue.6", label: t("portfolio.performance.current"), x: vm.currentPoint.date }]
|
||||||
|
: [];
|
||||||
|
|
||||||
|
const profitCaption = t("portfolio.performance.profitCaption", { current: vm.current, invested: vm.invested });
|
||||||
|
|
||||||
|
const chartLabel = [
|
||||||
|
`${t("portfolio.performance.invested")}: ${vm.invested}`,
|
||||||
|
`${t("portfolio.performance.benchmark")}: ${vm.indexValue}`,
|
||||||
|
`${t("portfolio.performance.current")}: ${vm.current}`,
|
||||||
|
`${t("portfolio.performance.returnLabel")}: ${percentText}`,
|
||||||
|
].join("; ");
|
||||||
|
|
||||||
|
return (
|
||||||
|
<Stack gap="md">
|
||||||
|
{vm.excluded.length > 0 && (
|
||||||
|
<Alert role="status" title={t("portfolio.performance.incomplete")}>
|
||||||
|
{vm.excluded.map(item => (
|
||||||
|
<Text key={item.id} size="sm">
|
||||||
|
{t("portfolio.performance.unavailableReason", item)}
|
||||||
|
</Text>
|
||||||
|
))}
|
||||||
|
</Alert>
|
||||||
|
)}
|
||||||
|
|
||||||
|
{vm.basis === "period" && (
|
||||||
|
<Alert role="status">
|
||||||
|
{t("portfolio.performance.periodNote", { days: vm.days })}
|
||||||
|
</Alert>
|
||||||
|
)}
|
||||||
|
|
||||||
|
<SimpleGrid cols={{ base: 1, lg: 4, sm: 2 }}>
|
||||||
|
<Paper component="dl" m={0} p="md" withBorder>
|
||||||
|
<Text component="dt" size="sm">{t("portfolio.performance.returnLabel")}</Text>
|
||||||
|
|
||||||
|
<Text className={classes[vm.returnValue.tone]} component="dd" fw={700} m={0} size="xl">
|
||||||
|
{percentText}
|
||||||
|
</Text>
|
||||||
|
|
||||||
|
<Text c="dimmed" size="xs">{vm.returnReason ?? basis}</Text>
|
||||||
|
</Paper>
|
||||||
|
|
||||||
|
<Paper component="dl" m={0} p="md" withBorder>
|
||||||
|
<Text component="dt" size="sm">{t("portfolio.performance.profit")}</Text>
|
||||||
|
|
||||||
|
<Text className={classes[vm.profit.tone]} component="dd" fw={700} m={0} size="xl">
|
||||||
|
{vm.profit.value}
|
||||||
|
</Text>
|
||||||
|
|
||||||
|
<Text c="dimmed" size="xs">{profitCaption}</Text>
|
||||||
|
</Paper>
|
||||||
|
|
||||||
|
<Paper component="dl" m={0} p="md" withBorder>
|
||||||
|
<Group gap="xs">
|
||||||
|
<Text component="dt" size="sm">{t("portfolio.performance.benchmark")}</Text>
|
||||||
|
|
||||||
|
<Tooltip
|
||||||
|
events={{ focus: true, hover: true, touch: true }}
|
||||||
|
label={t("portfolio.performance.benchmarkHint")}
|
||||||
|
multiline
|
||||||
|
w={280}
|
||||||
|
>
|
||||||
|
<ActionIcon
|
||||||
|
aria-label={t("portfolio.performance.benchmarkHint")}
|
||||||
|
size="xs"
|
||||||
|
variant="subtle"
|
||||||
|
>?
|
||||||
|
</ActionIcon>
|
||||||
|
</Tooltip>
|
||||||
|
</Group>
|
||||||
|
|
||||||
|
<Text component="dd" fw={700} m={0} size="xl">{indexText}</Text>
|
||||||
|
|
||||||
|
<Text c="dimmed" size="xs">
|
||||||
|
{vm.indexReason ?? `${basis} · ${vm.indexValue}`}
|
||||||
|
</Text>
|
||||||
|
</Paper>
|
||||||
|
|
||||||
|
<Paper component="dl" m={0} p="md" withBorder>
|
||||||
|
<Text component="dt" size="sm">
|
||||||
|
{comparisonTitle}
|
||||||
|
</Text>
|
||||||
|
|
||||||
|
<Text
|
||||||
|
className={classes[vm.comparison?.points.tone ?? "neutral"]}
|
||||||
|
component="dd"
|
||||||
|
fw={700}
|
||||||
|
m={0}
|
||||||
|
size="xl"
|
||||||
|
>
|
||||||
|
{vm.comparison?.points.value ?? "—"}
|
||||||
|
</Text>
|
||||||
|
|
||||||
|
<Text c="dimmed" size="xs">{vm.comparison?.money.value ?? vm.indexReason ?? vm.returnReason}</Text>
|
||||||
|
</Paper>
|
||||||
|
</SimpleGrid>
|
||||||
|
|
||||||
|
<Paper component="section" p="md" withBorder>
|
||||||
|
<Title mb="sm" order={2} size="h4">{t("portfolio.performance.chartTitle")}</Title>
|
||||||
|
|
||||||
|
{vm.series.length > 0
|
||||||
|
? (
|
||||||
|
<LineChart
|
||||||
|
aria-label={chartLabel}
|
||||||
|
curveType="linear"
|
||||||
|
data={vm.series}
|
||||||
|
dataKey="label"
|
||||||
|
gridAxis="y"
|
||||||
|
h={{ base: 220, sm: 300 }}
|
||||||
|
lineProps={{ isAnimationActive: false }}
|
||||||
|
referenceLines={currentLines}
|
||||||
|
series={[
|
||||||
|
{ color: "dark.4", label: t("portfolio.performance.invested"), name: "netInvested" },
|
||||||
|
{ color: "orange.6", label: t("portfolio.performance.benchmark"), name: "benchmarkValue" },
|
||||||
|
{ color: "gray.5", label: t("portfolio.performance.reference"), name: "referenceValue", strokeDasharray: "4 3" },
|
||||||
|
]}
|
||||||
|
tooltipAnimationDuration={0}
|
||||||
|
valueFormatter={formatRub}
|
||||||
|
yAxisProps={{ domain: [0, "auto"], width: 70 }}
|
||||||
|
/>
|
||||||
|
)
|
||||||
|
: <Text c="dimmed">{t("portfolio.performance.benchmarkUnavailable")}</Text>}
|
||||||
|
|
||||||
|
<Text c="dimmed" mt="sm" size="sm">
|
||||||
|
{t("portfolio.performance.missingHistory")}
|
||||||
|
</Text>
|
||||||
|
</Paper>
|
||||||
|
|
||||||
|
<Accordion variant="contained">
|
||||||
|
<Accordion.Item value="method">
|
||||||
|
<Accordion.Control>{t("portfolio.performance.calculation")}</Accordion.Control>
|
||||||
|
|
||||||
|
<Accordion.Panel>
|
||||||
|
<Text size="sm">
|
||||||
|
{t("portfolio.performance.datePeriod", { from: formatDate(`${vm.from}T00:00:00Z`), to: formatDate(`${vm.to}T00:00:00Z`) })}
|
||||||
|
</Text>
|
||||||
|
|
||||||
|
<Text mt="sm" size="sm">{t("portfolio.performance.method")}</Text>
|
||||||
|
</Accordion.Panel>
|
||||||
|
</Accordion.Item>
|
||||||
|
</Accordion>
|
||||||
|
</Stack>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
export { PerformanceView };
|
||||||
@@ -0,0 +1,193 @@
|
|||||||
|
import { MantineProvider } from "@mantine/core";
|
||||||
|
import { QueryClientProvider } from "@tanstack/react-query";
|
||||||
|
import { fireEvent, render, screen } from "@testing-library/react";
|
||||||
|
import { http, HttpResponse, type JsonBodyType } from "msw";
|
||||||
|
import { describe, expect, it, vi } from "vitest";
|
||||||
|
|
||||||
|
import type { Performance } from "@/entities/performance";
|
||||||
|
|
||||||
|
import { configureAuthClient } from "@/shared/api";
|
||||||
|
import { createTestQueryClient } from "@/test/query";
|
||||||
|
import { server } from "@/test/server";
|
||||||
|
|
||||||
|
import { PerformanceTab } from "./PerformanceTab";
|
||||||
|
|
||||||
|
const url = "*/api/v1/brokerage-accounts/:accountId/performance";
|
||||||
|
|
||||||
|
const rub = (value: string) => ({ currency: "RUB", value });
|
||||||
|
|
||||||
|
function performance(overrides: Partial<Performance> = {}): Performance {
|
||||||
|
return {
|
||||||
|
accountId: "account-1",
|
||||||
|
benchmark: {
|
||||||
|
asOf: "2025-12-31",
|
||||||
|
code: "MCFTRR",
|
||||||
|
return: { basis: "annual", unavailableReason: null, value: "0.048809" },
|
||||||
|
unavailableReason: null,
|
||||||
|
value: rub("110000"),
|
||||||
|
},
|
||||||
|
calculatedAt: "2026-01-01T00:00:00Z",
|
||||||
|
completeness: "complete",
|
||||||
|
currentValue: rub("121000"),
|
||||||
|
excludedAccounts: [],
|
||||||
|
netInvested: rub("100000"),
|
||||||
|
outperformance: { money: rub("11000"), percentagePoints: "0.051191" },
|
||||||
|
period: { days: 730, from: "2024-01-01", to: "2025-12-31" },
|
||||||
|
profit: rub("21000"),
|
||||||
|
reference: {
|
||||||
|
asOf: "2025-12-31",
|
||||||
|
code: "IMOEX",
|
||||||
|
return: { basis: "annual", unavailableReason: null, value: "0.02" },
|
||||||
|
unavailableReason: null,
|
||||||
|
value: rub("105000"),
|
||||||
|
},
|
||||||
|
return: { basis: "annual", unavailableReason: null, value: "0.1" },
|
||||||
|
series: [
|
||||||
|
{ benchmarkValue: "100000", date: "2024-01-01", netInvested: "100000", referenceValue: "100000" },
|
||||||
|
{ benchmarkValue: "110000", date: "2025-12-31", netInvested: "100000", referenceValue: "105000" },
|
||||||
|
],
|
||||||
|
...overrides,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
function renderTab(body: JsonBodyType, status = 200) {
|
||||||
|
configureAuthClient({
|
||||||
|
accessToken: () => "test-token",
|
||||||
|
clear: vi.fn(),
|
||||||
|
refresh: () => Promise.resolve(true),
|
||||||
|
});
|
||||||
|
server.use(http.get(url, () => HttpResponse.json(body, { status })));
|
||||||
|
|
||||||
|
return render(
|
||||||
|
<QueryClientProvider client={createTestQueryClient()}>
|
||||||
|
<MantineProvider>
|
||||||
|
<PerformanceTab accountId="account-1" />
|
||||||
|
</MantineProvider>
|
||||||
|
</QueryClientProvider>,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
const meta = { dependencies: [], unavailable: [] };
|
||||||
|
|
||||||
|
describe("PerformanceTab", () => {
|
||||||
|
it("shows return, profit, the same money in the index and outperformance with signs", async () => {
|
||||||
|
renderTab({ data: performance(), meta });
|
||||||
|
|
||||||
|
expect(await screen.findByText("+10,0 %")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("+21 000 ₽")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("+4,9 %")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("Опережение рынка")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("+5,1 п.п.")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("+11 000 ₽")).toBeInTheDocument();
|
||||||
|
// Index codes are allowed only inside "Как считали", not as captions.
|
||||||
|
expect(screen.getByText("Те же деньги в индексе Мосбиржи")).toBeInTheDocument();
|
||||||
|
expect(screen.queryByText("MCFTRR")).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("labels lagging the market without colour-only meaning", async () => {
|
||||||
|
renderTab({
|
||||||
|
data: performance({
|
||||||
|
outperformance: { money: rub("-5000"), percentagePoints: "-0.02" },
|
||||||
|
}),
|
||||||
|
meta,
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(await screen.findByText("Отставание от рынка")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("−2,0 п.п.")).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("never says annual when history is shorter than a year", async () => {
|
||||||
|
renderTab({
|
||||||
|
data: performance({
|
||||||
|
benchmark: { ...performance().benchmark, return: { basis: "period", unavailableReason: null, value: "0.05" } },
|
||||||
|
period: { days: 200, from: "2025-06-14", to: "2025-12-31" },
|
||||||
|
return: { basis: "period", unavailableReason: null, value: "0.07" },
|
||||||
|
}),
|
||||||
|
meta,
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(await screen.findByText(/проценты показаны за 200 дн\./)).toBeInTheDocument();
|
||||||
|
expect(screen.queryByText(/годовых/)).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("lists excluded accounts when the all-accounts result is incomplete", async () => {
|
||||||
|
renderTab({
|
||||||
|
data: performance({
|
||||||
|
completeness: "incomplete",
|
||||||
|
excludedAccounts: [{ accountId: "usd", name: "Валютный", reason: "PORTFOLIO_VALUATION_INCOMPLETE" }],
|
||||||
|
}),
|
||||||
|
meta,
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(await screen.findByText("Результат неполный")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("Валютный: Нет полной оценки портфеля")).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("explains unavailability instead of showing zeros, including unknown reasons", async () => {
|
||||||
|
renderTab({
|
||||||
|
data: null,
|
||||||
|
meta: {
|
||||||
|
dependencies: [],
|
||||||
|
unavailable: [
|
||||||
|
{ accountId: "iis", name: "ИИС", reason: "HISTORY_START_UNKNOWN" },
|
||||||
|
{ accountId: "x", name: "Новый", reason: "SOMETHING_NEW" },
|
||||||
|
],
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(await screen.findByText("Доходность недоступна")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("ИИС: Начало истории счёта неизвестно")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("Новый: Причину недоступности не удалось определить")).toBeInTheDocument();
|
||||||
|
expect(screen.queryByText(/0,0 %/)).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("keeps profit and hides the comparison when the index is unavailable", async () => {
|
||||||
|
renderTab({
|
||||||
|
data: performance({
|
||||||
|
benchmark: {
|
||||||
|
asOf: null,
|
||||||
|
code: "MCFTRR",
|
||||||
|
return: { basis: "annual", unavailableReason: "INDEX_HISTORY_UNAVAILABLE", value: null },
|
||||||
|
unavailableReason: "INDEX_HISTORY_UNAVAILABLE",
|
||||||
|
value: null,
|
||||||
|
},
|
||||||
|
outperformance: null,
|
||||||
|
series: [],
|
||||||
|
}),
|
||||||
|
meta,
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(await screen.findByText("+21 000 ₽")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("Сравнение с индексом сейчас недоступно")).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("does not colour or call a rounded-to-zero difference outperformance", async () => {
|
||||||
|
renderTab({
|
||||||
|
data: performance({
|
||||||
|
outperformance: { money: rub("0"), percentagePoints: "-0.0004" },
|
||||||
|
}),
|
||||||
|
meta,
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(await screen.findByText("Сравнение с рынком")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("0,0 п.п.")).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("explains a pending sync when no account reasons are available", async () => {
|
||||||
|
renderTab({ data: null, meta });
|
||||||
|
|
||||||
|
expect(await screen.findByText(/ещё синхронизируются/)).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("shows a local error with retry", async () => {
|
||||||
|
renderTab({ code: "INTERNAL_SERVER_ERROR", status: 500 }, 500);
|
||||||
|
|
||||||
|
expect(await screen.findByText("Не удалось загрузить результат инвестирования", {}, { timeout: 8000 })).toBeInTheDocument();
|
||||||
|
server.use(http.get(
|
||||||
|
url,
|
||||||
|
() => HttpResponse.json({ data: performance(), meta }),
|
||||||
|
));
|
||||||
|
fireEvent.click(screen.getByRole("button", { name: "Повторить" }));
|
||||||
|
expect(await screen.findByText("+10,0 %")).toBeInTheDocument();
|
||||||
|
}, 10_000);
|
||||||
|
});
|
||||||
@@ -0,0 +1,66 @@
|
|||||||
|
import { Button, Paper, SimpleGrid, Skeleton, Stack, Text, Title } from "@mantine/core";
|
||||||
|
import { useTranslation } from "react-i18next";
|
||||||
|
|
||||||
|
import { usePerformance } from "@/entities/performance";
|
||||||
|
|
||||||
|
import { reasonText } from "../../../../model/performance";
|
||||||
|
import { PerformanceView } from "./Performance.view";
|
||||||
|
|
||||||
|
function PerformanceTab({ accountId }: Readonly<{ accountId: string }>) {
|
||||||
|
const { t } = useTranslation();
|
||||||
|
const query = usePerformance(accountId);
|
||||||
|
|
||||||
|
if (query.isPending) return (
|
||||||
|
<Stack aria-label={t("portfolio.performance.returnLabel")} gap="md">
|
||||||
|
<SimpleGrid cols={{ base: 1, lg: 4, sm: 2 }}>
|
||||||
|
{["rate", "profit", "benchmark", "difference"].map(key => (
|
||||||
|
<Paper key={key} p="md" withBorder>
|
||||||
|
<Skeleton h={14} mb="sm" w="60%" />
|
||||||
|
|
||||||
|
<Skeleton h={28} w="80%" />
|
||||||
|
</Paper>
|
||||||
|
))}
|
||||||
|
</SimpleGrid>
|
||||||
|
|
||||||
|
<Skeleton h={220} />
|
||||||
|
</Stack>
|
||||||
|
);
|
||||||
|
|
||||||
|
const onRetry = () => {
|
||||||
|
void query.refetch();
|
||||||
|
};
|
||||||
|
|
||||||
|
if (query.isError) return (
|
||||||
|
<Paper p="lg" withBorder>
|
||||||
|
<Stack align="flex-start" gap="sm">
|
||||||
|
<Text>{t("portfolio.performance.error")}</Text>
|
||||||
|
|
||||||
|
<Button onClick={onRetry} variant="light">
|
||||||
|
{t("portfolio.performance.retry")}
|
||||||
|
</Button>
|
||||||
|
</Stack>
|
||||||
|
</Paper>
|
||||||
|
);
|
||||||
|
if (!query.data.data) return (
|
||||||
|
<Paper p="xl" withBorder>
|
||||||
|
<Title order={2} size="h4">{t("portfolio.performance.unavailable")}</Title>
|
||||||
|
|
||||||
|
{query.data.meta.unavailable.length === 0 && (
|
||||||
|
<Text c="dimmed" mt="sm">{t("portfolio.performance.syncing")}</Text>
|
||||||
|
)}
|
||||||
|
|
||||||
|
{query.data.meta.unavailable.map(item => (
|
||||||
|
<Text c="dimmed" key={item.accountId} mt="sm">
|
||||||
|
{t("portfolio.performance.unavailableReason", {
|
||||||
|
name: item.name,
|
||||||
|
reason: reasonText(item.reason),
|
||||||
|
})}
|
||||||
|
</Text>
|
||||||
|
))}
|
||||||
|
</Paper>
|
||||||
|
);
|
||||||
|
|
||||||
|
return <PerformanceView data={query.data.data} />;
|
||||||
|
}
|
||||||
|
|
||||||
|
export { PerformanceTab };
|
||||||
+19
-52
@@ -4,20 +4,20 @@ import type { Portfolio } from "@/entities/portfolio";
|
|||||||
|
|
||||||
import { PortfolioStructure } from "./PortfolioStructure";
|
import { PortfolioStructure } from "./PortfolioStructure";
|
||||||
|
|
||||||
const rub: Portfolio["structure"]["currencies"][number] = {
|
const rub: Portfolio["structure"] = {
|
||||||
categories: [
|
categories: [
|
||||||
{ sharePercent: "52", type: "STOCK", value: "650000" },
|
{ sharePercent: "52", type: "STOCK", value: "650000" },
|
||||||
{ sharePercent: "30", type: "BOND", value: "375000" },
|
{ sharePercent: "30", type: "BOND", value: "375000" },
|
||||||
{ sharePercent: "10", type: "OTHER", value: "125000" },
|
{ sharePercent: "10", type: "OTHER", value: "125000" },
|
||||||
{ sharePercent: "8", type: "CASH", value: "100000" },
|
{ sharePercent: "8", type: "CASH", value: "100000" },
|
||||||
],
|
],
|
||||||
currency: "RUB",
|
|
||||||
hasNegativeValues: false,
|
hasNegativeValues: false,
|
||||||
totalValue: "1250000",
|
totalValue: "1250000",
|
||||||
|
unvaluedCategories: [],
|
||||||
};
|
};
|
||||||
|
|
||||||
const meta = {
|
const meta = {
|
||||||
args: { structure: { currencies: [rub], unvaluedCategories: [] } },
|
args: { structure: rub },
|
||||||
component: PortfolioStructure,
|
component: PortfolioStructure,
|
||||||
parameters: {
|
parameters: {
|
||||||
docs: {
|
docs: {
|
||||||
@@ -28,7 +28,7 @@ const meta = {
|
|||||||
},
|
},
|
||||||
},
|
},
|
||||||
tags: ["autodocs"],
|
tags: ["autodocs"],
|
||||||
title: "Widgets/PortfolioStructure",
|
title: "Product/PortfolioStructure",
|
||||||
} satisfies Meta<typeof PortfolioStructure>;
|
} satisfies Meta<typeof PortfolioStructure>;
|
||||||
|
|
||||||
export default meta;
|
export default meta;
|
||||||
@@ -36,60 +36,34 @@ export default meta;
|
|||||||
type Story = StoryObj<typeof meta>;
|
type Story = StoryObj<typeof meta>;
|
||||||
|
|
||||||
export const Regular: Story = {};
|
export const Regular: Story = {};
|
||||||
export const MultipleCurrencies: Story = {
|
|
||||||
args: {
|
|
||||||
structure: {
|
|
||||||
currencies: [
|
|
||||||
rub,
|
|
||||||
{
|
|
||||||
categories: [{ sharePercent: "100", type: "CASH", value: "500" }],
|
|
||||||
currency: "USD",
|
|
||||||
hasNegativeValues: false,
|
|
||||||
totalValue: "500",
|
|
||||||
},
|
|
||||||
],
|
|
||||||
unvaluedCategories: [],
|
|
||||||
},
|
|
||||||
},
|
|
||||||
};
|
|
||||||
export const CashOnly: Story = {
|
export const CashOnly: Story = {
|
||||||
args: {
|
args: {
|
||||||
structure: {
|
structure: {
|
||||||
currencies: [
|
...rub,
|
||||||
{
|
|
||||||
categories: rub.categories.map(row => ({
|
categories: rub.categories.map(row => ({
|
||||||
...row,
|
...row,
|
||||||
sharePercent: row.type === "CASH" ? "100" : "0",
|
sharePercent: row.type === "CASH" ? "100" : "0",
|
||||||
value: row.type === "CASH" ? "100000" : "0",
|
value: row.type === "CASH" ? "100000" : "0",
|
||||||
})),
|
})),
|
||||||
currency: "RUB",
|
|
||||||
hasNegativeValues: false,
|
|
||||||
totalValue: "100000",
|
totalValue: "100000",
|
||||||
},
|
},
|
||||||
],
|
|
||||||
unvaluedCategories: [],
|
|
||||||
},
|
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
export const Empty: Story = {
|
export const Empty: Story = {
|
||||||
args: { structure: { currencies: [], unvaluedCategories: [] } },
|
args: {
|
||||||
|
structure: {
|
||||||
|
categories: [],
|
||||||
|
hasNegativeValues: false,
|
||||||
|
totalValue: "0",
|
||||||
|
unvaluedCategories: [],
|
||||||
|
},
|
||||||
|
},
|
||||||
};
|
};
|
||||||
export const Incomplete: Story = {
|
export const Incomplete: Story = {
|
||||||
args: {
|
args: {
|
||||||
structure: {
|
structure: {
|
||||||
currencies: [
|
|
||||||
{
|
|
||||||
...rub,
|
...rub,
|
||||||
categories: rub.categories.map(
|
categories: rub.categories.map(row => ({ ...row, sharePercent: null })),
|
||||||
|
|
||||||
row =>
|
|
||||||
({
|
|
||||||
...row,
|
|
||||||
sharePercent: null,
|
|
||||||
}),
|
|
||||||
),
|
|
||||||
},
|
|
||||||
],
|
|
||||||
unvaluedCategories: [{ count: 2, type: "STOCK" }],
|
unvaluedCategories: [{ count: 2, type: "STOCK" }],
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
@@ -97,7 +71,9 @@ export const Incomplete: Story = {
|
|||||||
export const UnknownOnly: Story = {
|
export const UnknownOnly: Story = {
|
||||||
args: {
|
args: {
|
||||||
structure: {
|
structure: {
|
||||||
currencies: [],
|
categories: [],
|
||||||
|
hasNegativeValues: false,
|
||||||
|
totalValue: "0",
|
||||||
unvaluedCategories: [{ count: 1, type: "BOND" }],
|
unvaluedCategories: [{ count: 1, type: "BOND" }],
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
@@ -105,23 +81,14 @@ export const UnknownOnly: Story = {
|
|||||||
export const Negative: Story = {
|
export const Negative: Story = {
|
||||||
args: {
|
args: {
|
||||||
structure: {
|
structure: {
|
||||||
currencies: [
|
|
||||||
{
|
|
||||||
...rub,
|
...rub,
|
||||||
categories: rub.categories.map(
|
categories: rub.categories.map(row => ({
|
||||||
|
|
||||||
row =>
|
|
||||||
({
|
|
||||||
...row,
|
...row,
|
||||||
sharePercent: null,
|
sharePercent: null,
|
||||||
value: row.type === "OTHER" ? "25000" : row.value,
|
value: row.type === "OTHER" ? "25000" : row.value,
|
||||||
}),
|
})),
|
||||||
),
|
|
||||||
hasNegativeValues: true,
|
hasNegativeValues: true,
|
||||||
totalValue: "1150000",
|
totalValue: "1150000",
|
||||||
},
|
},
|
||||||
],
|
|
||||||
unvaluedCategories: [],
|
|
||||||
},
|
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
+15
-42
@@ -1,21 +1,21 @@
|
|||||||
import { MantineProvider } from "@mantine/core";
|
import { MantineProvider } from "@mantine/core";
|
||||||
import { fireEvent, render, screen, within } from "@testing-library/react";
|
import { render, screen, within } from "@testing-library/react";
|
||||||
import { describe, expect, it } from "vitest";
|
import { describe, expect, it } from "vitest";
|
||||||
|
|
||||||
import type { Portfolio } from "@/entities/portfolio";
|
import type { Portfolio } from "@/entities/portfolio";
|
||||||
|
|
||||||
import { PortfolioStructure } from "./PortfolioStructure";
|
import { PortfolioStructure } from "./PortfolioStructure";
|
||||||
|
|
||||||
const rub: Portfolio["structure"]["currencies"][number] = {
|
const rub: Portfolio["structure"] = {
|
||||||
categories: [
|
categories: [
|
||||||
{ sharePercent: "60", type: "STOCK", value: "60" },
|
{ sharePercent: "60", type: "STOCK", value: "60" },
|
||||||
{ sharePercent: "20", type: "BOND", value: "20" },
|
{ sharePercent: "20", type: "BOND", value: "20" },
|
||||||
{ sharePercent: "0", type: "OTHER", value: "0" },
|
{ sharePercent: "0", type: "OTHER", value: "0" },
|
||||||
{ sharePercent: "20", type: "CASH", value: "20" },
|
{ sharePercent: "20", type: "CASH", value: "20" },
|
||||||
],
|
],
|
||||||
currency: "RUB",
|
|
||||||
hasNegativeValues: false,
|
hasNegativeValues: false,
|
||||||
totalValue: "100",
|
totalValue: "100",
|
||||||
|
unvaluedCategories: [],
|
||||||
};
|
};
|
||||||
|
|
||||||
const ui = (structure: null | Portfolio["structure"] | undefined) => (
|
const ui = (structure: null | Portfolio["structure"] | undefined) => (
|
||||||
@@ -39,7 +39,7 @@ describe("portfolio structure", () => {
|
|||||||
screen.queryByText(/Нет положительной стоимости/),
|
screen.queryByText(/Нет положительной стоимости/),
|
||||||
).not.toBeInTheDocument();
|
).not.toBeInTheDocument();
|
||||||
expect(screen.queryByRole("list")).not.toBeInTheDocument();
|
expect(screen.queryByRole("list")).not.toBeInTheDocument();
|
||||||
view.rerender(ui({ currencies: [rub], unvaluedCategories: [] }));
|
view.rerender(ui(rub));
|
||||||
expect(screen.getByRole("list")).toHaveTextContent("Акции60 ₽60 %");
|
expect(screen.getByRole("list")).toHaveTextContent("Акции60 ₽60 %");
|
||||||
expect(
|
expect(
|
||||||
screen.queryByText("Данные о структуре портфеля пока недоступны."),
|
screen.queryByText("Данные о структуре портфеля пока недоступны."),
|
||||||
@@ -47,41 +47,23 @@ describe("portfolio structure", () => {
|
|||||||
},
|
},
|
||||||
);
|
);
|
||||||
it("shows exact server amounts and cash-inclusive shares without hovering", () => {
|
it("shows exact server amounts and cash-inclusive shares without hovering", () => {
|
||||||
render(ui({ currencies: [rub], unvaluedCategories: [] }));
|
render(ui(rub));
|
||||||
const list = screen.getByRole("list", { name: "Категории активов" });
|
const list = screen.getByRole("list", { name: "Категории активов" });
|
||||||
expect(list).toHaveTextContent("Акции60 ₽60 %");
|
expect(list).toHaveTextContent("Акции60 ₽60 %");
|
||||||
expect(list).toHaveTextContent("Свободные деньги20 ₽20 %");
|
expect(list).toHaveTextContent("Свободные деньги20 ₽20 %");
|
||||||
expect(screen.queryByRole("combobox")).not.toBeInTheDocument();
|
expect(screen.queryByRole("combobox")).not.toBeInTheDocument();
|
||||||
});
|
});
|
||||||
it("switches currencies and falls back when a refresh removes the selection", () => {
|
|
||||||
const usd = { ...rub, currency: "USD" };
|
|
||||||
const view = render(ui({ currencies: [rub, usd], unvaluedCategories: [] }));
|
|
||||||
fireEvent.click(
|
|
||||||
screen.getByRole("combobox", { name: "Валюта структуры портфеля" }),
|
|
||||||
);
|
|
||||||
fireEvent.click(screen.getByRole("option", { name: "USD" }));
|
|
||||||
expect(screen.getByRole("list")).toHaveTextContent("60 USD");
|
|
||||||
expect(screen.getByRole("list")).not.toHaveTextContent("₽");
|
|
||||||
view.rerender(ui({ currencies: [rub], unvaluedCategories: [] }));
|
|
||||||
expect(screen.getByRole("list")).toHaveTextContent("60 ₽");
|
|
||||||
expect(screen.queryByRole("combobox")).not.toBeInTheDocument();
|
|
||||||
});
|
|
||||||
it("retains known amounts and names unvalued categories without inventing a zero", () => {
|
it("retains known amounts and names unvalued categories without inventing a zero", () => {
|
||||||
render(
|
render(
|
||||||
ui({
|
ui({
|
||||||
currencies: [
|
|
||||||
{
|
|
||||||
...rub,
|
...rub,
|
||||||
categories: rub.categories.map(
|
categories: rub.categories.map(
|
||||||
|
|
||||||
row =>
|
row =>
|
||||||
({
|
({
|
||||||
...row,
|
...row,
|
||||||
sharePercent: null,
|
sharePercent: null,
|
||||||
}),
|
}),
|
||||||
),
|
),
|
||||||
},
|
|
||||||
],
|
|
||||||
unvaluedCategories: [
|
unvaluedCategories: [
|
||||||
{ count: 2, type: "OTHER" },
|
{ count: 2, type: "OTHER" },
|
||||||
{ count: 1, type: "STOCK" },
|
{ count: 1, type: "STOCK" },
|
||||||
@@ -89,10 +71,8 @@ describe("portfolio structure", () => {
|
|||||||
}),
|
}),
|
||||||
);
|
);
|
||||||
expect(screen.getByText(/Оценка неполная/)).toBeInTheDocument();
|
expect(screen.getByText(/Оценка неполная/)).toBeInTheDocument();
|
||||||
expect(screen.getByRole("list")).toHaveTextContent("Известно: 60 ₽");
|
expect(screen.getByRole("list")).toHaveTextContent("АкцииИзвестно: 60 ₽");
|
||||||
expect(screen.getByRole("list")).toHaveTextContent(
|
expect(screen.getByRole("list")).toHaveTextContent("Другие активы");
|
||||||
"Другие активыНет оценки",
|
|
||||||
);
|
|
||||||
expect(
|
expect(
|
||||||
screen.queryByLabelText(/Структура по типам/),
|
screen.queryByLabelText(/Структура по типам/),
|
||||||
).not.toBeInTheDocument();
|
).not.toBeInTheDocument();
|
||||||
@@ -100,11 +80,8 @@ describe("portfolio structure", () => {
|
|||||||
it("keeps negative amounts visible without a donut or invented positive shares", () => {
|
it("keeps negative amounts visible without a donut or invented positive shares", () => {
|
||||||
render(
|
render(
|
||||||
ui({
|
ui({
|
||||||
currencies: [
|
|
||||||
{
|
|
||||||
...rub,
|
...rub,
|
||||||
categories: rub.categories.map(
|
categories: rub.categories.map(
|
||||||
|
|
||||||
row =>
|
row =>
|
||||||
({
|
({
|
||||||
...row,
|
...row,
|
||||||
@@ -113,9 +90,6 @@ describe("portfolio structure", () => {
|
|||||||
}),
|
}),
|
||||||
),
|
),
|
||||||
hasNegativeValues: true,
|
hasNegativeValues: true,
|
||||||
},
|
|
||||||
],
|
|
||||||
unvaluedCategories: [],
|
|
||||||
}),
|
}),
|
||||||
);
|
);
|
||||||
expect(screen.getByText(/Есть отрицательные/)).toBeInTheDocument();
|
expect(screen.getByText(/Есть отрицательные/)).toBeInTheDocument();
|
||||||
@@ -128,20 +102,21 @@ describe("portfolio structure", () => {
|
|||||||
).not.toBeInTheDocument();
|
).not.toBeInTheDocument();
|
||||||
});
|
});
|
||||||
it("handles unknown-only and empty compositions", () => {
|
it("handles unknown-only and empty compositions", () => {
|
||||||
const view = render(
|
render(
|
||||||
ui({ currencies: [], unvaluedCategories: [{ count: 1, type: "BOND" }] }),
|
ui({
|
||||||
|
categories: [],
|
||||||
|
hasNegativeValues: false,
|
||||||
|
totalValue: "0",
|
||||||
|
unvaluedCategories: [{ count: 1, type: "BOND" }],
|
||||||
|
}),
|
||||||
);
|
);
|
||||||
|
|
||||||
expect(screen.getByText("Облигации: без оценки — 1")).toBeInTheDocument();
|
expect(screen.getByText("Облигации: без оценки — 1")).toBeInTheDocument();
|
||||||
expect(screen.queryByRole("list")).not.toBeInTheDocument();
|
expect(screen.queryByRole("list")).not.toBeInTheDocument();
|
||||||
view.rerender(ui({ currencies: [], unvaluedCategories: [] }));
|
|
||||||
expect(screen.getByText(/Нет положительной стоимости/)).toBeInTheDocument();
|
|
||||||
});
|
});
|
||||||
it("keeps full decimal amounts and describes tiny shares", () => {
|
it("keeps full decimal amounts and describes tiny shares", () => {
|
||||||
render(
|
render(
|
||||||
ui({
|
ui({
|
||||||
currencies: [
|
|
||||||
{
|
|
||||||
...rub,
|
...rub,
|
||||||
categories: [
|
categories: [
|
||||||
{
|
{
|
||||||
@@ -150,9 +125,7 @@ describe("portfolio structure", () => {
|
|||||||
value: "9007199254740993.000000001",
|
value: "9007199254740993.000000001",
|
||||||
},
|
},
|
||||||
],
|
],
|
||||||
},
|
totalValue: "9007199254740993.000000001",
|
||||||
],
|
|
||||||
unvaluedCategories: [],
|
|
||||||
}),
|
}),
|
||||||
);
|
);
|
||||||
expect(screen.getByRole("list")).toHaveTextContent(
|
expect(screen.getByRole("list")).toHaveTextContent(
|
||||||
+3
-17
@@ -1,5 +1,5 @@
|
|||||||
import { DonutChart } from "@mantine/charts";
|
import { DonutChart } from "@mantine/charts";
|
||||||
import { Box, Group, Paper, Select, Stack, Text, Title } from "@mantine/core";
|
import { Box, Group, Paper, Stack, Text, Title } from "@mantine/core";
|
||||||
import { type FC, useId } from "react";
|
import { type FC, useId } from "react";
|
||||||
import { useTranslation } from "react-i18next";
|
import { useTranslation } from "react-i18next";
|
||||||
|
|
||||||
@@ -7,11 +7,8 @@ import classes from "./PortfolioStructure.module.css";
|
|||||||
|
|
||||||
type PortfolioStructureViewProps = {
|
type PortfolioStructureViewProps = {
|
||||||
chartData: StructureRow[];
|
chartData: StructureRow[];
|
||||||
currencies: string[];
|
|
||||||
currency: null | string;
|
|
||||||
incomplete: boolean;
|
incomplete: boolean;
|
||||||
negative: boolean;
|
negative: boolean;
|
||||||
onCurrencyChange: (currency: null | string) => void;
|
|
||||||
rows: StructureRow[];
|
rows: StructureRow[];
|
||||||
unavailable: boolean;
|
unavailable: boolean;
|
||||||
unvalued: string[];
|
unvalued: string[];
|
||||||
@@ -64,17 +61,6 @@ const PortfolioStructureView: FC<PortfolioStructureViewProps> = (props) => {
|
|||||||
<Title id={titleId} order={2} size="h4">
|
<Title id={titleId} order={2} size="h4">
|
||||||
{t("portfolio.structure.title")}
|
{t("portfolio.structure.title")}
|
||||||
</Title>
|
</Title>
|
||||||
|
|
||||||
{props.currencies.length > 1 && (
|
|
||||||
<Select
|
|
||||||
allowDeselect={false}
|
|
||||||
aria-label={t("portfolio.structure.currency")}
|
|
||||||
data={props.currencies}
|
|
||||||
onChange={props.onCurrencyChange}
|
|
||||||
value={props.currency}
|
|
||||||
w={112}
|
|
||||||
/>
|
|
||||||
)}
|
|
||||||
</Group>
|
</Group>
|
||||||
|
|
||||||
<Text c="dimmed" size="sm">
|
<Text c="dimmed" size="sm">
|
||||||
@@ -110,11 +96,11 @@ const PortfolioStructureView: FC<PortfolioStructureViewProps> = (props) => {
|
|||||||
</Text>
|
</Text>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
<div className={appearanceClass} key={props.currency}>
|
<div className={appearanceClass}>
|
||||||
{props.chartData.length > 0 && (
|
{props.chartData.length > 0 && (
|
||||||
<DonutChart
|
<DonutChart
|
||||||
aria-label={t("portfolio.structure.chartLabel")}
|
aria-label={t("portfolio.structure.chartLabel")}
|
||||||
chartLabel={props.currency ?? undefined}
|
chartLabel="₽"
|
||||||
data={props.chartData}
|
data={props.chartData}
|
||||||
endAngle={-270}
|
endAngle={-270}
|
||||||
pieChartProps={{ title: t("portfolio.structure.chartLabel") }}
|
pieChartProps={{ title: t("portfolio.structure.chartLabel") }}
|
||||||
+7
-22
@@ -1,6 +1,5 @@
|
|||||||
import type { TFunction } from "i18next";
|
import type { TFunction } from "i18next";
|
||||||
|
|
||||||
import { useState } from "react";
|
|
||||||
import { useTranslation } from "react-i18next";
|
import { useTranslation } from "react-i18next";
|
||||||
|
|
||||||
import type { Portfolio } from "@/entities/portfolio";
|
import type { Portfolio } from "@/entities/portfolio";
|
||||||
@@ -15,24 +14,15 @@ type PortfolioStructureProps = { structure?: null | Portfolio["structure"] };
|
|||||||
const usePortfolioStructureVm = (props: PortfolioStructureProps) => {
|
const usePortfolioStructureVm = (props: PortfolioStructureProps) => {
|
||||||
const { structure } = props;
|
const { structure } = props;
|
||||||
const { t } = useTranslation();
|
const { t } = useTranslation();
|
||||||
const [currency, setCurrency] = useState<null | string>(null);
|
|
||||||
|
|
||||||
const selected
|
|
||||||
= structure?.currencies.find(item => item.currency === currency)
|
|
||||||
?? structure?.currencies[0];
|
|
||||||
|
|
||||||
const isIncomplete = (structure?.unvaluedCategories.length ?? 0) > 0;
|
const isIncomplete = (structure?.unvaluedCategories.length ?? 0) > 0;
|
||||||
const rows = portfolioRows(selected, structure, t);
|
const rows = portfolioRows(structure, t);
|
||||||
const chartData = rows.filter(row => row.value > 0);
|
const chartData = rows.filter(row => row.value > 0);
|
||||||
|
|
||||||
return {
|
return {
|
||||||
chartData,
|
chartData,
|
||||||
currencies: structure?.currencies.map(item => item.currency) ?? [],
|
|
||||||
|
|
||||||
currency: selected?.currency ?? null,
|
|
||||||
incomplete: isIncomplete,
|
incomplete: isIncomplete,
|
||||||
negative: selected?.hasNegativeValues ?? false,
|
negative: structure?.hasNegativeValues ?? false,
|
||||||
onCurrencyChange: setCurrency,
|
|
||||||
rows,
|
rows,
|
||||||
unavailable: !structure,
|
unavailable: !structure,
|
||||||
unvalued:
|
unvalued:
|
||||||
@@ -46,14 +36,12 @@ const usePortfolioStructureVm = (props: PortfolioStructureProps) => {
|
|||||||
};
|
};
|
||||||
|
|
||||||
function portfolioRows(
|
function portfolioRows(
|
||||||
selected:
|
|
||||||
NonNullable<Portfolio["structure"]>["currencies"][number] | undefined,
|
|
||||||
structure: PortfolioStructureProps["structure"],
|
structure: PortfolioStructureProps["structure"],
|
||||||
t: TFunction,
|
t: TFunction,
|
||||||
) {
|
) {
|
||||||
if (!selected) return [];
|
if (!structure) return [];
|
||||||
|
|
||||||
return selected.categories.map((category) => {
|
return structure.categories.map((category) => {
|
||||||
const presentation = portfolioCategoryPresentation[category.type];
|
const presentation = portfolioCategoryPresentation[category.type];
|
||||||
|
|
||||||
const percentage
|
const percentage
|
||||||
@@ -61,16 +49,13 @@ function portfolioRows(
|
|||||||
? undefined
|
? undefined
|
||||||
: Number(category.sharePercent);
|
: Number(category.sharePercent);
|
||||||
|
|
||||||
const unknown = structure?.unvaluedCategories.some(
|
const isUnknown = structure.unvaluedCategories.some(
|
||||||
item => item.type === category.type,
|
item => item.type === category.type,
|
||||||
);
|
);
|
||||||
|
|
||||||
let amount = formatMoney({
|
let amount = formatMoney({ currency: "RUB", value: category.value });
|
||||||
currency: selected.currency,
|
|
||||||
value: category.value,
|
|
||||||
});
|
|
||||||
|
|
||||||
if (unknown) {
|
if (isUnknown) {
|
||||||
amount
|
amount
|
||||||
= category.value === "0"
|
= category.value === "0"
|
||||||
? t("portfolio.structure.unvalued")
|
? t("portfolio.structure.unvalued")
|
||||||
@@ -12,6 +12,7 @@ const syntheticPosition
|
|||||||
displayName: "Учебные технологии",
|
displayName: "Учебные технологии",
|
||||||
figi: null,
|
figi: null,
|
||||||
isin: null,
|
isin: null,
|
||||||
|
issuer: null,
|
||||||
logoName: null,
|
logoName: null,
|
||||||
logoSrc: null,
|
logoSrc: null,
|
||||||
quantity: "100",
|
quantity: "100",
|
||||||
@@ -19,6 +20,7 @@ const syntheticPosition
|
|||||||
returnPercentText: "+25,00 %",
|
returnPercentText: "+25,00 %",
|
||||||
returnText: "+5 000 ₽",
|
returnText: "+5 000 ₽",
|
||||||
returnTone: "positive",
|
returnTone: "positive",
|
||||||
|
sector: null,
|
||||||
shareText: "20%",
|
shareText: "20%",
|
||||||
ticker: "DEMO",
|
ticker: "DEMO",
|
||||||
type: "STOCK",
|
type: "STOCK",
|
||||||
|
|||||||
@@ -37,12 +37,14 @@ it("keeps expanded positions vertical while other positions adapt to the viewpor
|
|||||||
displayName: `Инструмент ${index}`,
|
displayName: `Инструмент ${index}`,
|
||||||
figi: null,
|
figi: null,
|
||||||
isin: null,
|
isin: null,
|
||||||
|
issuer: null,
|
||||||
logoName: null,
|
logoName: null,
|
||||||
logoSrc: null,
|
logoSrc: null,
|
||||||
quantity: "10",
|
quantity: "10",
|
||||||
returnPercent: null,
|
returnPercent: null,
|
||||||
returnPercentText: null,
|
returnPercentText: null,
|
||||||
returnText: null,
|
returnText: null,
|
||||||
|
sector: null,
|
||||||
shareText: null,
|
shareText: null,
|
||||||
ticker: null,
|
ticker: null,
|
||||||
type: kind === "stocks" ? "STOCK" : otherType,
|
type: kind === "stocks" ? "STOCK" : otherType,
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
import { MantineProvider } from "@mantine/core";
|
import { MantineProvider } from "@mantine/core";
|
||||||
import { type QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
import { type QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
||||||
import { render, screen, waitFor } from "@testing-library/react";
|
import { fireEvent, render, screen, waitFor } from "@testing-library/react";
|
||||||
import { http, HttpResponse } from "msw";
|
import { http, HttpResponse } from "msw";
|
||||||
import { MemoryRouter } from "react-router";
|
import { MemoryRouter } from "react-router";
|
||||||
import { describe, expect, it, vi } from "vitest";
|
import { describe, expect, it, vi } from "vitest";
|
||||||
@@ -31,16 +31,26 @@ function configureTestAuth() {
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
function portfolioSummary(totals: { currency: string; value: string }[]) {
|
function portfolioSummary(totals: { currency: string; value: string }) {
|
||||||
return {
|
return {
|
||||||
bondPositionCount: 1,
|
bondPositionCount: 1,
|
||||||
cashBalances: [],
|
cash: { currency: "RUB", value: "0" },
|
||||||
fundPositionCount: 0,
|
fundPositionCount: 0,
|
||||||
stockPositionCount: 0,
|
stockPositionCount: 0,
|
||||||
structure: { currencies: [], unvaluedCategories: [] },
|
structure: {
|
||||||
|
categories: [],
|
||||||
|
hasNegativeValues: false,
|
||||||
|
totalValue: "0",
|
||||||
|
unvaluedCategories: [],
|
||||||
|
},
|
||||||
totalPositionCount: 1,
|
totalPositionCount: 1,
|
||||||
totalsByCurrency: totals,
|
totals,
|
||||||
unrealizedReturnByCurrency: [],
|
unrealizedReturn: {
|
||||||
|
absolute: "0",
|
||||||
|
costBasis: "0",
|
||||||
|
partial: false,
|
||||||
|
percent: null,
|
||||||
|
},
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -59,23 +69,18 @@ function renderPage(queryClient: QueryClient) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
describe("AccountsPage", () => {
|
describe("AccountsPage", () => {
|
||||||
it("summarizes currencies separately and reports excluded accounts", async () => {
|
it("summarizes account totals and reports excluded accounts", async () => {
|
||||||
server.use(http.get("*/api/v1/brokerage-accounts", () =>
|
server.use(http.get("*/api/v1/brokerage-accounts", () =>
|
||||||
HttpResponse.json(resource([
|
HttpResponse.json(resource([
|
||||||
{
|
{
|
||||||
...account,
|
...account,
|
||||||
portfolioSummary: portfolioSummary([
|
portfolioSummary: portfolioSummary({ currency: "RUB", value: "100.10" }),
|
||||||
{ currency: "RUB", value: "100.10" },
|
|
||||||
{ currency: "USD", value: "20" },
|
|
||||||
]),
|
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
...account,
|
...account,
|
||||||
id: "account-2",
|
id: "account-2",
|
||||||
name: "Второй",
|
name: "Второй",
|
||||||
portfolioSummary: portfolioSummary([
|
portfolioSummary: portfolioSummary({ currency: "RUB", value: "50.20" }),
|
||||||
{ currency: "RUB", value: "50.20" },
|
|
||||||
]),
|
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
...account,
|
...account,
|
||||||
@@ -88,9 +93,9 @@ describe("AccountsPage", () => {
|
|||||||
id: "account-4",
|
id: "account-4",
|
||||||
name: "Только деньги",
|
name: "Только деньги",
|
||||||
portfolioSummary: {
|
portfolioSummary: {
|
||||||
...portfolioSummary([{ currency: "RUB", value: "25" }]),
|
...portfolioSummary({ currency: "RUB", value: "25" }),
|
||||||
bondPositionCount: 0,
|
bondPositionCount: 0,
|
||||||
cashBalances: [{ currency: "RUB", value: "25" }],
|
cash: { currency: "RUB", value: "25" },
|
||||||
totalPositionCount: 0,
|
totalPositionCount: 0,
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
@@ -99,7 +104,7 @@ describe("AccountsPage", () => {
|
|||||||
id: "account-5",
|
id: "account-5",
|
||||||
name: "Без сумм",
|
name: "Без сумм",
|
||||||
portfolioSummary: {
|
portfolioSummary: {
|
||||||
...portfolioSummary([]),
|
...portfolioSummary({ currency: "RUB", value: "0" }),
|
||||||
totalPositionCount: 0,
|
totalPositionCount: 0,
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
@@ -110,7 +115,8 @@ describe("AccountsPage", () => {
|
|||||||
renderPage(client);
|
renderPage(client);
|
||||||
|
|
||||||
expect(await screen.findByText("175,30 ₽")).toBeInTheDocument();
|
expect(await screen.findByText("175,30 ₽")).toBeInTheDocument();
|
||||||
expect(screen.getAllByText("20,00 USD")).not.toHaveLength(0);
|
expect(screen.queryByText("Ваши инвестиции по счетам"))
|
||||||
|
.not.toBeInTheDocument();
|
||||||
expect(screen.getByText("5 счетов")).toBeInTheDocument();
|
expect(screen.getByText("5 счетов")).toBeInTheDocument();
|
||||||
expect(screen.getByText("Нет текущих сумм")).toBeInTheDocument();
|
expect(screen.getByText("Нет текущих сумм")).toBeInTheDocument();
|
||||||
expect(screen.getByText(
|
expect(screen.getByText(
|
||||||
@@ -261,6 +267,101 @@ describe("AccountsPage", () => {
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// Automatic read retries wait 1s + 2s before the failure is final.
|
||||||
|
const RETRIES_EXHAUSTED_MS = 6000;
|
||||||
|
const TEST_MS = 10_000;
|
||||||
|
|
||||||
|
describe("exhausted read retries", () => {
|
||||||
|
it(
|
||||||
|
"keeps the cached list, warns and retries the same accounts GET",
|
||||||
|
{ timeout: TEST_MS },
|
||||||
|
async () => {
|
||||||
|
let isFailing = false;
|
||||||
|
let requests = 0;
|
||||||
|
server.use(
|
||||||
|
http.get("*/api/v1/brokerage-accounts", () => {
|
||||||
|
requests += 1;
|
||||||
|
if (isFailing)
|
||||||
|
return HttpResponse.json(
|
||||||
|
{ code: "TBANK_UNAVAILABLE" },
|
||||||
|
{ status: 503 },
|
||||||
|
);
|
||||||
|
|
||||||
|
return HttpResponse.json(resource([account]));
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
const queryClient = createTestQueryClient();
|
||||||
|
renderPage(queryClient);
|
||||||
|
await screen.findByText("Основной");
|
||||||
|
expect(screen.queryByRole("button", { name: "Повторить" }))
|
||||||
|
.not.toBeInTheDocument();
|
||||||
|
|
||||||
|
isFailing = true;
|
||||||
|
void queryClient.invalidateQueries({
|
||||||
|
queryKey: brokerageAccountsQueryKey,
|
||||||
|
});
|
||||||
|
|
||||||
|
const retry = await screen.findByRole(
|
||||||
|
"button",
|
||||||
|
{ name: "Повторить" },
|
||||||
|
{ timeout: RETRIES_EXHAUSTED_MS },
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(screen.getByText("Не удалось обновить данные")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("Основной")).toBeInTheDocument();
|
||||||
|
expect(requests).toBe(4);
|
||||||
|
|
||||||
|
isFailing = false;
|
||||||
|
fireEvent.click(retry);
|
||||||
|
|
||||||
|
await waitFor(() =>
|
||||||
|
expect(screen.queryByText("Не удалось обновить данные"))
|
||||||
|
.not.toBeInTheDocument());
|
||||||
|
expect(requests).toBe(5);
|
||||||
|
expect(screen.getByText("Основной")).toBeInTheDocument();
|
||||||
|
},
|
||||||
|
);
|
||||||
|
|
||||||
|
it(
|
||||||
|
"offers retry on the unavailable state after an initial failure",
|
||||||
|
{ timeout: TEST_MS },
|
||||||
|
async () => {
|
||||||
|
let isFailing = true;
|
||||||
|
server.use(
|
||||||
|
http.get("*/api/v1/brokerage-accounts", () =>
|
||||||
|
isFailing
|
||||||
|
? HttpResponse.json({ code: "TBANK_UNAVAILABLE" }, { status: 503 })
|
||||||
|
: HttpResponse.json(resource([account]))),
|
||||||
|
);
|
||||||
|
renderPage(createTestQueryClient());
|
||||||
|
|
||||||
|
const retry = await screen.findByRole(
|
||||||
|
"button",
|
||||||
|
{ name: "Повторить" },
|
||||||
|
{ timeout: RETRIES_EXHAUSTED_MS },
|
||||||
|
);
|
||||||
|
|
||||||
|
isFailing = false;
|
||||||
|
fireEvent.click(retry);
|
||||||
|
|
||||||
|
expect(await screen.findByText("Основной")).toBeInTheDocument();
|
||||||
|
},
|
||||||
|
);
|
||||||
|
|
||||||
|
it("does not offer a plain retry when the connection is lost", async () => {
|
||||||
|
server.use(
|
||||||
|
http.get("*/api/v1/brokerage-accounts", () =>
|
||||||
|
HttpResponse.json({ code: "TBANK_NOT_CONNECTED" }, { status: 409 })),
|
||||||
|
);
|
||||||
|
renderPage(createTestQueryClient());
|
||||||
|
|
||||||
|
expect(await screen.findByRole("link", { name: "Открыть настройки T-Bank" }))
|
||||||
|
.toBeInTheDocument();
|
||||||
|
expect(screen.queryByRole("button", { name: "Повторить" }))
|
||||||
|
.not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
it.each(["none", "failed"] as const)(
|
it.each(["none", "failed"] as const)(
|
||||||
"keeps incomplete empty membership distinct from no accounts (attempt=%s)",
|
"keeps incomplete empty membership distinct from no accounts (attempt=%s)",
|
||||||
async (state) => {
|
async (state) => {
|
||||||
|
|||||||
@@ -1,21 +1,22 @@
|
|||||||
import type { FC } from "react";
|
import type { FC } from "react";
|
||||||
|
|
||||||
import { useAccountsPageViewModel } from "./AccountsPage.vm";
|
import { useAccountsPageVm } from "./AccountsPage.vm";
|
||||||
import { AccountsPageEmpty } from "./components/AccountsPageEmpty.view";
|
import { AccountsPageEmpty } from "./components/AccountsPageEmpty.view";
|
||||||
import { AccountsPageError } from "./components/AccountsPageError.view";
|
import { AccountsPageError } from "./components/AccountsPageError.view";
|
||||||
import { AccountsPageLoaded } from "./components/AccountsPageLoaded.view";
|
import { AccountsPageLoaded } from "./components/AccountsPageLoaded.view";
|
||||||
import { AccountsPageLoading } from "./components/AccountsPageLoading.view";
|
import { AccountsPageLoading } from "./components/AccountsPageLoading.view";
|
||||||
|
|
||||||
const AccountsPage: FC = () => {
|
const AccountsPage: FC = () => {
|
||||||
const viewModel = useAccountsPageViewModel();
|
const vm = useAccountsPageVm();
|
||||||
if (viewModel.state === "loading") return <AccountsPageLoading />;
|
if (vm.state === "loading") return <AccountsPageLoading />;
|
||||||
if (viewModel.state === "error") return <AccountsPageError {...viewModel} />;
|
if (vm.state === "error") return <AccountsPageError {...vm} />;
|
||||||
if (viewModel.state === "empty") return <AccountsPageEmpty />;
|
if (vm.state === "empty") return <AccountsPageEmpty />;
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<AccountsPageLoaded
|
<AccountsPageLoaded
|
||||||
accounts={viewModel.accounts}
|
accounts={vm.accounts}
|
||||||
meta={viewModel.meta}
|
meta={vm.meta}
|
||||||
|
readRetry={vm.readRetry}
|
||||||
/>
|
/>
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -4,12 +4,24 @@ import {
|
|||||||
useBrokerageAccounts,
|
useBrokerageAccounts,
|
||||||
} from "@/entities/brokerage-account";
|
} from "@/entities/brokerage-account";
|
||||||
import { useScreenSync } from "@/features/tbank-connection";
|
import { useScreenSync } from "@/features/tbank-connection";
|
||||||
import { ApiErrorCode, apiErrorCode, isApiErrorCode } from "@/shared/api";
|
import {
|
||||||
|
ApiErrorCode,
|
||||||
|
apiErrorCode,
|
||||||
|
isApiErrorCode,
|
||||||
|
readRetry,
|
||||||
|
} from "@/shared/api";
|
||||||
import { useInitialAvailability } from "@/shared/lib";
|
import { useInitialAvailability } from "@/shared/lib";
|
||||||
|
|
||||||
|
type AccountsPageReadRetry = ReturnType<typeof readRetry>;
|
||||||
|
|
||||||
type AccountsPageViewModel
|
type AccountsPageViewModel
|
||||||
= | { accounts: BrokerageAccountCard[]; meta: NonNullable<ReturnType<typeof useBrokerageAccounts>["meta"]>; state: "loaded" }
|
= | {
|
||||||
| { code?: string; state: "error" }
|
accounts: BrokerageAccountCard[];
|
||||||
|
meta: NonNullable<ReturnType<typeof useBrokerageAccounts>["meta"]>;
|
||||||
|
readRetry: AccountsPageReadRetry;
|
||||||
|
state: "loaded";
|
||||||
|
}
|
||||||
|
| { code?: string; readRetry: AccountsPageReadRetry; state: "error" }
|
||||||
| { state: "empty" }
|
| { state: "empty" }
|
||||||
| { state: "loading" };
|
| { state: "loading" };
|
||||||
|
|
||||||
@@ -18,11 +30,12 @@ function isAccountsAccessFailure(code?: string) {
|
|||||||
|| isApiErrorCode(code, ApiErrorCode.TbankNotConnected);
|
|| isApiErrorCode(code, ApiErrorCode.TbankNotConnected);
|
||||||
}
|
}
|
||||||
|
|
||||||
function useAccountsPageViewModel(): AccountsPageViewModel {
|
function useAccountsPageVm(): AccountsPageViewModel {
|
||||||
const accounts = useBrokerageAccounts();
|
const accounts = useBrokerageAccounts();
|
||||||
useScreenSync({ screen: "accounts" }, [accounts]);
|
useScreenSync({ screen: "accounts" }, [accounts]);
|
||||||
|
|
||||||
const code = apiErrorCode(accounts.error);
|
const code = apiErrorCode(accounts.error);
|
||||||
|
const retry = readRetry([accounts]);
|
||||||
const isAccessFailure = isAccountsAccessFailure(code);
|
const isAccessFailure = isAccountsAccessFailure(code);
|
||||||
|
|
||||||
const hasResult = !!accounts.data
|
const hasResult = !!accounts.data
|
||||||
@@ -36,12 +49,13 @@ function useAccountsPageViewModel(): AccountsPageViewModel {
|
|||||||
isFetching: accounts.isFetching,
|
isFetching: accounts.isFetching,
|
||||||
});
|
});
|
||||||
|
|
||||||
if (isAccessFailure) return { code, state: "error" as const };
|
if (isAccessFailure)
|
||||||
|
return { code, readRetry: retry, state: "error" as const };
|
||||||
|
|
||||||
if (!hasResult || !accounts.data)
|
if (!hasResult || !accounts.data)
|
||||||
return {
|
return availability === "unavailable"
|
||||||
state: availability === "unavailable" ? "error" : "loading",
|
? { code, readRetry: retry, state: "error" as const }
|
||||||
} as const;
|
: { state: "loading" as const };
|
||||||
|
|
||||||
if (accounts.data.length === 0)
|
if (accounts.data.length === 0)
|
||||||
return {
|
return {
|
||||||
@@ -54,8 +68,9 @@ function useAccountsPageViewModel(): AccountsPageViewModel {
|
|||||||
return {
|
return {
|
||||||
accounts: brokerageAccountCards(accounts.data, meta.dependencies),
|
accounts: brokerageAccountCards(accounts.data, meta.dependencies),
|
||||||
meta,
|
meta,
|
||||||
|
readRetry: retry,
|
||||||
state: "loaded" as const,
|
state: "loaded" as const,
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
export { useAccountsPageViewModel };
|
export { useAccountsPageVm };
|
||||||
|
|||||||
@@ -6,8 +6,12 @@ import { useTranslation } from "react-i18next";
|
|||||||
import { Link } from "react-router";
|
import { Link } from "react-router";
|
||||||
|
|
||||||
import { ApiErrorCode, isApiErrorCode } from "@/shared/api";
|
import { ApiErrorCode, isApiErrorCode } from "@/shared/api";
|
||||||
|
import { ReadRetryButton, type ReadRetryProps } from "@/shared/ui";
|
||||||
|
|
||||||
type AccountsPageErrorProps = { code?: string };
|
type AccountsPageErrorProps = {
|
||||||
|
code?: string;
|
||||||
|
readRetry?: ReadRetryProps;
|
||||||
|
};
|
||||||
|
|
||||||
const AccountsPageError: FC<AccountsPageErrorProps> = (props) => {
|
const AccountsPageError: FC<AccountsPageErrorProps> = (props) => {
|
||||||
const { code } = props;
|
const { code } = props;
|
||||||
@@ -38,8 +42,18 @@ const AccountsPageError: FC<AccountsPageErrorProps> = (props) => {
|
|||||||
/>
|
/>
|
||||||
);
|
);
|
||||||
|
|
||||||
|
const retry = props.readRetry?.exhausted
|
||||||
|
? (
|
||||||
|
<ReadRetryButton
|
||||||
|
onRetry={props.readRetry.onRetry}
|
||||||
|
retrying={props.readRetry.retrying}
|
||||||
|
/>
|
||||||
|
)
|
||||||
|
: undefined;
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<StateView
|
<StateView
|
||||||
|
action={retry}
|
||||||
text={t("states.unavailableText")}
|
text={t("states.unavailableText")}
|
||||||
title={t("states.unavailableTitle")}
|
title={t("states.unavailableTitle")}
|
||||||
/>
|
/>
|
||||||
|
|||||||
@@ -0,0 +1,21 @@
|
|||||||
|
.summary {
|
||||||
|
min-width: 0;
|
||||||
|
padding-bottom: var(--mantine-spacing-lg);
|
||||||
|
border-bottom: 1px solid var(--wl-color-border);
|
||||||
|
}
|
||||||
|
|
||||||
|
.primaryTotal {
|
||||||
|
font-size: clamp(1.75rem, 4vw, 2.25rem);
|
||||||
|
font-variant-numeric: tabular-nums;
|
||||||
|
line-height: 1.2;
|
||||||
|
overflow-wrap: anywhere;
|
||||||
|
}
|
||||||
|
|
||||||
|
.otherTotal {
|
||||||
|
font-variant-numeric: tabular-nums;
|
||||||
|
overflow-wrap: anywhere;
|
||||||
|
}
|
||||||
|
|
||||||
|
.meta {
|
||||||
|
padding-top: var(--mantine-spacing-xs);
|
||||||
|
}
|
||||||
@@ -1,6 +1,6 @@
|
|||||||
import type { FC } from "react";
|
import type { FC } from "react";
|
||||||
|
|
||||||
import { Button, SimpleGrid, Stack, Text, Title } from "@mantine/core";
|
import { Button, Group, Stack, Text, Title } from "@mantine/core";
|
||||||
import { useTranslation } from "react-i18next";
|
import { useTranslation } from "react-i18next";
|
||||||
import { Link } from "react-router";
|
import { Link } from "react-router";
|
||||||
|
|
||||||
@@ -11,7 +11,9 @@ import {
|
|||||||
BrokerageAccountList,
|
BrokerageAccountList,
|
||||||
} from "@/entities/brokerage-account";
|
} from "@/entities/brokerage-account";
|
||||||
import { formatMoney } from "@/shared/lib";
|
import { formatMoney } from "@/shared/lib";
|
||||||
import { SourceSyncStatus } from "@/shared/ui";
|
import { ReadRetry, type ReadRetryProps, SourceSyncStatus } from "@/shared/ui";
|
||||||
|
|
||||||
|
import classes from "./AccountsPageLoaded.module.css";
|
||||||
|
|
||||||
const DECIMAL_BASE = 10n;
|
const DECIMAL_BASE = 10n;
|
||||||
const DECIMAL_PART_COUNT = 2;
|
const DECIMAL_PART_COUNT = 2;
|
||||||
@@ -20,36 +22,19 @@ const ZERO = 0n;
|
|||||||
type AccountsPageLoadedProps = {
|
type AccountsPageLoadedProps = {
|
||||||
accounts: BrokerageAccountCard[];
|
accounts: BrokerageAccountCard[];
|
||||||
meta: InvestmentResourceMeta;
|
meta: InvestmentResourceMeta;
|
||||||
|
readRetry?: ReadRetryProps;
|
||||||
};
|
};
|
||||||
|
|
||||||
type Money = { currency: string; value: string };
|
function accountTotals(accounts: BrokerageAccountCard[]): null | string {
|
||||||
|
const values: string[] = [];
|
||||||
function accountTotals(accounts: BrokerageAccountCard[]) {
|
|
||||||
const values = new Map<string, string[]>();
|
|
||||||
let excludedCount = 0;
|
|
||||||
|
|
||||||
for (const { summary } of accounts) {
|
for (const { summary } of accounts) {
|
||||||
if (summary.state === "empty") continue;
|
if (summary.state !== "available") continue;
|
||||||
|
|
||||||
if (summary.state === "unavailable") {
|
values.push(summary.portfolio.totals.value);
|
||||||
excludedCount += 1;
|
|
||||||
continue;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
for (const total of summary.portfolio.totalsByCurrency) {
|
return values.length > 0 ? sumDecimals(values) : null;
|
||||||
values.set(total.currency, [
|
|
||||||
...values.get(total.currency) ?? [],
|
|
||||||
total.value,
|
|
||||||
]);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
const totals: Money[] = Array.from(values, ([currency, amounts]) => ({
|
|
||||||
currency,
|
|
||||||
value: sumDecimals(amounts),
|
|
||||||
}));
|
|
||||||
|
|
||||||
return { excludedCount, totals };
|
|
||||||
}
|
}
|
||||||
|
|
||||||
function sumDecimals(values: string[]) {
|
function sumDecimals(values: string[]) {
|
||||||
@@ -85,53 +70,50 @@ function sumDecimals(values: string[]) {
|
|||||||
|
|
||||||
const AccountsPageLoaded: FC<AccountsPageLoadedProps> = (props) => {
|
const AccountsPageLoaded: FC<AccountsPageLoadedProps> = (props) => {
|
||||||
const { t } = useTranslation();
|
const { t } = useTranslation();
|
||||||
const { excludedCount, totals } = accountTotals(props.accounts);
|
const total = accountTotals(props.accounts);
|
||||||
|
|
||||||
|
const excludedCount = props.accounts.filter(
|
||||||
|
account => account.summary.state === "unavailable",
|
||||||
|
).length;
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<Stack gap="lg">
|
<Stack gap="lg">
|
||||||
<Stack gap={4}>
|
|
||||||
<Title order={1}>{t("accounts.title")}</Title>
|
<Title order={1}>{t("accounts.title")}</Title>
|
||||||
|
|
||||||
<Text c="dimmed" size="sm">
|
<Stack className={classes.summary} gap="xs">
|
||||||
{t("accounts.subtitle")}
|
|
||||||
</Text>
|
|
||||||
</Stack>
|
|
||||||
|
|
||||||
<Stack gap="xs">
|
|
||||||
<SimpleGrid cols={{ base: 1, xs: 2 }} spacing="xs">
|
|
||||||
<Stack gap={4}>
|
|
||||||
<Text c="dimmed" size="sm">
|
<Text c="dimmed" size="sm">
|
||||||
{t("accounts.currentValue")}
|
{t("accounts.currentValue")}
|
||||||
</Text>
|
</Text>
|
||||||
|
|
||||||
{totals.length > 0
|
{total === null
|
||||||
? totals.map(total => (
|
? (
|
||||||
<Text fw={700} key={total.currency} size="lg">
|
<Text c="dimmed">{t("accounts.summaryNoTotals")}</Text>
|
||||||
{formatMoney(total, { withRoundedCents: true })}
|
)
|
||||||
</Text>
|
: (
|
||||||
))
|
<Text className={classes.primaryTotal} fw={700}>
|
||||||
: <Text c="dimmed">{t("accounts.summaryNoTotals")}</Text>}
|
{formatMoney({ currency: "RUB", value: total }, { withRoundedCents: true })}
|
||||||
</Stack>
|
|
||||||
|
|
||||||
<Stack gap={4}>
|
|
||||||
<Text fw={600}>{t("accounts.count", {
|
|
||||||
count: props.accounts.length,
|
|
||||||
})}
|
|
||||||
</Text>
|
|
||||||
|
|
||||||
{excludedCount > 0 && (
|
|
||||||
<Text c="dimmed" size="sm">
|
|
||||||
{t("accounts.summaryExcluded", { count: excludedCount })}
|
|
||||||
</Text>
|
</Text>
|
||||||
)}
|
)}
|
||||||
</Stack>
|
|
||||||
</SimpleGrid>
|
<Group className={classes.meta} gap="xs" wrap="wrap">
|
||||||
|
<Text c="dimmed" size="xs">
|
||||||
|
{t("accounts.count", { count: props.accounts.length })}
|
||||||
|
</Text>
|
||||||
|
|
||||||
<SourceSyncStatus
|
<SourceSyncStatus
|
||||||
lastAttempt={props.meta.lastAttempt}
|
lastAttempt={props.meta.lastAttempt}
|
||||||
lastSuccessfulAt={props.meta.lastSuccessfulAt}
|
lastSuccessfulAt={props.meta.lastSuccessfulAt}
|
||||||
stale={props.meta.freshness === "stale"}
|
stale={props.meta.freshness === "stale"}
|
||||||
/>
|
/>
|
||||||
|
</Group>
|
||||||
|
|
||||||
|
{excludedCount > 0 && (
|
||||||
|
<Text c="dimmed" size="sm">
|
||||||
|
{t("accounts.summaryExcluded", { count: excludedCount })}
|
||||||
|
</Text>
|
||||||
|
)}
|
||||||
|
|
||||||
|
{!!props.readRetry && <ReadRetry {...props.readRetry} />}
|
||||||
</Stack>
|
</Stack>
|
||||||
|
|
||||||
<Button
|
<Button
|
||||||
|
|||||||
@@ -347,14 +347,29 @@ describe("bond page", () => {
|
|||||||
it("keeps market content and sold-position history when coupons fail", async () => {
|
it("keeps market content and sold-position history when coupons fail", async () => {
|
||||||
setup({ failCoupons: true, noPosition: true });
|
setup({ failCoupons: true, noPosition: true });
|
||||||
await screen.findByText("98,125 %");
|
await screen.findByText("98,125 %");
|
||||||
expect(screen.queryByRole("button", { name: "Повторить" })).not.toBeInTheDocument();
|
|
||||||
expect(
|
expect(
|
||||||
screen.queryByRole("heading", { name: "Моя позиция" }),
|
screen.queryByRole("heading", { name: "Моя позиция" }),
|
||||||
).not.toBeInTheDocument();
|
).not.toBeInTheDocument();
|
||||||
expect(
|
expect(
|
||||||
screen.getByRole("heading", { name: "Моя история событий" }),
|
screen.getByRole("heading", { name: "История операций" }),
|
||||||
).toBeVisible();
|
).toBeVisible();
|
||||||
});
|
});
|
||||||
|
it(
|
||||||
|
"offers a local retry for the failed coupons section only",
|
||||||
|
{ timeout: 10_000 },
|
||||||
|
async () => {
|
||||||
|
setup({ failCoupons: true });
|
||||||
|
await screen.findByText("98,125 %");
|
||||||
|
// Automatic read retries wait 1s + 2s before the failure is final.
|
||||||
|
await screen.findByRole(
|
||||||
|
"button",
|
||||||
|
{ name: "Повторить" },
|
||||||
|
{ timeout: 6000 },
|
||||||
|
);
|
||||||
|
expect(screen.getAllByRole("button", { name: "Повторить" })).toHaveLength(1);
|
||||||
|
expect(screen.getByText("98,125 %")).toBeVisible();
|
||||||
|
},
|
||||||
|
);
|
||||||
it("preserves cached quote without manual refresh", async () => {
|
it("preserves cached quote without manual refresh", async () => {
|
||||||
const controls = setup({ path: `/bonds/${uid}?period=year&events=trades` });
|
const controls = setup({ path: `/bonds/${uid}?period=year&events=trades` });
|
||||||
await screen.findByText("98,125 %");
|
await screen.findByText("98,125 %");
|
||||||
|
|||||||
@@ -120,11 +120,52 @@ const useOperationFormVm = (props: OperationFormProps) => {
|
|||||||
body: { ...body, version },
|
body: { ...body, version },
|
||||||
id: props.operation.id,
|
id: props.operation.id,
|
||||||
});
|
});
|
||||||
else
|
else {
|
||||||
await operationCreation.mutateAsync({
|
const base = {
|
||||||
|
amount: body.amount,
|
||||||
|
cardId: values.cardId,
|
||||||
|
date: values.date,
|
||||||
|
description: values.description,
|
||||||
id: intent,
|
id: intent,
|
||||||
...body,
|
};
|
||||||
|
|
||||||
|
switch (values.kind) {
|
||||||
|
case "expense": {
|
||||||
|
await operationCreation.mutateAsync({
|
||||||
|
...base,
|
||||||
|
categoryId: values.categoryId || defaultCategoryId,
|
||||||
|
kind: values.kind,
|
||||||
});
|
});
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
|
||||||
|
case "refund": {
|
||||||
|
await operationCreation.mutateAsync({
|
||||||
|
...base,
|
||||||
|
kind: values.kind,
|
||||||
|
originalExpenseId: values.originalExpenseId,
|
||||||
|
});
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
|
||||||
|
case "topup": {
|
||||||
|
await operationCreation.mutateAsync({
|
||||||
|
...base,
|
||||||
|
kind: values.kind,
|
||||||
|
});
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
|
||||||
|
case "transfer": {
|
||||||
|
await operationCreation.mutateAsync({
|
||||||
|
...base,
|
||||||
|
kind: values.kind,
|
||||||
|
targetCardId: values.targetCardId,
|
||||||
|
});
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
notifications.show({
|
notifications.show({
|
||||||
id: "bank-operation-saved-" + actionId,
|
id: "bank-operation-saved-" + actionId,
|
||||||
|
|||||||
@@ -1,13 +1,13 @@
|
|||||||
import type { FC } from "react";
|
import type { FC } from "react";
|
||||||
|
|
||||||
import { useDocumentTitle } from "@mantine/hooks";
|
|
||||||
import { useTranslation } from "react-i18next";
|
import { useTranslation } from "react-i18next";
|
||||||
|
|
||||||
import { AuthPageLayout, LoginForm } from "@/features/auth";
|
import { AuthPageLayout, LoginForm } from "@/features/auth";
|
||||||
|
import { useAppDocumentTitle } from "@/shared/ui";
|
||||||
|
|
||||||
const LoginPage: FC = () => {
|
const LoginPage: FC = () => {
|
||||||
const { t } = useTranslation();
|
const { t } = useTranslation();
|
||||||
useDocumentTitle(`${t("auth.login")} — ${t("appName")}`);
|
useAppDocumentTitle(t("auth.login"));
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<AuthPageLayout title={t("auth.login")}>
|
<AuthPageLayout title={t("auth.login")}>
|
||||||
|
|||||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user