test: cover null resource envelopes for account pages (#70) (#71)

.ai/conventions/data.md

@@ -30,7 +30,8 @@ backend checkout и не проверяют backend runtime OpenAPI; измен
 shape/status/route сохраняет
 публичный контракт предоставленного snapshot.
 Одна UI-модель не требует менять API. `openapi:generate` работает offline от snapshot;
-`openapi:check` генерирует во временный каталог и сравнивает, не меняя tracked files.
+`openapi:check` запускает native `--check` того же CLI и падает при устаревших
+generated types, не меняя tracked files.
 
 ## Auth и invalidation
 

package.json

@@ -20,7 +20,7 @@
 		"test:coverage": "npm run build:packages && vitest run --coverage",
 		"test:lint": "node --test scripts/test-eslint.mjs",
 		"openapi:generate": "openapi-typescript src/shared/api/spec/openapi.json -o src/shared/api/generated/schema.d.ts",
-		"openapi:check": "node scripts/check-openapi.mjs",
+		"openapi:check": "openapi-typescript src/shared/api/spec/openapi.json -o src/shared/api/generated/schema.d.ts --check",
 		"knip": "npm run build:packages && knip",
 		"deps": "npm run build:packages && depcruise src packages --config dependency-cruiser.cjs --output-type err-long",
 		"verify": "npm run build:packages && npm run openapi:check && tsc -b --noEmit && eslint . --max-warnings=0 && npm run test:lint && vitest run --coverage && knip && depcruise src packages --config dependency-cruiser.cjs --output-type err-long && depcruise src packages .storybook/preview.tsx --config .storybook/dependency-cruiser.cjs --output-type err-long && tsc -b && vite build && storybook build --output-dir storybook-static --disable-telemetry",

scripts/check-openapi.mjs

@@ -1,45 +0,0 @@
-import { spawnSync } from "node:child_process";
-import { mkdtemp, readFile, rm } from "node:fs/promises";
-import { tmpdir } from "node:os";
-import nodePath from "node:path";
-
-const temporaryDirectory = await mkdtemp(
-	nodePath.join(tmpdir(), "wealth-ledger-openapi-"),
-);
-
-const generatedPath = nodePath.join(temporaryDirectory, "schema.d.ts");
-const committedPath = nodePath.resolve("src/shared/api/generated/schema.d.ts");
-const cliPath = nodePath.resolve("node_modules/openapi-typescript/bin/cli.js");
-let exitCode = 0;
-
-try {
-	const generated = spawnSync(
-		process.execPath,
-		[cliPath, "src/shared/api/spec/openapi.json", "-o", generatedPath],
-		{ encoding: "utf8" },
-	);
-
-	if (generated.status === 0) {
-		const [committed, current] = await Promise.all([
-			readFile(committedPath, "utf8"),
-			// eslint-disable-next-line security/detect-non-literal-fs-filename -- Path is built from this check’s private mkdtemp directory and fixed filenames.
-			readFile(generatedPath, "utf8"),
-		]);
-
-		if (committed !== current) {
-			console.error(
-				"Generated OpenAPI types are stale. Run `npm run openapi:generate` and commit the result.",
-			);
-			exitCode = 1;
-		}
-	}
-	else {
-		process.stderr.write(generated.stderr || generated.stdout);
-		exitCode = generated.status ?? 1;
-	}
-}
-finally {
-	await rm(temporaryDirectory, { force: true, recursive: true });
-}
-
-process.exitCode = exitCode;

scripts/test-eslint.mjs

@@ -85,7 +85,7 @@ test("ESLint enforces the frontend profile and excludes generated artifacts", as
 			"security/detect-non-literal-regexp",
 		],
 		[
-			"scripts/check-openapi.mjs",
+			"scripts/test-pre-commit.mjs",
 			"import { exec } from \"node:child_process\"; exec(process.argv[2]);",
 			"security/detect-child-process",
 		],

src/pages/account-operations/ui/AccountOperationsPage/AccountOperationsPage.test.tsx

@@ -492,6 +492,20 @@ describe("AccountOperationsPage", () => {
 			}),
 		).toBeInTheDocument();
 	});
+
+	it("keeps a null operations envelope loading instead of a confirmed empty period", async () => {
+		configureTestAuth();
+		server.use(
+			http.get("*/api/v1/brokerage-accounts/:accountId/operations", () =>
+				HttpResponse.json(resource(null)),
+			),
+		);
+		renderPage();
+		expect(
+			await screen.findByRole("status", { name: "Загрузка" }, { timeout: 4000 }),
+		).toBeVisible();
+		expect(screen.queryByText("Операций нет")).not.toBeInTheDocument();
+	});
 });
 
 it("keeps UTC operation boundaries in GET and source sync requests", async () => {

src/pages/account/ui/AccountPage/AccountPage.test.tsx

@@ -402,6 +402,24 @@ describe("AccountPage states", () => {
 		).toBeInTheDocument();
 	});
 
+	it("keeps a null portfolio envelope loading instead of an empty portfolio", async () => {
+		server.use(
+			http.get("*/api/v1/brokerage-accounts/:accountId/portfolio", () =>
+				HttpResponse.json(resource(null)),
+			),
+		);
+		const queryClient = createTestQueryClient();
+		renderAccountRoute(queryClient);
+
+		expect(
+			await screen.findByRole("status", { name: "Загрузка" }, { timeout: 4000 }),
+		).toBeVisible();
+		expect(screen.queryByText("Портфель пока пуст")).not.toBeInTheDocument();
+		expect(
+			queryClient.getQueryData(portfolioQueryOptions("account-1").queryKey),
+		).toMatchObject({ data: null });
+	});
+
 	it("renders a stale portfolio in upstream order with nullable values hidden", () => {
 		renderPage(<AccountPageLoaded {...loadedProps()} />);