feat: improve bank card expenses summary

This commit is contained in:
2026-09-12 20:54:57 +03:00
parent 9a65687d38
commit d3ac8c242d
7 changed files with 227 additions and 81 deletions
+17
View File
@@ -5,6 +5,8 @@ import {
useAuthenticatedQuery, useAuthenticatedQuery,
} from "@/shared/api"; } from "@/shared/api";
import { moneyCents } from "../model/form-validation";
type BankCard = type BankCard =
paths["/api/v1/bank-cards/{id}"]["get"]["responses"][200]["content"]["application/json"]; paths["/api/v1/bank-cards/{id}"]["get"]["responses"][200]["content"]["application/json"];
type BankOperation = type BankOperation =
@@ -119,11 +121,25 @@ function useBankExpenses(
}); });
} }
function sortBankSummary(data: BankSummary): BankSummary {
return {
...data,
categories: data.categories.toSorted((a, b) => {
const left = moneyCents(a.net.value);
const right = moneyCents(b.net.value);
if (left === null || right === null)
throw new Error("Invalid bank summary amount");
return left > right ? -1 : left < right ? 1 : 0;
}),
};
}
function useBankSummary(month: string, cardId?: string) { function useBankSummary(month: string, cardId?: string) {
return useAuthenticatedQuery({ return useAuthenticatedQuery({
...apiQueryClient.queryOptions("get", "/api/v1/bank-cards/summary", { ...apiQueryClient.queryOptions("get", "/api/v1/bank-cards/summary", {
params: { query: { month, cardId } }, params: { query: { month, cardId } },
}), }),
select: sortBankSummary,
enabled: Boolean(month), enabled: Boolean(month),
}); });
} }
@@ -147,6 +163,7 @@ export {
type CreateBankOperation, type CreateBankOperation,
type CreateExpenseCategory, type CreateExpenseCategory,
type ExpenseCategory, type ExpenseCategory,
sortBankSummary,
type UpdateBankCard, type UpdateBankCard,
type UpdateBankOperation, type UpdateBankOperation,
type UpdateExpenseCategory, type UpdateExpenseCategory,
@@ -0,0 +1,32 @@
import { expect, it } from "vitest";
import { type BankSummary, sortBankSummary } from "./queries";
it("orders displayed expenses descending, preserving cents, ties and source data", () => {
const values = [
"-10",
"9007199254740992.01",
"0",
"9007199254740992.02",
"-2",
"0",
];
const money = (value: string) => ({ currency: "RUB", value });
const data: BankSummary = {
month: "2026-09",
cardId: "a",
expenses: money("0"),
refunds: money("0"),
net: money("0"),
categories: values.map((value, index) => ({
categoryId: String(index),
categoryName: String(index),
expenses: money("100"),
refunds: money("0"),
net: money(value),
})),
};
expect(sortBankSummary(data).categories.map((row) => row.categoryId)).toEqual(
["3", "1", "2", "5", "4", "0"],
);
expect(data.categories.map((row) => row.net.value)).toEqual(values);
});
@@ -0,0 +1,64 @@
.header {
display: flex;
align-items: center;
justify-content: space-between;
flex-wrap: wrap;
gap: var(--mantine-spacing-xs) var(--mantine-spacing-lg);
}
.total {
font-size: var(--mantine-font-size-xl);
font-weight: 650;
letter-spacing: -0.025em;
font-variant-numeric: tabular-nums;
overflow-wrap: anywhere;
min-width: 0;
}
.categories {
display: grid;
grid-template-columns: repeat(2, minmax(0, 1fr));
grid-template-rows: repeat(var(--category-rows), auto);
grid-auto-flow: column;
column-gap: var(--mantine-spacing-xl);
margin: 0;
}
.category {
display: flex;
align-items: center;
justify-content: space-between;
gap: var(--mantine-spacing-md);
padding-block: var(--mantine-spacing-sm);
border-top: 1px solid var(--mantine-color-gray-3);
min-width: 0;
}
.label {
display: flex;
align-items: center;
gap: var(--mantine-spacing-xs);
min-width: 0;
font-size: var(--mantine-font-size-sm);
overflow-wrap: anywhere;
}
.amount {
flex-shrink: 0;
max-width: 60%;
margin: 0;
font-size: var(--mantine-font-size-sm);
font-weight: 600;
font-variant-numeric: tabular-nums;
text-align: right;
min-width: 0;
overflow-wrap: anywhere;
}
@media (max-width: 48em) {
.categories {
grid-template-columns: minmax(0, 1fr);
grid-template-rows: none;
grid-auto-flow: row;
}
}
@@ -10,7 +10,7 @@ const meta = {
docs: { docs: {
description: { description: {
component: component:
"Месячные расходы ручного учёта. Вымышленные суммы, без API и сохранения. Возвраты учитываются отдельно; отрицательный итог не превращается в процентную диаграмму.", "Месячные расходы ручного учёта. Вымышленные суммы, без API и сохранения. Один итог с учётом возвратов и компактные строки категорий. Отрицательные суммы сохраняют знак.",
}, },
}, },
}, },
@@ -29,9 +29,30 @@ const meta = {
{ {
categoryId: "food", categoryId: "food",
categoryName: "Продукты", categoryName: "Продукты",
expenses: money("8500"), expenses: money("3500"),
refunds: money("1000"), refunds: money("1000"),
net: money("7500"), net: money("2500"),
},
{
categoryId: "cafe",
categoryName: "Кафе",
expenses: money("2200"),
refunds: money("0"),
net: money("2200"),
},
{
categoryId: "taxi",
categoryName: "Такси",
expenses: money("1800"),
refunds: money("0"),
net: money("1800"),
},
{
categoryId: "health",
categoryName: "Здоровье",
expenses: money("1000"),
refunds: money("0"),
net: money("1000"),
}, },
], ],
}, },
@@ -39,7 +60,7 @@ const meta = {
} satisfies Meta<typeof BankSummaryView>; } satisfies Meta<typeof BankSummaryView>;
export default meta; export default meta;
type Story = StoryObj<typeof meta>; type Story = StoryObj<typeof meta>;
export const Loaded: Story = { name: "Расходы и возвраты" }; export const Loaded: Story = { name: "Расходы по категориям" };
export const RefundMonth: Story = { export const RefundMonth: Story = {
name: "Возврат покупки прошлого месяца", name: "Возврат покупки прошлого месяца",
args: { args: {
@@ -96,7 +117,15 @@ export const LongAmounts: Story = {
expenses: money("184467440737095516.14"), expenses: money("184467440737095516.14"),
refunds: money("0"), refunds: money("0"),
net: money("184467440737095516.14"), net: money("184467440737095516.14"),
categories: [], categories: [
{
categoryId: "shopping",
categoryName: "Покупки",
expenses: money("184467440737095516.14"),
refunds: money("0"),
net: money("184467440737095516.14"),
},
],
}, },
}, },
}; };
+61 -72
View File
@@ -1,19 +1,11 @@
import { import { Button, Group, Skeleton, Stack, Text, Title } from "@mantine/core";
Button, import type { CSSProperties, FC } from "react";
Group,
Paper,
SimpleGrid,
Skeleton,
Stack,
Text,
Title,
} from "@mantine/core";
import type { FC } from "react";
import { useTranslation } from "react-i18next"; import { useTranslation } from "react-i18next";
import { formatMoney } from "@/shared/lib"; import { formatMoney } from "@/shared/lib";
import { LoadingSkeleton } from "@/shared/ui"; import { LoadingSkeleton } from "@/shared/ui";
import type { BankSummary } from "../api/queries"; import type { BankSummary } from "../api/queries";
import { BankOperationIcon } from "./BankOperationIcon"; import { BankOperationIcon } from "./BankOperationIcon";
import classes from "./BankSummary.module.css";
type BankSummaryViewProps = { type BankSummaryViewProps = {
data?: BankSummary; data?: BankSummary;
@@ -26,71 +18,68 @@ type BankSummaryViewProps = {
const BankSummaryView: FC<BankSummaryViewProps> = (props) => { const BankSummaryView: FC<BankSummaryViewProps> = (props) => {
const { t } = useTranslation(); const { t } = useTranslation();
return ( return (
<Paper p="md" withBorder> <Stack gap="md" aria-busy={props.loading || props.fetching}>
<Stack> <div className={classes.header}>
<Title order={2}> <Title order={2}>
{t(props.all ? "bank.allSummary" : "bank.summary")} {t(props.all ? "bank.allSummary" : "bank.summary")}
</Title> </Title>
{props.data ? ( {props.data && (
<> <Text className={classes.total}>
<SimpleGrid cols={{ base: 1, sm: 3 }}> {formatMoney(props.data.net, { withZeroCents: true })}
{(["expenses", "refunds", "net"] as const).map((key) => ( </Text>
<div key={key}>
<Text c="dimmed">{t(`bank.${key}`)}</Text>
<Text size="xl" fw={650} style={{ overflowWrap: "anywhere" }}>
{formatMoney(props.data?.[key] ?? null)}
</Text>
</div>
))}
</SimpleGrid>
<Text size="sm" c="dimmed">
{t("bank.summaryHint")}
</Text>
{props.data.categories.length ? (
props.data.categories.map((category) => (
<Paper p="sm" key={category.categoryId} withBorder>
<Group gap="xs" wrap="nowrap">
<BankOperationIcon
kind="expense"
categoryName={category.categoryName}
/>
<Text fw={600}>{category.categoryName}</Text>
</Group>
<Group>
{(["expenses", "refunds", "net"] as const).map((key) => (
<Text key={key} style={{ overflowWrap: "anywhere" }}>
{t(`bank.${key}`)}: {formatMoney(category[key])}
</Text>
))}
</Group>
</Paper>
))
) : (
<Text>{t("bank.noExpenses")}</Text>
)}
</>
) : props.loading ? (
<LoadingSkeleton label={t("bank.loading")}>
<SimpleGrid cols={3}>
<Skeleton h={60} />
<Skeleton h={60} />
<Skeleton h={60} />
</SimpleGrid>
</LoadingSkeleton>
) : null}
{props.error && (
<Group role="alert">
<Text>{t(props.data ? "bank.refreshError" : "bank.error")}</Text>
<Button variant="default" onClick={props.retry}>
{t("bank.retry")}
</Button>
</Group>
)} )}
{props.data && props.fetching && ( </div>
<Text role="status">{t("bank.refreshing")}</Text> {props.data ? (
)} props.data.categories.length ? (
</Stack> <dl
</Paper> className={classes.categories}
style={
{
"--category-rows": Math.ceil(props.data.categories.length / 2),
} as CSSProperties
}
>
{props.data.categories.map((category) => (
<div className={classes.category} key={category.categoryId}>
<dt className={classes.label}>
<BankOperationIcon
kind="expense"
categoryName={category.categoryName}
/>
<span>{category.categoryName}</span>
</dt>
<dd className={classes.amount}>
{formatMoney(category.net, { withZeroCents: true })}
</dd>
</div>
))}
</dl>
) : (
<Text size="sm" c="dimmed">
{t("bank.noExpenses")}
</Text>
)
) : props.loading ? (
<LoadingSkeleton label={t("bank.loading")}>
<Stack gap="sm">
<Skeleton h={32} w="35%" />
<Skeleton h={40} />
<Skeleton h={40} />
</Stack>
</LoadingSkeleton>
) : null}
{props.error && (
<Group role="alert">
<Text>{t(props.data ? "bank.refreshError" : "bank.error")}</Text>
<Button variant="default" onClick={props.retry}>
{t("bank.retry")}
</Button>
</Group>
)}
{props.data && props.fetching && (
<Text role="status">{t("bank.refreshing")}</Text>
)}
</Stack>
); );
}; };
+2 -2
View File
@@ -52,7 +52,7 @@ const ru = {
save: "Сохранить", save: "Сохранить",
cancel: "Отмена", cancel: "Отмена",
close: "Закрыть", close: "Закрыть",
summary: "Расходы за месяц", summary: "Расходы",
allSummary: "Расходы по всем картам", allSummary: "Расходы по всем картам",
month: "Месяц", month: "Месяц",
expenses: "Потрачено", expenses: "Потрачено",
@@ -60,7 +60,7 @@ const ru = {
net: "После возвратов", net: "После возвратов",
summaryHint: summaryHint:
"Возвраты учитываются в месяце получения. Итог может быть отрицательным.", "Возвраты учитываются в месяце получения. Итог может быть отрицательным.",
noExpenses: "Расходов и возвратов за месяц нет.", noExpenses: "За этот месяц операций по расходам нет.",
categories: "Категории", categories: "Категории",
category: "Категория", category: "Категория",
categoryName: "Название категории", categoryName: "Название категории",
+17 -2
View File
@@ -1,4 +1,7 @@
type Money = { currency: string; value: string }; type Money = { currency: string; value: string };
type FormatMoneyOptions = {
withZeroCents?: boolean;
};
function formatDecimal(value: string): string { function formatDecimal(value: string): string {
const [integer, fraction] = value.split("."); const [integer, fraction] = value.split(".");
@@ -10,9 +13,21 @@ function formatDecimal(value: string): string {
return `${sign}${grouped}${fraction ? `,${fraction}` : ""}`; return `${sign}${grouped}${fraction ? `,${fraction}` : ""}`;
} }
function formatMoney(money: Money | null): string { function formatMoney(
money: Money | null,
{ withZeroCents = false }: FormatMoneyOptions = {},
): string {
if (!money) return "—"; if (!money) return "—";
return `${formatDecimal(money.value)} ${money.currency === "RUB" ? "₽" : money.currency}`; const [integerPart, fractionPart = ""] = money.value.split(".");
const normalizedFraction =
withZeroCents && !fractionPart
? "00"
: withZeroCents && fractionPart.length === 1
? `${fractionPart}0`
: fractionPart;
return `${formatDecimal(
`${integerPart}${normalizedFraction ? `.${normalizedFraction}` : ""}`,
)} ${money.currency === "RUB" ? "₽" : money.currency}`;
} }
function formatDate(value: string): string { function formatDate(value: string): string {