refactor: enforce frontend view model boundaries

2026-09-28 18:48:23 +03:00
parent 5b69003516
commit ca0ad4f824
287 changed files with 8558 additions and 4538 deletions
@@ -28,8 +28,11 @@ const accounts = [
 	{ id: "a", name: "Основной" },
 	{ id: "b", name: "ИИС" },
 ];
-const position: Portfolio["positions"][number] = (/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
-	{
+
+/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+
+const position: Portfolio["positions"][number]
+	= {
 		absoluteReturn: null,
 		averagePurchasePrice: null,
 		currentValue: { currency: "RUB", value: "600" },
@@ -40,8 +43,9 @@ const position: Portfolio["positions"][number] = (/* eslint-disable unicorn/no-n
 		quantity: "2",
 		ticker: "SBER",
 		type: "STOCK",
-	}
-/* eslint-enable unicorn/no-null */);
+	};
+
+/* eslint-enable unicorn/no-null */
 const portfolio: Portfolio = {
 	cashBalances: [],
 	isStale: false,
@@ -50,8 +54,11 @@ const portfolio: Portfolio = {
 	structure: { currencies: [], unvaluedCategories: [] },
 	totalsByCurrency: [{ currency: "RUB", value: "1200" }],
 };
-const receipt: BrokerageOperation = (/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
-	{
+
+/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+
+const receipt: BrokerageOperation
+	= {
 		accruedInterest: null,
 		category: "income",
 		commission: null,
@@ -67,11 +74,15 @@ const receipt: BrokerageOperation = (/* eslint-disable unicorn/no-null -- Fixtur
 		quantity: null,
 		ticker: "BOND",
 		type: "OPERATION_TYPE_COUPON",
-	}
-/* eslint-enable unicorn/no-null */);
+	};
+
+/* eslint-enable unicorn/no-null */
 const items = accounts.map(account => ({ ...receipt, account }));
-const analytics: IncomeAnalytics = (/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
-	{
+
+/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+
+const analytics: IncomeAnalytics
+	= {
 		accountId: "all",
 		bucketGranularity: "day",
 		buckets: [],
@@ -105,17 +116,21 @@ const analytics: IncomeAnalytics = (/* eslint-disable unicorn/no-null -- Fixture
 			},
 		],
 		yearComparison: null,
-	}
-/* eslint-enable unicorn/no-null */);
+	};
+
+/* eslint-enable unicorn/no-null */
 const CurrentLocation: FC = () => {
 	const location = useLocation();
+
 	return (
 		<output aria-label="Текущий путь">
 			{location.pathname}
+
 			{location.search}
 		</output>
 	);
 };
+
 function renderPage(path: string) {
 	const client = createTestQueryClient();
 	render(
@@ -124,12 +139,14 @@ function renderPage(path: string) {
 				<MemoryRouter initialEntries={[path]}>
 					<AuthProvider>
 						<AppRoutes />
+
 						<CurrentLocation />
 					</AuthProvider>
 				</MemoryRouter>
 			</MantineProvider>
 		</QueryClientProvider>,
 	);
+
 	return client;
 }

@@ -144,14 +161,17 @@ beforeEach(() => {
 		http.get("*/api/v1/brokerage-accounts", () =>
 			HttpResponse.json(
 				resource(
-					accounts.map(account => ((/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
-						{
-							...account,
-							openedOn: null,
-							portfolioSummary: null,
-							type: "BROKERAGE",
-						}
-						/* eslint-enable unicorn/no-null */))),
+					accounts.map(
+						/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+						account =>
+							({
+								...account,
+								openedOn: null,
+								portfolioSummary: null,
+								type: "BROKERAGE",
+							}),
+						/* eslint-enable unicorn/no-null */
+					),
 				),
 			),
 		),
@@ -162,15 +182,17 @@ beforeEach(() => {
 			"*/api/v1/brokerage-accounts/:accountId/operations",
 			({ params }) =>
 				HttpResponse.json(
-					resource((/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+					/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+					resource(
 						{
 							accountId: params.accountId,
 							hasNext: false,
 							items,
 							nextCursor: null,
 							observedAt: receipt.occurredAt,
-						}
-						/* eslint-enable unicorn/no-null */)),
+						},
+						/* eslint-enable unicorn/no-null */
+					),
 				),
 		),
 		http.get("*/api/v1/brokerage-accounts/:accountId/income-analytics", () =>
@@ -181,21 +203,24 @@ beforeEach(() => {
 				resource({
 					accountId: "all",
 					calculatedAt: receipt.occurredAt,
-					events: accounts.map(account => ((/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
-						{
-							account,
-							date: "2026-09-15",
-							dateKind: "event",
-							displayName: "Облигация",
-							figi: null,
-							instrumentUid: null,
-							isin: null,
-							logoName: null,
-							projectedAmount: { currency: "RUB", value: "2" },
-							ticker: "BOND",
-							type: "coupon",
-						}
-						/* eslint-enable unicorn/no-null */))),
+					events: accounts.map(
+						/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+						account =>
+							({
+								account,
+								date: "2026-09-15",
+								dateKind: "event",
+								displayName: "Облигация",
+								figi: null,
+								instrumentUid: null,
+								isin: null,
+								logoName: null,
+								projectedAmount: { currency: "RUB", value: "2" },
+								ticker: "BOND",
+								type: "coupon",
+							}),
+						/* eslint-enable unicorn/no-null */
+					),
 					incomeTotalsByCurrency: [],
 				}),
 			),
@@ -235,7 +260,11 @@ describe("All accounts routes", () => {
 			);
 		for (const suffix of ["operations", "income", "events"])
 			expect(
-				screen.getAllByRole("link").find(link => link.getAttribute("href") === `/accounts/all/${suffix}`),
+				screen
+					.getAllByRole("link")
+					.find(
+						link => link.getAttribute("href") === `/accounts/all/${suffix}`,
+					),
 			).toBeInTheDocument();
 	});

@@ -247,8 +276,10 @@ describe("All accounts routes", () => {
 				({ params, request }) => {
 					const url = new URL(request.url);
 					requests.push(url);
+
 					return HttpResponse.json(
-						resource((/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+						/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+						resource(
 							{
 								accountId: params.accountId,
 								hasNext: !url.searchParams.has("cursor"),
@@ -262,8 +293,9 @@ describe("All accounts routes", () => {
 								],
 								nextCursor: url.searchParams.has("cursor") ? null : "next",
 								observedAt: receipt.occurredAt,
-							}
-							/* eslint-enable unicorn/no-null */)),
+							},
+							/* eslint-enable unicorn/no-null */
+						),
 					);
 				},
 			),
@@ -281,9 +313,11 @@ describe("All accounts routes", () => {
 				requests.some(url => url.pathname.includes("/b/operations")),
 			).toBe(true),
 		);
+
 		const selected = requests.find(url =>
 			url.pathname.includes("/b/operations"),
 		);
+
 		expect(selected?.searchParams.get("from")).toBe("2026-08-01T00:00:00.000Z");
 		expect(selected?.searchParams.get("to")).toBe("2026-08-31T23:59:59.999Z");
 		expect(selected?.searchParams.get("categories")).toBe("income");