refactor: align frontend ownership boundaries

Close audit gaps across API drift, query policy, UI, and tests.

src/entities/broker-operation/api/useBrokerageOperations.test.tsx

@@ -1,17 +1,13 @@
-import { MantineProvider } from "@mantine/core";
-import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
 import { renderHook, waitFor } from "@testing-library/react";
-import type { FC, PropsWithChildren } from "react";
-import { afterEach, describe, expect, it, vi } from "vitest";
+import { describe, expect, it, vi } from "vitest";
 import { configureAuthClient } from "@/shared/api";
+import { createQueryWrapper } from "@/test/query";
 import {
 	brokerageOperationsQueryParams,
 	useBrokerageOperations,
 } from "./useBrokerageOperations";
 
 describe("useBrokerageOperations", () => {
-	afterEach(() => configureAuthClient(null));
-
 	it("normalizes query parameters and loads a page without retries", async () => {
 		configureAuthClient({
 			accessToken: () => "token",
@@ -24,20 +20,9 @@ describe("useBrokerageOperations", () => {
 				cursor: "next",
 			}),
 		).toEqual({ categories: ["income", "tax"], cursor: "next" });
-		const client = new QueryClient();
-		const wrapper: FC<PropsWithChildren> = (props) => {
-			const { children } = props;
-
-			return (
-				<MantineProvider>
-					<QueryClientProvider client={client}>{children}</QueryClientProvider>
-				</MantineProvider>
-			);
-		};
-
 		const { result } = renderHook(
 			() => useBrokerageOperations("account-1", { limit: 5 }),
-			{ wrapper },
+			{ wrapper: createQueryWrapper().wrapper },
 		);
 
 		await waitFor(() => expect(result.current.isSuccess).toBe(true));

src/entities/broker-operation/api/useBrokerageOperations.ts

@@ -1,5 +1,8 @@
-import { apiQueryClient, useAuthenticatedQuery } from "@/shared/api";
-import type { paths } from "@/shared/api/generated/schema";
+import {
+	apiQueryClient,
+	type paths,
+	useAuthenticatedQuery,
+} from "@/shared/api";
 
 type OperationsEndpoint =
 	paths["/api/v1/brokerage-accounts/{accountId}/operations"]["get"];
@@ -32,25 +35,36 @@ function brokerageOperationsQueryParams(query: BrokerageOperationsQuery) {
 	};
 }
 
+function brokerageOperationsQueryOptions(
+	accountId: string | undefined,
+	query: BrokerageOperationsQuery = {},
+) {
+	return apiQueryClient.queryOptions(
+		"get",
+		"/api/v1/brokerage-accounts/{accountId}/operations",
+		{
+			params: {
+				path: { accountId: accountId ?? "" },
+				query: brokerageOperationsQueryParams(query),
+			},
+		},
+	);
+}
+
 function useBrokerageOperations(
 	accountId: string | undefined,
 	query: BrokerageOperationsQuery = {},
 ) {
-	const params = brokerageOperationsQueryParams(query);
 	return useAuthenticatedQuery({
-		...apiQueryClient.queryOptions(
-			"get",
-			"/api/v1/brokerage-accounts/{accountId}/operations",
-			{ params: { path: { accountId: accountId ?? "" }, query: params } },
-		),
+		...brokerageOperationsQueryOptions(accountId, query),
 		enabled: Boolean(accountId),
 		staleTime: 30_000,
-		retry: false,
 	});
 }
 
 export {
 	type BrokerageOperation,
+	brokerageOperationsQueryOptions,
 	brokerageOperationsQueryParams,
 	type OperationCategory,
 	operationCategories,

src/entities/broker-operation/index.ts

@@ -1,5 +1,6 @@
 export {
 	type BrokerageOperation,
+	brokerageOperationsQueryOptions,
 	type OperationCategory,
 	operationCategories,
 	useBrokerageOperations,

src/entities/broker-operation/model/display.ts

@@ -0,0 +1,53 @@
+import { formatMoney } from "@/shared/lib";
+import type { BrokerageOperation } from "../api/useBrokerageOperations";
+
+type PaymentPresentation = {
+	amount: string;
+	label: string;
+	tone: "positive" | "negative" | "neutral";
+};
+
+function entryLabelKey(operation: BrokerageOperation): string {
+	if (operation.category === "income")
+		return operation.type === "OPERATION_TYPE_COUPON"
+			? "ledger.entryLabel.income.coupon"
+			: "ledger.entryLabel.income.dividend";
+	return `ledger.category.${operation.category}`;
+}
+
+function paymentPresentation(
+	operation: BrokerageOperation,
+): PaymentPresentation {
+	if (!operation.payment)
+		return {
+			amount: "—",
+			label: "ledger.noMoney",
+			tone: "neutral",
+		};
+	if (isZeroDecimal(operation.payment.value))
+		return {
+			amount: formatMoney(operation.payment),
+			label: "ledger.noMoney",
+			tone: "neutral",
+		};
+	if (operation.payment.value.startsWith("-"))
+		return {
+			amount: `−${formatMoney({
+				...operation.payment,
+				value: operation.payment.value.slice(1),
+			})}`,
+			label: entryLabelKey(operation),
+			tone: "negative",
+		};
+	return {
+		amount: `+${formatMoney(operation.payment)}`,
+		label: entryLabelKey(operation),
+		tone: "positive",
+	};
+}
+
+function isZeroDecimal(value: string): boolean {
+	return /^-?0(?:\.0+)?$/.test(value);
+}
+
+export { paymentPresentation };

src/entities/broker-operation/ui/LedgerEntryRow.tsx

@@ -2,32 +2,15 @@ import { Avatar, Paper, Stack, Text } from "@mantine/core";
 import type { FC } from "react";
 import { useState } from "react";
 import { useTranslation } from "react-i18next";
-import {
-	formatMoney,
-	formatSnapshotTime,
-	instrumentLogoUrl,
-} from "@/entities/portfolio";
+import { formatSnapshotTime, instrumentLogoUrl } from "@/shared/lib";
 import type { BrokerageOperation } from "../api/useBrokerageOperations";
+import { paymentPresentation } from "../model/display";
 import classes from "./LedgerEntryRow.module.css";
 
 type LedgerEntryRowProps = {
 	operation: BrokerageOperation;
 };
 
-type PaymentPresentation = {
-	amount: string;
-	label: string;
-	tone: "positive" | "negative" | "neutral";
-};
-
-function entryLabelKey(operation: BrokerageOperation): string {
-	if (operation.category === "income")
-		return operation.type === "OPERATION_TYPE_COUPON"
-			? "ledger.entryLabel.income.coupon"
-			: "ledger.entryLabel.income.dividend";
-	return `ledger.category.${operation.category}`;
-}
-
 const LedgerEntryRow: FC<LedgerEntryRowProps> = (props) => {
 	const { operation } = props;
 	const { t } = useTranslation();
@@ -72,39 +55,4 @@ const LedgerEntryRow: FC<LedgerEntryRowProps> = (props) => {
 	);
 };
 
-function paymentPresentation(
-	operation: BrokerageOperation,
-): PaymentPresentation {
-	if (!operation.payment)
-		return {
-			amount: "—",
-			label: "ledger.noMoney",
-			tone: "neutral",
-		};
-	if (isZeroDecimal(operation.payment.value))
-		return {
-			amount: formatMoney(operation.payment),
-			label: "ledger.noMoney",
-			tone: "neutral",
-		};
-	if (operation.payment.value.startsWith("-"))
-		return {
-			amount: `−${formatMoney({
-				...operation.payment,
-				value: operation.payment.value.slice(1),
-			})}`,
-			label: entryLabelKey(operation),
-			tone: "negative",
-		};
-	return {
-		amount: `+${formatMoney(operation.payment)}`,
-		label: entryLabelKey(operation),
-		tone: "positive",
-	};
-}
-
-function isZeroDecimal(value: string): boolean {
-	return /^-?0(?:\.0+)?$/.test(value);
-}
-
 export { LedgerEntryRow };