refactor: address frontend review feedback
Frontend verify / commits (pull_request) Successful in 29s
Frontend verify / security (pull_request) Successful in 9s
Frontend verify / verify (pull_request) Successful in 8m54s
Frontend verify / commits (push) Skipped
Frontend verify / security (push) Successful in 12s
Frontend verify / verify (push) Successful in 9m59s

This commit was merged in pull request #43.
This commit is contained in:
2026-09-28 19:20:32 +03:00
parent ca0ad4f824
commit a4046dbe87
139 changed files with 1549 additions and 941 deletions
+2 -4
View File
@@ -19,10 +19,9 @@ const handlers = [
),
http.get("*/api/v1/auth/me", () => HttpResponse.json(authentication.user)),
http.get("*/api/v1/tbank-connection", () =>
/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
HttpResponse.json(
{ connected: false, connectedAt: null },
/* eslint-enable unicorn/no-null */
),
),
http.put("*/api/v1/tbank-connection", () =>
@@ -49,7 +48,7 @@ const handlers = [
),
http.get("*/api/v1/brokerage-accounts/:accountId/operations", () =>
HttpResponse.json(
/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
resource(
{
accountId: "account-1",
@@ -58,7 +57,6 @@ const handlers = [
nextCursor: null,
observedAt: "2026-08-14T00:00:00Z",
},
/* eslint-enable unicorn/no-null */
),
),
),
+13 -17
View File
@@ -4,23 +4,19 @@ type Meta
= paths["/api/v1/brokerage-accounts"]["get"]["responses"][200]["content"]["application/json"]["meta"];
function resource<T>(data: T, meta: Partial<Meta> = {}) {
/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
return (
{
data,
meta: {
availability: data === null ? "missing" : "complete",
dataRevision: "1",
freshness: "fresh",
lastSuccessfulAt: "2026-08-14T00:00:00Z",
resourceKey: "fixture",
stateVersion: "1",
sync: { errorCode: null, id: null, state: "idle" },
...meta,
} satisfies Meta,
}
/* eslint-enable unicorn/no-null */
);
return {
data,
meta: {
availability: data === null ? "missing" : "complete",
dataRevision: "1",
freshness: "fresh",
lastSuccessfulAt: "2026-08-14T00:00:00Z",
resourceKey: "fixture",
stateVersion: "1",
sync: { errorCode: null, id: null, state: "idle" },
...meta,
} satisfies Meta,
};
}
export { resource };
-1
View File
@@ -40,7 +40,6 @@ Object.defineProperty(globalThis, "matchMedia", {
matches: false,
media: query,
onchange:
// eslint-disable-next-line unicorn/no-null -- Exercise the explicit null returned by the production API/DOM contract.
null,
removeEventListener: () => {},
removeListener: () => {},