refactor: address frontend review feedback
Frontend verify / commits (pull_request) Successful in 29s
Frontend verify / security (pull_request) Successful in 9s
Frontend verify / verify (pull_request) Successful in 8m54s
Frontend verify / commits (push) Skipped
Frontend verify / security (push) Successful in 12s
Frontend verify / verify (push) Successful in 9m59s

This commit was merged in pull request #43.
This commit is contained in:
2026-09-28 19:20:32 +03:00
parent ca0ad4f824
commit a4046dbe87
139 changed files with 1549 additions and 941 deletions
@@ -4,8 +4,6 @@ import type { AccountPagePosition } from "../../AccountPage.vm";
import { PositionCard } from "./PositionCard.view";
/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
const syntheticPosition
= {
absoluteReturn: { currency: "RUB", value: "5000" },
@@ -22,7 +20,7 @@ const syntheticPosition
shareText: "20%",
ticker: "DEMO",
type: "STOCK",
} satisfies /* eslint-enable unicorn/no-null */ AccountPagePosition;
} satisfies AccountPagePosition;
const meta = {
args: { kind: "stocks", position: syntheticPosition },
@@ -62,8 +60,6 @@ export const StockGain: Story = {
},
};
/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
export const BondLoss: Story
= {
args: {
@@ -94,9 +90,6 @@ export const BondLoss: Story
},
},
};
/* eslint-enable unicorn/no-null */
/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
export const Other: Story
= {
@@ -120,9 +113,6 @@ export const Other: Story
},
},
};
/* eslint-enable unicorn/no-null */
/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
export const MissingValuation: Story
= {
@@ -149,4 +139,3 @@ export const MissingValuation: Story
},
},
};
/* eslint-enable unicorn/no-null */
@@ -60,10 +60,10 @@ const PositionCard: FC<PositionCardProps> = (props) => {
? t("portfolio.avgPrice", {
value: formatMoney(position.averagePurchasePrice),
})
: null, // eslint-disable-line unicorn/no-null -- Mantine represents an empty controlled field as null.
: null,
position.shareText
? t("portfolio.share", { value: position.shareText })
: null, // eslint-disable-line unicorn/no-null -- Mantine represents an empty controlled field as null.
: null,
]
.filter(Boolean)
.join(" · ");