chore: finish frontend ESLint migration #18

Enable every plugin recommended preset and replace Biome with ESLint formatting. Preserve API contracts and JSX whitespace; verify source, tests, builds and tooling.
2026-09-28 16:36:40 +03:00
parent 57630102e4
commit 72d7835227
253 changed files with 10059 additions and 8864 deletions
@@ -1,7 +1,9 @@
-import { resource } from "@/test/resource";
+import type { FC } from "react";
+
 import "dayjs/locale/ru";
 import { MantineProvider } from "@mantine/core";
 import { DatesProvider } from "@mantine/dates";
+import { QueryClientProvider } from "@tanstack/react-query";
 import {
 	act,
 	fireEvent,
@@ -11,8 +13,7 @@ import {
 	waitFor,
 	within,
 } from "@testing-library/react";
-import { HttpResponse, http } from "msw";
-import type { FC } from "react";
+import { http, HttpResponse } from "msw";
 import {
 	MemoryRouter,
 	Route,
@@ -21,10 +22,14 @@ import {
 	useNavigate,
 } from "react-router";
 import { afterEach, describe, expect, it, vi } from "vitest";
+
 import type { IncomeAnalytics } from "@/entities/income";
+
 import { configureAuthClient } from "@/shared/api";
-import { createQueryWrapper } from "@/test/query";
+import { createTestQueryClient } from "@/test/query";
+import { resource } from "@/test/resource";
 import { server } from "@/test/server";
+
 import { isDate } from "../../model/period";
 import { AccountIncomePage } from "./AccountIncomePage";
 import {
@@ -33,16 +38,9 @@ import {
 } from "./AccountIncomePage.vm";
 import { IncomePayments } from "./components/IncomePayments.view";

-const analytics = {
+const analytics = (/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+{
 	accountId: "account-1",
-	period: { from: "2026-08-01", to: "2026-08-27" },
-	calculatedAt: "2026-08-27T00:00:00Z",
-	totalsByCurrency: [summary("RUB", "10", "2")],
-	previous: {
-		period: { from: "2026-07-01", to: "2026-07-31" },
-		totalsByCurrency: [comparison("RUB")],
-	},
-	yearComparison: null,
 	bucketGranularity: "day",
 	buckets: [
 		{
@@ -50,113 +48,124 @@ const analytics = {
 			totalsByCurrency: [summary("RUB", "10", "2")],
 		},
 	],
-	instruments: [
-		{
-			key: "income-group-opaque-v2",
-			figi: "FIGI",
-			instrumentUid: null,
-			ticker: "BOND",
-			instrumentType: "bond",
-			displayName: "BOND",
-			coupon: money("RUB", "10"),
-			dividend: money("RUB", "2"),
-			total: money("RUB", "12"),
-			receiptCount: 2,
-		},
-	],
+	calculatedAt: "2026-08-27T00:00:00Z",
 	entries: [
 		entry(),
 		{
 			...entry(),
 			id: "dividend-1",
-			type: "OPERATION_TYPE_DIVIDEND",
 			payment: money("RUB", "2"),
+			type: "OPERATION_TYPE_DIVIDEND",
 		},
 	],
-} satisfies IncomeAnalytics;
+	instruments: [
+		{
+			coupon: money("RUB", "10"),
+			displayName: "BOND",
+			dividend: money("RUB", "2"),
+			figi: "FIGI",
+			instrumentType: "bond",
+			instrumentUid: null,
+			key: "income-group-opaque-v2",
+			receiptCount: 2,
+			ticker: "BOND",
+			total: money("RUB", "12"),
+		},
+	],
+	period: { from: "2026-08-01", to: "2026-08-27" },
+	previous: {
+		period: { from: "2026-07-01", to: "2026-07-31" },
+		totalsByCurrency: [comparison("RUB")],
+	},
+	totalsByCurrency: [summary("RUB", "10", "2")],
+	yearComparison: null,
+}
+/* eslint-enable unicorn/no-null */) satisfies IncomeAnalytics;
+
+function comparison(currency: string) {
+	return {
+		compared: summary(currency, "1", "0"),
+		currency,
+		difference: summary(currency, "9", "2"),
+		selected: summary(currency, "10", "2"),
+	};
+}
+
+function entry(): IncomeAnalytics["entries"][number] {
+	return (/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+		{
+			accruedInterest: null,
+			category: "income",
+			commission: null,
+			description: "Купон",
+			figi: "FIGI",
+			id: "coupon-1",
+			instrumentKey: "income-group-opaque-v2",
+			instrumentType: "bond",
+			instrumentUid: null,
+			logoName: null,
+			occurredAt: "2026-08-01T12:00:00Z",
+			payment: money("RUB", "10"),
+			price: null,
+			quantity: null,
+			ticker: "BOND",
+			type: "OPERATION_TYPE_COUPON",
+		}
+	/* eslint-enable unicorn/no-null */);
+}

 function money(currency: string, value: string) {
 	return { currency, value };
 }

-function summary(currency: string, coupon: string, dividend: string) {
-	return {
-		currency,
-		coupon: money(currency, coupon),
-		dividend: money(currency, dividend),
-		total: money(currency, String(Number(coupon) + Number(dividend))),
-	};
-}
-
-function comparison(currency: string) {
-	return {
-		currency,
-		selected: summary(currency, "10", "2"),
-		compared: summary(currency, "1", "0"),
-		difference: summary(currency, "9", "2"),
-	};
-}
-
-function entry(): IncomeAnalytics["entries"][number] {
-	return {
-		id: "coupon-1",
-		instrumentKey: "income-group-opaque-v2",
-		occurredAt: "2026-08-01T12:00:00Z",
-		type: "OPERATION_TYPE_COUPON",
-		category: "income",
-		description: "Купон",
-		figi: "FIGI",
-		instrumentUid: null,
-		ticker: "BOND",
-		instrumentType: "bond",
-		logoName: null,
-		payment: money("RUB", "10"),
-		quantity: null,
-		price: null,
-		accruedInterest: null,
-		commission: null,
-	};
-}
-
 function renderPage(search = "from=2026-08-01&to=2026-08-27") {
 	configureAuthClient({
 		accessToken: () => "token",
-		refresh: async () => true,
 		clear: vi.fn(),
+		refresh: () => Promise.resolve(true),
 	});
-	const { wrapper: QueryWrapper, queryClient } = createQueryWrapper();
-	const result = render(
+	const queryClient = createTestQueryClient();
+	const view = render(
 		<MantineProvider env="test">
 			<DatesProvider settings={{ locale: "ru" }}>
-				<QueryWrapper>
+				<QueryClientProvider client={queryClient}>
 					<MemoryRouter
 						initialEntries={[`/accounts/account-1/income?${search}`]}
 					>
 						<LocationProbe />
 						<Routes>
 							<Route
-								path="/accounts/:accountId/income"
 								element={<AccountIncomePage />}
+								path="/accounts/:accountId/income"
 							/>
 							<Route
-								path="/accounts/:accountId/events"
 								element={<h1>Events</h1>}
+								path="/accounts/:accountId/events"
 							/>
 						</Routes>
 					</MemoryRouter>
-				</QueryWrapper>
+				</QueryClientProvider>
 			</DatesProvider>
 		</MantineProvider>,
 	);
-	return { ...result, queryClient };
+	return { ...view, queryClient };
+}
+
+function summary(currency: string, coupon: string, dividend: string) {
+	return {
+		coupon: money(currency, coupon),
+		currency,
+		dividend: money(currency, dividend),
+		total: money(currency, String(Number(coupon) + Number(dividend))),
+	};
 }

 describe("AccountIncomePage", () => {
 	it("keeps reads and sync disabled without an account scope", async () => {
 		configureAuthClient({
 			accessToken: () => "token",
-			refresh: async () => true,
 			clear: vi.fn(),
+			refresh: () => Promise.resolve(true),
 		});
 		const requests: string[] = [];
 		server.use(
@@ -165,17 +174,17 @@ describe("AccountIncomePage", () => {
 				return new HttpResponse(null, { status: 503 });
 			}),
 		);
-		const { wrapper: QueryWrapper, queryClient } = createQueryWrapper();
+		const queryClient = createTestQueryClient();
 		const { result } = renderHook(() => useAccountIncomePageViewModel(), {
 			wrapper: ({ children }) => (
-				<QueryWrapper>
+				<QueryClientProvider client={queryClient}>
 					<MemoryRouter initialEntries={["?from=2024-02-29&to=2024-03-01"]}>
 						{children}
 					</MemoryRouter>
-				</QueryWrapper>
+				</QueryClientProvider>
 			),
 		});
-		await act(async () => {});
+		await new Promise(resolve => setTimeout(resolve, 0));
 		expect(result.current).toEqual({ state: "loading" });
 		expect(queryClient.isFetching()).toBe(0);
 		expect(requests).toEqual([]);
@@ -190,13 +199,15 @@ describe("AccountIncomePage", () => {
 				({ request }) => {
 					requested.push(new URL(request.url).search);
 					return HttpResponse.json(
-						resource(null, {
-							sync: {
-								id: null,
-								state: "failed",
-								errorCode: "TBANK_UNAVAILABLE",
-							},
-						}),
+						resource(null, (/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+							{
+								sync: {
+									errorCode: "TBANK_UNAVAILABLE",
+									id: null,
+									state: "failed",
+								},
+							}
+							/* eslint-enable unicorn/no-null */)),
 					);
 				},
 			),
@@ -216,9 +227,9 @@ describe("AccountIncomePage", () => {
 		await waitFor(() =>
 			expect(syncRequests).toEqual([
 				{
-					screen: "income",
 					accountId: "account-1",
 					from: "2024-02-29",
+					screen: "income",
 					to: "2024-03-01",
 				},
 			]),
@@ -243,32 +254,32 @@ describe("AccountIncomePage", () => {
 	});

 	it("preserves every repeated-ID payment when an open card updates", async () => {
-		const first = { ...entry(), id: "same-id", description: "Выплата A" };
+		const first = { ...entry(), description: "Выплата A", id: "same-id" };
 		const second = {
 			...entry(),
-			id: "same-id",
 			description: "Выплата B",
+			id: "same-id",
 			payment: money("RUB", "-2"),
 		};
 		const third = {
 			...entry(),
-			id: "other-id",
 			description: "Выплата C",
+			id: "other-id",
 			payment: money("RUB", "1"),
 		};
 		function breakdown(entries: IncomeAnalytics["entries"], total: string) {
 			const display = toIncomeDisplayModel({
 				...analytics,
+				entries,
 				instruments: [
 					{
 						...analytics.instruments[0],
 						coupon: money("RUB", total),
 						dividend: money("RUB", "0"),
-						total: money("RUB", total),
 						receiptCount: entries.length,
+						total: money("RUB", total),
 					},
 				],
-				entries,
 			});
 			expect(display).not.toBeNull();
 			return (
@@ -282,7 +293,7 @@ describe("AccountIncomePage", () => {
 		const payments = () =>
 			within(panel)
 				.getAllByText(/^Выплата [ABC]$/)
-				.map((element) => element.textContent);
+				.map(element => element.textContent);
 		expect(payments()).toEqual(["Выплата A", "Выплата B", "Выплата C"]);

 		rerender(breakdown([third, first, second], "9"));
@@ -380,10 +391,10 @@ describe("AccountIncomePage", () => {
 				HttpResponse.json(
 					resource({
 						...analytics,
-						totalsByCurrency: [],
 						buckets: [],
-						instruments: [],
 						entries: [],
+						instruments: [],
+						totalsByCurrency: [],
 					}),
 				),
 			),
@@ -398,33 +409,35 @@ describe("AccountIncomePage", () => {
 	});

 	it("renders the signed drill-down using opaque membership rather than instrument identity", async () => {
-		const response = {
-			...analytics,
-			instruments: [
-				{
-					...analytics.instruments[0],
-					key: "server-only-key",
-					total: money("RUB", "8"),
-					dividend: money("RUB", "-2"),
-				},
-			],
-			entries: [
-				{
-					...analytics.entries[0],
-					instrumentKey: "server-only-key",
-					figi: null,
-					ticker: null,
-					description: "Исходная выплата",
-				},
-				{
-					...analytics.entries[1],
-					instrumentKey: "server-only-key",
-					instrumentUid: "unrelated-uid",
-					payment: money("RUB", "-2"),
-					description: "Отрицательная корректировка",
-				},
-			],
-		};
+		const response = (/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+			{
+				...analytics,
+				entries: [
+					{
+						...analytics.entries[0],
+						description: "Исходная выплата",
+						figi: null,
+						instrumentKey: "server-only-key",
+						ticker: null,
+					},
+					{
+						...analytics.entries[1],
+						description: "Отрицательная корректировка",
+						instrumentKey: "server-only-key",
+						instrumentUid: "unrelated-uid",
+						payment: money("RUB", "-2"),
+					},
+				],
+				instruments: [
+					{
+						...analytics.instruments[0],
+						dividend: money("RUB", "-2"),
+						key: "server-only-key",
+						total: money("RUB", "8"),
+					},
+				],
+			}
+		/* eslint-enable unicorn/no-null */);
 		server.use(
 			http.get("*/api/v1/brokerage-accounts/account-1/income-analytics", () =>
 				HttpResponse.json(resource(response)),
@@ -485,7 +498,7 @@ describe("AccountIncomePage", () => {
 		expect(screen.queryByText("Выбранный период")).not.toBeInTheDocument();
 		expect(screen.queryByText("Сравниваемый период")).not.toBeInTheDocument();
 		expect(
-			screen.getByRole("heading", { name: "Годом ранее", level: 2 }),
+			screen.getByRole("heading", { level: 2, name: "Годом ранее" }),
 		).toBeInTheDocument();
 		expect(screen.queryByText("Сравнения")).not.toBeInTheDocument();
 		expect(screen.queryByText("RUB", { exact: true })).not.toBeInTheDocument();
@@ -501,6 +514,7 @@ describe("AccountIncomePage", () => {
 		expect(within(difference).queryByText("нет базы")).not.toBeInTheDocument();
 		expect(within(difference).getAllByText(/%$/)).toHaveLength(2);
 		expect(
+			// eslint-disable-next-line testing-library/no-node-access -- This assertion checks DOM structure, decoration or focus behavior that semantic queries cannot establish.
 			within(difference).getByText("+2 ₽").closest("dd"),
 		).toHaveTextContent(/^\+2 ₽$/);
 	});
@@ -509,11 +523,13 @@ describe("AccountIncomePage", () => {
 		const dependencies = [
 			{ ...resource(analytics).meta, role: "selected" as const },
 			{ ...resource(analytics).meta, role: "previous" as const },
-			{
-				...resource(null).meta,
-				role: "year" as const,
-				unavailableReason: "CALENDAR_OR_ACCOUNT_HISTORY",
-			},
+			(
+				{
+					...resource(null).meta,
+					role: "year" as const,
+					unavailableReason: "CALENDAR_OR_ACCOUNT_HISTORY",
+				}
+			),
 		];
 		server.use(
 			http.get("*/api/v1/brokerage-accounts/account-1/income-analytics", () =>
@@ -556,12 +572,12 @@ describe("income comparison display", () => {
 		["1", "3", "+33,3 %"],
 		["0.01", "0.04", "+25 %"],
 		["123456789012345678.123456789", "123456789012345678.123456789", "+100 %"],
-		["10", "0", null],
-		["0", "0", null],
-		["10", "-0.00", null],
-		["10", "-100", null],
-		["9".repeat(400), "1", null],
-		["1", "9".repeat(400), null],
+		["10", "0", /* eslint-disable-line unicorn/no-null -- Exercise the explicit null returned by the production API/DOM contract. */ null],
+		["0", "0", /* eslint-disable-line unicorn/no-null -- Exercise the explicit null returned by the production API/DOM contract. */ null],
+		["10", "-0.00", /* eslint-disable-line unicorn/no-null -- Exercise the explicit null returned by the production API/DOM contract. */ null],
+		["10", "-100", /* eslint-disable-line unicorn/no-null -- Exercise the explicit null returned by the production API/DOM contract. */ null],
+		["9".repeat(400), "1", /* eslint-disable-line unicorn/no-null -- Exercise the explicit null returned by the production API/DOM contract. */ null],
+		["1", "9".repeat(400), /* eslint-disable-line unicorn/no-null -- Exercise the explicit null returned by the production API/DOM contract. */ null],
 	])("formats change %s against base %s", (difference, base, expected) => {
 		const value = comparison("RUB");
 		value.difference.coupon = money("RUB", difference);
@@ -574,7 +590,7 @@ describe("income comparison display", () => {
 			},
 		});
 		const result = display?.comparison?.values[0];
-		expect(result?.percentages.coupon?.replaceAll("\u00a0", " ") ?? null).toBe(
+		expect(result?.percentages.coupon?.replaceAll("\u{A0}", " ") ?? /* eslint-disable-line unicorn/no-null -- Exercise the explicit null returned by the production API/DOM contract. */ null).toBe(
 			expected,
 		);
 		expect(result?.difference.coupon.value).toBe(difference);
@@ -596,7 +612,7 @@ describe("income comparison display", () => {
 		expect(display?.comparison?.comparedPeriod.replaceAll(/\s/g, " ")).toBe(
 			"01.12.2024 – 09.01.2025",
 		);
-		expect(display?.comparison?.values.map((value) => value.currency)).toEqual([
+		expect(display?.comparison?.values.map(value => value.currency)).toEqual([
 			"RUB",
 			"USD",
 		]);
@@ -609,19 +625,13 @@ const LocationProbe: FC = () => {
 	return (
 		<>
 			<output data-testid="location">{location.search}</output>
-			<button type="button" onClick={() => navigate(-1)}>
+			<button onClick={() => navigate(-1)} type="button">
 				Back
 			</button>
 		</>
 	);
 };

-function selectPeriod() {
-	fireEvent.click(screen.getByLabelText("Период"));
-	fireEvent.click(screen.getByRole("button", { name: /^2 августа 2026$/i }));
-	fireEvent.click(screen.getByRole("button", { name: /^27 августа 2026$/i }));
-}
-
 function respondWithRequestedPeriod(requests: string[]) {
 	server.use(
 		http.get(
@@ -643,6 +653,12 @@ function respondWithRequestedPeriod(requests: string[]) {
 	);
 }

+function selectPeriod() {
+	fireEvent.click(screen.getByLabelText("Период"));
+	fireEvent.click(screen.getByRole("button", { name: /^2 августа 2026$/i }));
+	fireEvent.click(screen.getByRole("button", { name: /^27 августа 2026$/i }));
+}
+
 describe("income period and snapshot boundary", () => {
 	afterEach(() => vi.useRealTimers());

@@ -664,6 +680,7 @@ describe("income period and snapshot boundary", () => {
 		fireEvent.submit(
 			screen
 				.getByRole("button", { name: "Применить" })
+				// eslint-disable-next-line testing-library/no-node-access -- This assertion checks DOM structure, decoration or focus behavior that semantic queries cannot establish.
 				.closest("form") as HTMLFormElement,
 		);
 		await waitFor(() => expect(requests).toHaveLength(2));
@@ -735,10 +752,8 @@ describe("income period and snapshot boundary", () => {
 		const { queryClient } = renderPage();
 		await screen.findByLabelText("Период");
 		selectPeriod();
-		let release!: () => void;
-		const pending = new Promise<void>((resolve) => {
-			release = resolve;
-		});
+
+		const { promise: pending, resolve: release } = Promise.withResolvers<void>();
 		server.use(
 			http.get(
 				"*/api/v1/brokerage-accounts/account-1/income-analytics",
@@ -768,22 +783,24 @@ describe("income period and snapshot boundary", () => {
 				HttpResponse.json(
 					{
 						id: "income",
-						scope: { screen: "income", accountId: "account-1" },
 						now: "2026-09-25T00:00:00Z",
+						scope: { accountId: "account-1", screen: "income" },
 					},
 					{ status: 202 },
 				),
 			),
 			http.get("*/api/v1/tbank-sync/:id", () =>
-				HttpResponse.json({
-					id: "income",
-					scope: null,
-					now: "2026-09-25T00:00:00Z",
-					state: "succeeded",
-					errorCode: null,
-					progress: { total: 1, completed: 1, discovering: false },
-					resources: [resource(null, { stateVersion: "2" }).meta],
-				}),
+				HttpResponse.json((/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+					{
+						errorCode: null,
+						id: "income",
+						now: "2026-09-25T00:00:00Z",
+						progress: { completed: 1, discovering: false, total: 1 },
+						resources: [resource(null, { stateVersion: "2" }).meta],
+						scope: null,
+						state: "succeeded",
+					}
+					/* eslint-enable unicorn/no-null */)),
 			),
 			http.get("*/api/v1/brokerage-accounts/account-1/income-analytics", () =>
 				HttpResponse.json(resource(analytics, { stateVersion: "2" })),
@@ -804,10 +821,8 @@ describe("income period and snapshot boundary", () => {
 		respondWithRequestedPeriod([]);
 		renderPage();
 		await screen.findByLabelText("Период");
-		let release!: () => void;
-		const pending = new Promise<void>((resolve) => {
-			release = resolve;
-		});
+
+		const { promise: pending, resolve: release } = Promise.withResolvers<void>();
 		server.use(
 			http.get(
 				"*/api/v1/brokerage-accounts/account-1/income-analytics",
@@ -843,39 +858,39 @@ describe("income period and snapshot boundary", () => {
 		const instruments = [
 			{
 				...analytics.instruments[0],
-				key: "usd",
-				total: money("USD", "10"),
 				coupon: money("USD", "10"),
 				dividend: money("USD", "0"),
+				key: "usd",
 				receiptCount: 1,
+				total: money("USD", "10"),
 			},
 			{
 				...analytics.instruments[0],
-				key: "rub",
-				total: money("RUB", "-2"),
 				coupon: money("RUB", "-2"),
 				dividend: money("RUB", "0"),
+				key: "rub",
 				receiptCount: 1,
+				total: money("RUB", "-2"),
 			},
 			{
 				...analytics.instruments[0],
-				key: "rub-negative",
-				displayName: "Другой инструмент",
-				total: money("RUB", "-3"),
 				coupon: money("RUB", "-3"),
+				displayName: "Другой инструмент",
 				dividend: money("RUB", "0"),
+				key: "rub-negative",
 				receiptCount: 1,
+				total: money("RUB", "-3"),
 			},
 		];
 		const display = toIncomeDisplayModel({
 			...analytics,
-			totalsByCurrency: [summary("RUB", "-5", "0"), summary("USD", "10", "0")],
-			instruments,
-			entries: instruments.map((instrument) => ({
+			entries: instruments.map(instrument => ({
 				...entry(),
 				instrumentKey: instrument.key,
 				payment: instrument.total,
 			})),
+			instruments,
+			totalsByCurrency: [summary("RUB", "-5", "0"), summary("USD", "10", "0")],
 		});
 		render(
 			<MantineProvider env="test">
@@ -902,22 +917,26 @@ describe("income period and snapshot boundary", () => {

 it("maps comparison notices by role regardless of dependency order or resource key", () => {
 	const selected = { ...resource(analytics).meta, role: "selected" as const };
-	const previous = {
-		...resource(null).meta,
-		resourceKey: "opaque/year-looking-key",
-		role: "previous" as const,
-		sync: {
-			id: null,
-			state: "failed" as const,
-			errorCode: "TBANK_UNAVAILABLE",
-		},
-	};
-	const year = {
-		...resource(null).meta,
-		resourceKey: "opaque/previous-looking-key",
-		role: "year" as const,
-		unavailableReason: "CALENDAR_OR_ACCOUNT_HISTORY",
-	};
+	const previous = (/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+		{
+			...resource(null).meta,
+			resourceKey: "opaque/year-looking-key",
+			role: "previous" as const,
+			sync: {
+				errorCode: "TBANK_UNAVAILABLE",
+				id: null,
+				state: "failed" as const,
+			},
+		}
+	/* eslint-enable unicorn/no-null */);
+	const year = (
+		{
+			...resource(null).meta,
+			resourceKey: "opaque/previous-looking-key",
+			role: "year" as const,
+			unavailableReason: "CALENDAR_OR_ACCOUNT_HISTORY",
+		}
+	);
 	for (const dependencies of [
 		[selected, previous, year],
 		[year, selected, previous],
@@ -939,16 +958,20 @@ it.each([false, true])(
 			http.get("*/api/v1/brokerage-accounts/account-1/income-analytics", () =>
 				HttpResponse.json(
 					resource(
-						{ ...analytics, previous: null, yearComparison: null },
-						{
-							dependencies: legacy
-								? [
-										resource(null).meta,
-										resource(null).meta,
-										resource(null).meta,
-									]
-								: [],
-						},
+						(/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+							{ ...analytics, previous: null, yearComparison: null }
+						/* eslint-enable unicorn/no-null */),
+						(
+							{
+								dependencies: legacy
+									? [
+											resource(null).meta,
+											resource(null).meta,
+											resource(null).meta,
+										]
+									: [],
+							}
+						),
 					),
 				),
 			),
@@ -969,16 +992,20 @@ it.each([false, true])(

 it("shows selected income before comparison coverage without inventing a zero baseline", async () => {
 	const dependencies = (["year", "selected", "previous"] as const).map(
-		(role) => ({
-			...resource(role === "selected" ? analytics : null).meta,
-			role,
-		}),
+		role => ((/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+			{
+				...resource(role === "selected" ? analytics : null).meta,
+				role,
+			}
+			/* eslint-enable unicorn/no-null */)),
 	);
 	server.use(
 		http.get("*/api/v1/brokerage-accounts/account-1/income-analytics", () =>
 			HttpResponse.json(
 				resource(
-					{ ...analytics, previous: null, yearComparison: null },
+					(/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+						{ ...analytics, previous: null, yearComparison: null }
+					/* eslint-enable unicorn/no-null */),
 					{ dependencies },
 				),
 			),
@@ -1005,15 +1032,17 @@ it("shows selected income before comparison coverage without inventing a zero ba
 it("keeps complete previous comparison while year source failed without inventing its amounts", async () => {
 	const dependencies = [
 		{ ...resource(analytics).meta, role: "previous" as const },
-		{
-			...resource(null).meta,
-			role: "year" as const,
-			sync: {
-				id: null,
-				state: "failed" as const,
-				errorCode: "TBANK_UNAVAILABLE",
-			},
-		},
+		(/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+			{
+				...resource(null).meta,
+				role: "year" as const,
+				sync: {
+					errorCode: "TBANK_UNAVAILABLE",
+					id: null,
+					state: "failed" as const,
+				},
+			}
+		/* eslint-enable unicorn/no-null */),
 		{ ...resource(analytics).meta, role: "selected" as const },
 	];
 	server.use(