chore: finish frontend ESLint migration #18

Enable every plugin recommended preset and replace Biome with ESLint formatting.

Preserve API contracts and JSX whitespace; verify source, tests, builds and tooling.

src/app/routes/AppRoutes/AllAccounts.test.tsx

@@ -1,3 +1,5 @@
+import type { FC } from "react";
+
 import { MantineProvider } from "@mantine/core";
 import { QueryClientProvider } from "@tanstack/react-query";
 import {
@@ -7,96 +9,104 @@ import {
 	screen,
 	waitFor,
 } from "@testing-library/react";
-import { HttpResponse, http } from "msw";
-import type { FC } from "react";
+import { http, HttpResponse } from "msw";
 import { MemoryRouter, useLocation } from "react-router";
 import { beforeEach, describe, expect, it } from "vitest";
+
 import type { BrokerageOperation } from "@/entities/broker-operation";
 import type { IncomeAnalytics } from "@/entities/income";
 import type { Portfolio } from "@/entities/portfolio";
+
 import { AuthProvider } from "@/features/auth";
 import { createTestQueryClient } from "@/test/query";
 import { resource } from "@/test/resource";
 import { server } from "@/test/server";
+
 import { AppRoutes } from "./AppRoutes";
 
 const accounts = [
 	{ id: "a", name: "Основной" },
 	{ id: "b", name: "ИИС" },
 ];
-const position: Portfolio["positions"][number] = {
-	figi: "SBER",
-	displayName: "Сбербанк",
-	type: "STOCK",
-	quantity: "2",
-	currentValue: { currency: "RUB", value: "600" },
-	absoluteReturn: null,
-	averagePurchasePrice: null,
-	isin: null,
-	ticker: "SBER",
-	logoName: null,
-};
+const position: Portfolio["positions"][number] = (/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+	{
+		absoluteReturn: null,
+		averagePurchasePrice: null,
+		currentValue: { currency: "RUB", value: "600" },
+		displayName: "Сбербанк",
+		figi: "SBER",
+		isin: null,
+		logoName: null,
+		quantity: "2",
+		ticker: "SBER",
+		type: "STOCK",
+	}
+/* eslint-enable unicorn/no-null */);
 const portfolio: Portfolio = {
-	lastSuccessfulAt: "2026-08-15T12:00:00Z",
-	isStale: false,
-	totalsByCurrency: [{ currency: "RUB", value: "1200" }],
-	structure: { currencies: [], unvaluedCategories: [] },
 	cashBalances: [],
-	positions: accounts.map((account) => ({ ...position, account })),
+	isStale: false,
+	lastSuccessfulAt: "2026-08-15T12:00:00Z",
+	positions: accounts.map(account => ({ ...position, account })),
+	structure: { currencies: [], unvaluedCategories: [] },
+	totalsByCurrency: [{ currency: "RUB", value: "1200" }],
 };
-const receipt: BrokerageOperation = {
-	id: "same",
-	occurredAt: "2026-08-15T12:00:00Z",
-	type: "OPERATION_TYPE_COUPON",
-	category: "income",
-	description: "Выплата купона",
-	figi: null,
-	instrumentUid: null,
-	ticker: "BOND",
-	instrumentType: "bond",
-	logoName: null,
-	payment: { currency: "RUB", value: "1" },
-	quantity: null,
-	price: null,
-	accruedInterest: null,
-	commission: null,
-};
-const items = accounts.map((account) => ({ ...receipt, account }));
-const analytics: IncomeAnalytics = {
-	accountId: "all",
-	period: { from: "2026-08-01", to: "2026-08-31" },
-	calculatedAt: "2026-09-01T12:00:00Z",
-	totalsByCurrency: [
-		{
-			currency: "RUB",
-			coupon: { currency: "RUB", value: "2" },
-			dividend: { currency: "RUB", value: "0" },
-			total: { currency: "RUB", value: "2" },
+const receipt: BrokerageOperation = (/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+	{
+		accruedInterest: null,
+		category: "income",
+		commission: null,
+		description: "Выплата купона",
+		figi: null,
+		id: "same",
+		instrumentType: "bond",
+		instrumentUid: null,
+		logoName: null,
+		occurredAt: "2026-08-15T12:00:00Z",
+		payment: { currency: "RUB", value: "1" },
+		price: null,
+		quantity: null,
+		ticker: "BOND",
+		type: "OPERATION_TYPE_COUPON",
+	}
+/* eslint-enable unicorn/no-null */);
+const items = accounts.map(account => ({ ...receipt, account }));
+const analytics: IncomeAnalytics = (/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+	{
+		accountId: "all",
+		bucketGranularity: "day",
+		buckets: [],
+		calculatedAt: "2026-09-01T12:00:00Z",
+		entries: items.map(entry => ({ ...entry, instrumentKey: "bond:RUB" })),
+		instruments: [
+			{
+				coupon: { currency: "RUB", value: "2" },
+				displayName: "Облигация",
+				dividend: { currency: "RUB", value: "0" },
+				figi: null,
+				instrumentType: "bond",
+				instrumentUid: null,
+				key: "bond:RUB",
+				receiptCount: 2,
+				ticker: "BOND",
+				total: { currency: "RUB", value: "2" },
+			},
+		],
+		period: { from: "2026-08-01", to: "2026-08-31" },
+		previous: {
+			period: { from: "2026-07-01", to: "2026-07-31" },
+			totalsByCurrency: [],
 		},
-	],
-	previous: {
-		period: { from: "2026-07-01", to: "2026-07-31" },
-		totalsByCurrency: [],
-	},
-	yearComparison: null,
-	bucketGranularity: "day",
-	buckets: [],
-	instruments: [
-		{
-			key: "bond:RUB",
-			figi: null,
-			instrumentUid: null,
-			ticker: "BOND",
-			instrumentType: "bond",
-			displayName: "Облигация",
-			coupon: { currency: "RUB", value: "2" },
-			dividend: { currency: "RUB", value: "0" },
-			total: { currency: "RUB", value: "2" },
-			receiptCount: 2,
-		},
-	],
-	entries: items.map((entry) => ({ ...entry, instrumentKey: "bond:RUB" })),
-};
+		totalsByCurrency: [
+			{
+				coupon: { currency: "RUB", value: "2" },
+				currency: "RUB",
+				dividend: { currency: "RUB", value: "0" },
+				total: { currency: "RUB", value: "2" },
+			},
+		],
+		yearComparison: null,
+	}
+/* eslint-enable unicorn/no-null */);
 const CurrentLocation: FC = () => {
 	const location = useLocation();
 	return (
@@ -128,18 +138,20 @@ beforeEach(() => {
 		http.post("*/api/v1/auth/refresh", () =>
 			HttpResponse.json({
 				accessToken: "test",
-				user: { id: "user", email: "user@example.com" },
+				user: { email: "user@example.com", id: "user" },
 			}),
 		),
 		http.get("*/api/v1/brokerage-accounts", () =>
 			HttpResponse.json(
 				resource(
-					accounts.map((account) => ({
-						...account,
-						type: "BROKERAGE",
-						openedOn: null,
-						portfolioSummary: null,
-					})),
+					accounts.map(account => ((/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+						{
+							...account,
+							openedOn: null,
+							portfolioSummary: null,
+							type: "BROKERAGE",
+						}
+						/* eslint-enable unicorn/no-null */))),
 				),
 			),
 		),
@@ -150,13 +162,15 @@ beforeEach(() => {
 			"*/api/v1/brokerage-accounts/:accountId/operations",
 			({ params }) =>
 				HttpResponse.json(
-					resource({
-						accountId: params.accountId,
-						items,
-						hasNext: false,
-						nextCursor: null,
-						observedAt: receipt.occurredAt,
-					}),
+					resource((/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+						{
+							accountId: params.accountId,
+							hasNext: false,
+							items,
+							nextCursor: null,
+							observedAt: receipt.occurredAt,
+						}
+						/* eslint-enable unicorn/no-null */)),
 				),
 		),
 		http.get("*/api/v1/brokerage-accounts/:accountId/income-analytics", () =>
@@ -167,20 +181,22 @@ beforeEach(() => {
 				resource({
 					accountId: "all",
 					calculatedAt: receipt.occurredAt,
+					events: accounts.map(account => ((/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+						{
+							account,
+							date: "2026-09-15",
+							dateKind: "event",
+							displayName: "Облигация",
+							figi: null,
+							instrumentUid: null,
+							isin: null,
+							logoName: null,
+							projectedAmount: { currency: "RUB", value: "2" },
+							ticker: "BOND",
+							type: "coupon",
+						}
+						/* eslint-enable unicorn/no-null */))),
 					incomeTotalsByCurrency: [],
-					events: accounts.map((account) => ({
-						account,
-						type: "coupon",
-						date: "2026-09-15",
-						dateKind: "event",
-						figi: null,
-						instrumentUid: null,
-						ticker: "BOND",
-						displayName: "Облигация",
-						isin: null,
-						logoName: null,
-						projectedAmount: { currency: "RUB", value: "2" },
-					})),
 				}),
 			),
 		),
@@ -219,7 +235,7 @@ describe("All accounts routes", () => {
 			);
 		for (const suffix of ["operations", "income", "events"])
 			expect(
-				document.querySelector(`a[href="/accounts/all/${suffix}"]`),
+				screen.getAllByRole("link").find(link => link.getAttribute("href") === `/accounts/all/${suffix}`),
 			).toBeInTheDocument();
 	});
 
@@ -228,24 +244,26 @@ describe("All accounts routes", () => {
 		server.use(
 			http.get(
 				"*/api/v1/brokerage-accounts/:accountId/operations",
-				({ request, params }) => {
+				({ params, request }) => {
 					const url = new URL(request.url);
 					requests.push(url);
 					return HttpResponse.json(
-						resource({
-							accountId: params.accountId,
-							items: [
-								{
-									...receipt,
-									description: url.searchParams.has("cursor")
-										? "Вторая страница"
-										: "Первая страница",
-								},
-							],
-							hasNext: !url.searchParams.has("cursor"),
-							nextCursor: url.searchParams.has("cursor") ? null : "next",
-							observedAt: receipt.occurredAt,
-						}),
+						resource((/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+							{
+								accountId: params.accountId,
+								hasNext: !url.searchParams.has("cursor"),
+								items: [
+									{
+										...receipt,
+										description: url.searchParams.has("cursor")
+											? "Вторая страница"
+											: "Первая страница",
+									},
+								],
+								nextCursor: url.searchParams.has("cursor") ? null : "next",
+								observedAt: receipt.occurredAt,
+							}
+							/* eslint-enable unicorn/no-null */)),
 					);
 				},
 			),
@@ -260,10 +278,10 @@ describe("All accounts routes", () => {
 		fireEvent.click(await screen.findByRole("option", { name: "ИИС" }));
 		await waitFor(() =>
 			expect(
-				requests.some((url) => url.pathname.includes("/b/operations")),
+				requests.some(url => url.pathname.includes("/b/operations")),
 			).toBe(true),
 		);
-		const selected = requests.find((url) =>
+		const selected = requests.find(url =>
 			url.pathname.includes("/b/operations"),
 		);
 		expect(selected?.searchParams.get("from")).toBe("2026-08-01T00:00:00.000Z");
@@ -286,8 +304,8 @@ describe("All accounts routes", () => {
 					: HttpResponse.json(
 							resource({
 								accountId: "all",
-								items,
 								hasNext: true,
+								items,
 								nextCursor: "expired",
 								observedAt: receipt.occurredAt,
 							}),
@@ -305,7 +323,7 @@ describe("All accounts routes", () => {
 	});
 
 	it("retains the complete portfolio during a failed refresh", async () => {
-		const client = renderPage("/accounts/all");
+		const view = renderPage("/accounts/all");
 		await screen.findAllByText("Сбербанк");
 		server.use(
 			http.get("*/api/v1/brokerage-accounts/all/portfolio", () =>
@@ -313,7 +331,7 @@ describe("All accounts routes", () => {
 			),
 		);
 		await act(() =>
-			client.invalidateQueries({
+			view.invalidateQueries({
 				predicate: ({ queryKey }) => String(queryKey[1]).endsWith("/portfolio"),
 			}),
 		);

src/app/routes/AppRoutes/AppRoutes.test.tsx

@@ -2,32 +2,34 @@ import { MantineProvider } from "@mantine/core";
 import { QueryClientProvider } from "@tanstack/react-query";
 import { fireEvent, render, screen } from "@testing-library/react";
 import { cssVariablesResolver, theme } from "@wealthledger/ui/theme";
-import { HttpResponse, http } from "msw";
+import { http, HttpResponse } from "msw";
 import { MemoryRouter } from "react-router";
 import { describe, expect, it } from "vitest";
+
 import { AuthProvider } from "@/features/auth";
 import { createTestQueryClient } from "@/test/query";
 import { server } from "@/test/server";
+
 import { AppRoutes } from "./AppRoutes";
 
-describe("AppRoutes", () => {
-	function renderRoutes(path: string) {
-		return render(
-			<QueryClientProvider client={createTestQueryClient()}>
-				<MemoryRouter initialEntries={[path]}>
-					<MantineProvider
-						cssVariablesResolver={cssVariablesResolver}
-						theme={theme}
-					>
-						<AuthProvider>
-							<AppRoutes />
-						</AuthProvider>
-					</MantineProvider>
-				</MemoryRouter>
-			</QueryClientProvider>,
-		);
-	}
+function renderRoutes(path: string) {
+	return render(
+		<QueryClientProvider client={createTestQueryClient()}>
+			<MemoryRouter initialEntries={[path]}>
+				<MantineProvider
+					cssVariablesResolver={cssVariablesResolver}
+					theme={theme}
+				>
+					<AuthProvider>
+						<AppRoutes />
+					</AuthProvider>
+				</MantineProvider>
+			</MemoryRouter>
+		</QueryClientProvider>,
+	);
+}
 
+describe("AppRoutes", () => {
 	it.each([
 		["/", "Вход"],
 		["/login", "Вход"],
@@ -62,7 +64,7 @@ describe("AppRoutes", () => {
 				credentials = await request.json();
 				return HttpResponse.json({
 					accessToken: "login-token",
-					user: { id: "user-1", email: "user@example.com" },
+					user: { email: "user@example.com", id: "user-1" },
 				});
 			}),
 		);
@@ -96,19 +98,21 @@ describe("AppRoutes", () => {
 			http.post("*/api/v1/auth/login", () =>
 				HttpResponse.json({
 					accessToken: "test",
-					user: { id: "user-1", email: "user@example.com" },
+					user: { email: "user@example.com", id: "user-1" },
 				}),
 			),
 			http.get("*/api/v1/bank-cards", () => HttpResponse.json([])),
 			http.get("*/api/v1/bank-cards/summary", () =>
-				HttpResponse.json({
-					month: "2026-08",
-					cardId: null,
-					expenses: { currency: "RUB", value: "0" },
-					refunds: { currency: "RUB", value: "0" },
-					net: { currency: "RUB", value: "0" },
-					categories: [],
-				}),
+				HttpResponse.json((/* eslint-disable unicorn/no-null -- Fixture preserves the production contract’s explicit null values. */
+					{
+						cardId: null,
+						categories: [],
+						expenses: { currency: "RUB", value: "0" },
+						month: "2026-08",
+						net: { currency: "RUB", value: "0" },
+						refunds: { currency: "RUB", value: "0" },
+					}
+					/* eslint-enable unicorn/no-null */)),
 			),
 		);
 		renderRoutes("/cards?month=2026-08");
@@ -132,7 +136,7 @@ describe("AppRoutes", () => {
 			http.post("*/api/v1/auth/refresh", () =>
 				HttpResponse.json({
 					accessToken: "test-token",
-					user: { id: "user-1", email: "user@example.com" },
+					user: { email: "user@example.com", id: "user-1" },
 				}),
 			),
 		);

src/app/routes/AppRoutes/AppRoutes.tsx

@@ -1,6 +1,8 @@
 import type { FC } from "react";
+
 import { lazy } from "react";
 import { Navigate, Route, Routes } from "react-router";
+
 import { LazyPage } from "../RouteFallback";
 import { Protected, Public } from "../RouteGuards";
 
@@ -71,172 +73,172 @@ const ProtectedLayout = lazy(async () => {
 
 const AppRoutes: FC = () => (
 	<Routes>
-		<Route path="/" element={<Navigate to="/accounts" replace />} />
+		<Route element={<Navigate replace to="/accounts" />} path="/" />
 		<Route
-			path="/login"
-			element={
+			element={(
 				<Public>
 					<LazyPage variant="auth">
 						<LoginPage />
 					</LazyPage>
 				</Public>
-			}
+			)}
+			path="/login"
 		/>
 		<Route
-			path="/register"
-			element={
+			element={(
 				<Public>
 					<LazyPage variant="auth">
 						<RegisterPage />
 					</LazyPage>
 				</Public>
-			}
+			)}
+			path="/register"
 		/>
 		<Route
-			element={
+			element={(
 				<Protected>
 					<LazyPage variant="shell">
 						<ProtectedLayout />
 					</LazyPage>
 				</Protected>
-			}
+			)}
 		>
 			<Route
-				path="/cards/:cardId"
-				element={
+				element={(
 					<LazyPage variant="content">
 						<CardPage />
 					</LazyPage>
-				}
+				)}
+				path="/cards/:cardId"
 			/>
 			<Route
-				path="/cards"
-				element={
+				element={(
 					<LazyPage variant="content">
 						<CardsPage />
 					</LazyPage>
-				}
+				)}
+				path="/cards"
 			/>
 			<Route
-				path="/bonds"
-				element={
+				element={(
 					<LazyPage variant="content">
 						<BondsPage />
 					</LazyPage>
-				}
+				)}
+				path="/bonds"
 			/>
 			<Route
-				path="/bonds/:bondId"
-				element={
+				element={(
 					<LazyPage variant="content">
 						<BondPage />
 					</LazyPage>
-				}
+				)}
+				path="/bonds/:bondId"
 			/>
 			<Route
-				path="/stocks"
-				element={
+				element={(
 					<LazyPage variant="content">
 						<StocksPage />
 					</LazyPage>
-				}
+				)}
+				path="/stocks"
 			/>
 			<Route
-				path="/stocks/:stockId"
-				element={
+				element={(
 					<LazyPage variant="content">
 						<StockPage />
 					</LazyPage>
-				}
+				)}
+				path="/stocks/:stockId"
 			/>
 			<Route
-				path="/accounts"
-				element={
+				element={(
 					<LazyPage variant="content">
 						<AccountsPage />
 					</LazyPage>
-				}
+				)}
+				path="/accounts"
 			/>
 			<Route
-				path="/accounts/all"
-				element={
+				element={(
 					<LazyPage variant="content">
 						<AccountPage accountId="all" />
 					</LazyPage>
-				}
+				)}
+				path="/accounts/all"
 			/>
 			<Route
-				path="/accounts/all/operations"
-				element={
+				element={(
 					<LazyPage variant="content">
 						<AccountOperationsPage accountId="all" />
 					</LazyPage>
-				}
+				)}
+				path="/accounts/all/operations"
 			/>
 			<Route
-				path="/accounts/all/income"
-				element={
+				element={(
 					<LazyPage variant="content">
 						<AccountIncomePage accountId="all" />
 					</LazyPage>
-				}
+				)}
+				path="/accounts/all/income"
 			/>
 			<Route
-				path="/accounts/all/events"
-				element={
+				element={(
 					<LazyPage variant="content">
 						<AccountEventsPage accountId="all" />
 					</LazyPage>
-				}
+				)}
+				path="/accounts/all/events"
 			/>
 			<Route
-				path="/accounts/:accountId"
-				element={
+				element={(
 					<LazyPage variant="content">
 						<AccountPage />
 					</LazyPage>
-				}
+				)}
+				path="/accounts/:accountId"
 			/>
 			<Route
-				path="/accounts/:accountId/events"
-				element={
+				element={(
 					<LazyPage variant="content">
 						<AccountEventsPage />
 					</LazyPage>
-				}
+				)}
+				path="/accounts/:accountId/events"
 			/>
 			<Route
-				path="/accounts/:accountId/income"
-				element={
+				element={(
 					<LazyPage variant="content">
 						<AccountIncomePage />
 					</LazyPage>
-				}
+				)}
+				path="/accounts/:accountId/income"
 			/>
 			<Route
-				path="/accounts/:accountId/operations"
-				element={
+				element={(
 					<LazyPage variant="content">
 						<AccountOperationsPage />
 					</LazyPage>
-				}
+				)}
+				path="/accounts/:accountId/operations"
 			/>
 			<Route
-				path="/settings"
-				element={
+				element={(
 					<LazyPage variant="content">
 						<SettingsPage />
 					</LazyPage>
-				}
+				)}
+				path="/settings"
 			/>
 		</Route>
 		<Route
-			path="*"
-			element={
+			element={(
 				<LazyPage variant="content">
 					<NotFoundPage />
 				</LazyPage>
-			}
+			)}
+			path="*"
 		/>
 	</Routes>
 );