WealthLedger/frontend
5
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: enforce enum machine codes #18
Frontend verify / commits (push) Skipped
Details
Frontend verify / security (push) Successful in 11s
Details
Frontend verify / verify (push) Successful in 9m31s
Details

Browse Source 
Use owner enums for known codes; preserve wire values and unknown fallbacks.

Verified npm ci and verify: 379 tests, 5 lint checks, app and Storybook builds.
This commit was merged in pull request #41.
This commit is contained in:
ksv741
2026-09-28 16:36:40 +03:00
committed by ksv741
parent 12c3b72bfb
commit 5b69003516
26 changed files with 248 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/entities/broker-operation/model/display.ts
+37 -16
View File
@@ -2,6 +2,23 @@ import { formatMoney } from "@/shared/lib";
import type { BrokerageOperation } from "../api/useBrokerageOperations";
enum OperationType {
Buy = "OPERATION_TYPE_BUY",
BuyCard = "OPERATION_TYPE_BUY_CARD",
BuyMargin = "OPERATION_TYPE_BUY_MARGIN",
Coupon = "OPERATION_TYPE_COUPON",
DivExtension = "OPERATION_TYPE_DIV_EXT",
Dividend = "OPERATION_TYPE_DIVIDEND",
DividendTransfer = "OPERATION_TYPE_DIVIDEND_TRANSFER",
InputSecurities = "OPERATION_TYPE_INPUT_SECURITIES",
OutputSecurities = "OPERATION_TYPE_OUTPUT_SECURITIES",
Sell = "OPERATION_TYPE_SELL",
SellCard = "OPERATION_TYPE_SELL_CARD",
SellMargin = "OPERATION_TYPE_SELL_MARGIN",
}
const operationTransferPrefix = "OPERATION_TYPE_TRANS_";
type PaymentPresentation = {
amount: string;
label: string;
@@ -10,12 +27,16 @@ type PaymentPresentation = {
function entryLabelKey(operation: BrokerageOperation): string {
if (operation.category === "income")
return operation.type === "OPERATION_TYPE_COUPON"
return isOperationType(operation.type, OperationType.Coupon)
? "ledger.entryLabel.income.coupon"
: "ledger.entryLabel.income.dividend";
return `ledger.category.${operation.category}`;
}
function isOperationType(value: unknown, expected: OperationType): boolean {
return value === expected;
}
function isZeroDecimal(value: string): boolean {
return /^-?0$|^-?0\.0+$/.test(value);
}
@@ -23,35 +44,35 @@ function isZeroDecimal(value: string): boolean {
function operationLabelKey(type: string): string {
if (
[
"OPERATION_TYPE_BUY",
"OPERATION_TYPE_BUY_CARD",
"OPERATION_TYPE_BUY_MARGIN",
].includes(type)
OperationType.Buy,
OperationType.BuyCard,
OperationType.BuyMargin,
].some(candidate => isOperationType(type, candidate))
)
return "ledger.operationType.buy";
if (
[
"OPERATION_TYPE_SELL",
"OPERATION_TYPE_SELL_CARD",
"OPERATION_TYPE_SELL_MARGIN",
].includes(type)
OperationType.Sell,
OperationType.SellCard,
OperationType.SellMargin,
].some(candidate => isOperationType(type, candidate))
)
return "ledger.operationType.sell";
if (
[
"OPERATION_TYPE_DIV_EXT",
"OPERATION_TYPE_DIVIDEND",
"OPERATION_TYPE_DIVIDEND_TRANSFER",
].includes(type)
OperationType.DivExtension,
OperationType.Dividend,
OperationType.DividendTransfer,
].some(candidate => isOperationType(type, candidate))
)
return "ledger.operationType.dividend";
if (type.includes("TAX")) return "ledger.operationType.tax";
if (type.includes("FEE")) return "ledger.operationType.fee";
if (type === "OPERATION_TYPE_INPUT_SECURITIES")
if (isOperationType(type, OperationType.InputSecurities))
return "ledger.operationType.input";
if (type === "OPERATION_TYPE_OUTPUT_SECURITIES")
if (isOperationType(type, OperationType.OutputSecurities))
return "ledger.operationType.output";
return type.startsWith("OPERATION_TYPE_TRANS_") ? "ledger.operationType.transfer" : "ledger.operationType.other";
return type.startsWith(operationTransferPrefix) ? "ledger.operationType.transfer" : "ledger.operationType.other";
}
function paymentPresentation(