feat: add quiet reading with rare confirmations

Part of the quiet-user-feedback change; docs and specs land in their own repositories.

src/features/instrument-details/model/section.test.ts

@@ -1,4 +1,4 @@
-import { describe, expect, it, vi } from "vitest";
+import { describe, expect, it } from "vitest";
 
 import { resource } from "@/test/resource";
 
@@ -13,9 +13,7 @@ describe("instrument source and transport presentation", () => {
 			const state = section({
 				data,
 				isError: false,
-				isFetching: false,
 				meta: resource(data, { availability }).meta,
-				refetch: vi.fn(),
 			});
 
 			expect(state.loading).toBe(availability === "missing");
@@ -23,39 +21,40 @@ describe("instrument source and transport presentation", () => {
 			expect(state.hasData).toBe(availability !== "missing");
 		},
 	);
-	it("preserves a full fresh source and timestamp when force fails, while offering scoped retry", () => {
-		const retry = vi.fn();
-		const refetch = vi.fn();
+	it("preserves empty successful data instead of treating it as missing", () => {
+		const state = section({
+			data: [],
+			isError: false,
+			meta: resource([]).meta,
+		});
 
+		expect(state).toMatchObject({
+			error: false,
+			hasData: true,
+			loading: false,
+		});
+	});
+
+	it("preserves a full source when force fails", () => {
 		const meta = resource([], {
 			sync: { errorCode: "TBANK_UNAVAILABLE", id: "work", state: "failed" },
 		}).meta;
 
-		const state = section(
-			{ data: [], isError: false, isFetching: false, meta, refetch },
-			retry,
-		);
+		const state = section({ data: [], isError: false, meta });
 
 		expect(state).toMatchObject({
 			error: true,
 			hasData: true,
-			lastSuccessfulAt: meta.lastSuccessfulAt,
 			loading: false,
-			refreshing: false,
 		});
-		state.retry();
-		expect(retry).toHaveBeenCalledOnce();
-		expect(refetch).not.toHaveBeenCalled();
 	});
 	it("shows source failure without a false loading or empty result", () => {
 		const state = section({
 			data: undefined,
 			isError: false,
-			isFetching: false,
 			meta: resource(null, {
 				sync: { errorCode: "TBANK_UNAVAILABLE", id: "work", state: "failed" },
 			}).meta,
-			refetch: vi.fn(),
 		});
 
 		expect(state).toMatchObject({

src/features/instrument-details/model/section.ts

@@ -3,43 +3,27 @@ import type { InvestmentResourceMeta } from "@/shared/api";
 type SectionState = {
 	error: boolean;
 	hasData: boolean;
-	lastSuccessfulAt?: null | string;
 	loading: boolean;
 	partial?: boolean;
-	refreshing: boolean;
-	retry: () => void;
-	sourceError?: boolean;
-	stale?: boolean;
 };
 
-function section(
-	query: {
-		data: unknown;
-		isError: boolean;
-		isFetching: boolean;
-		meta?: InvestmentResourceMeta;
-		refetch: () => unknown;
-	},
-	retry?: () => unknown,
-): SectionState {
+function hasSectionData(data: unknown) {
+	return data !== undefined;
+}
+
+function section(query: {
+	data: unknown;
+	isError: boolean;
+	meta?: InvestmentResourceMeta;
+}): SectionState {
 	const isError = query.isError || query.meta?.sync.state === "failed";
+	const hasData = hasSectionData(query.data);
 
 	return {
 		error: isError,
-		hasData: Boolean(query.data),
-		lastSuccessfulAt: query.meta?.lastSuccessfulAt,
-		loading: !query.data && !isError,
+		hasData,
+		loading: !hasData && !isError,
 		partial: query.meta?.availability === "partial",
-		refreshing:
-			Boolean(query.data)
-			&& (query.isFetching
-				|| query.meta?.sync.state === "running"
-			),
-		retry: () => {
-			void (retry ?? query.refetch)();
-		},
-		sourceError: query.meta?.sync.state === "failed",
-		stale: query.meta?.freshness === "stale",
 	};
 }