refactor: simplify finance view models

src/pages/accounts/ui/AccountsPage/AccountsPage.vm.ts

@@ -15,31 +15,31 @@ function useAccountsPageViewModel() {
 	) {
 		if (!accounts.isError && accounts.meta?.sync.state !== "failed")
 			return { state: "loading" as const };
-		if (accounts.isError || accounts.meta?.sync.state === "failed")
-			return {
-				code: apiErrorCode(accounts.error),
-				retry: sync.retry,
-				state: "error" as const,
-			};
+
+		return {
+			code: apiErrorCode(accounts.error),
+			retry: sync.retry,
+			state: "error" as const,
+		};
 	}
 
-	if (!accounts.data?.length)
-		return {
-			lastSuccessfulAt: accounts.meta?.lastSuccessfulAt,
-			refreshError: accounts.isError || sync.transportError || sync.sourceError,
-			refreshing: accounts.isFetching || sync.refreshing,
-			retry: sync.retry,
-			sourceError: sync.sourceError,
-			state: "empty" as const,
-		};
-
-	return {
-		accounts: brokerageAccountCards(accounts.data, accounts.meta?.dependencies),
+	const refresh = {
 		lastSuccessfulAt: accounts.meta?.lastSuccessfulAt,
 		refreshError: accounts.isError || sync.transportError || sync.sourceError,
 		refreshing: accounts.isFetching || sync.refreshing,
 		retry: sync.retry,
 		sourceError: sync.sourceError,
+	};
+
+	if (accounts.data.length === 0)
+		return {
+			...refresh,
+			state: "empty" as const,
+		};
+
+	return {
+		accounts: brokerageAccountCards(accounts.data, accounts.meta?.dependencies),
+		...refresh,
 		state: "loaded" as const,
 	};
 }