refactor: clarify frontend model ownership

2026-09-28 21:44:53 +03:00
parent 7e976c330c
commit 0865b35f93
44 changed files with 685 additions and 710 deletions
@@ -1,4 +1,4 @@
-import type { IncomeAnalytics, useIncomeAnalytics } from "@/entities/income";
+import type { IncomeAnalytics, IncomeAnalyticsMeta } from "@/entities/income";

 import { formatDate } from "@/shared/lib";

@@ -29,8 +29,6 @@ type IncomeDisplayModel = {
 	yearNotice: ComparisonNotice;
 };

-type IncomeMeta = ReturnType<typeof useIncomeAnalytics>["meta"];
-
 function comparisonDisplay(
 	period: IncomePeriod,
 	comparison: IncomeAnalytics["yearComparison"],
@@ -63,7 +61,7 @@ function comparisonDisplay(

 function comparisonNotice(
 	dependency:
-		NonNullable<NonNullable<IncomeMeta>["dependencies"]>[number] | undefined,
+		IncomeAnalyticsMeta["dependencies"][number] | undefined,
 	unavailable: "previousUnavailable" | "yearUnavailable",
 ): ComparisonNotice {
 	if (!dependency || dependency.unavailableReason) return unavailable;
@@ -98,7 +96,7 @@ function formatIncomeChange(

 function toIncomeDisplayModel(
 	analytics: IncomeAnalytics,
-	meta?: IncomeMeta,
+	meta?: IncomeAnalyticsMeta,
 ): IncomeDisplayModel | null {
 	const instruments = new Map<
 		string,