refactor: clarify frontend model ownership

src/pages/account-events/ui/AccountEventsPage/AccountEventsPage.filters.test.tsx

@@ -146,12 +146,14 @@ describe("Upcoming event date filters", () => {
 			const queryClient = createTestQueryClient();
 
 			const { result } = renderHook(
-				() => useAccountEventsPageViewModel("all"),
+				() => useAccountEventsPageViewModel(),
 				{
 					wrapper: ({ children }) => (
 						<QueryClientProvider client={queryClient}>
-							<MemoryRouter initialEntries={[`?${search}`]}>
-								{children}
+							<MemoryRouter initialEntries={[`/accounts/all/events?${search}`]}>
+								<Routes>
+									<Route element={children} path="/accounts/:accountId/events" />
+								</Routes>
 							</MemoryRouter>
 						</QueryClientProvider>
 					),
@@ -326,10 +328,14 @@ it("retains the previous complete forecast and timestamp when its source refresh
 	);
 	const queryClient = createTestQueryClient();
 
-	const { result } = renderHook(() => useAccountEventsPageViewModel("all"), {
+	const { result } = renderHook(() => useAccountEventsPageViewModel(), {
 		wrapper: ({ children }) => (
 			<QueryClientProvider client={queryClient}>
-				<MemoryRouter>{children}</MemoryRouter>
+				<MemoryRouter initialEntries={["/accounts/all/events"]}>
+					<Routes>
+						<Route element={children} path="/accounts/:accountId/events" />
+					</Routes>
+				</MemoryRouter>
 			</QueryClientProvider>
 		),
 	});

src/pages/account-events/ui/AccountEventsPage/AccountEventsPage.tsx

@@ -5,10 +5,8 @@ import { AccountEventsPageError } from "./components/AccountEventsPageError.view
 import { AccountEventsPageLoaded } from "./components/AccountEventsPageLoaded.view";
 import { AccountEventsPageLoading } from "./components/AccountEventsPageLoading.view";
 
-type AccountEventsPageProps = { accountId?: string };
-
-const AccountEventsPage: FC<AccountEventsPageProps> = (props) => {
-	const viewModel = useAccountEventsPageViewModel(props.accountId);
+const AccountEventsPage: FC = () => {
+	const viewModel = useAccountEventsPageViewModel();
 	if (viewModel.state === "loading") return <AccountEventsPageLoading />;
 
 	return viewModel.state === "error"

src/pages/account-events/ui/AccountEventsPage/AccountEventsPage.vm.ts

@@ -27,11 +27,8 @@ type AccountEventsPageViewModel
 	| { onReset: () => void; retry: () => void; state: "error" }
 	| { state: "loading" };
 
-function useAccountEventsPageViewModel(
-	scopeId?: string,
-): AccountEventsPageViewModel {
-	const { accountId: routeAccountId } = useParams();
-	const accountId = scopeId ?? routeAccountId ?? "";
+function useAccountEventsPageViewModel(): AccountEventsPageViewModel {
+	const { accountId = "" } = useParams();
 	const [searchParameters, setSearchParameters] = useSearchParams();
 	const urlFrom = searchParameters.get("from");
 	const urlTo = searchParameters.get("to");
@@ -59,13 +56,11 @@ function useAccountEventsPageViewModel(
 		setSearchParameters(normalized, { replace: true });
 	}, [isValidUrlPeriod, searchParameters, setSearchParameters]);
 
-	const [previousPeriod, setPreviousPeriod] = useState([
-		appliedFrom,
-		appliedTo,
-	]);
+	const scope = JSON.stringify([accountId, appliedFrom, appliedTo]);
+	const [previousScope, setPreviousScope] = useState(scope);
 
-	if (previousPeriod[0] !== appliedFrom || previousPeriod[1] !== appliedTo) {
-		setPreviousPeriod([appliedFrom, appliedTo]);
+	if (previousScope !== scope) {
+		setPreviousScope(scope);
 		setDraftPeriod([appliedFrom, appliedTo]);
 	}