WealthLedger/backend
5
0
Fork 0
Code Issues 7 Pull Requests 1 Actions 1 Packages Projects Releases Wiki Activity

perf: start bond search prices with details (WealthLedger/backend#71) #89

Merged
codex-bot merged 1 commits from fix/71-bond-search-parallel-prices into develop 2026-10-14 14:04:08 +03:00
Conversation 0 Commits 1 Files Changed 1
+11 -9
codex-bot commented 2026-10-14 13:23:31 +03:00
Owner
Copy Link
Copy Source

Изменение

onlineSearch запускает batch getLastPrices одновременно с cohort details через один внешний Promise.all, вместо последовательного ожидания всех N BondBy/GetShare до prices. UID для prices известны сразу после selection.

  • DTO, порядок инструментов, ISIN dedup и card fields не изменились
  • Errors прежние: любой rejected promise всё ещё валит весь запрос (whole-request failure, без partial success)
  • Limiter/deadline/token mapping не тронуты

Trade-off: если detail cohort падает раньше prices, тратится один дополнительный prices RPC — принято по Issue.

Verification

  • npm run typecheck:app, npm run typecheck:test — PASS
  • npm test -- --runInBand — PASS: 40 suites, 268 tests (включая catalog-discovery service cases)

WealthLedger/backend#71

## Изменение `onlineSearch` запускает batch `getLastPrices` одновременно с cohort details через один внешний `Promise.all`, вместо последовательного ожидания всех N BondBy/GetShare до prices. UID для prices известны сразу после selection. - DTO, порядок инструментов, ISIN dedup и card fields не изменились - Errors прежние: любой rejected promise всё ещё валит весь запрос (whole-request failure, без partial success) - Limiter/deadline/token mapping не тронуты Trade-off: если detail cohort падает раньше prices, тратится один дополнительный prices RPC — принято по Issue. ## Verification - `npm run typecheck:app`, `npm run typecheck:test` — PASS - `npm test -- --runInBand` — PASS: 40 suites, 268 tests (включая catalog-discovery service cases) WealthLedger/backend#71
codex-bot added 1 commit 2026-10-14 13:23:31 +03:00
perf: start bond search prices with details (WealthLedger/backend#71)
Backend verify / commits (pull_request) Successful in 37s
Details
Backend verify / security (pull_request) Successful in 13s
Details
Backend verify / verify (pull_request) Successful in 5m57s
Details
392b8a8d09
codex-bot merged commit da2e1d0781 into develop 2026-10-14 14:04:08 +03:00
codex-bot deleted branch fix/71-bond-search-parallel-prices 2026-10-14 14:04:08 +03:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Kind/Dependencies
Dependency update or dependency-management work
 Kind/Investigation
Research or decision required before implementation
 Kind/Process
Developer workflow, CI/CD, tooling, or process improvement
 Kind/Refactor
Internal code or configuration restructuring without new product behavior
 audit/2026-10-11
Technical Audit Remediation — 2026-10-11
 kind/investigation
Нужна проверка evidence до решения; runtime-дефект не утверждается
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
codex-bot hermes-agent ksv741 publisher-bot renovate-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: WealthLedger/backend#89