[Refactor] Запускать bond search prices параллельно независимым details #71
Closed
opened 2026-10-11 21:47:21 +03:00 by codex-bot
·
0 comments
No Branch/Tag Specified
Labels
Clear labels
Kind/Dependencies
Kind/Investigation
Kind/Process
Kind/Refactor
audit/2026-10-11
kind/investigation
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Dependency update or dependency-management work
Research or decision required before implementation
Developer workflow, CI/CD, tooling, or process improvement
Internal code or configuration restructuring without new product behavior
Technical Audit Remediation — 2026-10-11
Нужна проверка evidence до решения; runtime-дефект не утверждается
Breaking change that won't be backward compatible
Something is not working
Documentation changes
Improve existing functionality
New functionality
This is security issue
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Milestone
No items
No Milestone
Technical Audit Remediation — 2026-10-11
Projects
Clear projects
No projects
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: WealthLedger/backend#71
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Problem
onlineSearch после selection ждёт все N BondBy и лишь затем GetLastPrices, хотя prices нужны уже известные UID. Details parallel друг другу и нужны actual card fields; N+2 logical calls сами по себе не доказали допустимость их удаления.
Expected Behavior
Независимый prices request перекрывается с details при прежних DTO/order/errors и existing limiter.
Evidence
Audit date
2026-10-11; 07. IDs FLOW-003, TA-F10. Revision0ad84ff4f0b4712abc7e69dc299856f14af6eadd; Confidence High dependency, latency unmeasured; Verification status static.Affected: catalog-discovery.service.ts:295–325; catalog-selection.ts:5–40; tbank.client.ts:358–379,441–447.
Scope
In scope
Existing Promise concurrency после bounded selection и controlled error/DTO proof.
Out of scope
Новый endpoint/pool/cache/retry, удаление необходимых detail fields, partial success вместо whole-request failure.
Proposed Approach
Start batch prices вместе с detail cohort. Trade-off: detail failure может потратить один дополнительный prices RPC; limiter contention может поглотить latency gain.
Acceptance Criteria
Verification
Controlled service deferred mocks, same DTO and exact counts; existing bond/search HTTP cases и final backend gate. Revert order при adverse measured trade-off.
Dependencies
Нет; token translation T06 — independent boundary.
Traceability
Campaign WealthLedger/main#23 . Findings FLOW-003, TA-F10. WealthLedger/backend; T39.