[Investigation] Определить поддержку legacy status/observe contracts #64
Closed
opened 2026-10-11 21:45:18 +03:00 by codex-bot
·
1 comment
No Branch/Tag Specified
Labels
Clear labels
Kind/Dependencies
Kind/Investigation
Kind/Process
Kind/Refactor
audit/2026-10-11
kind/investigation
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Dependency update or dependency-management work
Research or decision required before implementation
Developer workflow, CI/CD, tooling, or process improvement
Internal code or configuration restructuring without new product behavior
Technical Audit Remediation — 2026-10-11
Нужна проверка evidence до решения; runtime-дефект не утверждается
Breaking change that won't be backward compatible
Something is not working
Documentation changes
Improve existing functionality
New functionality
This is security issue
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Milestone
No items
No Milestone
Technical Audit Remediation — 2026-10-11
Projects
Clear projects
No projects
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: WealthLedger/backend#64
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Problem
GET /tbank-sync/{id} и catalog sync=observe публично достижимы. SPA callers отсутствуют, но external consumers/old screen rows не проверены; blanket deletion рискует API compatibility и candle FK.
Expected Behavior
Для каждого legacy entrypoint есть evidence-backed support/retirement решение до breaking removal.
Evidence
Audit date
2026-10-11; 04. IDs DEAD-006, DEAD-007, ARCH-009, CPLX-005. Revision0ad84ff4f0b4712abc7e69dc299856f14af6eadd; Confidence High reachability / Medium removal; Verification status runtime-unverified для external use.Affected: tbank-sync.controller.ts:21–41; service:313–391; catalog-discovery.service.ts:84–141,168–217,251–293; investment-resource.dto.ts:15–24; prisma/schema.prisma:148–229.
Scope
In scope
Endpoint-specific declared consumers, обезличенная existing access evidence и aggregate old-row counts на disposable copy при доступности; support horizon без придуманного deadline.
Out of scope
Публикация user/account/token payloads, live DB mutation, destructive migration, automatic public route withdrawal.
Proposed Approach
Owner подтверждает список consumers; если logs/DB evidence недоступны, явно сохранить compatibility и записать оставшийся input. Shared identities/calendars/candles не считать справочным legacy целиком.
Acceptance Criteria
Verification
Static contract/caller inventory + private aggregate evidence; existing status/reference HTTP cases при последующем code change. Application full verify для чистого investigation не нужен.
Dependencies
Нет; code-only dead producers могут удаляться независимо, сохраняя readers.
Traceability
Campaign WealthLedger/main#23 . Findings DEAD-006, DEAD-007, ARCH-009, CPLX-005. WealthLedger/backend; T11.
Решение владельца (2026-11-05): RETIRE
GET /tbank-sync/{id}и публичныйsync=observe(оба), без удаления данных/схемы. Confidence: high для отсутствия SPA callers (frontend#141), medium для возможности удаления — внешние consumers/logs и старые строки не проверены. Status защищён JWT; observe поддерживает passive path, который backend tests ещё проверяют. Ни отсутствие SPA calls, ни отсутствие canonical spec не доказывают отсутствие внешних обязанностей. Переход/rollback и удаление вынесены в backend#196: проверка внешних запросов, окно совместимости, восстановление предыдущего образа при регрессии, без миграции. Из этого investigation кода не удалено.