[Refactor] Удалить недостижимую manual/catalog producer closure #62
Closed
opened 2026-10-11 21:45:17 +03:00 by codex-bot
·
1 comment
No Branch/Tag Specified
Labels
Clear labels
Kind/Dependencies
Kind/Investigation
Kind/Process
Kind/Refactor
audit/2026-10-11
kind/investigation
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Dependency update or dependency-management work
Research or decision required before implementation
Developer workflow, CI/CD, tooling, or process improvement
Internal code or configuration restructuring without new product behavior
Technical Audit Remediation — 2026-10-11
Нужна проверка evidence до решения; runtime-дефект не утверждается
Breaking change that won't be backward compatible
Something is not working
Documentation changes
Improve existing functionality
New functionality
This is security issue
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Milestone
No items
No Milestone
Technical Audit Remediation — 2026-10-11
Projects
Clear projects
No projects
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: WealthLedger/backend#62
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Problem
TbankSyncService.request/dispatch не имеет command entrypoint. CatalogDiscovery request/refresh/drain запускают direct tests и dead parent; ordinary HTTP online, observe reader passive. Orphan Accepted DTO создаёт ложную command surface.
Expected Behavior
Поддерживается только достижимая orchestration; status/observe readers и live source owners сохранены.
Evidence
Audit date
2026-10-11; 04, previous Complexity. IDs DEAD-001, DEAD-002, DEAD-003, BE-007, TQ-009, TA-F09, CA-X03. Revision0ad84ff4f0b4712abc7e69dc299856f14af6eadd; Confidence High (CA-X03 secondary-only); Verification status static.Affected: tbank-sync.service.ts:54–311; tbank-screen.ts/spec.ts; sync repository reserve/progress; catalog-discovery.service.ts:340–496; catalog-discovery.repository.ts:341–464; sync.dto.ts:212–218,232–250.
Scope
In scope
Manual parent→exclusive discovery writer deletion, unused DI/fields/helpers/tests, orphan DTO после caller/schema proof.
Out of scope
Status/sourceStatus, public sync=observe, shared reserve/finish/publishSource, instrument schema/FK/rows, hourly/candle/Ledger owners.
Proposed Approach
Повторить current production/dynamic caller inventory. Удалять method-level closure, не folders. Rebind полезные online whitelist/selection proofs; orphan HourlySyncSectionDto удалять лишь если fresh schema/callers подтверждают вторичную гипотезу.
Acceptance Criteria
Verification
Existing OpenAPI/status, stocks/bonds, Ledger/local-read/source/candle SQLite cases; no new tests ради trivial DTO deletion; backend final verify/e2e по touched boundary.
Dependencies
Нет внешнего blocker: compatibility investigation T11 не задерживает code-only deletion; public reader сохраняется.
Traceability
Campaign WealthLedger/main#23 . Findings DEAD-001, DEAD-002, DEAD-003, BE-007, TQ-009, TA-F09, CA-X03. WealthLedger/backend; T10.
Выполнено: PR #98 смержен в develop (commit
96d4de4). Удалены недостижимые TbankSyncService.request/dispatch, CatalogDiscovery request/refresh/drain с producer-состоянием, orphan DTO TbankSyncAcceptedDto и HourlySyncSectionDto, producer-only тесты. Status/observe readers и shared owners сохранены. Остаточный follow-up (неиспользуемые repository reserve/publish/finish) вынесен отдельно и в этот issue не входит. Проверки: verify, 20/20 SQLite suites, openapi-contract.