[Bug] Пропускать hourly terms, перекрытые длительным walk #54
Closed
opened 2026-10-11 21:41:56 +03:00 by codex-bot
·
1 comment
No Branch/Tag Specified
Labels
Clear labels
Kind/Dependencies
Kind/Investigation
Kind/Process
Kind/Refactor
audit/2026-10-11
kind/investigation
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Dependency update or dependency-management work
Research or decision required before implementation
Developer workflow, CI/CD, tooling, or process improvement
Internal code or configuration restructuring without new product behavior
Technical Audit Remediation — 2026-10-11
Нужна проверка evidence до решения; runtime-дефект не утверждается
Breaking change that won't be backward compatible
Something is not working
Documentation changes
Improve existing functionality
New functionality
This is security issue
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Milestone
No items
No Milestone
Technical Audit Remediation — 2026-10-11
Projects
Clear projects
No projects
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: WealthLedger/backend#54
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Problem
reserveHourly проверяет elapsed hour от createdAt. После walk 10:00–11:10 tick 11:11 eligible, хотя сохранённое требование допускает следующий term не ранее 12:00. Overlap guard существует; это cadence defect, не подтверждённая concurrent эксплуатация.
Expected Behavior
Перекрытые работой terms пропускаются; restart/downtime не ускоряют retry и не создают catch-up queue.
Evidence
Audit date:
2026-10-11. Report: 06. IDs: BE-006, TQ-003 (time arm), TA-F04. Revision:0ad84ff4f0b4712abc7e69dc299856f14af6eadd; Confidence: High; Verification status: static.Affected code: tbank-sync.repository.ts:171–218; scheduler:48–86. Requirement: specs hourly-investment-sync/spec.md:19–25 at
fcdc805f6c1b3be6a20a7e858e3e80cbd83a9121.Scope
In scope
Existing eligibility formula и real SQLite reservation time table.
Out of scope
Второй scheduler, distributed lease, изменение approved cadence без решения owner.
Proposed Approach
Вычислять следующий допустимый 60-minute term от attempt start, учитывая terms во время работы; сохранить один catch-up после downtime.
Acceptance Criteria
Verification
Existing isolated SQLite runner, controlled Date/start/finish, persisted rows; backend verify на конечном diff.
Dependencies
Нет. T01 — связанный owner, но его реализация не обязательна для локальной формулы.
Traceability
Campaign: WealthLedger/main#23 . Findings: BE-006, TQ-003, TA-F04. Repository: WealthLedger/backend; T03.
Сделано в WealthLedger/backend#93 (merged в develop): следующий term считается от старта попытки с учётом длительности walk. Тесты в test/tbank-hourly-lifecycle.e2e-spec.ts (boundary, overlap на 1 и 2 term, новая revision, dead-process + downtime, same-process running).
npm run verifyOK, e2e 28/28.