refactor: retire legacy tbank-sync status and sync=observe (WealthLedger/backend#196)

src/modules/investments/instruments/application/catalog-enrichment.service.ts

@@ -222,9 +222,8 @@ export class CatalogEnrichmentService {
     instrumentType: 'bond' | 'share',
     uid: string,
     section: 'company' | 'metrics' | 'quote',
-    observe = false,
   ) {
-    if (section === 'company' && !observe) {
+    if (section === 'company') {
       const { description, fundamentals, instrument } = await this.access.online(userId, async ({ token }) => {
         const instrument =
           instrumentType === 'share'
@@ -254,25 +253,22 @@ export class CatalogEnrichmentService {
         observedAt: meta.lastSuccessfulAt ?? new Date().toISOString(),
       };
     }
-    const kinds: CatalogSource['kind'][] =
-      section === 'company'
-        ? ['detail', 'description', 'fundamentals']
-        : [
-            ...(instrumentType === 'bond'
-              ? ['bond-current' as const]
-              : ['detail' as const]),
-            'last-price',
-            'trading-status',
-            'comparison',
-            ...(section === 'metrics'
-              ? ['coupons' as const, 'yield' as const, 'rating' as const]
-              : []),
-          ];
+    const kinds: CatalogSource['kind'][] = [
+      ...(instrumentType === 'bond'
+        ? ['bond-current' as const]
+        : ['detail' as const]),
+      'last-price',
+      'trading-status',
+      'comparison',
+      ...(section === 'metrics'
+        ? ['coupons' as const, 'yield' as const, 'rating' as const]
+        : []),
+    ];
     const sources = await this.readMany(
       userId,
       instrumentType,
       [uid],
-      observe,
+      false,
       kinds,
     );
     const first = sources[0];
@@ -300,7 +296,7 @@ export class CatalogEnrichmentService {
       fetchedAt: first.meta.lastSuccessfulAt
         ? new Date(first.meta.lastSuccessfulAt)
         : null,
-      freshForMs: section === 'company' ? Number.MAX_SAFE_INTEGER : tbankSourceTtlMs.quote,
+      freshForMs: tbankSourceTtlMs.quote,
       work: null,
       dependencies,
     });