refactor: replace ignored numeric literals with constants

src/modules/investments/instruments/application/instrument-position.ts

@@ -12,6 +12,10 @@ import {
 } from '../../portfolio/portfolio.api';
 import { StockPositionDto } from '../stocks/presentation/stock.dto';
 
+const EMPTY_POSITIONS_COUNT = 0;
+const ZERO_QUANTITY = 0n;
+const ZERO_AMOUNT = 0n;
+
 const PRICE_DECIMAL_PLACES = 9;
 const RETURN_PERCENT_DECIMAL_PLACES = 6;
 
@@ -32,8 +36,8 @@ export function instrumentPosition(
   const currentValue = sumComplete(positions.map((p) => p.currentValue));
   const absoluteReturn = sumComplete(positions.map((p) => p.absoluteReturn));
   const positive =
-    positions.length > 0 &&
-    positions.every((p) => decimalFromString(p.quantity).value > 0n);
+    positions.length > EMPTY_POSITIONS_COUNT &&
+    positions.every((p) => decimalFromString(p.quantity).value > ZERO_QUANTITY);
   return {
     quantity: formatDecimal(quantity),
     currentValue,
@@ -55,7 +59,7 @@ export function instrumentPosition(
     accounts: positions.map((p) => ({
       ...p,
       returnPercent:
-        decimalFromString(p.quantity).value > 0n ?
+        decimalFromString(p.quantity).value > ZERO_QUANTITY ?
             percent(p.absoluteReturn, cost(p)) :
           null,
     })),
@@ -103,7 +107,7 @@ function percent(
     !base ||
     !result ||
     base.currency !== result.currency ||
-    decimalFromString(base.value).value <= 0n
+    decimalFromString(base.value).value <= ZERO_AMOUNT
   ) {
     return null;
   }