refactor: replace ignored numeric literals with constants

src/modules/investments/instruments/application/instrument-market.ts

@@ -3,19 +3,21 @@ import type {
   TbankTimestamp,
 } from '../../../../integrations/tbank/tbank.api';
 
-import { MILLISECONDS_PER_SECOND } from '../../../../common/time';
+import { ISO_DATE_LENGTH, ISO_DATE_START, MILLISECONDS_PER_SECOND } from '../../../../common/time';
+
+const MIN_TIMESTAMP_SECONDS_EXCLUSIVE = 0;
 
 const MOSCOW_OFFSET_MS = 10_800_000;
 export function timestamp(value?: TbankTimestamp): null | string {
   const seconds = Number(value?.seconds);
-  return Number.isFinite(seconds) && seconds > 0 ?
+  return Number.isFinite(seconds) && seconds > MIN_TIMESTAMP_SECONDS_EXCLUSIVE ?
       new Date(seconds * MILLISECONDS_PER_SECOND).toISOString() :
     null;
 }
 export function moscowDay(iso: string): string {
   return new Date(Date.parse(iso) + MOSCOW_OFFSET_MS)
     .toISOString()
-    .slice(0, 10);
+    .slice(ISO_DATE_START, ISO_DATE_LENGTH);
 }
 export function previousClose(
   candles: TbankCandle[],
@@ -29,7 +31,7 @@ export function previousClose(
           candle.isComplete &&
           candle.close &&
           time &&
-          time.slice(0, 10) < moscowDay(priceAt)
+          time.slice(ISO_DATE_START, ISO_DATE_LENGTH) < moscowDay(priceAt)
         );
       })
       .sort((a, b) => Number(b.time?.seconds) - Number(a.time?.seconds))[0] ??