chore: strengthen backend eslint profile

This commit is contained in:
2026-09-28 16:37:01 +03:00
committed by ksv741
parent 53b2794963
commit a970eaaf7a
179 changed files with 4485 additions and 2716 deletions
@@ -1,5 +1,7 @@
import { Injectable } from '@nestjs/common';
import type { TbankFundamentals } from '../../../../../integrations/tbank/tbank.api';
import { CatalogEnrichmentService } from '../../application/catalog-enrichment.service';
import {
StockCompanyResourceDto,
@@ -21,8 +23,8 @@ export class GetStockCompanyUseCase {
observe,
);
return {
data: result.values.instrument
? {
data: result.values.instrument ?
{
description: result.values.description ?? null,
metrics: metrics(
result.values.fundamentals ?? null,
@@ -30,14 +32,14 @@ export class GetStockCompanyUseCase {
),
unavailable: result.unavailable,
observedAt: result.observedAt,
}
: null,
} :
null,
meta: result.meta,
};
}
}
export function metrics(
values: TbankFundamentals | null,
values: null | TbankFundamentals,
sector?: string,
): StockMetricDto[] {
if (!values) return [];
@@ -49,30 +51,31 @@ export function metrics(
][] = [
['marketCapitalization', 'money', null],
['peRatioTtm', 'ratio', 'TTM'],
...(bank
? ([
...(bank ?
([
['priceToBookTtm', 'ratio', 'TTM'],
['roe', 'percent', null],
] as typeof selection)
: ([
] as typeof selection) :
([
['revenueTtm', 'money', 'TTM'],
['ebitdaTtm', 'money', 'TTM'],
] as typeof selection)),
['netIncomeTtm', 'money', 'TTM'],
...(!bank
? ([
...(!bank ?
([
['totalDebtMrq', 'money', 'MRQ'],
['netDebtToEbitda', 'ratio', null],
] as typeof selection)
: []),
] as typeof selection) :
[]),
];
return selection.flatMap(([key, unit, period]) => {
// eslint-disable-next-line security/detect-object-injection -- Keys come from the fixed metric selection declared above.
const value = values[key];
const currency = values.currency?.toUpperCase() || null;
return typeof value === 'number' &&
Number.isFinite(value) &&
(unit !== 'money' || currency)
? [
(unit !== 'money' || currency) ?
[
{
key,
value,
@@ -80,7 +83,7 @@ export function metrics(
period,
currency: unit === 'money' ? currency : null,
},
]
: [];
] :
[];
});
}
@@ -1,8 +1,10 @@
import { CatalogDiscoveryService } from '../../application/catalog-discovery.service';
import { Injectable } from '@nestjs/common';
import { formatDecimal } from '../../../../../common/decimal';
import type { TbankShare } from '../../../../../integrations/tbank/tbank.api';
import { formatDecimal } from '../../../../../common/decimal';
import { decimal } from '../../../../../integrations/tbank/decimal';
import { CatalogDiscoveryService } from '../../application/catalog-discovery.service';
import { timestamp } from '../../application/instrument-market';
import {
StockDto,
@@ -30,9 +32,9 @@ export class StockCatalogService {
data:
result.data?.map((item) => {
const short = stock(item);
const detail = item.detail
? stock({ ...item.detail, uid: item.uid })
: short;
const detail = item.detail ?
stock({ ...item.detail, uid: item.uid }) :
short;
const last = item.price;
return {
...detail,
@@ -40,17 +42,18 @@ export class StockCatalogService {
isin: detail.isin ?? short.isin,
apiTradeAvailable: short.apiTradeAvailable,
price:
last?.price && detail.currency
? {
last?.price && detail.currency ?
{
currency: detail.currency,
value: formatDecimal(decimal(last.price)),
}
: null,
} :
null,
priceAt: timestamp(last?.time),
};
}) ?? null,
};
}
async get(
userId: string,
uid: string,
@@ -59,11 +62,12 @@ export class StockCatalogService {
const result = await this.discovery.detail(userId, 'share', uid, observe);
return {
...result,
data: result.data
? { ...stock(result.data), slug: result.data.slug }
: null,
data: result.data ?
{ ...stock(result.data), slug: result.data.slug } :
null,
};
}
async getByTicker(
userId: string,
ticker: string,
@@ -77,9 +81,9 @@ export class StockCatalogService {
);
return {
...result,
data: result.data
? { ...stock(result.data), slug: result.data.slug }
: null,
data: result.data ?
{ ...stock(result.data), slug: result.data.slug } :
null,
};
}
}
@@ -1,27 +1,28 @@
import { Injectable, NotFoundException } from '@nestjs/common';
import {
decimalFromString,
formatDecimal,
multiply,
} from '../../../../../common/decimal';
import { decimal } from '../../../../../integrations/tbank/decimal';
import {
TbankAccessService,
type TbankDividend,
} from '../../../../../integrations/tbank/tbank.api';
import {
PortfolioService,
ForecastService,
PortfolioService,
} from '../../../portfolio/portfolio.api';
import { CatalogEnrichmentService } from '../../application/catalog-enrichment.service';
import { moscowDay, timestamp } from '../../application/instrument-market';
import { instrumentPosition } from '../../application/instrument-position';
import {
StockDividendDto,
StockDividendsDto,
StockDividendsResourceDto,
StockPositionDto,
StockDividendDto,
} from '../presentation/stock.dto';
import { decimal } from '../../../../../integrations/tbank/decimal';
const ISO_YEAR_LENGTH = 4;
const INCOME_HISTORY_YEARS = 5;
@Injectable()
@@ -40,6 +41,7 @@ export class StockIncomeService {
meta: { ...saved.meta, resourceKey: `stock/position/${uid}` },
};
}
async dividends(
userId: string,
uid: string,
@@ -58,21 +60,22 @@ export class StockIncomeService {
['detail', 'dividends'],
{ from, to },
);
if (sources[0].meta.availability === 'complete' && !sources[0].instrument)
if (sources[0].meta.availability === 'complete' && !sources[0].instrument) {
throw new NotFoundException();
}
const events = sources[1].payload?.dividends;
const position = portfolio.data
? instrumentPosition(portfolio.data, uid, 'STOCK')
: null;
const projected = events
? stockDividends(
const position = portfolio.data ?
instrumentPosition(portfolio.data, uid, 'STOCK') :
null;
const projected = events ?
stockDividends(
events,
position,
{ from, to, today },
sources[1].meta.lastSuccessfulAt ?? new Date().toISOString(),
!portfolio.data,
)
: undefined;
) :
undefined;
const result = await this.forecasts.result({
userId,
revision: connection.revision,
@@ -83,9 +86,9 @@ export class StockIncomeService {
candidate:
portfolio.data && sources[0].instrument ? projected : undefined,
});
return result.data || !projected
? result
: {
return result.data || !projected ?
result :
{
data: stockDividends(
events ?? [],
null,
@@ -100,7 +103,7 @@ export class StockIncomeService {
export function stockDividends(
events: TbankDividend[],
position: StockPositionDto | null,
position: null | StockPositionDto,
window: { from: string; to: string; today: string },
observedAt: string,
positionUnavailable: boolean,
@@ -109,9 +112,9 @@ export function stockDividends(
const quantity =
position &&
position.accounts.length &&
position.accounts.every((p) => decimalFromString(p.quantity).value > 0n)
? decimalFromString(position.quantity)
: null;
position.accounts.every((p) => decimalFromString(p.quantity).value > 0n) ?
decimalFromString(position.quantity) :
null;
const dividends: StockDividendDto[] = events
.filter((event) => event.dividendType?.toLowerCase() !== 'cancelled')
.map((event) => {
@@ -120,29 +123,29 @@ export function stockDividends(
const lastBuyDate = timestamp(event.lastBuyDate)?.slice(0, 10) ?? null;
const currency = event.dividendNet?.currency?.toUpperCase();
const perShare =
currency && event.dividendNet
? { currency, value: formatDecimal(decimal(event.dividendNet)) }
: null;
currency && event.dividendNet ?
{ currency, value: formatDecimal(decimal(event.dividendNet)) } :
null;
// A future payment can have an already-fixed register: keep the event, but do not estimate entitlement from today's holding.
const eventDate = paymentDate ?? recordDate;
const timing: StockDividendDto['timing'] = eventDate
? eventDate >= today
? 'upcoming'
: 'past'
: 'undated';
const timing: StockDividendDto['timing'] = eventDate ?
eventDate >= today ?
'upcoming' :
'past' :
'undated';
const estimatedAmount =
quantity &&
perShare &&
recordDate &&
recordDate >= today &&
timing === 'upcoming'
? {
timing === 'upcoming' ?
{
currency: perShare.currency,
value: formatDecimal(
multiply(quantity, decimalFromString(perShare.value)),
),
}
: null;
} :
null;
return {
perShare,
recordDate,
@@ -1,9 +1,5 @@
import { CandleService } from '../../application/candle.service';
import {
CatalogEnrichmentService,
type CatalogPayload,
} from '../../application/catalog-enrichment.service';
import { Injectable } from '@nestjs/common';
import {
decimalFromString,
divide,
@@ -12,6 +8,11 @@ import {
subtract,
} from '../../../../../common/decimal';
import { decimal } from '../../../../../integrations/tbank/decimal';
import { CandleService } from '../../application/candle.service';
import {
CatalogEnrichmentService,
type CatalogPayload,
} from '../../application/catalog-enrichment.service';
import { timestamp } from '../../application/instrument-market';
import {
StockCandlesQueryDto,
@@ -26,6 +27,7 @@ export class StockMarketService {
private readonly history: CandleService,
private readonly sources: CatalogEnrichmentService,
) {}
async quote(
userId: string,
uid: string,
@@ -39,12 +41,13 @@ export class StockMarketService {
observe,
);
return {
data: result.values.instrument
? stockQuote(result.values, result.unavailable, result.observedAt)
: null,
data: result.values.instrument ?
stockQuote(result.values, result.unavailable, result.observedAt) :
null,
meta: result.meta,
};
}
candles(
userId: string,
uid: string,
@@ -69,20 +72,20 @@ export function stockQuote(
const priceAt = timestamp(last?.time);
const currency = share?.currency?.toUpperCase();
const price =
last?.price && currency
? { currency, value: formatDecimal(decimal(last.price)) }
: null;
last?.price && currency ?
{ currency, value: formatDecimal(decimal(last.price)) } :
null;
const previousPrice =
previous?.close && currency
? { currency, value: formatDecimal(decimal(previous.close)) }
: null;
previous?.close && currency ?
{ currency, value: formatDecimal(decimal(previous.close)) } :
null;
const difference =
price && previousPrice
? subtract(
price && previousPrice ?
subtract(
decimalFromString(price.value),
decimalFromString(previousPrice.value),
)
: null;
) :
null;
return {
price,
priceAt,
@@ -90,21 +93,21 @@ export function stockQuote(
previousCloseDate: timestamp(previous?.time)?.slice(0, 10) ?? null,
previousClose: previousPrice,
change:
difference && currency
? { currency, value: formatDecimal(difference) }
: null,
difference && currency ?
{ currency, value: formatDecimal(difference) } :
null,
changePercent:
difference &&
previousPrice &&
decimalFromString(previousPrice.value).value > 0n
? formatDecimal(
decimalFromString(previousPrice.value).value > 0n ?
formatDecimal(
divide(
multiply(difference, decimalFromString('100')),
decimalFromString(previousPrice.value),
CHANGE_PERCENT_DECIMAL_PLACES,
),
)
: null,
) :
null,
unavailable,
observedAt,
};
@@ -1,7 +1,7 @@
import { previousClose } from '../../application/instrument-market';
import { metrics } from './get-stock-company.use-case';
import { stockDividends } from './stock-income.service';
import { stockQuote } from './stock-market.service';
import { previousClose } from '../../application/instrument-market';
jest.mock('../../../../../prisma/prisma.service', () => ({
PrismaService: class {},
}));