chore: strengthen backend eslint profile

src/modules/investments/income/income-analytics.service.ts

@@ -1,5 +1,6 @@
-import assert from 'node:assert/strict';
 import { Injectable } from '@nestjs/common';
+import assert from 'node:assert/strict';
+
 import {
   add,
   compare,
@@ -7,24 +8,21 @@ import {
   formatDecimal,
   subtract,
 } from '../../../common/decimal';
-import { investmentResourceMeta } from '../investment-resource.mapper';
-import {
-  IncomeAnalyticsResourceDto,
-  IncomeDependencyDto,
-  IncomeSummaryResourceDto,
-} from './income-analytics.dto';
 import { DateOnlyRange, moscowDate } from '../investment-calendar';
+import { investmentResourceMeta } from '../investment-resource.mapper';
 import {
   BrokerageOperationDto,
   BrokerageOperationsService,
 } from '../operations/operations.api';
-
 import {
   IncomeAnalyticsEntryDto,
+  IncomeAnalyticsResourceDto,
   IncomeComparisonDto,
   IncomeCurrencySummaryDto,
+  IncomeDependencyDto,
   IncomeInstrumentDto,
   IncomeSummaryDto,
+  IncomeSummaryResourceDto,
 } from './income-analytics.dto';
 import {
   IncomeBucketGranularity,
@@ -96,9 +94,9 @@ export class IncomeAnalyticsService {
       { ...current.meta, role: 'selected' },
       { ...prior.meta, role: 'previous' },
       {
-        ...(plan.yearAgo && year
-          ? year.meta
-          : investmentResourceMeta({
+        ...(plan.yearAgo && year ?
+          year.meta :
+            investmentResourceMeta({
               resourceKey: 'income/yearAgo', // gitleaks:allow public resource identifier
               dataRevision: 'unavailable',
               availability: 'missing',
@@ -119,9 +117,9 @@ export class IncomeAnalyticsService {
         resourceKey: `income/${accountId}/${plan.selected.from}/${plan.selected.to}`,
         dataRevision: current.meta.dataRevision,
         availability: current.meta.availability,
-        fetchedAt: current.meta.lastSuccessfulAt
-          ? new Date(current.meta.lastSuccessfulAt)
-          : null,
+        fetchedAt: current.meta.lastSuccessfulAt ?
+            new Date(current.meta.lastSuccessfulAt) :
+          null,
         freshForMs: current.meta.freshness === 'fresh' ? Infinity : 0,
         work: work?.id ? { ...work, id: work.id } : null,
         coverage: current.meta.coverage,
@@ -144,13 +142,13 @@ export class IncomeAnalyticsService {
           current.meta.lastSuccessfulAt,
         ),
         previous:
-          prior.items === null
-            ? null
-            : comparison(selected, plan.previous, qualifying(prior.items)),
+          prior.items === null ?
+            null :
+              comparison(selected, plan.previous, qualifying(prior.items)),
         yearComparison:
-          plan.yearAgo && year?.items !== null && year
-            ? comparison(selected, plan.yearAgo, qualifying(year.items))
-            : null,
+          plan.yearAgo && year?.items !== null && year ?
+              comparison(selected, plan.yearAgo, qualifying(year.items)) :
+            null,
         bucketGranularity: plan.granularity,
         buckets: buckets(plan.selected, plan.granularity, selected),
         instruments: instruments(selected),
@@ -184,9 +182,9 @@ function totals(entries: BrokerageOperationDto[]): IncomeCurrencySummaryDto[] {
     if (!entry.payment) continue;
     const total = values.get(entry.payment.currency) ?? zeroTotal();
     const value = decimalFromString(entry.payment.value);
-    if (entry.type === 'OPERATION_TYPE_COUPON')
+    if (entry.type === 'OPERATION_TYPE_COUPON') {
       total.coupon = add(total.coupon, value);
-    else total.dividend = add(total.dividend, value);
+    } else total.dividend = add(total.dividend, value);
     values.set(entry.payment.currency, total);
   }
   return [...values]
@@ -207,6 +205,7 @@ function comparison(
   );
   const currencies = [
     ...new Set([...selected.keys(), ...compared.keys()]),
+  // eslint-disable-next-line sonarjs/no-alphabetical-sort -- Code-unit ordering is intentional for canonical keys and ISO dates; locale collation would change persisted bindings.
   ].sort();
   return {
     period: comparedPeriod,
@@ -279,8 +278,9 @@ function instruments(
 function instrumentKey(entry: BrokerageOperationDto): string {
   if (entry.instrumentUid) return `uid:${entry.instrumentUid}`;
   if (entry.figi) return `figi:${entry.figi}`;
-  if (entry.ticker || entry.instrumentType)
+  if (entry.ticker || entry.instrumentType) {
     return `ticker:${entry.ticker ?? ''}:${entry.instrumentType ?? ''}`;
+  }
   return `operation:${entry.account ? `${entry.account.id}:` : ''}${entry.id}`;
 }