refactor: replace ignored numeric literals with constants

src/modules/investments/portfolio/application/forecast.service.ts

@@ -9,6 +9,9 @@ import {
   type ForecastSourceVersion,
 } from '../infrastructure/forecast.repository';
 
+const MISSING_DATA_REVISION = 0;
+const STALE_FRESHNESS_MS = 0;
+
 @Injectable()
 export class ForecastService {
   constructor(private readonly repository: ForecastRepository) {}
@@ -89,7 +92,7 @@ export class ForecastService {
       data,
       meta: investmentResourceMeta({
         resourceKey: input.scopeKey,
-        dataRevision: String(stored?.dataRevision ?? 0),
+        dataRevision: String(stored?.dataRevision ?? MISSING_DATA_REVISION),
         availability: stored ?
           'complete' :
           dependencies.some(
@@ -100,7 +103,7 @@ export class ForecastService {
         fetchedAt: first ? new Date(first) : null,
         freshForMs:
           data && 'positionIsStale' in data && data.positionIsStale === true ?
-            0 :
+            STALE_FRESHNESS_MS :
             Number.POSITIVE_INFINITY,
         work: work?.id ? { ...work, id: work.id } : null,
         dependencies,

src/modules/investments/portfolio/application/portfolio.service.ts

@@ -43,6 +43,8 @@ import {
   PortfolioPositionDto,
 } from '../presentation/portfolio.dto';
 
+const MISSING_DATA_REVISION = 0;
+
 const membershipFreshForMs = tbankSourceTtlMs.membership;
 const types: Record<string, string> = {
   share: 'STOCK',
@@ -167,7 +169,7 @@ export class PortfolioService {
     }
     const membershipMeta = investmentResourceMeta({
       resourceKey: 'accounts/membership',
-      dataRevision: String(saved?.membershipRevision ?? 0),
+      dataRevision: String(saved?.membershipRevision ?? MISSING_DATA_REVISION),
       availability: saved?.membershipAt ? 'complete' : 'missing',
       fetchedAt: saved?.membershipAt ?? null,
       freshForMs: membershipFreshForMs,
@@ -195,7 +197,7 @@ export class PortfolioService {
             null,
           meta: investmentResourceMeta({
             resourceKey: `portfolio/${encodeURIComponent(account.accountId)}`,
-            dataRevision: String(account.portfolio?.dataRevision ?? 0),
+            dataRevision: String(account.portfolio?.dataRevision ?? MISSING_DATA_REVISION),
             availability: account.portfolio ? 'complete' : 'missing',
             fetchedAt: account.portfolio?.fetchedAt ?? null,
             freshForMs: portfolioFreshForMs,