refactor: replace ignored numeric literals with constants

src/modules/investments/instruments/application/catalog-enrichment.service.ts

@@ -39,6 +39,10 @@ import {
 import { catalogSearchLimit } from './catalog-selection';
 import { previousClose, timestamp } from './instrument-market';
 
+const MISSING_DATA_REVISION = 0;
+const FIRST_QUEUE_INDEX = 0;
+const DEQUEUED_ITEM_COUNT = 1;
+
 type Producer = {
   attempt: TbankSyncAttempt;
   input: CatalogSource;
@@ -147,7 +151,7 @@ export class CatalogEnrichmentService {
         price: payload?.price ?? null,
         meta: investmentResourceMeta({
           resourceKey: catalogScope(input),
-          dataRevision: String(row?.dataRevision ?? 0),
+          dataRevision: String(row?.dataRevision ?? MISSING_DATA_REVISION),
           availability: row ? 'complete' : 'missing',
           fetchedAt: row?.fetchedAt ?? null,
           freshForMs: tbankSourceTtlMs[sourcePolicy(input.kind)],
@@ -485,7 +489,7 @@ export class CatalogEnrichmentService {
         // One batch RPC for queued prices sharing the same authorized producer.
         if (producer.input.kind === 'last-price') {
           for (
-            let i = 0;
+            let i = FIRST_QUEUE_INDEX;
             i < this.queue.length && batch.length < catalogSearchLimit;
           ) {
             // eslint-disable-next-line security/detect-object-injection -- Numeric queue indexes and validated instrument UIDs select internal data only.
@@ -496,7 +500,7 @@ export class CatalogEnrichmentService {
               next.attempt.revision === producer.attempt.revision
             ) {
               batch.push(next);
-              this.queue.splice(i, 1);
+              this.queue.splice(i, DEQUEUED_ITEM_COUNT);
             } else i++;
           }
         }