refactor: centralize domain values and enforce numeric lint

src/modules/investments/instruments/stocks/application/stock-market.service.ts

@@ -22,6 +22,12 @@ import {
 const dayMs = 86_400_000;
 
 import { StockCatalogService } from './stock-catalog.service';
+
+const PREVIOUS_CLOSE_LOOKBACK_DAYS = 20;
+const HALF_YEAR_MONTHS = 6;
+const YEAR_MONTHS = 12;
+const CANDLE_WINDOW_DAYS = 365;
+const CHANGE_PERCENT_DECIMAL_PLACES = 6;
 @Injectable()
 export class StockMarketService {
   constructor(
@@ -58,7 +64,9 @@ export class StockMarketService {
                 await this.tbank.getCandles(
                   token,
                   uid,
-                  new Date(end.valueOf() - 20 * dayMs),
+                  new Date(
+                    end.valueOf() - PREVIOUS_CLOSE_LOOKBACK_DAYS * dayMs,
+                  ),
                   end,
                 ),
                 priceAt,
@@ -97,7 +105,7 @@ export class StockMarketService {
                 divide(
                   multiply(difference, decimalFromString('100')),
                   decimalFromString(previousPrice.value),
-                  6,
+                  CHANGE_PERCENT_DECIMAL_PLACES,
                 ),
               )
             : null,
@@ -121,7 +129,11 @@ export class StockMarketService {
         const from = new Date(to);
         from.setUTCMonth(
           from.getUTCMonth() -
-            (period === 'month' ? 1 : period === 'halfYear' ? 6 : 12),
+            (period === 'month'
+              ? 1
+              : period === 'halfYear'
+                ? HALF_YEAR_MONTHS
+                : YEAR_MONTHS),
         );
         if (period === 'all') {
           if (!historyFrom)
@@ -134,7 +146,10 @@ export class StockMarketService {
         const collected = new Map<string, StockCandlesDto['candles'][number]>();
         // Conservative one-year windows also work with older deployed RPC limits.
         for (let start = from.valueOf(); start < to.valueOf();) {
-          const end = Math.min(start + 365 * dayMs, to.valueOf());
+          const end = Math.min(
+            start + CANDLE_WINDOW_DAYS * dayMs,
+            to.valueOf(),
+          );
           for (const candle of await this.tbank.getCandles(
             token,
             uid,