refactor: centralize domain values and enforce numeric lint

src/modules/investments/instruments/bonds/application/bond-market.service.ts

@@ -24,6 +24,12 @@ const dayMs = 86_400_000;
 
 import { money } from '../infrastructure/bond-money.mapper';
 import { BondCatalogService } from './bond-catalog.service';
+
+const PREVIOUS_CLOSE_LOOKBACK_DAYS = 20;
+const HALF_YEAR_MONTHS = 6;
+const YEAR_MONTHS = 12;
+const CANDLE_WINDOW_DAYS = 365;
+const PRICE_DECIMAL_PLACES = 9;
 @Injectable()
 export class BondMarketService {
   constructor(
@@ -66,7 +72,7 @@ export class BondMarketService {
                     decimalFromString(nominal.value),
                   ),
                   decimalFromString('100'),
-                  9,
+                  PRICE_DECIMAL_PLACES,
                 ),
               ),
             }
@@ -90,7 +96,9 @@ export class BondMarketService {
                 await this.tbank.getCandles(
                   token,
                   uid,
-                  new Date(Date.parse(priceAt) - 20 * dayMs),
+                  new Date(
+                    Date.parse(priceAt) - PREVIOUS_CLOSE_LOOKBACK_DAYS * dayMs,
+                  ),
                   new Date(priceAt),
                 ),
                 priceAt,
@@ -134,7 +142,11 @@ export class BondMarketService {
         const from = new Date(to);
         from.setUTCMonth(
           from.getUTCMonth() -
-            (period === 'month' ? 1 : period === 'halfYear' ? 6 : 12),
+            (period === 'month'
+              ? 1
+              : period === 'halfYear'
+                ? HALF_YEAR_MONTHS
+                : YEAR_MONTHS),
         );
         if (period === 'all') {
           if (!historyFrom)
@@ -147,7 +159,10 @@ export class BondMarketService {
         const collected = new Map<string, BondCandlesDto['candles'][number]>();
         // Conservative one-year windows also work with older deployed RPC limits.
         for (let start = from.valueOf(); start < to.valueOf();) {
-          const end = Math.min(start + 365 * dayMs, to.valueOf());
+          const end = Math.min(
+            start + CANDLE_WINDOW_DAYS * dayMs,
+            to.valueOf(),
+          );
           for (const candle of await this.tbank.getCandles(
             token,
             uid,