refactor: centralize domain values and enforce numeric lint

src/common/decorators/api-safe-error-response.decorator.ts

@@ -1,4 +1,4 @@
-import { applyDecorators } from '@nestjs/common';
+import { HttpStatus, applyDecorators } from '@nestjs/common';
 import {
   ApiExtraModels,
   ApiProperty,
@@ -35,10 +35,13 @@ function problemResponse(status: number, description: string) {
 export function ApiProblemResponses(): MethodDecorator & ClassDecorator {
   return applyDecorators(
     ApiExtraModels(ProblemDetailsDto),
-    problemResponse(400, 'Invalid request'),
-    problemResponse(401, 'Authentication required'),
-    problemResponse(404, 'Resource not found'),
-    problemResponse(503, 'Upstream service unavailable'),
-    problemResponse(500, 'Internal server error'),
+    problemResponse(HttpStatus.BAD_REQUEST, 'Invalid request'),
+    problemResponse(HttpStatus.UNAUTHORIZED, 'Authentication required'),
+    problemResponse(HttpStatus.NOT_FOUND, 'Resource not found'),
+    problemResponse(
+      HttpStatus.SERVICE_UNAVAILABLE,
+      'Upstream service unavailable',
+    ),
+    problemResponse(HttpStatus.INTERNAL_SERVER_ERROR, 'Internal server error'),
   );
 }

src/common/logging/request-logging.middleware.ts

@@ -1,3 +1,4 @@
+import { constants as httpStatus } from 'node:http2';
 import { Injectable, NestMiddleware } from '@nestjs/common';
 import type { NextFunction, Request, Response } from 'express';
 import { randomUUID } from 'node:crypto';
@@ -46,11 +47,11 @@ export class RequestLoggingMiddleware implements NestMiddleware {
           : {}),
       };
       const level =
-        response.statusCode >= 500
+        response.statusCode >= httpStatus.HTTP_STATUS_INTERNAL_SERVER_ERROR
           ? 'error'
-          : response.statusCode === 429 ||
-              response.statusCode === 401 ||
-              response.statusCode === 403
+          : response.statusCode === httpStatus.HTTP_STATUS_TOO_MANY_REQUESTS ||
+              response.statusCode === httpStatus.HTTP_STATUS_UNAUTHORIZED ||
+              response.statusCode === httpStatus.HTTP_STATUS_FORBIDDEN
             ? 'warn'
             : 'info';
       this.logger.event(level, 'http.request.completed', context);

src/common/time.ts

@@ -0,0 +1,2 @@
+export const MILLISECONDS_PER_SECOND = 1_000;
+export const MILLISECONDS_PER_DAY = 86_400_000;