refactor: enforce enum machine codes
Use owner enums for error and T-Bank protocol values with ESLint regression checks. Preserve open wire fallbacks and keep protocol imports independent of DI and Prisma. Verified npm ci, verify, 226 unit tests, 262 isolated e2e tests and unchanged OpenAPI.
This commit is contained in:
@@ -1,10 +1,8 @@
|
||||
import { formatDecimal } from '../../../../common/decimal';
|
||||
import { MILLISECONDS_PER_SECOND } from '../../../../common/time';
|
||||
import { decimal } from '../../../../integrations/tbank/decimal';
|
||||
import {
|
||||
TbankMoney,
|
||||
TbankOperationItem,
|
||||
} from '../../../../integrations/tbank/tbank.api';
|
||||
import { TbankOperationType } from '../../../../integrations/tbank/tbank-protocol';
|
||||
import { TbankMoney, TbankOperationItem } from '../../../../integrations/tbank/tbank.api';
|
||||
import {
|
||||
BrokerageOperationDto,
|
||||
OperationCategory,
|
||||
@@ -15,29 +13,29 @@ const MISSING_TIMESTAMP_COMPONENT = 0;
|
||||
const NANOSECONDS_PER_MILLISECOND = 1_000_000;
|
||||
|
||||
const types: Record<string, OperationCategory> = {
|
||||
OPERATION_TYPE_BUY: 'trade',
|
||||
OPERATION_TYPE_BUY_CARD: 'trade',
|
||||
OPERATION_TYPE_SELL: 'trade',
|
||||
OPERATION_TYPE_SELL_CARD: 'trade',
|
||||
OPERATION_TYPE_BUY_MARGIN: 'trade',
|
||||
OPERATION_TYPE_SELL_MARGIN: 'trade',
|
||||
OPERATION_TYPE_COUPON: 'income',
|
||||
OPERATION_TYPE_DIVIDEND: 'income',
|
||||
OPERATION_TYPE_DIVIDEND_TRANSFER: 'income',
|
||||
OPERATION_TYPE_DIV_EXT: 'income',
|
||||
OPERATION_TYPE_TRANS_IIS_BS: 'transfer',
|
||||
OPERATION_TYPE_TRANS_BS_BS: 'transfer',
|
||||
OPERATION_TYPE_BOND_TAX: 'tax',
|
||||
OPERATION_TYPE_TAX: 'tax',
|
||||
OPERATION_TYPE_DIVIDEND_TAX: 'tax',
|
||||
OPERATION_TYPE_SERVICE_FEE: 'fee',
|
||||
OPERATION_TYPE_MARGIN_FEE: 'fee',
|
||||
OPERATION_TYPE_BROKER_FEE: 'fee',
|
||||
OPERATION_TYPE_SUCCESS_FEE: 'fee',
|
||||
OPERATION_TYPE_INPUT: 'transfer',
|
||||
OPERATION_TYPE_OUTPUT: 'transfer',
|
||||
OPERATION_TYPE_INPUT_SECURITIES: 'transfer',
|
||||
OPERATION_TYPE_OUTPUT_SECURITIES: 'transfer',
|
||||
[TbankOperationType.Buy]: 'trade',
|
||||
[TbankOperationType.BuyCard]: 'trade',
|
||||
[TbankOperationType.Sell]: 'trade',
|
||||
[TbankOperationType.SellCard]: 'trade',
|
||||
[TbankOperationType.BuyMargin]: 'trade',
|
||||
[TbankOperationType.SellMargin]: 'trade',
|
||||
[TbankOperationType.Coupon]: 'income',
|
||||
[TbankOperationType.Dividend]: 'income',
|
||||
[TbankOperationType.DividendTransfer]: 'income',
|
||||
[TbankOperationType.DivExt]: 'income',
|
||||
[TbankOperationType.TransIisBs]: 'transfer',
|
||||
[TbankOperationType.TransBsBs]: 'transfer',
|
||||
[TbankOperationType.BondTax]: 'tax',
|
||||
[TbankOperationType.Tax]: 'tax',
|
||||
[TbankOperationType.DividendTax]: 'tax',
|
||||
[TbankOperationType.ServiceFee]: 'fee',
|
||||
[TbankOperationType.MarginFee]: 'fee',
|
||||
[TbankOperationType.BrokerFee]: 'fee',
|
||||
[TbankOperationType.SuccessFee]: 'fee',
|
||||
[TbankOperationType.Input]: 'transfer',
|
||||
[TbankOperationType.Output]: 'transfer',
|
||||
[TbankOperationType.InputSecurities]: 'transfer',
|
||||
[TbankOperationType.OutputSecurities]: 'transfer',
|
||||
};
|
||||
|
||||
export function operationCategory(type: string | undefined): OperationCategory {
|
||||
@@ -51,7 +49,7 @@ export function mapBrokerageOperation(
|
||||
return {
|
||||
id: operation.id ?? operation.cursor ?? '',
|
||||
occurredAt: occurredAt.toISOString(),
|
||||
type: operation.type ?? 'OPERATION_TYPE_UNSPECIFIED',
|
||||
type: operation.type ?? TbankOperationType.Unspecified,
|
||||
category: operationCategory(operation.type),
|
||||
description: operation.description?.trim() || operation.name?.trim() || '',
|
||||
figi: text(operation.figi),
|
||||
|
||||
Reference in New Issue
Block a user