refactor: enforce enum machine codes

Use owner enums for error and T-Bank protocol values with ESLint regression checks.

Preserve open wire fallbacks and keep protocol imports independent of DI and Prisma.

Verified npm ci, verify, 226 unit tests, 262 isolated e2e tests and unchanged OpenAPI.

src/modules/investments/instruments/application/candle.service.ts

@@ -9,6 +9,7 @@ import { formatDecimal } from '../../../../common/decimal';
 import { StructuredLogger } from '../../../../common/logging/structured-logger.service';
 import { MILLISECONDS_PER_DAY } from '../../../../common/time';
 import { decimal } from '../../../../integrations/tbank/decimal';
+import { isTbankErrorCode, TbankErrorCode } from '../../../../integrations/tbank/tbank-error-code';
 import {
   TbankAccessService,
   TbankClient,
@@ -23,6 +24,7 @@ import {
   candleWindows,
   utcDay,
 } from '../domain/candle-coverage';
+import { InstrumentErrorCode } from '../domain/instrument-error-code';
 import { CandleRepository } from '../infrastructure/candle.repository';
 import { CatalogEnrichmentService } from './catalog-enrichment.service';
 import { timestamp } from './instrument-market';
@@ -71,8 +73,8 @@ function rangeFor(
       throw new ServiceUnavailableException({
         code:
           input.instrumentType === 'share'
-            ? 'STOCK_HISTORY_START_UNAVAILABLE'
-            : 'BOND_HISTORY_START_UNAVAILABLE',
+            ? InstrumentErrorCode.StockHistoryStartUnavailable
+            : InstrumentErrorCode.BondHistoryStartUnavailable,
       });
     }
     from.setTime(utcDay(new Date(history)).valueOf());
@@ -448,7 +450,7 @@ export class CandleService {
         const producer = this.queue.shift();
         if (!producer) break;
         let success = false;
-        let code = 'TBANK_UNAVAILABLE';
+        let code: string = TbankErrorCode.Unavailable;
         try {
           const result = await this.load(producer);
           if (result === null) {
@@ -457,7 +459,7 @@ export class CandleService {
           }
           success = result;
         } catch (error) {
-          if (error instanceof Error && error.message === 'INVALID_TBANK_TOKEN') {
+          if (error instanceof Error && isTbankErrorCode(error.message, TbankErrorCode.InvalidToken)) {
             await this.access.rejectMembershipToken(producer.attempt);
           }
           if (error instanceof ServiceUnavailableException) {
@@ -523,7 +525,7 @@ export class CandleService {
       }
     } catch {
       this.logger.event('error', 'candles.persistence-failed', {
-        code: 'TBANK_UNAVAILABLE',
+        code: TbankErrorCode.Unavailable,
       });
     } finally {
       this.active.clear();

src/modules/investments/instruments/application/catalog-discovery.service.ts

@@ -6,6 +6,7 @@ import {
 import { randomUUID } from 'node:crypto';
 
 import { StructuredLogger } from '../../../../common/logging/structured-logger.service';
+import { isTbankErrorCode, TbankErrorCode } from '../../../../integrations/tbank/tbank-error-code';
 import {
   TbankAccessService,
   TbankClient,
@@ -14,6 +15,7 @@ import {
   type TbankSyncAttempt,
 } from '../../../../integrations/tbank/tbank.api';
 import { investmentResourceMeta } from '../../investment-resource.mapper';
+import { InstrumentErrorCode } from '../domain/instrument-error-code';
 import {
   CatalogDiscoveryRepository,
   catalogQuery,
@@ -209,8 +211,8 @@ export class CatalogDiscoveryService {
       throw new ConflictException({
         code:
           instrumentType === 'share'
-            ? 'STOCK_TICKER_AMBIGUOUS'
-            : 'BOND_TICKER_AMBIGUOUS',
+            ? InstrumentErrorCode.StockTickerAmbiguous
+            : InstrumentErrorCode.BondTickerAmbiguous,
       });
     }
     const result = lookup.data
@@ -357,11 +359,11 @@ export class CatalogDiscoveryService {
             );
           }
         } catch (error) {
-          if (error instanceof Error && error.message === 'INVALID_TBANK_TOKEN') {
+          if (error instanceof Error && isTbankErrorCode(error.message, TbankErrorCode.InvalidToken)) {
             await this.access.rejectMembershipToken(attempt);
           } else {
             this.logger.event('warn', 'catalog-discovery.failed', {
-              code: 'TBANK_UNAVAILABLE',
+              code: TbankErrorCode.Unavailable,
             });
           }
         }
@@ -395,7 +397,7 @@ export class CatalogDiscoveryService {
       this.producers.clear();
       this.queue.length = 0;
       this.logger.event('error', 'catalog-discovery.persistence-failed', {
-        code: 'TBANK_UNAVAILABLE',
+        code: TbankErrorCode.Unavailable,
       });
     } finally {
       this.running = false;

src/modules/investments/instruments/application/catalog-enrichment.service.ts

@@ -14,6 +14,7 @@ import {
 import { type MoexBondEvent, MoexClient } from '../../../../integrations/moex/moex.api';
 import { NcrRatingsClient } from '../../../../integrations/ncr/ncr.api';
 import { decimal } from '../../../../integrations/tbank/decimal';
+import { isTbankErrorCode, TbankErrorCode } from '../../../../integrations/tbank/tbank-error-code';
 import {
   TbankAccessService,
   type TbankBond,
@@ -520,11 +521,11 @@ export class CatalogEnrichmentService {
           }
         } catch (error) {
           failed = true;
-          if (error instanceof Error && error.message === 'INVALID_TBANK_TOKEN') {
+          if (error instanceof Error && isTbankErrorCode(error.message, TbankErrorCode.InvalidToken)) {
             await this.access.rejectMembershipToken(producer.attempt);
           } else {
             this.logger.event('warn', 'catalog-enrichment.failed', {
-              code: 'TBANK_UNAVAILABLE',
+              code: TbankErrorCode.Unavailable,
             });
           }
         }
@@ -572,7 +573,7 @@ export class CatalogEnrichmentService {
       this.producers.clear();
       this.queue.length = 0;
       this.logger.event('error', 'catalog-enrichment.persistence-failed', {
-        code: 'TBANK_UNAVAILABLE',
+        code: TbankErrorCode.Unavailable,
       });
     } finally {
       this.running = false;

src/modules/investments/instruments/application/catalog-selection.ts

@@ -1,5 +1,7 @@
 import type { TbankShare } from '../../../../integrations/tbank/tbank.api';
 
+import { TbankInstrumentType } from '../../../../integrations/tbank/tbank-protocol';
+
 export const catalogSearchLimit = 30;
 
 export function selectCatalogInstruments<T extends TbankShare>(
@@ -10,8 +12,8 @@ export function selectCatalogInstruments<T extends TbankShare>(
   const seen = new Set<string>();
   const kind =
     instrumentType === 'share'
-      ? 'INSTRUMENT_TYPE_SHARE'
-      : 'INSTRUMENT_TYPE_BOND';
+      ? TbankInstrumentType.Share
+      : TbankInstrumentType.Bond;
   const preferredClass = instrumentType === 'share' ? 'TQBR' : 'TQOB';
   return found
     .filter(

src/modules/investments/instruments/bonds/application/bond-income.service.ts

@@ -7,6 +7,7 @@ import {
   multiply,
 } from '../../../../../common/decimal';
 import { ISO_DATE_LENGTH, ISO_DATE_START } from '../../../../../common/time';
+import { isTbankProtocolValue, TbankCouponType } from '../../../../../integrations/tbank/tbank-protocol';
 import {
   TbankAccessService,
   type TbankBond,
@@ -241,10 +242,10 @@ export function bondMetrics(
         )
       : null;
   const couponType =
-    next?.couponType && next.couponType !== 'COUPON_TYPE_UNSPECIFIED'
+    next?.couponType && !isTbankProtocolValue(next.couponType, TbankCouponType.Unspecified)
       ? next.couponType
       : instrument.floatingCouponFlag === true
-        ? 'COUPON_TYPE_FLOATING'
+        ? TbankCouponType.Floating
         : null;
   return {
     creditRating,

src/modules/investments/instruments/domain/instrument-error-code.ts

@@ -0,0 +1,6 @@
+export enum InstrumentErrorCode {
+  BondHistoryStartUnavailable = 'BOND_HISTORY_START_UNAVAILABLE',
+  BondTickerAmbiguous = 'BOND_TICKER_AMBIGUOUS',
+  StockHistoryStartUnavailable = 'STOCK_HISTORY_START_UNAVAILABLE',
+  StockTickerAmbiguous = 'STOCK_TICKER_AMBIGUOUS',
+}

src/modules/investments/instruments/infrastructure/catalog-discovery.repository.ts

@@ -3,12 +3,9 @@ import { randomUUID } from 'node:crypto';
 import { isDeepStrictEqual } from 'node:util';
 
 import type { Prisma } from '../../../../../generated/prisma/client';
-import type {
-  TbankBond,
-  TbankShare,
-  TbankSyncAttempt,
-} from '../../../../integrations/tbank/tbank.api';
+import type { TbankBond, TbankShare, TbankSyncAttempt } from '../../../../integrations/tbank/tbank.api';
 
+import { TbankErrorCode } from '../../../../integrations/tbank/tbank-error-code';
 import { PrismaService } from '../../../../prisma/prisma.service';
 
 const UNCHANGED_REVISION_INCREMENT = 0;
@@ -462,7 +459,7 @@ export class CatalogDiscoveryRepository {
           state: 'running',
           connection: { invalidToken: true },
         },
-        data: { state: 'failed', errorCode: 'INVALID_TBANK_TOKEN' },
+        data: { state: 'failed', errorCode: TbankErrorCode.InvalidToken },
       });
       await tx.tbankSyncWork.updateMany({
         where: {
@@ -472,7 +469,7 @@ export class CatalogDiscoveryRepository {
         },
         data: {
           state: success ? 'complete' : 'failed',
-          errorCode: success ? null : 'TBANK_UNAVAILABLE',
+          errorCode: success ? null : TbankErrorCode.Unavailable,
         },
       });
     });